Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the .DotSettings in _build #5555

Merged
merged 1 commit into from
May 15, 2024
Merged

Update the .DotSettings in _build #5555

merged 1 commit into from
May 15, 2024

Conversation

andrewlock
Copy link
Member

Summary of changes

Add additional values to the .DotSettings file

Reason for change

Rider keeps adding them, and it's annoying

Implementation details

Let it add them

Test coverage

Other details

@andrewlock andrewlock added the area:builds project files, build scripts, pipelines, versioning, releases, packages label May 13, 2024
@andrewlock andrewlock requested a review from a team as a code owner May 13, 2024 09:34
@datadog-ddstaging
Copy link

datadog-ddstaging bot commented May 13, 2024 •
edited
Loading

Datadog Report

Branch report: andrew/add-new-rider-settings
Commit report: 94f5a2d
Test service: dd-trace-dotnet

✅ 0 Failed, 332411 Passed, 1550 Skipped, 14h 10m 15.99s Total Time
❄️ 4 New Flaky

New Flaky Tests (4)

  • Finish_StartTimeInThePastWithNoEndTime_DurationProperlyComputed - Datadog.Trace.Tests.SpanTests - Last Failure

    Expand for error 
     Assert.True() Failure
 Expected: True
 Actual:   False

  • UtcNow_GivesLegitTime - Datadog.Trace.Tests.TraceContextTests - Last Failure

    Expand for error 
     Expected the date and time to be within 200ms from <2024-05-13 10:21:24.876835 +0h>, but it was <2024-05-13 10:21:28.836566 +0h>.

  • UtcNow_GivesLegitTime - Datadog.Trace.Tests.TraceContextTests - Last Failure

    Expand for error 
     Expected now to be within 200ms from <2024-05-13 10:56:03.365601 +0h>, but it was <2024-05-13 10:55:59.5309681 +0h>.

  • NextTraceId_128_Is_Valid - Datadog.Trace.Tests.Util.RandomIdGeneratorTests - Last Failure

    Expand for error 
     Expected (value.Upper<<32) to be between 1715597027UL and 1715597031UL, but found 1715597025UL.

@andrewlock
Copy link
Member Author

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5555) - mean (74ms)  : 66, 83
     .   : milestone, 74,
    master - mean (75ms)  : 66, 83
     .   : milestone, 75,

    section CallTarget+Inlining+NGEN
    This PR (5555) - mean (1,005ms)  : 979, 1031
     .   : milestone, 1005,
    master - mean (1,005ms)  : 981, 1029
     .   : milestone, 1005,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5555) - mean (110ms)  : 107, 112
     .   : milestone, 110,
    master - mean (109ms)  : 106, 112
     .   : milestone, 109,

    section CallTarget+Inlining+NGEN
    This PR (5555) - mean (720ms)  : 702, 738
     .   : milestone, 720,
    master - mean (724ms)  : 698, 749
     .   : milestone, 724,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5555) - mean (93ms)  : 91, 95
     .   : milestone, 93,
    master - mean (93ms)  : 90, 96
     .   : milestone, 93,

    section CallTarget+Inlining+NGEN
    This PR (5555) - mean (677ms)  : 661, 694
     .   : milestone, 677,
    master - mean (678ms)  : 658, 699
     .   : milestone, 678,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5555) - mean (191ms)  : 187, 196
     .   : milestone, 191,
    master - mean (190ms)  : 186, 194
     .   : milestone, 190,

    section CallTarget+Inlining+NGEN
    This PR (5555) - mean (1,075ms)  : 1046, 1104
     .   : milestone, 1075,
    master - mean (1,075ms)  : 1052, 1098
     .   : milestone, 1075,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5555) - mean (275ms)  : 271, 280
     .   : milestone, 275,
    master - mean (275ms)  : 271, 279
     .   : milestone, 275,

    section CallTarget+Inlining+NGEN
    This PR (5555) - mean (860ms)  : 836, 883
     .   : milestone, 860,
    master - mean (860ms)  : 837, 882
     .   : milestone, 860,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5555) - mean (264ms)  : 260, 269
     .   : milestone, 264,
    master - mean (264ms)  : 260, 268
     .   : milestone, 264,

    section CallTarget+Inlining+NGEN
    This PR (5555) - mean (848ms)  : 829, 867
     .   : milestone, 848,
    master - mean (850ms)  : 820, 881
     .   : milestone, 850,
Loading

@andrewlock
Copy link
Member Author

Benchmarks Report for tracer 🐌

Benchmarks for #5555 compared to master:

  • 3 benchmarks are faster, with geometric mean 1.145
  • 3 benchmarks are slower, with geometric mean 1.126
  • 1 benchmarks have fewer allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 8.75μs 43.4ns 221ns 0.0183 0.00913 0 7.56 KB
master StartStopWithChild netcoreapp3.1 11μs 58.8ns 328ns 0.0267 0.0107 0 7.66 KB
master StartStopWithChild net472 17.1μs 40.9ns 158ns 1.34 0.351 0.1 8.09 KB
#5555 StartStopWithChild net6.0 8.69μs 27.3ns 106ns 0.0209 0.0126 0 7.56 KB
#5555 StartStopWithChild netcoreapp3.1 11μs 57.9ns 289ns 0.0281 0.0112 0 7.65 KB
#5555 StartStopWithChild net472 17.1μs 24.7ns 92.4ns 1.34 0.357 0.111 8.09 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 483μs 848ns 3.17μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 640μs 340ns 1.32μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 826μs 526ns 2.04μs 0.411 0 0 3.3 KB
#5555 WriteAndFlushEnrichedTraces net6.0 468μs 135ns 486ns 0 0 0 2.7 KB
#5555 WriteAndFlushEnrichedTraces netcoreapp3.1 633μs 337ns 1.26μs 0 0 0 2.7 KB
#5555 WriteAndFlushEnrichedTraces net472 842μs 408ns 1.58μs 0.419 0 0 3.3 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 173μs 273ns 1.06μs 0.173 0 0 18.49 KB
master SendRequest netcoreapp3.1 192μs 185ns 715ns 0.191 0 0 20.65 KB
master SendRequest net472 0.00011ns 0.000105ns 0.000377ns 0 0 0 0 b
#5555 SendRequest net6.0 168μs 167ns 623ns 0.168 0 0 18.49 KB
#5555 SendRequest netcoreapp3.1 192μs 231ns 863ns 0.19 0 0 20.65 KB
#5555 SendRequest net472 0.000444ns 0.000148ns 0.000534ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #5555

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑netcoreapp3.1 42.01 KB 41.56 KB -449 B -1.07%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 541μs 303ns 1.17μs 0.553 0 0 41.51 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 673μs 1.33μs 5.17μs 0.329 0 0 42.01 KB
master WriteAndFlushEnrichedTraces net472 842μs 3.53μs 13.2μs 8.08 2.55 0.425 53.26 KB
#5555 WriteAndFlushEnrichedTraces net6.0 555μs 179ns 644ns 0.556 0 0 41.55 KB
#5555 WriteAndFlushEnrichedTraces netcoreapp3.1 647μs 711ns 2.75μs 0.329 0 0 41.56 KB
#5555 WriteAndFlushEnrichedTraces net472 845μs 3.95μs 15.8μs 8.13 2.57 0.428 53.23 KB
Benchmarks.Trace.DbCommandBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #5555

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.DbCommandBenchmark.ExecuteNonQuery‑net6.0 1.126 1,229.74 1,092.50

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.23μs 0.375ns 1.45ns 0.0117 0 0 808 B
master ExecuteNonQuery netcoreapp3.1 1.6μs 1.16ns 4.48ns 0.011 0 0 808 B
master ExecuteNonQuery net472 1.82μs 0.919ns 3.56ns 0.122 0 0 770 B
#5555 ExecuteNonQuery net6.0 1.09μs 0.452ns 1.75ns 0.0115 0 0 808 B
#5555 ExecuteNonQuery netcoreapp3.1 1.56μs 1.72ns 6.19ns 0.0108 0 0 808 B
#5555 ExecuteNonQuery net472 1.73μs 0.462ns 1.6ns 0.122 0 0 770 B
Benchmarks.Trace.ElasticsearchBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #5555

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch‑net6.0 1.123 1,209.13 1,358.06

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.21μs 2.01ns 7.77ns 0.0142 0 0 1.03 KB
master CallElasticsearch netcoreapp3.1 1.65μs 2.4ns 8.64ns 0.0137 0 0 1.03 KB
master CallElasticsearch net472 2.45μs 1.68ns 6.5ns 0.166 0 0 1.04 KB
master CallElasticsearchAsync net6.0 1.37μs 0.789ns 3.06ns 0.0137 0 0 1.01 KB
master CallElasticsearchAsync netcoreapp3.1 1.69μs 1.47ns 5.71ns 0.0145 0 0 1.08 KB
master CallElasticsearchAsync net472 2.52μs 1.82ns 7.07ns 0.174 0.00125 0 1.1 KB
#5555 CallElasticsearch net6.0 1.36μs 1.41ns 5.46ns 0.0142 0 0 1.03 KB
#5555 CallElasticsearch netcoreapp3.1 1.65μs 1.06ns 3.95ns 0.0142 0 0 1.03 KB
#5555 CallElasticsearch net472 2.62μs 1.38ns 5.33ns 0.165 0 0 1.04 KB
#5555 CallElasticsearchAsync net6.0 1.41μs 0.576ns 2.23ns 0.0142 0 0 1.01 KB
#5555 CallElasticsearchAsync netcoreapp3.1 1.74μs 5.17ns 20ns 0.0148 0 0 1.08 KB
#5555 CallElasticsearchAsync net472 2.57μs 1.34ns 4.82ns 0.173 0 0 1.1 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.3μs 0.552ns 2.14ns 0.013 0 0 952 B
master ExecuteAsync netcoreapp3.1 1.63μs 1.95ns 7.56ns 0.0131 0 0 952 B
master ExecuteAsync net472 1.79μs 0.575ns 2.15ns 0.145 0 0 915 B
#5555 ExecuteAsync net6.0 1.39μs 0.7ns 2.52ns 0.0133 0 0 952 B
#5555 ExecuteAsync netcoreapp3.1 1.66μs 0.608ns 2.19ns 0.0125 0 0 952 B
#5555 ExecuteAsync net472 1.77μs 0.495ns 1.92ns 0.145 0 0 915 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 4.27μs 1.51ns 5.66ns 0.0319 0 0 2.27 KB
master SendAsync netcoreapp3.1 5.27μs 2.12ns 8.22ns 0.0367 0 0 2.81 KB
master SendAsync net472 7.99μs 1.41ns 5.26ns 0.504 0 0 3.18 KB
#5555 SendAsync net6.0 4.42μs 1.53ns 5.91ns 0.031 0 0 2.27 KB
#5555 SendAsync netcoreapp3.1 5.25μs 2.13ns 7.96ns 0.0395 0 0 2.81 KB
#5555 SendAsync net472 7.95μs 3.74ns 14ns 0.504 0 0 3.18 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 1.64μs 0.906ns 3.39ns 0.0238 0 0 1.7 KB
master EnrichedLog netcoreapp3.1 2.14μs 0.981ns 3.67ns 0.0224 0 0 1.7 KB
master EnrichedLog net472 2.73μs 1.14ns 4.43ns 0.257 0 0 1.62 KB
#5555 EnrichedLog net6.0 1.58μs 0.959ns 3.59ns 0.0237 0 0 1.7 KB
#5555 EnrichedLog netcoreapp3.1 2.24μs 1.02ns 3.68ns 0.0224 0 0 1.7 KB
#5555 EnrichedLog net472 2.85μs 1.75ns 6.53ns 0.258 0 0 1.62 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 114μs 106ns 398ns 0.0567 0 0 4.28 KB
master EnrichedLog netcoreapp3.1 119μs 171ns 664ns 0 0 0 4.28 KB
master EnrichedLog net472 151μs 88.8ns 320ns 0.681 0.227 0 4.46 KB
#5555 EnrichedLog net6.0 112μs 187ns 724ns 0.056 0 0 4.28 KB
#5555 EnrichedLog netcoreapp3.1 120μs 139ns 521ns 0.0597 0 0 4.28 KB
#5555 EnrichedLog net472 150μs 168ns 629ns 0.672 0.224 0 4.46 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 3.07μs 0.59ns 2.21ns 0.0307 0 0 2.25 KB
master EnrichedLog netcoreapp3.1 4.23μs 1.59ns 5.94ns 0.0296 0 0 2.25 KB
master EnrichedLog net472 5.09μs 1.31ns 5.08ns 0.329 0 0 2.07 KB
#5555 EnrichedLog net6.0 3.14μs 1.53ns 5.74ns 0.0313 0 0 2.25 KB
#5555 EnrichedLog netcoreapp3.1 4.28μs 1.81ns 7.03ns 0.0299 0 0 2.25 KB
#5555 EnrichedLog net472 4.88μs 1.24ns 4.79ns 0.328 0 0 2.07 KB
Benchmarks.Trace.RedisBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #5555

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.RedisBenchmark.SendReceive‑net6.0 1.119 1,392.17 1,557.96

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 1.39μs 0.744ns 2.88ns 0.0166 0 0 1.2 KB
master SendReceive netcoreapp3.1 1.83μs 1.83ns 6.59ns 0.0155 0 0 1.2 KB
master SendReceive net472 2.29μs 0.652ns 2.53ns 0.191 0 0 1.2 KB
#5555 SendReceive net6.0 1.56μs 0.569ns 2.05ns 0.0166 0 0 1.2 KB
#5555 SendReceive netcoreapp3.1 1.92μs 3.2ns 12.4ns 0.0163 0 0 1.2 KB
#5555 SendReceive net472 2.28μs 0.595ns 2.06ns 0.191 0.00114 0 1.2 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.8μs 0.581ns 2.17ns 0.0224 0 0 1.6 KB
master EnrichedLog netcoreapp3.1 3.92μs 1.5ns 5.83ns 0.022 0 0 1.65 KB
master EnrichedLog net472 4.47μs 1.42ns 5.48ns 0.323 0 0 2.04 KB
#5555 EnrichedLog net6.0 2.77μs 0.857ns 3.32ns 0.022 0 0 1.6 KB
#5555 EnrichedLog netcoreapp3.1 4.01μs 1.56ns 5.63ns 0.0218 0 0 1.65 KB
#5555 EnrichedLog net472 4.51μs 1.94ns 7.25ns 0.323 0 0 2.04 KB
Benchmarks.Trace.SpanBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #5555

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net6.0 1.194 732.83 613.73
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net472 1.116 863.94 774.19

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 481ns 0.109ns 0.408ns 0.00797 0 0 576 B
master StartFinishSpan netcoreapp3.1 763ns 0.379ns 1.42ns 0.00753 0 0 576 B
master StartFinishSpan net472 864ns 0.243ns 0.942ns 0.0917 0 0 578 B
master StartFinishScope net6.0 733ns 0.305ns 1.18ns 0.00955 0 0 696 B
master StartFinishScope netcoreapp3.1 890ns 0.415ns 1.55ns 0.00953 0 0 696 B
master StartFinishScope net472 1.05μs 1.5ns 5.8ns 0.104 0 0 658 B
#5555 StartFinishSpan net6.0 481ns 0.154ns 0.575ns 0.00798 0 0 576 B
#5555 StartFinishSpan netcoreapp3.1 706ns 0.499ns 1.87ns 0.00786 0 0 576 B
#5555 StartFinishSpan net472 774ns 0.419ns 1.57ns 0.0916 0 0 578 B
#5555 StartFinishScope net6.0 614ns 0.276ns 1.03ns 0.00973 0 0 696 B
#5555 StartFinishScope netcoreapp3.1 897ns 0.351ns 1.27ns 0.00943 0 0 696 B
#5555 StartFinishScope net472 1.03μs 0.69ns 2.67ns 0.105 0 0 658 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #5555

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑netcoreapp3.1 1.136 877.01 996.42

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 619ns 0.36ns 1.35ns 0.00969 0 0 696 B
master RunOnMethodBegin netcoreapp3.1 878ns 0.778ns 3.01ns 0.00956 0 0 696 B
master RunOnMethodBegin net472 1.17μs 0.423ns 1.64ns 0.104 0 0 658 B
#5555 RunOnMethodBegin net6.0 619ns 0.149ns 0.578ns 0.0096 0 0 696 B
#5555 RunOnMethodBegin netcoreapp3.1 996ns 0.653ns 2.53ns 0.00927 0 0 696 B
#5555 RunOnMethodBegin net472 1.17μs 0.657ns 2.54ns 0.104 0 0 658 B

@andrewlock
Copy link
Member Author

Throughput/Crank Report:zap:

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5555) (11.881M)   : 0, 11880909
    master (12.086M)   : 0, 12085968
    benchmarks/2.9.0 (11.694M)   : 0, 11694440

    section Automatic
    This PR (5555) (7.910M)   : 0, 7910146
    master (7.928M)   : 0, 7928428
    benchmarks/2.9.0 (8.460M)   : 0, 8459793

    section Trace stats
    master (8.362M)   : 0, 8362314

    section Manual
    This PR (5555) (10.157M)   : 0, 10156831
    master (10.136M)   : 0, 10135938

    section Manual + Automatic
    This PR (5555) (7.530M)   : 0, 7529685
    master (7.517M)   : 0, 7516749

    section Version Conflict
    master (6.734M)   : 0, 6734049
Loading 
gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5555) (9.413M)   : 0, 9412764
    master (9.547M)   : 0, 9547395
    benchmarks/2.9.0 (9.570M)   : 0, 9570467

    section Automatic
    This PR (5555) (6.629M)   : 0, 6628742
    master (6.503M)   : 0, 6503020

    section Trace stats
    master (6.931M)   : 0, 6930931

    section Manual
    This PR (5555) (8.326M)   : 0, 8325728
    master (8.165M)   : 0, 8165052

    section Manual + Automatic
    This PR (5555) (6.122M)   : 0, 6122377
    master (6.152M)   : 0, 6151654

    section Version Conflict
    master (5.792M)   : 0, 5791571
Loading 
gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5555) (9.669M)   : 0, 9668919
    master (9.831M)   : 0, 9831044
    benchmarks/2.9.0 (9.961M)   : 0, 9960539

    section Automatic
    This PR (5555) (6.927M)   : 0, 6927178
    master (7.054M)   : 0, 7054086
    benchmarks/2.9.0 (7.528M)   : 0, 7527964

    section Trace stats
    master (7.381M)   : 0, 7380708

    section Manual
    This PR (5555) (8.547M)   : 0, 8547020
    master (8.840M)   : 0, 8839501

    section Manual + Automatic
    This PR (5555) (6.759M)   : 0, 6759382
    master (6.871M)   : 0, 6871103

    section Version Conflict
    master (6.172M)   : 0, 6172210
Loading

kevingosse
kevingosse approved these changes May 15, 2024
View reviewed changes
Copy link
Collaborator

@kevingosse kevingosse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:vs_peeking:

@andrewlock andrewlock merged commit fa8e95d into master May 15, 2024
57 checks passed
@andrewlock andrewlock deleted the andrew/add-new-rider-settings branch May 15, 2024 08:55
@github-actions github-actions bot added this to the vNext-v2 milestone May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevingosse kevingosse kevingosse approved these changes

Assignees
No one assigned
Labels
area:builds project files, build scripts, pipelines, versioning, releases, packages
Projects
None yet
Milestone
2.52.0
Development

Successfully merging this pull request may close these issues.
2 participants
@andrewlock @kevingosse