[Tracer][Tests] scrub `_dd.agent_psr` tag from `TraceAnnotationsTests` snapshots only #5591

lucaspimentel · 2024-05-21T18:24:53Z

Summary of changes

In a previous PR, #5562, I scrubbed the _dd.agent_psr tag from all snapshots. In this PR, I try scrubbing it only from the tests where is causes flake (because the test intentionally loads older tracer versions). There's no need to scrub it everywhere since the tag should not appear anymore in other tests after #5545.

Reason for change

Allowing this tag in snapshots would allow us to test this tag in the future if we ever return sampling rates from the mock agent.

Implementation details

Move the tag-scrubbing code from the global VerifyHelper into TraceAnnotationsTests.

Test coverage

the test tests itself

Other details

datadog-ddstaging · 2024-05-21T18:47:23Z

Datadog Report

Branch report: lpimentel/agent-psr-tests
Commit report: 90bf9f0
Test service: dd-trace-dotnet

✅ 0 Failed, 336118 Passed, 1567 Skipped, 13h 49m 9.54s Total Time

andrewlock · 2024-05-21T18:48:47Z

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

Welch test with statistical test for significance of 5%
Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5591) - mean (71ms)  : 65, 77
     .   : milestone, 71,
    master - mean (73ms)  : 65, 82
     .   : milestone, 73,

    section CallTarget+Inlining+NGEN
    This PR (5591) - mean (1,006ms)  : 973, 1038
     .   : milestone, 1006,
    master - mean (1,008ms)  : 971, 1044
     .   : milestone, 1008,

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5591) - mean (109ms)  : 106, 111
     .   : milestone, 109,
    master - mean (108ms)  : 105, 112
     .   : milestone, 108,

    section CallTarget+Inlining+NGEN
    This PR (5591) - mean (724ms)  : 699, 749
     .   : milestone, 724,
    master - mean (727ms)  : 694, 760
     .   : milestone, 727,

gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5591) - mean (92ms)  : 87, 96
     .   : milestone, 92,
    master - mean (92ms)  : 89, 95
     .   : milestone, 92,

    section CallTarget+Inlining+NGEN
    This PR (5591) - mean (676ms)  : 647, 705
     .   : milestone, 676,
    master - mean (678ms)  : 655, 702
     .   : milestone, 678,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5591) - mean (194ms)  : 190, 197
     .   : milestone, 194,
    master - mean (195ms)  : 192, 198
     .   : milestone, 195,

    section CallTarget+Inlining+NGEN
    This PR (5591) - mean (1,114ms)  : 1097, 1132
     .   : milestone, 1114,
    master - mean (1,114ms)  : 1089, 1139
     .   : milestone, 1114,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5591) - mean (280ms)  : 273, 287
     .   : milestone, 280,
    master - mean (276ms)  : 272, 280
     .   : milestone, 276,

    section CallTarget+Inlining+NGEN
    This PR (5591) - mean (910ms)  : 880, 941
     .   : milestone, 910,
    master - mean (911ms)  : 891, 931
     .   : milestone, 911,

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5591) - mean (274ms)  : 267, 280
     .   : milestone, 274,
    master - mean (265ms)  : 260, 270
     .   : milestone, 265,

    section CallTarget+Inlining+NGEN
    This PR (5591) - mean (891ms)  : 868, 915
     .   : milestone, 891,
    master - mean (891ms)  : 862, 920
     .   : milestone, 891,

andrewlock · 2024-05-21T19:12:20Z

Throughput/Crank Report:zap:

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5591) (11.118M)   : 0, 11118389
    master (11.209M)   : 0, 11209172
    benchmarks/2.9.0 (11.345M)   : 0, 11344659

    section Automatic
    This PR (5591) (7.460M)   : 0, 7459752
    master (7.650M)   : 0, 7650063
    benchmarks/2.9.0 (7.909M)   : 0, 7908964

    section Trace stats
    master (7.837M)   : 0, 7836514

    section Manual
    This PR (5591) (9.735M)   : 0, 9734993
    master (9.801M)   : 0, 9800780

    section Manual + Automatic
    This PR (5591) (7.046M)   : 0, 7045768
    master (7.162M)   : 0, 7161859

    section Version Conflict
    master (6.431M)   : 0, 6430935

gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5591) (9.514M)   : 0, 9513534
    master (9.621M)   : 0, 9620797
    benchmarks/2.9.0 (9.624M)   : 0, 9623972

    section Automatic
    This PR (5591) (6.657M)   : 0, 6657067
    master (6.683M)   : 0, 6683301

    section Trace stats
    master (6.985M)   : 0, 6984579

    section Manual
    This PR (5591) (8.274M)   : 0, 8273736
    master (8.217M)   : 0, 8216851

    section Manual + Automatic
    This PR (5591) (6.235M)   : 0, 6234630
    master (6.203M)   : 0, 6202649

    section Version Conflict
    master (5.681M)   : 0, 5681280

gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5591) (9.899M)   : 0, 9899455
    master (10.108M)   : 0, 10108183
    benchmarks/2.9.0 (9.811M)   : 0, 9811314

    section Automatic
    This PR (5591) (7.010M)   : 0, 7010388
    master (7.102M)   : 0, 7101824
    benchmarks/2.9.0 (7.273M)   : 0, 7272966

    section Trace stats
    master (7.391M)   : 0, 7391133

    section Manual
    This PR (5591) (8.713M)   : 0, 8713322
    master (8.800M)   : 0, 8800179

    section Manual + Automatic
    This PR (5591) (6.669M)   : 0, 6669158
    master (6.928M)   : 0, 6928216

    section Version Conflict
    master (6.177M)   : 0, 6177156

andrewlock · 2024-05-21T19:12:40Z

Benchmarks Report for tracer 🐌

Benchmarks for #5591 compared to master:

2 benchmarks are slower, with geometric mean 1.132
1 benchmarks have more allocations

The following thresholds were used for comparing the benchmark speeds:

Mann–Whitney U test with statistical test for significance of 5%
Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`StartStopWithChild`	net6.0	8.64μs	45.6ns	237ns	0.0212	0.00849	0	7.55 KB
master	`StartStopWithChild`	netcoreapp3.1	10.8μs	55.7ns	261ns	0.0169	0.00564	0	7.66 KB
master	`StartStopWithChild`	net472	17.1μs	54.3ns	203ns	1.35	0.364	0.101	8.05 KB
#5591	`StartStopWithChild`	net6.0	8.67μs	46.2ns	244ns	0.0208	0.00831	0	7.55 KB
#5591	`StartStopWithChild`	netcoreapp3.1	10.6μs	53.7ns	257ns	0.0265	0.0106	0	7.65 KB
#5591	`StartStopWithChild`	net472	17μs	44.9ns	174ns	1.33	0.334	0.103	8.05 KB

Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	480μs	173ns	625ns	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	628μs	222ns	861ns	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	net472	836μs	277ns	1.04μs	0.414	3.3 KB
#5591	`WriteAndFlushEnrichedTraces`	net6.0	478μs	96ns	359ns	0	2.7 KB
#5591	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	626μs	355ns	1.38μs	0	2.7 KB
#5591	`WriteAndFlushEnrichedTraces`	net472	849μs	178ns	668ns	0.422	3.3 KB

Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendRequest`	net6.0	169μs	260ns	1.01μs	0.254	18.44 KB
master	`SendRequest`	netcoreapp3.1	190μs	385ns	1.49μs	0.189	20.6 KB
master	`SendRequest`	net472	0.15ns	0.000779ns	0.00302ns	0	0 b
#5591	`SendRequest`	net6.0	171μs	196ns	758ns	0.258	18.44 KB
#5591	`SendRequest`	netcoreapp3.1	191μs	281ns	1.09μs	0.192	20.6 KB
#5591	`SendRequest`	net472	0.000501ns	0.000202ns	0.000783ns	0	0 b

Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ More allocations ⚠️

More allocations ⚠️ in #5591

Benchmark	Base Allocated	Diff Allocated	Change	Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑netcoreapp3.1	41.61 KB	41.85 KB	237 B	0.57%

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	528μs	887ns	3.44μs	0.534	0	0	41.58 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	660μs	3.35μs	14.6μs	0.334	0	0	41.61 KB
master	`WriteAndFlushEnrichedTraces`	net472	816μs	2.39μs	8.63μs	8.39	2.52	0.419	53.26 KB
#5591	`WriteAndFlushEnrichedTraces`	net6.0	542μs	1.7μs	6.57μs	0.534	0	0	41.69 KB
#5591	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	654μs	1.81μs	7μs	0.324	0	0	41.85 KB
#5591	`WriteAndFlushEnrichedTraces`	net472	839μs	2.43μs	9.4μs	8.12	2.44	0.406	53.23 KB

Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`ExecuteNonQuery`	net6.0	1.04μs	0.548ns	2.12ns	0.0116	808 B
master	`ExecuteNonQuery`	netcoreapp3.1	1.43μs	0.512ns	1.98ns	0.0107	808 B
master	`ExecuteNonQuery`	net472	1.71μs	0.76ns	2.94ns	0.122	770 B
#5591	`ExecuteNonQuery`	net6.0	1.04μs	0.37ns	1.43ns	0.011	808 B
#5591	`ExecuteNonQuery`	netcoreapp3.1	1.43μs	0.704ns	2.54ns	0.0108	808 B
#5591	`ExecuteNonQuery`	net472	1.7μs	1.51ns	5.83ns	0.122	770 B

Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`CallElasticsearch`	net6.0	1.16μs	0.724ns	2.71ns	0.0136	976 B
master	`CallElasticsearch`	netcoreapp3.1	1.51μs	0.678ns	2.45ns	0.0128	976 B
master	`CallElasticsearch`	net472	2.54μs	2.36ns	9.13ns	0.157	995 B
master	`CallElasticsearchAsync`	net6.0	1.34μs	1.52ns	5.89ns	0.0134	952 B
master	`CallElasticsearchAsync`	netcoreapp3.1	1.66μs	1.43ns	5.36ns	0.0133	1.02 KB
master	`CallElasticsearchAsync`	net472	2.58μs	1.53ns	5.74ns	0.166	1.05 KB
#5591	`CallElasticsearch`	net6.0	1.2μs	1.2ns	4.49ns	0.0138	976 B
#5591	`CallElasticsearch`	netcoreapp3.1	1.49μs	0.836ns	3.13ns	0.0133	976 B
#5591	`CallElasticsearch`	net472	2.51μs	1.64ns	6.37ns	0.158	995 B
#5591	`CallElasticsearchAsync`	net6.0	1.22μs	0.743ns	2.78ns	0.0134	952 B
#5591	`CallElasticsearchAsync`	netcoreapp3.1	1.65μs	2.07ns	7.76ns	0.0133	1.02 KB
#5591	`CallElasticsearchAsync`	net472	2.58μs	1.5ns	5.82ns	0.166	1.05 KB

Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`ExecuteAsync`	net6.0	1.33μs	0.86ns	3.33ns	0.0133	952 B
master	`ExecuteAsync`	netcoreapp3.1	1.64μs	2.13ns	7.96ns	0.0131	952 B
master	`ExecuteAsync`	net472	1.85μs	0.779ns	2.91ns	0.145	915 B
#5591	`ExecuteAsync`	net6.0	1.27μs	0.967ns	3.74ns	0.0134	952 B
#5591	`ExecuteAsync`	netcoreapp3.1	1.73μs	1.2ns	4.65ns	0.0123	952 B
#5591	`ExecuteAsync`	net472	1.77μs	0.911ns	3.53ns	0.145	915 B

Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendAsync`	net6.0	4.2μs	1.51ns	5.64ns	0.0317	2.22 KB
master	`SendAsync`	netcoreapp3.1	5.06μs	2.52ns	9.75ns	0.0355	2.76 KB
master	`SendAsync`	net472	7.63μs	4.19ns	15.7ns	0.494	3.12 KB
#5591	`SendAsync`	net6.0	4.19μs	1.99ns	7.44ns	0.0317	2.22 KB
#5591	`SendAsync`	netcoreapp3.1	5.13μs	2.12ns	8.22ns	0.0385	2.76 KB
#5591	`SendAsync`	net472	7.51μs	3.07ns	11.5ns	0.495	3.12 KB

Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	1.41μs	0.423ns	1.47ns	0.0227	1.64 KB
master	`EnrichedLog`	netcoreapp3.1	2.2μs	0.599ns	2.32ns	0.0219	1.64 KB
master	`EnrichedLog`	net472	2.56μs	0.65ns	2.52ns	0.249	1.57 KB
#5591	`EnrichedLog`	net6.0	1.49μs	0.585ns	2.19ns	0.0231	1.64 KB
#5591	`EnrichedLog`	netcoreapp3.1	2.21μs	1.15ns	4.46ns	0.022	1.64 KB
#5591	`EnrichedLog`	net472	2.6μs	0.98ns	3.67ns	0.249	1.57 KB

Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`EnrichedLog`	net6.0	115μs	110ns	427ns	0.0567	0	4.28 KB
master	`EnrichedLog`	netcoreapp3.1	118μs	81.9ns	317ns	0	0	4.28 KB
master	`EnrichedLog`	net472	148μs	54.5ns	211ns	0.662	0.221	4.46 KB
#5591	`EnrichedLog`	net6.0	114μs	218ns	843ns	0	0	4.28 KB
#5591	`EnrichedLog`	netcoreapp3.1	118μs	178ns	666ns	0	0	4.28 KB
#5591	`EnrichedLog`	net472	148μs	95.7ns	371ns	0.665	0.222	4.46 KB

Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	3.14μs	0.424ns	1.47ns	0.0315	2.2 KB
master	`EnrichedLog`	netcoreapp3.1	4.22μs	2.5ns	9.67ns	0.0299	2.2 KB
master	`EnrichedLog`	net472	4.75μs	1.68ns	6.51ns	0.319	2.02 KB
#5591	`EnrichedLog`	net6.0	2.85μs	0.682ns	2.64ns	0.0301	2.2 KB
#5591	`EnrichedLog`	netcoreapp3.1	3.98μs	1.61ns	6.23ns	0.0299	2.2 KB
#5591	`EnrichedLog`	net472	4.77μs	0.604ns	2.26ns	0.32	2.02 KB

Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`SendReceive`	net6.0	1.29μs	0.488ns	1.83ns	0.0162	0	1.14 KB
master	`SendReceive`	netcoreapp3.1	1.76μs	0.68ns	2.63ns	0.0158	0	1.14 KB
master	`SendReceive`	net472	2.16μs	1.36ns	5.1ns	0.183	0	1.16 KB
#5591	`SendReceive`	net6.0	1.33μs	0.484ns	1.87ns	0.016	0	1.14 KB
#5591	`SendReceive`	netcoreapp3.1	1.87μs	0.82ns	3.18ns	0.015	0	1.14 KB
#5591	`SendReceive`	net472	2.16μs	1.58ns	6.12ns	0.183	0.00108	1.16 KB

Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	2.79μs	0.839ns	3.25ns	0.0224	1.6 KB
master	`EnrichedLog`	netcoreapp3.1	3.98μs	1.91ns	7.16ns	0.0219	1.65 KB
master	`EnrichedLog`	net472	4.45μs	3.51ns	13.6ns	0.324	2.04 KB
#5591	`EnrichedLog`	net6.0	2.75μs	1.29ns	4.83ns	0.022	1.6 KB
#5591	`EnrichedLog`	netcoreapp3.1	3.78μs	2.05ns	7.95ns	0.0227	1.65 KB
#5591	`EnrichedLog`	net472	4.32μs	2.22ns	8.32ns	0.322	2.04 KB

Benchmarks.Trace.SpanBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #5591

Benchmark	diff/base	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net472	1.141	586.21	669.14
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net6.0	1.122	474.44	532.22

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`StartFinishSpan`	net6.0	461ns	0.176ns	0.68ns	0.00812	576 B
master	`StartFinishSpan`	netcoreapp3.1	597ns	0.196ns	0.76ns	0.00784	576 B
master	`StartFinishSpan`	net472	585ns	0.883ns	3.42ns	0.0918	578 B
master	`StartFinishScope`	net6.0	474ns	0.124ns	0.481ns	0.0097	696 B
master	`StartFinishScope`	netcoreapp3.1	763ns	0.28ns	1.09ns	0.00922	696 B
master	`StartFinishScope`	net472	883ns	1.33ns	5.15ns	0.105	658 B
#5591	`StartFinishSpan`	net6.0	449ns	0.231ns	0.864ns	0.00812	576 B
#5591	`StartFinishSpan`	netcoreapp3.1	576ns	0.163ns	0.63ns	0.0079	576 B
#5591	`StartFinishSpan`	net472	670ns	0.401ns	1.55ns	0.0918	578 B
#5591	`StartFinishScope`	net6.0	532ns	0.179ns	0.693ns	0.00983	696 B
#5591	`StartFinishScope`	netcoreapp3.1	770ns	0.356ns	1.38ns	0.00933	696 B
#5591	`StartFinishScope`	net472	916ns	0.46ns	1.78ns	0.104	658 B

Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`RunOnMethodBegin`	net6.0	661ns	0.321ns	1.24ns	0.00957	696 B
master	`RunOnMethodBegin`	netcoreapp3.1	912ns	0.724ns	2.81ns	0.00909	696 B
master	`RunOnMethodBegin`	net472	1.14μs	0.349ns	1.31ns	0.104	658 B
#5591	`RunOnMethodBegin`	net6.0	603ns	0.229ns	0.886ns	0.00965	696 B
#5591	`RunOnMethodBegin`	netcoreapp3.1	990ns	1.16ns	4.49ns	0.0094	696 B
#5591	`RunOnMethodBegin`	net472	1.19μs	0.414ns	1.55ns	0.104	658 B

andrewlock

LGTM, thanks!

remove "_dd.agent_psr" only from TraceAnnotationsTests spanshots

90bf9f0

lucaspimentel added area:tracer The core tracer library (Datadog.Trace, does not include OpenTracing, native code, or integrations) area:tests unit tests, integration tests labels May 21, 2024

lucaspimentel marked this pull request as ready for review May 21, 2024 20:21

lucaspimentel requested a review from a team as a code owner May 21, 2024 20:21

andrewlock approved these changes May 22, 2024

View reviewed changes

lucaspimentel merged commit ba3b50b into master May 22, 2024
56 of 57 checks passed

lucaspimentel deleted the lpimentel/agent-psr-tests branch May 22, 2024 16:33

lucaspimentel changed the title ~~[Tracer] scrub _dd.agent_psr tag from TraceAnnotationsTests snapshots only~~ [Tracer][Tests] scrub _dd.agent_psr tag from TraceAnnotationsTests snapshots only May 22, 2024

github-actions bot added this to the vNext-v2 milestone May 22, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Tracer][Tests] scrub `_dd.agent_psr` tag from `TraceAnnotationsTests` snapshots only #5591

[Tracer][Tests] scrub `_dd.agent_psr` tag from `TraceAnnotationsTests` snapshots only #5591

lucaspimentel commented May 21, 2024 •

edited

Loading

datadog-ddstaging bot commented May 21, 2024 •

edited

Loading

andrewlock commented May 21, 2024

andrewlock commented May 21, 2024

andrewlock commented May 21, 2024

Raw results

Raw results

Raw results

More allocations ⚠️ in #5591

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Slower ⚠️ in #5591

Raw results

Raw results

andrewlock left a comment

[Tracer][Tests] scrub _dd.agent_psr tag from TraceAnnotationsTests snapshots only #5591

[Tracer][Tests] scrub _dd.agent_psr tag from TraceAnnotationsTests snapshots only #5591

Conversation

lucaspimentel commented May 21, 2024 • edited Loading

Summary of changes

Reason for change

Implementation details

Test coverage

Other details

datadog-ddstaging bot commented May 21, 2024 • edited Loading

Datadog Report

andrewlock commented May 21, 2024

Execution-Time Benchmarks Report ⏱️

andrewlock commented May 21, 2024

Throughput/Crank Report:zap:

andrewlock commented May 21, 2024

Benchmarks Report for tracer 🐌

Benchmark details

Raw results

Raw results

Raw results

More allocations ⚠️ in #5591

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Slower ⚠️ in #5591

Raw results

Raw results

andrewlock left a comment

Choose a reason for hiding this comment

[Tracer][Tests] scrub `_dd.agent_psr` tag from `TraceAnnotationsTests` snapshots only #5591

[Tracer][Tests] scrub `_dd.agent_psr` tag from `TraceAnnotationsTests` snapshots only #5591

lucaspimentel commented May 21, 2024 •

edited

Loading

datadog-ddstaging bot commented May 21, 2024 •

edited

Loading