Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(lib-injection): update base image to alpine 3.20 #5613

Merged
merged 2 commits into from
Jun 3, 2024

Conversation

Kyle-Verhoog
Copy link
Member

Summary of changes

3.18.3 has a known vulnerability, CVE-2023-5363 that can trigger warnings even though this image is not used to run any applications.

Reason for change

Implementation details

Test coverage

Other details

3.18.3 has a known vulnerability, CVE-2023-5363 that can trigger warnings even though this image is not used to run any applications.
@Kyle-Verhoog Kyle-Verhoog requested a review from a team as a code owner May 24, 2024 19:10
@datadog-ddstaging
Copy link

datadog-ddstaging bot commented May 24, 2024

Datadog Report

Branch report: Kyle-Verhoog-patch-1
Commit report: d38e5ad
Test service: dd-trace-dotnet

✅ 0 Failed, 334522 Passed, 1573 Skipped, 14h 4m 46.29s Total Time

@andrewlock
Copy link
Member

andrewlock commented May 24, 2024

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5613) - mean (74ms)  : 65, 82
     .   : milestone, 74,
    master - mean (74ms)  : 67, 81
     .   : milestone, 74,

    section CallTarget+Inlining+NGEN
    This PR (5613) - mean (991ms)  : 967, 1015
     .   : milestone, 991,
    master - mean (1,007ms)  : 976, 1039
     .   : milestone, 1007,

Loading
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5613) - mean (108ms)  : 106, 111
     .   : milestone, 108,
    master - mean (126ms)  : 102, 149
     .   : milestone, 126,

    section CallTarget+Inlining+NGEN
    This PR (5613) - mean (707ms)  : 685, 730
     .   : milestone, 707,
    master - mean (750ms)  : 689, 811
     .   : milestone, 750,

Loading
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5613) - mean (92ms)  : 89, 96
     .   : milestone, 92,
    master - mean (97ms)  : 91, 104
     .   : milestone, 97,

    section CallTarget+Inlining+NGEN
    This PR (5613) - mean (663ms)  : 649, 677
     .   : milestone, 663,
    master - mean (675ms)  : 636, 713
     .   : milestone, 675,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5613) - mean (193ms)  : 189, 198
     .   : milestone, 193,
    master - mean (192ms)  : 188, 196
     .   : milestone, 192,

    section CallTarget+Inlining+NGEN
    This PR (5613) - mean (1,095ms)  : 1072, 1119
     .   : milestone, 1095,
    master - mean (1,096ms)  : 1078, 1113
     .   : milestone, 1096,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5613) - mean (278ms)  : 273, 283
     .   : milestone, 278,
    master - mean (278ms)  : 273, 283
     .   : milestone, 278,

    section CallTarget+Inlining+NGEN
    This PR (5613) - mean (895ms)  : 872, 918
     .   : milestone, 895,
    master - mean (895ms)  : 868, 921
     .   : milestone, 895,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5613) - mean (266ms)  : 261, 270
     .   : milestone, 266,
    master - mean (267ms)  : 262, 273
     .   : milestone, 267,

    section CallTarget+Inlining+NGEN
    This PR (5613) - mean (879ms)  : 857, 901
     .   : milestone, 879,
    master - mean (880ms)  : 860, 900
     .   : milestone, 880,

Loading

@andrewlock
Copy link
Member

andrewlock commented May 24, 2024

Benchmarks Report for tracer 🐌

Benchmarks for #5613 compared to master:

  • 1 benchmarks are faster, with geometric mean 1.138
  • 1 benchmarks have fewer allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 8.79μs 47.9ns 271ns 0.017 0.00425 0 7.56 KB
master StartStopWithChild netcoreapp3.1 11μs 57.9ns 301ns 0.027 0.0108 0 7.65 KB
master StartStopWithChild net472 17.1μs 52.5ns 203ns 1.35 0.356 0.102 8.07 KB
#5613 StartStopWithChild net6.0 8.8μs 41.5ns 166ns 0.0176 0.00879 0 7.55 KB
#5613 StartStopWithChild netcoreapp3.1 11μs 61.4ns 426ns 0.0216 0.0108 0 7.65 KB
#5613 StartStopWithChild net472 17.1μs 66.5ns 257ns 1.35 0.372 0.11 8.06 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 490μs 207ns 774ns 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 645μs 292ns 1.13μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 854μs 82.1ns 318ns 0.425 0 0 3.3 KB
#5613 WriteAndFlushEnrichedTraces net6.0 491μs 224ns 836ns 0 0 0 2.7 KB
#5613 WriteAndFlushEnrichedTraces netcoreapp3.1 654μs 600ns 2.16μs 0 0 0 2.7 KB
#5613 WriteAndFlushEnrichedTraces net472 852μs 196ns 705ns 0.425 0 0 3.3 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 175μs 277ns 1.07μs 0.172 0 0 18.44 KB
master SendRequest netcoreapp3.1 192μs 337ns 1.31μs 0.191 0 0 20.6 KB
master SendRequest net472 0.000947ns 0.000352ns 0.00136ns 0 0 0 0 b
#5613 SendRequest net6.0 174μs 132ns 477ns 0.174 0 0 18.44 KB
#5613 SendRequest netcoreapp3.1 193μs 476ns 1.71μs 0.192 0 0 20.6 KB
#5613 SendRequest net472 0.000174ns 0.000106ns 0.00041ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #5613

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑netcoreapp3.1 41.73 KB 41.51 KB -217 B -0.52%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 545μs 1.14μs 4.43μs 0.553 0 0 41.68 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 652μs 2.24μs 8.68μs 0.332 0 0 41.73 KB
master WriteAndFlushEnrichedTraces net472 822μs 3.07μs 11.9μs 8.28 2.48 0.414 53.25 KB
#5613 WriteAndFlushEnrichedTraces net6.0 557μs 547ns 2.05μs 0.553 0 0 41.72 KB
#5613 WriteAndFlushEnrichedTraces netcoreapp3.1 647μs 2.88μs 11.2μs 0.321 0 0 41.51 KB
#5613 WriteAndFlushEnrichedTraces net472 846μs 3.35μs 13μs 8.39 2.52 0.419 53.25 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.19μs 0.797ns 3.09ns 0.0114 0 0 808 B
master ExecuteNonQuery netcoreapp3.1 1.46μs 0.607ns 2.19ns 0.0109 0 0 808 B
master ExecuteNonQuery net472 1.78μs 1.63ns 6.3ns 0.122 0 0 770 B
#5613 ExecuteNonQuery net6.0 1.19μs 0.852ns 3.3ns 0.0114 0 0 808 B
#5613 ExecuteNonQuery netcoreapp3.1 1.45μs 0.893ns 3.34ns 0.0109 0 0 808 B
#5613 ExecuteNonQuery net472 1.71μs 1.82ns 7.06ns 0.122 0 0 770 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.18μs 0.81ns 3.03ns 0.0135 0 0 976 B
master CallElasticsearch netcoreapp3.1 1.55μs 0.958ns 3.71ns 0.0132 0 0 976 B
master CallElasticsearch net472 2.5μs 1.69ns 6.54ns 0.157 0 0 995 B
master CallElasticsearchAsync net6.0 1.27μs 0.628ns 2.35ns 0.0134 0 0 952 B
master CallElasticsearchAsync netcoreapp3.1 1.57μs 0.422ns 1.58ns 0.0141 0 0 1.02 KB
master CallElasticsearchAsync net472 2.66μs 1.64ns 6.15ns 0.167 0.00133 0 1.05 KB
#5613 CallElasticsearch net6.0 1.19μs 0.854ns 3.19ns 0.0136 0 0 976 B
#5613 CallElasticsearch netcoreapp3.1 1.58μs 0.908ns 3.4ns 0.0132 0 0 976 B
#5613 CallElasticsearch net472 2.55μs 1.62ns 5.82ns 0.158 0.0013 0 995 B
#5613 CallElasticsearchAsync net6.0 1.3μs 0.709ns 2.65ns 0.0132 0 0 952 B
#5613 CallElasticsearchAsync netcoreapp3.1 1.55μs 0.717ns 2.68ns 0.0139 0 0 1.02 KB
#5613 CallElasticsearchAsync net472 2.67μs 1.87ns 7.24ns 0.167 0.00132 0 1.05 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.32μs 1.26ns 4.56ns 0.0132 0 0 952 B
master ExecuteAsync netcoreapp3.1 1.61μs 1.08ns 3.88ns 0.0129 0 0 952 B
master ExecuteAsync net472 1.76μs 1.12ns 4.35ns 0.145 0 0 915 B
#5613 ExecuteAsync net6.0 1.23μs 0.536ns 2.01ns 0.0135 0 0 952 B
#5613 ExecuteAsync netcoreapp3.1 1.57μs 0.927ns 3.59ns 0.0126 0 0 952 B
#5613 ExecuteAsync net472 1.69μs 0.676ns 2.62ns 0.145 0.000846 0 915 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 3.98μs 1.69ns 6.09ns 0.0299 0 0 2.22 KB
master SendAsync netcoreapp3.1 5.12μs 2.02ns 7.81ns 0.0359 0 0 2.76 KB
master SendAsync net472 7.55μs 2.45ns 9.49ns 0.494 0 0 3.12 KB
#5613 SendAsync net6.0 4.2μs 9.62ns 37.2ns 0.0311 0 0 2.22 KB
#5613 SendAsync netcoreapp3.1 5.08μs 1.73ns 6.71ns 0.0356 0 0 2.76 KB
#5613 SendAsync net472 7.56μs 1.63ns 6.3ns 0.494 0 0 3.12 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 1.47μs 0.356ns 1.33ns 0.0228 0 0 1.64 KB
master EnrichedLog netcoreapp3.1 2.32μs 2.29ns 8.58ns 0.022 0 0 1.64 KB
master EnrichedLog net472 2.5μs 1.16ns 4.36ns 0.25 0 0 1.57 KB
#5613 EnrichedLog net6.0 1.48μs 0.457ns 1.65ns 0.0236 0 0 1.64 KB
#5613 EnrichedLog netcoreapp3.1 2.13μs 1.35ns 5.05ns 0.0222 0 0 1.64 KB
#5613 EnrichedLog net472 2.54μs 1.39ns 5.37ns 0.249 0 0 1.57 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 117μs 150ns 580ns 0.0587 0 0 4.28 KB
master EnrichedLog netcoreapp3.1 122μs 195ns 755ns 0.0605 0 0 4.28 KB
master EnrichedLog net472 150μs 90ns 349ns 0.676 0.225 0 4.46 KB
#5613 EnrichedLog net6.0 116μs 77ns 298ns 0.0579 0 0 4.28 KB
#5613 EnrichedLog netcoreapp3.1 120μs 162ns 625ns 0.0595 0 0 4.28 KB
#5613 EnrichedLog net472 150μs 126ns 489ns 0.678 0.226 0 4.46 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 3.13μs 1.38ns 5.36ns 0.0297 0 0 2.2 KB
master EnrichedLog netcoreapp3.1 4.16μs 6.55ns 24.5ns 0.0288 0 0 2.2 KB
master EnrichedLog net472 4.81μs 2ns 7.48ns 0.319 0 0 2.02 KB
#5613 EnrichedLog net6.0 3.11μs 1.29ns 5ns 0.0311 0 0 2.2 KB
#5613 EnrichedLog netcoreapp3.1 4.38μs 1.59ns 5.73ns 0.0285 0 0 2.2 KB
#5613 EnrichedLog net472 4.82μs 0.594ns 2.14ns 0.319 0 0 2.02 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 1.33μs 3.19ns 12.4ns 0.0163 0 0 1.14 KB
master SendReceive netcoreapp3.1 1.73μs 1.76ns 6.83ns 0.0155 0 0 1.14 KB
master SendReceive net472 2.16μs 1.52ns 5.67ns 0.183 0.00108 0 1.16 KB
#5613 SendReceive net6.0 1.42μs 0.795ns 3.08ns 0.0155 0 0 1.14 KB
#5613 SendReceive netcoreapp3.1 1.71μs 2.86ns 11.1ns 0.0154 0 0 1.14 KB
#5613 SendReceive net472 2.08μs 1.13ns 4.22ns 0.183 0 0 1.16 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.72μs 0.903ns 3.5ns 0.0218 0 0 1.6 KB
master EnrichedLog netcoreapp3.1 3.98μs 2.12ns 8.2ns 0.022 0 0 1.65 KB
master EnrichedLog net472 4.4μs 1.66ns 6.21ns 0.323 0 0 2.04 KB
#5613 EnrichedLog net6.0 2.74μs 0.989ns 3.83ns 0.022 0 0 1.6 KB
#5613 EnrichedLog netcoreapp3.1 3.92μs 1.54ns 5.78ns 0.0214 0 0 1.65 KB
#5613 EnrichedLog net472 4.3μs 2.27ns 8.48ns 0.323 0 0 2.04 KB
Benchmarks.Trace.SpanBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #5613

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net472 1.138 706.58 620.83

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 394ns 0.145ns 0.563ns 0.00813 0 0 576 B
master StartFinishSpan netcoreapp3.1 590ns 0.292ns 1.01ns 0.00799 0 0 576 B
master StartFinishSpan net472 706ns 0.4ns 1.55ns 0.0916 0 0 578 B
master StartFinishScope net6.0 479ns 0.15ns 0.582ns 0.00987 0 0 696 B
master StartFinishScope netcoreapp3.1 671ns 1.25ns 4.84ns 0.00955 0 0 696 B
master StartFinishScope net472 842ns 0.217ns 0.842ns 0.104 0 0 658 B
#5613 StartFinishSpan net6.0 401ns 0.101ns 0.378ns 0.00805 0 0 576 B
#5613 StartFinishSpan netcoreapp3.1 643ns 0.221ns 0.856ns 0.00779 0 0 576 B
#5613 StartFinishSpan net472 620ns 0.297ns 1.15ns 0.0918 0 0 578 B
#5613 StartFinishScope net6.0 501ns 0.0899ns 0.348ns 0.00977 0 0 696 B
#5613 StartFinishScope netcoreapp3.1 663ns 0.638ns 2.47ns 0.00942 0 0 696 B
#5613 StartFinishScope net472 807ns 0.86ns 3.22ns 0.104 0 0 658 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 641ns 0.24ns 0.93ns 0.00964 0 0 696 B
master RunOnMethodBegin netcoreapp3.1 911ns 0.253ns 0.945ns 0.00914 0 0 696 B
master RunOnMethodBegin net472 1.09μs 0.485ns 1.88ns 0.104 0 0 658 B
#5613 RunOnMethodBegin net6.0 588ns 0.241ns 0.933ns 0.00974 0 0 696 B
#5613 RunOnMethodBegin netcoreapp3.1 857ns 0.428ns 1.6ns 0.00948 0 0 696 B
#5613 RunOnMethodBegin net472 1.06μs 0.447ns 1.73ns 0.104 0 0 658 B

@andrewlock
Copy link
Member

andrewlock commented May 24, 2024

Throughput/Crank Report:zap:

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5613) (11.184M)   : 0, 11184076
    master (11.174M)   : 0, 11174063
    benchmarks/2.9.0 (11.124M)   : 0, 11124333

    section Automatic
    This PR (5613) (7.600M)   : 0, 7599579
    master (7.581M)   : 0, 7581279
    benchmarks/2.9.0 (7.978M)   : 0, 7978037

    section Trace stats
    master (8.044M)   : 0, 8044259

    section Manual
    This PR (5613) (9.715M)   : 0, 9714844
    master (9.597M)   : 0, 9596996

    section Manual + Automatic
    This PR (5613) (7.056M)   : 0, 7056111
    master (7.169M)   : 0, 7169410

    section Version Conflict
    master (6.407M)   : 0, 6406765

Loading
gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5613) (9.665M)   : 0, 9664670
    master (9.585M)   : 0, 9585367
    benchmarks/2.9.0 (9.596M)   : 0, 9596252

    section Automatic
    This PR (5613) (6.590M)   : 0, 6589789
    master (6.556M)   : 0, 6556478

    section Trace stats
    master (6.834M)   : 0, 6834091

    section Manual
    This PR (5613) (8.413M)   : 0, 8412890
    master (7.904M)   : 0, 7903978

    section Manual + Automatic
    This PR (5613) (6.250M)   : 0, 6250324
    master (6.244M)   : 0, 6244358

    section Version Conflict
    master (5.595M)   : 0, 5594532

Loading
gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5613) (9.981M)   : 0, 9980574
    master (9.962M)   : 0, 9961646
    benchmarks/2.9.0 (9.869M)   : 0, 9868550

    section Automatic
    This PR (5613) (6.277M)   : crit ,0, 6276720
    master (7.151M)   : 0, 7151268
    benchmarks/2.9.0 (7.444M)   : 0, 7444484

    section Trace stats
    master (7.367M)   : 0, 7366630

    section Manual
    This PR (5613) (8.816M)   : 0, 8815771
    master (8.881M)   : 0, 8881308

    section Manual + Automatic
    This PR (5613) (6.824M)   : 0, 6823734
    master (6.894M)   : 0, 6894136

    section Version Conflict
    master (6.098M)   : 0, 6097707

Loading

Copy link
Member

@andrewlock andrewlock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given "we are not actually running anything in these images other than copying our packages out of them" is there any reason we can't/shouldn't use scratch containers instead?

don't pin a minor version
@Kyle-Verhoog Kyle-Verhoog changed the title chore(lib-injection): update base image to alpine 3.18.6 chore(lib-injection): update base image to alpine 3.20 May 28, 2024
@Kyle-Verhoog
Copy link
Member Author

not opposed. Not sure if scratch containers contain a cp command though 🤔

@andrewlock
Copy link
Member

not opposed. Not sure if scratch containers contain a cp command though 🤔

I doubt it, I think scratch is only really useful if you're using it purely as a data container. I take it that's not the case then @Kyle-Verhoog? 🤷‍♂️

Anyway, merging for now, we can always revisit

@andrewlock andrewlock merged commit 78cab01 into master Jun 3, 2024
57 checks passed
@andrewlock andrewlock deleted the Kyle-Verhoog-patch-1 branch June 3, 2024 10:40
@github-actions github-actions bot added this to the vNext-v2 milestone Jun 3, 2024
@andrewlock andrewlock added the area:builds project files, build scripts, pipelines, versioning, releases, packages label Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:builds project files, build scripts, pipelines, versioning, releases, packages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants