[Dynamic Instrumentation] Cleansing third party module names to avoid conflicts with customer's modules #5622

GreenMatan · 2024-05-28T11:52:57Z

Summary of changes

The system tests are using a .NET app named app, which falls into the third party modules list, leading to the avoidance of reading it's PDB. It has failed the line probe's System Tests, since line probes rely on PDB information to map between line number -> bytecode offset.

Reason for change

Fix System Tests breakage.

Implementation details

Got rid of app and Application from the module list. This list, in general, needs to be cleansed further, where Microsoft assemblies will also be ruled out since we can easily determine those based on a naming pattern.

Test coverage

System tests.

andrewlock · 2024-05-28T12:18:48Z

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

Welch test with statistical test for significance of 5%
Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5622) - mean (77ms)  : 65, 88
     .   : milestone, 77,
    master - mean (74ms)  : 64, 83
     .   : milestone, 74,

    section CallTarget+Inlining+NGEN
    This PR (5622) - mean (1,000ms)  : 970, 1030
     .   : milestone, 1000,
    master - mean (992ms)  : 966, 1017
     .   : milestone, 992,

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5622) - mean (113ms)  : 106, 120
     .   : milestone, 113,
    master - mean (109ms)  : 105, 113
     .   : milestone, 109,

    section CallTarget+Inlining+NGEN
    This PR (5622) - mean (765ms)  : crit, 723, 808
     .   : crit, milestone, 765,
    master - mean (708ms)  : 683, 733
     .   : milestone, 708,

gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5622) - mean (99ms)  : 93, 105
     .   : milestone, 99,
    master - mean (91ms)  : 89, 93
     .   : milestone, 91,

    section CallTarget+Inlining+NGEN
    This PR (5622) - mean (683ms)  : 661, 705
     .   : milestone, 683,
    master - mean (662ms)  : 642, 681
     .   : milestone, 662,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5622) - mean (195ms)  : 188, 201
     .   : milestone, 195,
    master - mean (191ms)  : 189, 194
     .   : milestone, 191,

    section CallTarget+Inlining+NGEN
    This PR (5622) - mean (1,101ms)  : 1078, 1124
     .   : milestone, 1101,
    master - mean (1,096ms)  : 1069, 1122
     .   : milestone, 1096,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5622) - mean (281ms)  : 274, 289
     .   : milestone, 281,
    master - mean (276ms)  : 271, 280
     .   : milestone, 276,

    section CallTarget+Inlining+NGEN
    This PR (5622) - mean (903ms)  : 881, 925
     .   : milestone, 903,
    master - mean (895ms)  : 869, 922
     .   : milestone, 895,

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5622) - mean (268ms)  : 263, 273
     .   : milestone, 268,
    master - mean (266ms)  : 262, 271
     .   : milestone, 266,

    section CallTarget+Inlining+NGEN
    This PR (5622) - mean (879ms)  : 861, 898
     .   : milestone, 879,
    master - mean (875ms)  : 856, 894
     .   : milestone, 875,

andrewlock · 2024-05-28T13:03:51Z

Benchmarks Report for tracer 🐌

Benchmarks for #5622 compared to master:

1 benchmarks are faster, with geometric mean 1.157
1 benchmarks are slower, with geometric mean 1.131
1 benchmarks have more allocations

The following thresholds were used for comparing the benchmark speeds:

Mann–Whitney U test with statistical test for significance of 5%
Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`StartStopWithChild`	net6.0	8.88μs	46.6ns	287ns	0.0217	0.00868	0	7.55 KB
master	`StartStopWithChild`	netcoreapp3.1	10.7μs	59.3ns	356ns	0.0255	0.0102	0	7.65 KB
master	`StartStopWithChild`	net472	16.8μs	49.6ns	186ns	1.38	0.443	0.142	8.06 KB
#5622	`StartStopWithChild`	net6.0	8.58μs	47.7ns	309ns	0.0268	0.0134	0	7.56 KB
#5622	`StartStopWithChild`	netcoreapp3.1	10.7μs	54ns	253ns	0.0258	0.0103	0	7.65 KB
#5622	`StartStopWithChild`	net472	17.4μs	41.9ns	157ns	1.34	0.337	0.104	8.05 KB

Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	470μs	207ns	775ns	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	629μs	203ns	788ns	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	net472	844μs	155ns	559ns	0.422	3.3 KB
#5622	`WriteAndFlushEnrichedTraces`	net6.0	484μs	293ns	1.1μs	0	2.7 KB
#5622	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	624μs	226ns	875ns	0	2.7 KB
#5622	`WriteAndFlushEnrichedTraces`	net472	847μs	325ns	1.26μs	0.422	3.3 KB

Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendRequest`	net6.0	171μs	345ns	1.34μs	0.256	18.44 KB
master	`SendRequest`	netcoreapp3.1	191μs	408ns	1.58μs	0.189	20.61 KB
master	`SendRequest`	net472	0.000798ns	0.000313ns	0.00113ns	0	0 b
#5622	`SendRequest`	net6.0	172μs	186ns	696ns	0.257	18.44 KB
#5622	`SendRequest`	netcoreapp3.1	188μs	304ns	1.18μs	0.188	20.6 KB
#5622	`SendRequest`	net472	0.000395ns	0.000206ns	0.000797ns	0	0 b

Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ More allocations ⚠️

More allocations ⚠️ in #5622

Benchmark	Base Allocated	Diff Allocated	Change	Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑netcoreapp3.1	41.7 KB	42.06 KB	358 B	0.86%

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	549μs	404ns	1.51μs	0.551	0	0	41.67 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	672μs	1.17μs	4.53μs	0.329	0	0	41.7 KB
master	`WriteAndFlushEnrichedTraces`	net472	846μs	2.28μs	8.82μs	8.08	2.55	0.425	53.23 KB
#5622	`WriteAndFlushEnrichedTraces`	net6.0	554μs	421ns	1.63μs	0.558	0	0	41.65 KB
#5622	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	646μs	872ns	3.14μs	0.331	0	0	42.06 KB
#5622	`WriteAndFlushEnrichedTraces`	net472	830μs	1.45μs	5.02μs	8.25	2.6	0.434	53.23 KB

Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`ExecuteNonQuery`	net6.0	978ns	0.498ns	1.93ns	0.0112	808 B
master	`ExecuteNonQuery`	netcoreapp3.1	1.46μs	1.05ns	4.06ns	0.0109	808 B
master	`ExecuteNonQuery`	net472	1.67μs	1.9ns	7.37ns	0.122	770 B
#5622	`ExecuteNonQuery`	net6.0	1.05μs	0.58ns	2.17ns	0.0111	808 B
#5622	`ExecuteNonQuery`	netcoreapp3.1	1.47μs	0.56ns	2.17ns	0.011	808 B
#5622	`ExecuteNonQuery`	net472	1.7μs	1.85ns	7.17ns	0.122	770 B

Benchmarks.Trace.ElasticsearchBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #5622

Benchmark	diff/base	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync‑net6.0	1.131	1,196.76	1,353.37

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`CallElasticsearch`	net6.0	1.25μs	1.27ns	4.77ns	0.0136	0	976 B
master	`CallElasticsearch`	netcoreapp3.1	1.58μs	0.84ns	3.14ns	0.0127	0	976 B
master	`CallElasticsearch`	net472	2.5μs	1.14ns	4.28ns	0.157	0	995 B
master	`CallElasticsearchAsync`	net6.0	1.2μs	1.54ns	5.98ns	0.0133	0	952 B
master	`CallElasticsearchAsync`	netcoreapp3.1	1.65μs	0.909ns	3.28ns	0.0132	0	1.02 KB
master	`CallElasticsearchAsync`	net472	2.53μs	1.91ns	7.15ns	0.167	0.00127	1.05 KB
#5622	`CallElasticsearch`	net6.0	1.14μs	0.89ns	3.45ns	0.0137	0	976 B
#5622	`CallElasticsearch`	netcoreapp3.1	1.52μs	1.24ns	4.8ns	0.0137	0	976 B
#5622	`CallElasticsearch`	net472	2.52μs	1.45ns	5.61ns	0.157	0	995 B
#5622	`CallElasticsearchAsync`	net6.0	1.35μs	0.967ns	3.75ns	0.0129	0	952 B
#5622	`CallElasticsearchAsync`	netcoreapp3.1	1.5μs	0.684ns	2.56ns	0.0135	0	1.02 KB
#5622	`CallElasticsearchAsync`	net472	2.68μs	2.2ns	8.51ns	0.167	0	1.05 KB

Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`ExecuteAsync`	net6.0	1.26μs	1.23ns	4.78ns	0.0133	0	952 B
master	`ExecuteAsync`	netcoreapp3.1	1.67μs	2.99ns	11.6ns	0.0123	0	952 B
master	`ExecuteAsync`	net472	1.78μs	0.678ns	2.54ns	0.145	0	915 B
#5622	`ExecuteAsync`	net6.0	1.23μs	0.798ns	3.09ns	0.0136	0	952 B
#5622	`ExecuteAsync`	netcoreapp3.1	1.67μs	4.17ns	16.1ns	0.0124	0	952 B
#5622	`ExecuteAsync`	net472	1.77μs	1.03ns	3.99ns	0.145	0.000887	915 B

Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`SendAsync`	net6.0	4.01μs	1.16ns	4.35ns	0.03	0	2.22 KB
master	`SendAsync`	netcoreapp3.1	4.99μs	2.43ns	9.41ns	0.0349	0	2.76 KB
master	`SendAsync`	net472	7.46μs	2.08ns	8.04ns	0.493	0	3.12 KB
#5622	`SendAsync`	net6.0	4.18μs	1.83ns	6.84ns	0.0314	0	2.22 KB
#5622	`SendAsync`	netcoreapp3.1	5.1μs	1.09ns	4.06ns	0.0357	0	2.76 KB
#5622	`SendAsync`	net472	7.52μs	2.04ns	7.89ns	0.496	0.00376	3.12 KB

Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	1.51μs	0.602ns	2.33ns	0.0227	1.64 KB
master	`EnrichedLog`	netcoreapp3.1	2.31μs	1.37ns	5.12ns	0.0218	1.64 KB
master	`EnrichedLog`	net472	2.58μs	2.09ns	8.11ns	0.249	1.57 KB
#5622	`EnrichedLog`	net6.0	1.61μs	0.978ns	3.66ns	0.0232	1.64 KB
#5622	`EnrichedLog`	netcoreapp3.1	2.24μs	1.24ns	4.63ns	0.0223	1.64 KB
#5622	`EnrichedLog`	net472	2.5μs	0.811ns	3.03ns	0.25	1.57 KB

Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`EnrichedLog`	net6.0	117μs	124ns	482ns	0.0585	0	4.28 KB
master	`EnrichedLog`	netcoreapp3.1	121μs	137ns	492ns	0.0602	0	4.28 KB
master	`EnrichedLog`	net472	149μs	183ns	708ns	0.672	0.224	4.46 KB
#5622	`EnrichedLog`	net6.0	116μs	135ns	521ns	0.0581	0	4.28 KB
#5622	`EnrichedLog`	netcoreapp3.1	119μs	187ns	676ns	0	0	4.28 KB
#5622	`EnrichedLog`	net472	151μs	95.5ns	370ns	0.676	0.225	4.46 KB

Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	3.07μs	0.876ns	3.39ns	0.0307	2.2 KB
master	`EnrichedLog`	netcoreapp3.1	4.14μs	0.858ns	3.32ns	0.029	2.2 KB
master	`EnrichedLog`	net472	5.05μs	1.08ns	4.03ns	0.319	2.02 KB
#5622	`EnrichedLog`	net6.0	2.99μs	0.837ns	3.24ns	0.0303	2.2 KB
#5622	`EnrichedLog`	netcoreapp3.1	4.26μs	1.26ns	4.72ns	0.0298	2.2 KB
#5622	`EnrichedLog`	net472	4.99μs	1.71ns	6.61ns	0.32	2.02 KB

Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendReceive`	net6.0	1.33μs	3.53ns	13.7ns	0.0157	1.14 KB
master	`SendReceive`	netcoreapp3.1	1.76μs	0.935ns	3.62ns	0.015	1.14 KB
master	`SendReceive`	net472	1.96μs	8.59ns	33.3ns	0.183	1.16 KB
#5622	`SendReceive`	net6.0	1.34μs	0.623ns	2.41ns	0.0161	1.14 KB
#5622	`SendReceive`	netcoreapp3.1	1.76μs	1.07ns	4.14ns	0.0147	1.14 KB
#5622	`SendReceive`	net472	2.14μs	7.46ns	28.9ns	0.184	1.16 KB

Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	2.77μs	0.877ns	3.4ns	0.0222	1.6 KB
master	`EnrichedLog`	netcoreapp3.1	3.9μs	4.55ns	17.6ns	0.0215	1.65 KB
master	`EnrichedLog`	net472	4.33μs	3.68ns	14.2ns	0.323	2.04 KB
#5622	`EnrichedLog`	net6.0	2.87μs	0.684ns	2.65ns	0.0214	1.6 KB
#5622	`EnrichedLog`	netcoreapp3.1	3.83μs	1.01ns	3.64ns	0.0211	1.65 KB
#5622	`EnrichedLog`	net472	4.38μs	3.08ns	11.9ns	0.324	2.04 KB

Benchmarks.Trace.SpanBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #5622

Benchmark	base/diff	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net472	1.157	672.41	581.09

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`StartFinishSpan`	net6.0	423ns	0.166ns	0.643ns	0.00817	576 B
master	`StartFinishSpan`	netcoreapp3.1	603ns	0.643ns	2.49ns	0.00785	576 B
master	`StartFinishSpan`	net472	672ns	0.659ns	2.55ns	0.0917	578 B
master	`StartFinishScope`	net6.0	564ns	0.246ns	0.953ns	0.00966	696 B
master	`StartFinishScope`	netcoreapp3.1	686ns	0.918ns	3.44ns	0.00918	696 B
master	`StartFinishScope`	net472	824ns	0.28ns	1.09ns	0.104	658 B
#5622	`StartFinishSpan`	net6.0	445ns	0.256ns	0.993ns	0.00802	576 B
#5622	`StartFinishSpan`	netcoreapp3.1	628ns	0.808ns	3.02ns	0.00769	576 B
#5622	`StartFinishSpan`	net472	580ns	0.609ns	2.36ns	0.0916	578 B
#5622	`StartFinishScope`	net6.0	554ns	0.144ns	0.557ns	0.00976	696 B
#5622	`StartFinishScope`	netcoreapp3.1	763ns	0.346ns	1.34ns	0.0095	696 B
#5622	`StartFinishScope`	net472	873ns	0.557ns	2.16ns	0.104	658 B

Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`RunOnMethodBegin`	net6.0	592ns	0.113ns	0.423ns	0.00983	696 B
master	`RunOnMethodBegin`	netcoreapp3.1	968ns	0.462ns	1.79ns	0.0093	696 B
master	`RunOnMethodBegin`	net472	1.1μs	0.461ns	1.78ns	0.104	658 B
#5622	`RunOnMethodBegin`	net6.0	602ns	0.136ns	0.473ns	0.00978	696 B
#5622	`RunOnMethodBegin`	netcoreapp3.1	1.03μs	0.585ns	2.27ns	0.00936	696 B
#5622	`RunOnMethodBegin`	net472	1.06μs	0.33ns	1.28ns	0.104	658 B

datadog-ddstaging · 2024-05-28T13:20:35Z

Datadog Report

Branch report: matang/get-rid-of-popular-dll-name
Commit report: 3230e9b
Test service: dd-trace-dotnet

✅ 0 Failed, 342271 Passed, 2068 Skipped, 22h 0m 19.91s Total Time

shurivich

Excellent!

andrewlock · 2024-05-28T16:26:20Z

Throughput/Crank Report:zap:

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5622) (11.295M)   : 0, 11294922
    master (11.287M)   : 0, 11286909
    benchmarks/2.9.0 (11.124M)   : 0, 11124333

    section Automatic
    This PR (5622) (7.652M)   : 0, 7652295
    master (7.532M)   : 0, 7531630
    benchmarks/2.9.0 (7.978M)   : 0, 7978037

    section Trace stats
    master (7.847M)   : 0, 7846841

    section Manual
    This PR (5622) (9.816M)   : 0, 9816469
    master (9.555M)   : 0, 9554821

    section Manual + Automatic
    This PR (5622) (7.172M)   : 0, 7172463
    master (7.040M)   : 0, 7040391

    section Version Conflict
    master (6.415M)   : 0, 6415291

gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5622) (9.486M)   : 0, 9486268
    master (9.647M)   : 0, 9647153
    benchmarks/2.9.0 (9.596M)   : 0, 9596252

    section Automatic
    This PR (5622) (6.715M)   : 0, 6715100
    master (6.592M)   : 0, 6592073

    section Trace stats
    master (6.776M)   : 0, 6775564

    section Manual
    This PR (5622) (8.361M)   : 0, 8360698
    master (8.406M)   : 0, 8406275

    section Manual + Automatic
    This PR (5622) (6.230M)   : 0, 6230128
    master (6.130M)   : 0, 6129538

    section Version Conflict
    master (5.621M)   : 0, 5620706

gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5622) (10.145M)   : 0, 10145382
    master (9.785M)   : 0, 9785489
    benchmarks/2.9.0 (9.869M)   : 0, 9868550

    section Automatic
    This PR (5622) (7.077M)   : 0, 7076948
    master (6.936M)   : 0, 6935654
    benchmarks/2.9.0 (7.444M)   : 0, 7444484

    section Trace stats
    master (7.298M)   : 0, 7298462

    section Manual
    This PR (5622) (8.829M)   : 0, 8829096
    master (8.674M)   : 0, 8674367

    section Manual + Automatic
    This PR (5622) (6.834M)   : 0, 6834422
    master (6.671M)   : 0, 6671278

    section Version Conflict
    master (6.004M)   : 0, 6003969

github-actions bot added area:tracer The core tracer library (Datadog.Trace, does not include OpenTracing, native code, or integrations) area:debugger labels May 28, 2024

GreenMatan changed the title ~~[Dynamic Instrumentation] Cleansing third party module names to avoid conflicts with customer dlls~~ [Dynamic Instrumentation] Cleansing third party module names to avoid conflicts with customer's modules May 28, 2024

Got rid of popular dll names

3230e9b

GreenMatan force-pushed the matang/get-rid-of-popular-dll-name branch from 948fc6e to 3230e9b Compare May 28, 2024 13:32

GreenMatan marked this pull request as ready for review May 28, 2024 13:32

GreenMatan requested a review from a team as a code owner May 28, 2024 13:32

shurivich approved these changes May 28, 2024

View reviewed changes

GreenMatan merged commit db0345c into master May 29, 2024
60 of 62 checks passed

GreenMatan deleted the matang/get-rid-of-popular-dll-name branch May 29, 2024 09:18

github-actions bot added this to the vNext-v2 milestone May 29, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Dynamic Instrumentation] Cleansing third party module names to avoid conflicts with customer's modules #5622

[Dynamic Instrumentation] Cleansing third party module names to avoid conflicts with customer's modules #5622

GreenMatan commented May 28, 2024 •

edited

Loading

andrewlock commented May 28, 2024 •

edited

Loading

andrewlock commented May 28, 2024 •

edited

Loading

Raw results

Raw results

Raw results

More allocations ⚠️ in #5622

Raw results

Raw results

Slower ⚠️ in #5622

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Faster 🎉 in #5622

Raw results

Raw results

datadog-ddstaging bot commented May 28, 2024 •

edited

Loading

shurivich left a comment

andrewlock commented May 28, 2024

[Dynamic Instrumentation] Cleansing third party module names to avoid conflicts with customer's modules #5622

[Dynamic Instrumentation] Cleansing third party module names to avoid conflicts with customer's modules #5622

Conversation

GreenMatan commented May 28, 2024 • edited Loading

Summary of changes

Reason for change

Implementation details

Test coverage

andrewlock commented May 28, 2024 • edited Loading

Execution-Time Benchmarks Report ⏱️

andrewlock commented May 28, 2024 • edited Loading

Benchmarks Report for tracer 🐌

Benchmark details

Raw results

Raw results

Raw results

More allocations ⚠️ in #5622

Raw results

Raw results

Slower ⚠️ in #5622

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Faster 🎉 in #5622

Raw results

Raw results

datadog-ddstaging bot commented May 28, 2024 • edited Loading

Datadog Report

shurivich left a comment

Choose a reason for hiding this comment

andrewlock commented May 28, 2024

Throughput/Crank Report:zap:

GreenMatan commented May 28, 2024 •

edited

Loading

andrewlock commented May 28, 2024 •

edited

Loading

andrewlock commented May 28, 2024 •

edited

Loading

datadog-ddstaging bot commented May 28, 2024 •

edited

Loading