[Dynamic Instrumentation] Aligned the line probe snapshot to fix System Tests failures #5628

GreenMatan · 2024-05-30T11:18:01Z

Summary of changes

There was a check that was added into the System Test that make sure each field in the snapshot is correctly typed. There was a small gap between .NET and Java snapshots where the line field in Java is a string, and in .NET is an int.

This difference is from earlier design decision that was made, to allow a line probe to be applied to multiple lines (hence be presented as X - Y). This decision was discarded by then, but for backward compatibility reasons with previous library versioning the string is kept.

The changes in this PR aligns with this requirement.

Reason for change

Fix System Tests breakage on improper data type.

github-actions · 2024-05-30T11:18:48Z

Snapshots difference summary

The following differences have been observed in committed snapshots. It is meant to help the reviewer.
The diff is simplistic, so please check some files anyway while we improve it.

2 occurrences of :

-              21
+              "21"

2 occurrences of :

-              34
+              "34"

6 occurrences of :

-              23
+              "23"

7 occurrences of :

-              25
+              "25"

6 occurrences of :

-              26
+              "26"

3 occurrences of :

-              27
+              "27"

3 occurrences of :

-              28
+              "28"

2 occurrences of :

-              29
+              "29"

1 occurrences of :

-              45
+              "45"

7 occurrences of :

-              46
+              "46"

1 occurrences of :

-              47
+              "47"

3 occurrences of :

-              35
+              "35"

3 occurrences of :

-              36
+              "36"

2 occurrences of :

-              37
+              "37"

2 occurrences of :

-              42
+              "42"

1 occurrences of :

-              10
+              "10"

2 occurrences of :

-              11
+              "11"

2 occurrences of :

-              12
+              "12"

2 occurrences of :

-              70
+              "70"

3 occurrences of :

-              24
+              "24"

1 occurrences of :

-              30
+              "30"

1 occurrences of :

-              31
+              "31"

4 occurrences of :

-              32
+              "32"

2 occurrences of :

-              22
+              "22"

1 occurrences of :

-              16
+              "16"

1 occurrences of :

-              17
+              "17"

2 occurrences of :

-              18
+              "18"

1 occurrences of :

-                                          "pruned": true
+                                          "notCapturedReason": "depth",
+                                          "type": "BigObject",
+                                          "value": "BigObject"
[...]
-                                          "pruned": true
+                                          "notCapturedReason": "depth",
+                                          "type": "BigObject",
+                                          "value": "BigObject"
[...]
-                                          "pruned": true
+                                          "notCapturedReason": "depth",
+                                          "type": "BigObject",
+                                          "value": "BigObject"
[...]
-                                          "pruned": true
+                                          "notCapturedReason": "depth",
+                                          "type": "BigObject",
+                                          "value": "BigObject"

1 occurrences of :

-              20
+              "20"

2 occurrences of :

-              41
+              "41"

3 occurrences of :

-              55
+              "55"

2 occurrences of :

-              56
+              "56"

1 occurrences of :

-              57
+              "57"

1 occurrences of :

-              58
+              "58"

1 occurrences of :

-              59
+              "59"

2 occurrences of :

-    "ddtags": "Unknown",

1 occurrences of :

-              11
+              "11"
[...]
+          "version": 0

1 occurrences of :

-              12
+              "12"
[...]
+          "version": 0

1 occurrences of :

-              39
+              "39"

1 occurrences of :

-              53
+              "53"

1 occurrences of :

-              51
+              "51"

1 occurrences of :

-              64
+              "64"

1 occurrences of :

-              33
+              "33"

1 occurrences of :

-              38
+              "38"

tracer/src/Datadog.Trace/Debugger/Snapshots/DebuggerSnapshotCreator.cs

shurivich

LGTM.

datadog-ddstaging · 2024-05-30T11:31:55Z

Datadog Report

Branch report: matang/align-line-probe-lines-data-type
Commit report: 7c7586a
Test service: dd-trace-dotnet

❌ 35 Failed (0 Known Flaky), 335400 Passed, 2037 Skipped, 21h 59m 40.39s Total Time
❄️ 20 New Flaky

❌ Failed Tests (35)

This report shows up to 5 failed tests.

Profiler_allocation - scenarios - Details
Expand for error
```
 
 
```
Profiler_allocation - scenarios - Details
Expand for error
```
 
 
```
Profiler_allocation - scenarios - Details
Expand for error
```
 
 
```
Profiler_allocation_cpu_walltime - scenarios - Details
Expand for error
```
 
 
```
Profiler_allocation_cpu_walltime - scenarios - Details
Expand for error
```
 
 
```

New Flaky Tests (20)

ClientDisconnect - Datadog.Trace.ClrProfiler.IntegrationTests.AspNetMvc4TestsCallTargetClassicWithFeatureFlag - Last Failure

Expand for error

 [Test Class Cleanup Failure (Datadog.Trace.ClrProfiler.IntegrationTests.AspNetMvc4TestsCallTargetClassicWithFeatureFlag)]: System.Net.WebException : The operation has timed out

SubmitsTraces - Datadog.Trace.ClrProfiler.IntegrationTests.AspNetMvc4TestsCallTargetClassicWithFeatureFlag - Last Failure

Expand for error

 [Test Class Cleanup Failure (Datadog.Trace.ClrProfiler.IntegrationTests.AspNetMvc4TestsCallTargetClassicWithFeatureFlag)]: System.Net.WebException : The operation has timed out

SubmitsTraces - Datadog.Trace.ClrProfiler.IntegrationTests.AspNetMvc4TestsCallTargetClassicWithFeatureFlag - Last Failure

Expand for error

 [Test Class Cleanup Failure (Datadog.Trace.ClrProfiler.IntegrationTests.AspNetMvc4TestsCallTargetClassicWithFeatureFlag)]: System.Net.WebException : The operation has timed out

SubmitsTraces - Datadog.Trace.ClrProfiler.IntegrationTests.AspNetMvc4TestsCallTargetClassicWithFeatureFlag - Last Failure

Expand for error

 [Test Class Cleanup Failure (Datadog.Trace.ClrProfiler.IntegrationTests.AspNetMvc4TestsCallTargetClassicWithFeatureFlag)]: System.Net.WebException : The operation has timed out

SubmitsTraces - Datadog.Trace.ClrProfiler.IntegrationTests.AspNetMvc4TestsCallTargetClassicWithFeatureFlag - Last Failure

Expand for error

 [Test Class Cleanup Failure (Datadog.Trace.ClrProfiler.IntegrationTests.AspNetMvc4TestsCallTargetClassicWithFeatureFlag)]: System.Net.WebException : The operation has timed out

andrewlock · 2024-05-30T11:42:10Z

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

Welch test with statistical test for significance of 5%
Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5628) - mean (72ms)  : 64, 81
     .   : milestone, 72,
    master - mean (73ms)  : 63, 82
     .   : milestone, 73,

    section CallTarget+Inlining+NGEN
    This PR (5628) - mean (995ms)  : 973, 1018
     .   : milestone, 995,
    master - mean (996ms)  : 974, 1018
     .   : milestone, 996,

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5628) - mean (109ms)  : 106, 112
     .   : milestone, 109,
    master - mean (109ms)  : 106, 112
     .   : milestone, 109,

    section CallTarget+Inlining+NGEN
    This PR (5628) - mean (712ms)  : 691, 733
     .   : milestone, 712,
    master - mean (712ms)  : 690, 735
     .   : milestone, 712,

gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5628) - mean (92ms)  : 89, 95
     .   : milestone, 92,
    master - mean (93ms)  : 90, 97
     .   : milestone, 93,

    section CallTarget+Inlining+NGEN
    This PR (5628) - mean (662ms)  : 638, 685
     .   : milestone, 662,
    master - mean (665ms)  : 641, 689
     .   : milestone, 665,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5628) - mean (192ms)  : 189, 196
     .   : milestone, 192,
    master - mean (192ms)  : 188, 196
     .   : milestone, 192,

    section CallTarget+Inlining+NGEN
    This PR (5628) - mean (1,096ms)  : 1074, 1118
     .   : milestone, 1096,
    master - mean (1,097ms)  : 1080, 1114
     .   : milestone, 1097,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5628) - mean (278ms)  : 274, 282
     .   : milestone, 278,
    master - mean (277ms)  : 272, 281
     .   : milestone, 277,

    section CallTarget+Inlining+NGEN
    This PR (5628) - mean (893ms)  : 871, 916
     .   : milestone, 893,
    master - mean (897ms)  : 874, 919
     .   : milestone, 897,

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5628) - mean (267ms)  : 263, 271
     .   : milestone, 267,
    master - mean (268ms)  : 264, 272
     .   : milestone, 268,

    section CallTarget+Inlining+NGEN
    This PR (5628) - mean (876ms)  : 851, 901
     .   : milestone, 876,
    master - mean (875ms)  : 853, 898
     .   : milestone, 875,

andrewlock · 2024-05-30T12:40:45Z

Throughput/Crank Report:zap:

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5628) (11.477M)   : 0, 11476822
    master (12.119M)   : 0, 12119071
    benchmarks/2.9.0 (11.934M)   : 0, 11934329

    section Automatic
    This PR (5628) (7.715M)   : crit ,0, 7714940
    master (8.127M)   : 0, 8127212
    benchmarks/2.9.0 (8.544M)   : 0, 8544145

    section Trace stats
    master (8.573M)   : 0, 8573333

    section Manual
    This PR (5628) (10.014M)   : 0, 10014313
    master (10.412M)   : 0, 10411657

    section Manual + Automatic
    This PR (5628) (7.265M)   : crit ,0, 7265415
    master (7.679M)   : 0, 7678738

    section Version Conflict
    master (6.916M)   : 0, 6916380

gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5628) (9.457M)   : 0, 9456876
    master (9.542M)   : 0, 9542196
    benchmarks/2.9.0 (9.673M)   : 0, 9672539

    section Automatic
    This PR (5628) (6.630M)   : 0, 6629820
    master (6.484M)   : 0, 6483952

    section Trace stats
    master (6.900M)   : 0, 6899505

    section Manual
    This PR (5628) (8.274M)   : 0, 8273847
    master (8.238M)   : 0, 8238350

    section Manual + Automatic
    This PR (5628) (6.208M)   : 0, 6207729
    master (6.218M)   : 0, 6217649

    section Version Conflict
    master (5.714M)   : 0, 5713748

gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5628) (9.829M)   : 0, 9828911
    master (10.207M)   : 0, 10206794
    benchmarks/2.9.0 (9.886M)   : 0, 9886161

    section Automatic
    This PR (5628) (6.940M)   : 0, 6939976
    master (7.069M)   : 0, 7068638
    benchmarks/2.9.0 (7.243M)   : 0, 7243023

    section Trace stats
    master (7.363M)   : 0, 7362715

    section Manual
    This PR (5628) (8.537M)   : 0, 8537214
    master (8.863M)   : 0, 8862765

    section Manual + Automatic
    This PR (5628) (6.639M)   : 0, 6638979
    master (6.734M)   : 0, 6734211

    section Version Conflict
    master (6.179M)   : 0, 6179243

andrewlock · 2024-05-30T12:44:15Z

Benchmarks Report for tracer 🐌

Benchmarks for #5628 compared to master:

4 benchmarks are faster, with geometric mean 1.268
1 benchmarks are slower, with geometric mean 1.121
All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

Mann–Whitney U test with statistical test for significance of 5%
Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #5628

Benchmark	base/diff	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.ActivityBenchmark.StartStopWithChild‑net472	1.193	21,087.31	17,682.36
Benchmarks.Trace.ActivityBenchmark.StartStopWithChild‑net6.0	1.189	10,469.43	8,806.42	bimodal
Benchmarks.Trace.ActivityBenchmark.StartStopWithChild‑netcoreapp3.1	1.188	12,770.21	10,747.12

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`StartStopWithChild`	net6.0	10.5μs	59.9ns	445ns	0.0257	0.0103	0	7.55 KB
master	`StartStopWithChild`	netcoreapp3.1	12.8μs	73.2ns	604ns	0.0253	0.00631	0	7.65 KB
master	`StartStopWithChild`	net472	21μs	101ns	404ns	1.35	0.364	0.111	8.06 KB
#5628	`StartStopWithChild`	net6.0	8.79μs	48.2ns	273ns	0.0212	0.00847	0	7.56 KB
#5628	`StartStopWithChild`	netcoreapp3.1	10.8μs	49.1ns	230ns	0.0277	0.0111	0	7.64 KB
#5628	`StartStopWithChild`	net472	17.7μs	83.3ns	323ns	1.33	0.329	0.107	8.07 KB

Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	503μs	2.57μs	12.3μs	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	629μs	332ns	1.29μs	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	net472	845μs	237ns	919ns	0.422	3.3 KB
#5628	`WriteAndFlushEnrichedTraces`	net6.0	483μs	149ns	576ns	0	2.7 KB
#5628	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	655μs	259ns	1μs	0	2.7 KB
#5628	`WriteAndFlushEnrichedTraces`	net472	850μs	150ns	562ns	0.425	3.3 KB

Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendRequest`	net6.0	168μs	230ns	892ns	0.251	18.44 KB
master	`SendRequest`	netcoreapp3.1	192μs	346ns	1.34μs	0.194	20.6 KB
master	`SendRequest`	net472	0.000448ns	0.000218ns	0.000844ns	0	0 b
#5628	`SendRequest`	net6.0	169μs	282ns	1.09μs	0.169	18.44 KB
#5628	`SendRequest`	netcoreapp3.1	193μs	398ns	1.54μs	0.192	20.6 KB
#5628	`SendRequest`	net472	0.000222ns	0.000142ns	0.000533ns	0	0 b

Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	558μs	404ns	1.57μs	0.553	0	0	41.59 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	674μs	2.22μs	8.58μs	0.329	0	0	41.66 KB
master	`WriteAndFlushEnrichedTraces`	net472	855μs	4.13μs	17.5μs	8.39	2.52	0.419	53.26 KB
#5628	`WriteAndFlushEnrichedTraces`	net6.0	562μs	533ns	2.06μs	0.548	0	0	41.51 KB
#5628	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	657μs	1.47μs	5.69μs	0.331	0	0	41.62 KB
#5628	`WriteAndFlushEnrichedTraces`	net472	843μs	4.16μs	17.2μs	8.08	2.55	0.425	53.26 KB

Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`ExecuteNonQuery`	net6.0	1.09μs	0.507ns	1.9ns	0.0114	808 B
master	`ExecuteNonQuery`	netcoreapp3.1	1.49μs	0.86ns	3.33ns	0.0104	808 B
master	`ExecuteNonQuery`	net472	1.73μs	2.09ns	8.09ns	0.122	770 B
#5628	`ExecuteNonQuery`	net6.0	1.08μs	0.427ns	1.48ns	0.0113	808 B
#5628	`ExecuteNonQuery`	netcoreapp3.1	1.48μs	0.872ns	3.38ns	0.0105	808 B
#5628	`ExecuteNonQuery`	net472	1.66μs	1.91ns	7.38ns	0.122	770 B

Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`CallElasticsearch`	net6.0	1.21μs	0.19ns	0.658ns	0.0138	0	976 B
master	`CallElasticsearch`	netcoreapp3.1	1.57μs	0.428ns	1.66ns	0.0134	0	976 B
master	`CallElasticsearch`	net472	2.57μs	0.977ns	3.66ns	0.158	0	995 B
master	`CallElasticsearchAsync`	net6.0	1.22μs	0.813ns	3.15ns	0.0135	0	952 B
master	`CallElasticsearchAsync`	netcoreapp3.1	1.63μs	0.497ns	1.92ns	0.0139	0	1.02 KB
master	`CallElasticsearchAsync`	net472	2.58μs	2.01ns	7.79ns	0.166	0	1.05 KB
#5628	`CallElasticsearch`	net6.0	1.2μs	1.24ns	4.64ns	0.0138	0	976 B
#5628	`CallElasticsearch`	netcoreapp3.1	1.5μs	0.375ns	1.4ns	0.0134	0	976 B
#5628	`CallElasticsearch`	net472	2.39μs	1.64ns	6.35ns	0.158	0.00119	995 B
#5628	`CallElasticsearchAsync`	net6.0	1.32μs	0.454ns	1.76ns	0.0132	0	952 B
#5628	`CallElasticsearchAsync`	netcoreapp3.1	1.7μs	1.72ns	6.2ns	0.0135	0	1.02 KB
#5628	`CallElasticsearchAsync`	net472	2.45μs	3.29ns	11.9ns	0.166	0.00123	1.05 KB

Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`ExecuteAsync`	net6.0	1.23μs	2.19ns	8.19ns	0.0134	0	952 B
master	`ExecuteAsync`	netcoreapp3.1	1.59μs	0.635ns	2.29ns	0.0127	0	952 B
master	`ExecuteAsync`	net472	1.79μs	1.81ns	7.03ns	0.145	0	915 B
#5628	`ExecuteAsync`	net6.0	1.3μs	1.36ns	5.08ns	0.013	0	952 B
#5628	`ExecuteAsync`	netcoreapp3.1	1.62μs	0.962ns	3.6ns	0.0132	0	952 B
#5628	`ExecuteAsync`	net472	1.8μs	0.677ns	2.44ns	0.145	0.000891	915 B

Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendAsync`	net6.0	4.1μs	3.93ns	14.7ns	0.0307	2.22 KB
master	`SendAsync`	netcoreapp3.1	5.12μs	1.67ns	6.45ns	0.0382	2.76 KB
master	`SendAsync`	net472	7.47μs	2.85ns	11ns	0.496	3.12 KB
#5628	`SendAsync`	net6.0	4.25μs	2.04ns	7.62ns	0.0297	2.22 KB
#5628	`SendAsync`	netcoreapp3.1	5.12μs	1.59ns	5.94ns	0.0357	2.76 KB
#5628	`SendAsync`	net472	7.57μs	3.46ns	13.4ns	0.493	3.12 KB

Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	1.54μs	0.632ns	2.36ns	0.023	1.64 KB
master	`EnrichedLog`	netcoreapp3.1	2.14μs	1.12ns	4.18ns	0.0222	1.64 KB
master	`EnrichedLog`	net472	2.5μs	0.941ns	3.65ns	0.249	1.57 KB
#5628	`EnrichedLog`	net6.0	1.62μs	1.09ns	4.08ns	0.0227	1.64 KB
#5628	`EnrichedLog`	netcoreapp3.1	2.23μs	1.28ns	4.96ns	0.0223	1.64 KB
#5628	`EnrichedLog`	net472	2.48μs	1.5ns	5.62ns	0.249	1.57 KB

Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`EnrichedLog`	net6.0	118μs	78.3ns	303ns	0.0584	0	4.28 KB
master	`EnrichedLog`	netcoreapp3.1	121μs	86.2ns	322ns	0	0	4.28 KB
master	`EnrichedLog`	net472	152μs	60.7ns	227ns	0.683	0.228	4.46 KB
#5628	`EnrichedLog`	net6.0	117μs	170ns	657ns	0.0581	0	4.28 KB
#5628	`EnrichedLog`	netcoreapp3.1	120μs	87.5ns	327ns	0	0	4.28 KB
#5628	`EnrichedLog`	net472	152μs	60.2ns	233ns	0.68	0.227	4.46 KB

Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	3.03μs	1.33ns	4.99ns	0.0304	2.2 KB
master	`EnrichedLog`	netcoreapp3.1	4.23μs	2.32ns	9ns	0.0298	2.2 KB
master	`EnrichedLog`	net472	4.76μs	2.05ns	7.69ns	0.319	2.02 KB
#5628	`EnrichedLog`	net6.0	3.08μs	0.889ns	3.44ns	0.0309	2.2 KB
#5628	`EnrichedLog`	netcoreapp3.1	4.14μs	7.37ns	28.5ns	0.0287	2.2 KB
#5628	`EnrichedLog`	net472	4.86μs	2.04ns	7.89ns	0.32	2.02 KB

Benchmarks.Trace.RedisBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #5628

Benchmark	diff/base	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.RedisBenchmark.SendReceive‑net6.0	1.121	1,305.74	1,463.69

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendReceive`	net6.0	1.31μs	0.598ns	2.24ns	0.0157	1.14 KB
master	`SendReceive`	netcoreapp3.1	1.81μs	1.82ns	7.04ns	0.0158	1.14 KB
master	`SendReceive`	net472	2.13μs	0.798ns	2.88ns	0.183	1.16 KB
#5628	`SendReceive`	net6.0	1.46μs	0.834ns	3.23ns	0.0161	1.14 KB
#5628	`SendReceive`	netcoreapp3.1	1.75μs	0.887ns	3.43ns	0.0149	1.14 KB
#5628	`SendReceive`	net472	2.1μs	1.32ns	5.11ns	0.183	1.16 KB

Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	2.77μs	0.791ns	2.96ns	0.0223	1.6 KB
master	`EnrichedLog`	netcoreapp3.1	3.9μs	1.1ns	4.26ns	0.0216	1.65 KB
master	`EnrichedLog`	net472	4.52μs	2.04ns	7.63ns	0.322	2.04 KB
#5628	`EnrichedLog`	net6.0	2.82μs	1.34ns	5.21ns	0.0226	1.6 KB
#5628	`EnrichedLog`	netcoreapp3.1	4.13μs	2.03ns	7.88ns	0.0207	1.65 KB
#5628	`EnrichedLog`	net472	4.35μs	1.57ns	5.67ns	0.323	2.04 KB

Benchmarks.Trace.SpanBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #5628

Benchmark	base/diff	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net6.0	1.534	629.70	410.55	several?

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`StartFinishSpan`	net6.0	642ns	11.2ns	112ns	0.00813	576 B
master	`StartFinishSpan`	netcoreapp3.1	572ns	0.674ns	2.61ns	0.00775	576 B
master	`StartFinishSpan`	net472	611ns	1.02ns	3.94ns	0.0916	578 B
master	`StartFinishScope`	net6.0	497ns	0.203ns	0.761ns	0.00978	696 B
master	`StartFinishScope`	netcoreapp3.1	737ns	0.308ns	1.19ns	0.00951	696 B
master	`StartFinishScope`	net472	897ns	0.801ns	3.1ns	0.104	658 B
#5628	`StartFinishSpan`	net6.0	411ns	0.152ns	0.569ns	0.00805	576 B
#5628	`StartFinishSpan`	netcoreapp3.1	556ns	2.74ns	11.6ns	0.00787	576 B
#5628	`StartFinishSpan`	net472	653ns	2.47ns	9.58ns	0.0915	578 B
#5628	`StartFinishScope`	net6.0	485ns	0.226ns	0.847ns	0.00975	696 B
#5628	`StartFinishScope`	netcoreapp3.1	707ns	0.442ns	1.71ns	0.00957	696 B
#5628	`StartFinishScope`	net472	856ns	1.21ns	4.7ns	0.104	658 B

Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`RunOnMethodBegin`	net6.0	622ns	0.357ns	1.38ns	0.00996	696 B
master	`RunOnMethodBegin`	netcoreapp3.1	971ns	0.519ns	2.01ns	0.00932	696 B
master	`RunOnMethodBegin`	net472	1.07μs	1.27ns	4.94ns	0.104	658 B
#5628	`RunOnMethodBegin`	net6.0	600ns	0.162ns	0.605ns	0.00988	696 B
#5628	`RunOnMethodBegin`	netcoreapp3.1	926ns	0.56ns	2.17ns	0.00952	696 B
#5628	`RunOnMethodBegin`	net472	1.07μs	0.863ns	3.34ns	0.104	658 B

GreenMatan requested a review from a team as a code owner May 30, 2024 11:18

GreenMatan force-pushed the matang/align-line-probe-lines-data-type branch from 13d2d01 to 51a5ecb Compare May 30, 2024 11:18

github-actions bot added the area:debugger label May 30, 2024

shurivich reviewed May 30, 2024

View reviewed changes

tracer/src/Datadog.Trace/Debugger/Snapshots/DebuggerSnapshotCreator.cs Show resolved Hide resolved

shurivich approved these changes May 30, 2024

View reviewed changes

Changed the lines in the snapshot from int to string

7c7586a

GreenMatan force-pushed the matang/align-line-probe-lines-data-type branch from 51a5ecb to 7c7586a Compare May 30, 2024 11:53

GreenMatan merged commit 0d9b857 into master May 30, 2024
62 checks passed

GreenMatan deleted the matang/align-line-probe-lines-data-type branch May 30, 2024 13:53

github-actions bot added this to the vNext-v2 milestone May 30, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Dynamic Instrumentation] Aligned the line probe snapshot to fix System Tests failures #5628

[Dynamic Instrumentation] Aligned the line probe snapshot to fix System Tests failures #5628

GreenMatan commented May 30, 2024 •

edited

Loading

github-actions bot commented May 30, 2024 •

edited

Loading

shurivich left a comment

datadog-ddstaging bot commented May 30, 2024 •

edited

Loading

andrewlock commented May 30, 2024 •

edited

Loading

andrewlock commented May 30, 2024

andrewlock commented May 30, 2024

Faster 🎉 in #5628

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Slower ⚠️ in #5628

Raw results

Raw results

Faster 🎉 in #5628

Raw results

Raw results

[Dynamic Instrumentation] Aligned the line probe snapshot to fix System Tests failures #5628

[Dynamic Instrumentation] Aligned the line probe snapshot to fix System Tests failures #5628

Conversation

GreenMatan commented May 30, 2024 • edited Loading

Summary of changes

Reason for change

github-actions bot commented May 30, 2024 • edited Loading

Snapshots difference summary

shurivich left a comment

Choose a reason for hiding this comment

datadog-ddstaging bot commented May 30, 2024 • edited Loading

Datadog Report

❌ Failed Tests (35)

New Flaky Tests (20)

andrewlock commented May 30, 2024 • edited Loading

Execution-Time Benchmarks Report ⏱️

andrewlock commented May 30, 2024

Throughput/Crank Report:zap:

andrewlock commented May 30, 2024

Benchmarks Report for tracer 🐌

Benchmark details

Faster 🎉 in #5628

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Slower ⚠️ in #5628

Raw results

Raw results

Faster 🎉 in #5628

Raw results

Raw results

GreenMatan commented May 30, 2024 •

edited

Loading

github-actions bot commented May 30, 2024 •

edited

Loading

datadog-ddstaging bot commented May 30, 2024 •

edited

Loading

andrewlock commented May 30, 2024 •

edited

Loading