Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Serilog v4 #5649

Merged
merged 3 commits into from
Jun 7, 2024
Merged

Add support for Serilog v4 #5649

merged 3 commits into from
Jun 7, 2024

Conversation

bouwkast
Copy link
Contributor

@bouwkast bouwkast commented Jun 4, 2024

Summary of changes

Serilog has come out with a new major version (V4) which has now changed the AssemblyVersion to be inline with the NuGet version. This updates our instrumentation and supported packages for that.

Didn't notice any issues or other changes with V4.

Reason for change

V4 of Serilog didn't work as it's AssemblyVersion changed.

Implementation details

  • Ran generate package versions and committed the Serilog changes
  • Updated Serilog instrumentations to support V4

Test coverage

  • Ran tests locally and they passed.

Other details

@datadog-ddstaging
Copy link

datadog-ddstaging bot commented Jun 4, 2024 •
edited
Loading

Datadog Report

Branch report: steven/serilog-v4
Commit report: cd44cfd
Test service: dd-trace-dotnet

✅ 0 Failed, 335469 Passed, 1586 Skipped, 14h 6m 25.77s Total Time
❄️ 1 New Flaky

New Flaky Tests (1)

  • SubmitsTraces - Datadog.Trace.ClrProfiler.IntegrationTests.AWS.AwsKinesisTests - Last Failure

    Expand for error 
     Expected relevantSpans to contain at least 5 item(s) because we want to ensure that we don't timeout while waiting for spans from the mock tracer agent, but found 0: {empty}.

@andrewlock
Copy link
Member

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5649) - mean (74ms)  : 62, 86
     .   : milestone, 74,
    master - mean (75ms)  : 64, 86
     .   : milestone, 75,

    section CallTarget+Inlining+NGEN
    This PR (5649) - mean (991ms)  : 924, 1057
     .   : milestone, 991,
    master - mean (977ms)  : 955, 998
     .   : milestone, 977,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5649) - mean (111ms)  : 106, 116
     .   : milestone, 111,
    master - mean (109ms)  : 105, 113
     .   : milestone, 109,

    section CallTarget+Inlining+NGEN
    This PR (5649) - mean (695ms)  : 661, 729
     .   : milestone, 695,
    master - mean (687ms)  : 665, 708
     .   : milestone, 687,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5649) - mean (93ms)  : 90, 96
     .   : milestone, 93,
    master - mean (93ms)  : 89, 97
     .   : milestone, 93,

    section CallTarget+Inlining+NGEN
    This PR (5649) - mean (645ms)  : 609, 681
     .   : milestone, 645,
    master - mean (645ms)  : 625, 665
     .   : milestone, 645,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5649) - mean (193ms)  : 188, 198
     .   : milestone, 193,
    master - mean (191ms)  : 188, 195
     .   : milestone, 191,

    section CallTarget+Inlining+NGEN
    This PR (5649) - mean (1,075ms)  : 1050, 1100
     .   : milestone, 1075,
    master - mean (1,071ms)  : 1042, 1100
     .   : milestone, 1071,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5649) - mean (277ms)  : 273, 280
     .   : milestone, 277,
    master - mean (276ms)  : 272, 281
     .   : milestone, 276,

    section CallTarget+Inlining+NGEN
    This PR (5649) - mean (861ms)  : 845, 878
     .   : milestone, 861,
    master - mean (864ms)  : 830, 898
     .   : milestone, 864,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5649) - mean (266ms)  : 263, 270
     .   : milestone, 266,
    master - mean (266ms)  : 261, 270
     .   : milestone, 266,

    section CallTarget+Inlining+NGEN
    This PR (5649) - mean (848ms)  : 829, 868
     .   : milestone, 848,
    master - mean (851ms)  : 826, 875
     .   : milestone, 851,
Loading

@andrewlock
Copy link
Member

Benchmarks Report for tracer 🐌

Benchmarks for #5649 compared to master:

  • 1 benchmarks are faster, with geometric mean 1.137
  • 1 benchmarks are slower, with geometric mean 1.136
  • 1 benchmarks have fewer allocations
  • 4 benchmarks have more allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ More allocations ⚠️

More allocations ⚠️ in #5649

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.ActivityBenchmark.StartStopWithChild‑netcoreapp3.1 7.65 KB 7.78 KB 132 B 1.73%
Benchmarks.Trace.ActivityBenchmark.StartStopWithChild‑net6.0 7.56 KB 7.69 KB 130 B 1.72%
Benchmarks.Trace.ActivityBenchmark.StartStopWithChild‑net472 8.06 KB 8.2 KB 136 B 1.69%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 8.85μs 48.1ns 263ns 0.0214 0.00854 0 7.56 KB
master StartStopWithChild netcoreapp3.1 10.7μs 58.9ns 358ns 0.0359 0.0154 0 7.65 KB
master StartStopWithChild net472 17.3μs 58.3ns 226ns 1.35 0.354 0.103 8.06 KB
#5649 StartStopWithChild net6.0 8.92μs 48.1ns 276ns 0.0222 0.0089 0 7.69 KB
#5649 StartStopWithChild netcoreapp3.1 11.1μs 58.7ns 288ns 0.0228 0.0114 0 7.78 KB
#5649 StartStopWithChild net472 17.3μs 55ns 206ns 1.38 0.342 0.12 8.2 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 472μs 168ns 629ns 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 640μs 303ns 1.17μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 839μs 289ns 1.12μs 0.417 0 0 3.3 KB
#5649 WriteAndFlushEnrichedTraces net6.0 470μs 437ns 1.69μs 0 0 0 2.7 KB
#5649 WriteAndFlushEnrichedTraces netcoreapp3.1 641μs 804ns 3.12μs 0 0 0 2.7 KB
#5649 WriteAndFlushEnrichedTraces net472 853μs 254ns 949ns 0.425 0 0 3.3 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 172μs 241ns 933ns 0.256 0 0 18.44 KB
master SendRequest netcoreapp3.1 192μs 231ns 864ns 0.192 0 0 20.6 KB
master SendRequest net472 0.000276ns 0.000116ns 0.000434ns 0 0 0 0 b
#5649 SendRequest net6.0 174μs 266ns 1.03μs 0.258 0 0 18.44 KB
#5649 SendRequest netcoreapp3.1 191μs 434ns 1.68μs 0.19 0 0 20.6 KB
#5649 SendRequest net472 0.000403ns 0.000221ns 0.000856ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ More allocations ⚠️

More allocations ⚠️ in #5649

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑net6.0 41.57 KB 41.78 KB 210 B 0.51%

Fewer allocations 🎉 in #5649

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑netcoreapp3.1 41.82 KB 41.61 KB -213 B -0.51%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 554μs 350ns 1.36μs 0.551 0 0 41.57 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 647μs 1.3μs 5.05μs 0.324 0 0 41.82 KB
master WriteAndFlushEnrichedTraces net472 847μs 4.21μs 17.9μs 8.17 2.45 0.408 53.26 KB
#5649 WriteAndFlushEnrichedTraces net6.0 554μs 1.72μs 6.68μs 0.543 0 0 41.78 KB
#5649 WriteAndFlushEnrichedTraces netcoreapp3.1 672μs 1.8μs 6.97μs 0.338 0 0 41.61 KB
#5649 WriteAndFlushEnrichedTraces net472 851μs 2.78μs 10.8μs 8.15 2.26 0.453 53.23 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.09μs 0.743ns 2.88ns 0.0114 0 0 808 B
master ExecuteNonQuery netcoreapp3.1 1.47μs 0.626ns 2.42ns 0.0108 0 0 808 B
master ExecuteNonQuery net472 1.71μs 1.68ns 6.5ns 0.122 0 0 770 B
#5649 ExecuteNonQuery net6.0 1.2μs 0.8ns 3.1ns 0.0114 0 0 808 B
#5649 ExecuteNonQuery netcoreapp3.1 1.52μs 1.07ns 4.16ns 0.0107 0 0 808 B
#5649 ExecuteNonQuery net472 1.78μs 1.44ns 5.57ns 0.122 0 0 770 B
Benchmarks.Trace.ElasticsearchBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #5649

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync‑net6.0 1.136 1,156.70 1,313.99

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.22μs 0.965ns 3.61ns 0.0135 0 0 976 B
master CallElasticsearch netcoreapp3.1 1.51μs 1.76ns 6.57ns 0.0127 0 0 976 B
master CallElasticsearch net472 2.56μs 1.7ns 6.13ns 0.158 0 0 995 B
master CallElasticsearchAsync net6.0 1.16μs 0.362ns 1.36ns 0.0133 0 0 952 B
master CallElasticsearchAsync netcoreapp3.1 1.65μs 1.72ns 6.65ns 0.0141 0 0 1.02 KB
master CallElasticsearchAsync net472 2.62μs 5.79ns 22.4ns 0.166 0.00133 0 1.05 KB
#5649 CallElasticsearch net6.0 1.18μs 0.813ns 3.04ns 0.0136 0 0 976 B
#5649 CallElasticsearch netcoreapp3.1 1.55μs 0.544ns 2.03ns 0.0127 0 0 976 B
#5649 CallElasticsearch net472 2.54μs 3.39ns 13.1ns 0.157 0 0 995 B
#5649 CallElasticsearchAsync net6.0 1.31μs 2.02ns 7.81ns 0.0131 0 0 952 B
#5649 CallElasticsearchAsync netcoreapp3.1 1.63μs 1.1ns 4.11ns 0.0136 0 0 1.02 KB
#5649 CallElasticsearchAsync net472 2.53μs 1.79ns 6.69ns 0.166 0 0 1.05 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.17μs 0.676ns 2.62ns 0.0135 0 0 952 B
master ExecuteAsync netcoreapp3.1 1.68μs 1.53ns 5.73ns 0.0128 0 0 952 B
master ExecuteAsync net472 1.79μs 0.479ns 1.73ns 0.145 0 0 915 B
#5649 ExecuteAsync net6.0 1.18μs 0.712ns 2.66ns 0.0135 0 0 952 B
#5649 ExecuteAsync netcoreapp3.1 1.58μs 0.728ns 2.72ns 0.0125 0 0 952 B
#5649 ExecuteAsync net472 1.87μs 0.596ns 2.31ns 0.145 0.000939 0 915 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 4.1μs 1.33ns 4.98ns 0.0307 0 0 2.22 KB
master SendAsync netcoreapp3.1 5.17μs 4.5ns 17.4ns 0.0363 0 0 2.76 KB
master SendAsync net472 7.47μs 2.09ns 8.11ns 0.496 0 0 3.12 KB
#5649 SendAsync net6.0 4.15μs 1.5ns 5.81ns 0.031 0 0 2.22 KB
#5649 SendAsync netcoreapp3.1 5.02μs 2.3ns 8.61ns 0.0351 0 0 2.76 KB
#5649 SendAsync net472 7.42μs 1.75ns 6.55ns 0.494 0 0 3.12 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 1.45μs 0.932ns 3.49ns 0.0231 0 0 1.64 KB
master EnrichedLog netcoreapp3.1 2.21μs 0.984ns 3.81ns 0.022 0 0 1.64 KB
master EnrichedLog net472 2.49μs 1.05ns 4.08ns 0.249 0 0 1.57 KB
#5649 EnrichedLog net6.0 1.48μs 0.758ns 2.93ns 0.0229 0 0 1.64 KB
#5649 EnrichedLog netcoreapp3.1 2.15μs 1.32ns 5.11ns 0.0215 0 0 1.64 KB
#5649 EnrichedLog net472 2.66μs 1.1ns 4.24ns 0.249 0 0 1.57 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 117μs 184ns 713ns 0.0579 0 0 4.28 KB
master EnrichedLog netcoreapp3.1 120μs 139ns 520ns 0 0 0 4.28 KB
master EnrichedLog net472 150μs 70.1ns 272ns 0.673 0.224 0 4.46 KB
#5649 EnrichedLog net6.0 115μs 101ns 390ns 0 0 0 4.28 KB
#5649 EnrichedLog netcoreapp3.1 120μs 123ns 478ns 0 0 0 4.28 KB
#5649 EnrichedLog net472 150μs 92.3ns 357ns 0.674 0.225 0 4.46 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 3.03μs 0.311ns 1.2ns 0.0306 0 0 2.2 KB
master EnrichedLog netcoreapp3.1 4.24μs 1.78ns 6.4ns 0.0296 0 0 2.2 KB
master EnrichedLog net472 4.77μs 1.56ns 6.06ns 0.321 0 0 2.02 KB
#5649 EnrichedLog net6.0 3.01μs 0.657ns 2.54ns 0.0301 0 0 2.2 KB
#5649 EnrichedLog netcoreapp3.1 4.21μs 1.77ns 6.85ns 0.0295 0 0 2.2 KB
#5649 EnrichedLog net472 4.85μs 1.44ns 5.58ns 0.319 0 0 2.02 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 1.35μs 0.799ns 3.09ns 0.0162 0 0 1.14 KB
master SendReceive netcoreapp3.1 1.82μs 0.987ns 3.82ns 0.0154 0 0 1.14 KB
master SendReceive net472 2.08μs 1.34ns 5.17ns 0.183 0.00106 0 1.16 KB
#5649 SendReceive net6.0 1.27μs 0.8ns 2.99ns 0.0158 0 0 1.14 KB
#5649 SendReceive netcoreapp3.1 1.74μs 1.07ns 4.02ns 0.0156 0 0 1.14 KB
#5649 SendReceive net472 2.08μs 1.15ns 4.15ns 0.184 0 0 1.16 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.8μs 0.697ns 2.61ns 0.0224 0 0 1.6 KB
master EnrichedLog netcoreapp3.1 3.83μs 2.59ns 10ns 0.0229 0 0 1.65 KB
master EnrichedLog net472 4.44μs 2.67ns 10.4ns 0.322 0 0 2.04 KB
#5649 EnrichedLog net6.0 2.75μs 0.936ns 3.5ns 0.022 0 0 1.6 KB
#5649 EnrichedLog netcoreapp3.1 3.86μs 2.11ns 8.19ns 0.0213 0 0 1.65 KB
#5649 EnrichedLog net472 4.44μs 7.22ns 27.9ns 0.322 0 0 2.04 KB
Benchmarks.Trace.SpanBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #5649

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net472 1.137 656.23 576.97

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 389ns 0.0922ns 0.345ns 0.00801 0 0 576 B
master StartFinishSpan netcoreapp3.1 548ns 0.856ns 3.32ns 0.00766 0 0 576 B
master StartFinishSpan net472 657ns 0.475ns 1.84ns 0.0918 0 0 578 B
master StartFinishScope net6.0 475ns 0.274ns 1.06ns 0.00966 0 0 696 B
master StartFinishScope netcoreapp3.1 709ns 0.519ns 2.01ns 0.00954 0 0 696 B
master StartFinishScope net472 870ns 0.92ns 3.56ns 0.104 0 0 658 B
#5649 StartFinishSpan net6.0 401ns 0.247ns 0.956ns 0.00808 0 0 576 B
#5649 StartFinishSpan netcoreapp3.1 540ns 0.406ns 1.52ns 0.00784 0 0 576 B
#5649 StartFinishSpan net472 577ns 0.443ns 1.71ns 0.0916 0 0 578 B
#5649 StartFinishScope net6.0 528ns 0.181ns 0.701ns 0.00974 0 0 696 B
#5649 StartFinishScope netcoreapp3.1 770ns 0.321ns 1.24ns 0.00958 0 0 696 B
#5649 StartFinishScope net472 791ns 0.239ns 0.924ns 0.105 0 0 658 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 590ns 0.326ns 1.26ns 0.0098 0 0 696 B
master RunOnMethodBegin netcoreapp3.1 936ns 1.16ns 4.5ns 0.00971 0 0 696 B
master RunOnMethodBegin net472 1.07μs 0.563ns 2.18ns 0.104 0 0 658 B
#5649 RunOnMethodBegin net6.0 644ns 0.235ns 0.909ns 0.00969 0 0 696 B
#5649 RunOnMethodBegin netcoreapp3.1 991ns 0.383ns 1.48ns 0.00945 0 0 696 B
#5649 RunOnMethodBegin net472 1.08μs 0.216ns 0.808ns 0.104 0 0 658 B

@andrewlock
Copy link
Member

Throughput/Crank Report:zap:

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5649) (11.515M)   : 0, 11515323
    master (11.308M)   : 0, 11308056
    benchmarks/2.9.0 (11.482M)   : 0, 11482120

    section Automatic
    This PR (5649) (7.707M)   : 0, 7707381
    master (7.743M)   : 0, 7742782
    benchmarks/2.9.0 (8.261M)   : 0, 8261135

    section Trace stats
    master (8.032M)   : 0, 8031945

    section Manual
    This PR (5649) (9.791M)   : 0, 9791079
    master (9.959M)   : 0, 9959205

    section Manual + Automatic
    This PR (5649) (7.254M)   : 0, 7253685
    master (7.319M)   : 0, 7318751

    section Version Conflict
    master (6.513M)   : 0, 6512738
Loading 
gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5649) (9.802M)   : 0, 9802479
    master (9.613M)   : 0, 9612762
    benchmarks/2.9.0 (9.752M)   : 0, 9752478

    section Automatic
    This PR (5649) (6.414M)   : 0, 6413928
    master (6.614M)   : 0, 6614282

    section Trace stats
    master (6.940M)   : 0, 6939747

    section Manual
    This PR (5649) (8.155M)   : 0, 8154795
    master (8.279M)   : 0, 8279328

    section Manual + Automatic
    This PR (5649) (6.169M)   : 0, 6168875
    master (6.254M)   : 0, 6253875

    section Version Conflict
    master (5.783M)   : 0, 5782655
Loading 
gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5649) (9.862M)   : 0, 9862286
    master (9.931M)   : 0, 9931208
    benchmarks/2.9.0 (9.820M)   : 0, 9820306

    section Automatic
    This PR (5649) (7.054M)   : 0, 7054429
    master (7.076M)   : 0, 7075838
    benchmarks/2.9.0 (7.183M)   : 0, 7183038

    section Trace stats
    master (7.372M)   : 0, 7372080

    section Manual
    This PR (5649) (8.742M)   : 0, 8742258
    master (8.719M)   : 0, 8719413

    section Manual + Automatic
    This PR (5649) (6.841M)   : 0, 6840917
    master (6.833M)   : 0, 6832516

    section Version Conflict
    master (6.121M)   : 0, 6120769
Loading

andrewlock
andrewlock approved these changes Jun 5, 2024
View reviewed changes
Copy link
Member

@andrewlock andrewlock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM, thanks! :shipit:

@bouwkast bouwkast marked this pull request as ready for review June 5, 2024 13:09
@bouwkast bouwkast requested review from a team as code owners June 5, 2024 13:09
@bouwkast bouwkast merged commit a8f3b77 into master Jun 7, 2024
57 of 59 checks passed
@bouwkast bouwkast deleted the steven/serilog-v4 branch June 7, 2024 13:45
@github-actions github-actions bot added this to the vNext-v2 milestone Jun 7, 2024
@andrewlock andrewlock added area:tracer The core tracer library (Datadog.Trace, does not include OpenTracing, native code, or integrations) area:automatic-instrumentation Automatic instrumentation managed C# code (Datadog.Trace.ClrProfiler.Managed) labels Jun 10, 2024
@mikebro mikebro mentioned this pull request Jun 20, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewlock andrewlock andrewlock approved these changes

@vandonr vandonr vandonr approved these changes

Assignees
No one assigned
Labels
area:automatic-instrumentation Automatic instrumentation managed C# code (Datadog.Trace.ClrProfiler.Managed) area:tracer The core tracer library (Datadog.Trace, does not include OpenTracing, native code, or integrations)
Projects
None yet
Milestone
2.53.0
Development

Successfully merging this pull request may close these issues.
3 participants
@bouwkast @andrewlock @vandonr