Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clean up project settings #565

Merged
merged 4 commits into from
Nov 21, 2019
Merged

clean up project settings #565

merged 4 commits into from
Nov 21, 2019

Conversation

lucaspimentel
Copy link
Member

Changes proposed in this pull request:

  • set C# version to latest in root props file (replacing several instances for 7.2 and 7.3)
  • target netstandard2.0 in library projects
  • target netcoreapp3.0 in tool projects (executables)
  • remove redundant System.Linq package reference

@lucaspimentel lucaspimentel added the area:builds project files, build scripts, pipelines, versioning, releases, packages label Nov 21, 2019
@lucaspimentel lucaspimentel added this to the 1.9.2 milestone Nov 21, 2019
@lucaspimentel lucaspimentel requested a review from a team as a code owner November 21, 2019 19:31
@lucaspimentel lucaspimentel self-assigned this Nov 21, 2019
zacharycmontoya
zacharycmontoya approved these changes Nov 21, 2019
View reviewed changes
Copy link
Collaborator

@zacharycmontoya zacharycmontoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup!

@lucaspimentel lucaspimentel merged commit 6cf5d1b into master Nov 21, 2019
@lucaspimentel lucaspimentel deleted the lpimentel/consolidate-project-settings branch November 21, 2019 23:05
@lucaspimentel lucaspimentel modified the milestones: 1.9.2, 1.10.0 Nov 21, 2019
MikeGoldsmith pushed a commit to lightstep/ls-trace-dotnet that referenced this pull request Mar 20, 2020
@lucaspimentel @MikeGoldsmith
clean up project settings (DataDog#565)
46e35f3 
Consolidate a few project settings, like target frameworks across all the tools.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zacharycmontoya zacharycmontoya zacharycmontoya approved these changes

Assignees

@lucaspimentel lucaspimentel

Labels
area:builds project files, build scripts, pipelines, versioning, releases, packages
Projects
None yet
Milestone
1.10.0
Development

Successfully merging this pull request may close these issues.
2 participants
@lucaspimentel @zacharycmontoya