Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update libdatadog to v10 #5653

Merged
merged 6 commits into from
Jun 7, 2024
Merged

Update libdatadog to v10 #5653

merged 6 commits into from
Jun 7, 2024

Conversation

kevingosse
Copy link
Collaborator

Summary of changes

Update libdatadog to v10

Reason for change

Some changes required for crash tracking.

@kevingosse kevingosse requested review from a team as code owners June 5, 2024 15:45
@datadog-ddstaging
Copy link

datadog-ddstaging bot commented Jun 5, 2024

Datadog Report

Branch report: kevin/libdatadog_10
Commit report: c692c18
Test service: dd-trace-dotnet

✅ 0 Failed, 343537 Passed, 1864 Skipped, 14h 53m 15.09s Total Time

@andrewlock
Copy link
Member

andrewlock commented Jun 5, 2024

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5653) - mean (74ms)  : 63, 86
     .   : milestone, 74,
    master - mean (74ms)  : 61, 87
     .   : milestone, 74,

    section CallTarget+Inlining+NGEN
    This PR (5653) - mean (985ms)  : 963, 1007
     .   : milestone, 985,
    master - mean (979ms)  : 954, 1005
     .   : milestone, 979,

Loading
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5653) - mean (110ms)  : 106, 113
     .   : milestone, 110,
    master - mean (109ms)  : 106, 112
     .   : milestone, 109,

    section CallTarget+Inlining+NGEN
    This PR (5653) - mean (693ms)  : 672, 715
     .   : milestone, 693,
    master - mean (687ms)  : 666, 709
     .   : milestone, 687,

Loading
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5653) - mean (92ms)  : 89, 96
     .   : milestone, 92,
    master - mean (92ms)  : 90, 95
     .   : milestone, 92,

    section CallTarget+Inlining+NGEN
    This PR (5653) - mean (648ms)  : 627, 669
     .   : milestone, 648,
    master - mean (650ms)  : 627, 673
     .   : milestone, 650,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5653) - mean (196ms)  : 192, 200
     .   : milestone, 196,
    master - mean (191ms)  : 188, 193
     .   : milestone, 191,

    section CallTarget+Inlining+NGEN
    This PR (5653) - mean (1,081ms)  : 1047, 1115
     .   : milestone, 1081,
    master - mean (1,072ms)  : 1046, 1097
     .   : milestone, 1072,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5653) - mean (279ms)  : 271, 287
     .   : milestone, 279,
    master - mean (278ms)  : 273, 282
     .   : milestone, 278,

    section CallTarget+Inlining+NGEN
    This PR (5653) - mean (874ms)  : 845, 902
     .   : milestone, 874,
    master - mean (861ms)  : 835, 887
     .   : milestone, 861,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5653) - mean (269ms)  : 262, 275
     .   : milestone, 269,
    master - mean (267ms)  : 262, 272
     .   : milestone, 267,

    section CallTarget+Inlining+NGEN
    This PR (5653) - mean (869ms)  : 842, 896
     .   : milestone, 869,
    master - mean (844ms)  : 820, 868
     .   : milestone, 844,

Loading

@andrewlock
Copy link
Member

andrewlock commented Jun 5, 2024

Benchmarks Report for tracer 🐌

Benchmarks for #5653 compared to master:

  • 1 benchmarks are faster, with geometric mean 1.150
  • 2 benchmarks are slower, with geometric mean 1.181
  • 1 benchmarks have more allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 8.83μs 48.7ns 288ns 0.0212 0.00848 0 7.68 KB
master StartStopWithChild netcoreapp3.1 10.6μs 54.2ns 242ns 0.0324 0.0162 0 7.78 KB
master StartStopWithChild net472 17.3μs 40.9ns 153ns 1.39 0.361 0.129 8.2 KB
#5653 StartStopWithChild net6.0 8.69μs 47ns 270ns 0.0217 0.00867 0 7.68 KB
#5653 StartStopWithChild netcoreapp3.1 11μs 53.9ns 229ns 0.0211 0.0106 0 7.78 KB
#5653 StartStopWithChild net472 17.3μs 58.3ns 218ns 1.39 0.36 0.103 8.2 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 491μs 127ns 493ns 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 661μs 258ns 998ns 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 847μs 226ns 844ns 0.425 0 0 3.3 KB
#5653 WriteAndFlushEnrichedTraces net6.0 502μs 287ns 1.11μs 0 0 0 2.7 KB
#5653 WriteAndFlushEnrichedTraces netcoreapp3.1 637μs 212ns 793ns 0 0 0 2.7 KB
#5653 WriteAndFlushEnrichedTraces net472 843μs 192ns 718ns 0.419 0 0 3.3 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 169μs 166ns 645ns 0.169 0 0 18.44 KB
master SendRequest netcoreapp3.1 193μs 465ns 1.8μs 0.195 0 0 20.6 KB
master SendRequest net472 0.000448ns 0.000256ns 0.000957ns 0 0 0 0 b
#5653 SendRequest net6.0 175μs 226ns 876ns 0.175 0 0 18.44 KB
#5653 SendRequest netcoreapp3.1 195μs 294ns 1.14μs 0.192 0 0 20.6 KB
#5653 SendRequest net472 0.00074ns 0.000272ns 0.00102ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ More allocations ⚠️

More allocations ⚠️ in #5653

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑netcoreapp3.1 41.61 KB 42.09 KB 478 B 1.15%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 539μs 2.12μs 8.22μs 0.553 0 0 41.49 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 652μs 982ns 3.8μs 0.324 0 0 41.61 KB
master WriteAndFlushEnrichedTraces net472 892μs 2.95μs 11.4μs 8.42 2.66 0.443 53.25 KB
#5653 WriteAndFlushEnrichedTraces net6.0 553μs 2.14μs 7.73μs 0.571 0 0 41.42 KB
#5653 WriteAndFlushEnrichedTraces netcoreapp3.1 659μs 2.13μs 8.25μs 0.336 0 0 42.09 KB
#5653 WriteAndFlushEnrichedTraces net472 839μs 3.47μs 13.4μs 8.33 2.5 0.417 53.23 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.14μs 0.619ns 2.4ns 0.0111 0 0 808 B
master ExecuteNonQuery netcoreapp3.1 1.54μs 0.497ns 1.92ns 0.0107 0 0 808 B
master ExecuteNonQuery net472 1.73μs 2.69ns 10.4ns 0.122 0 0 770 B
#5653 ExecuteNonQuery net6.0 1.1μs 0.756ns 2.93ns 0.0115 0 0 808 B
#5653 ExecuteNonQuery netcoreapp3.1 1.49μs 1.11ns 4.28ns 0.0104 0 0 808 B
#5653 ExecuteNonQuery net472 1.75μs 2.08ns 8.04ns 0.122 0 0 770 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.23μs 0.711ns 2.75ns 0.0135 0 0 976 B
master CallElasticsearch netcoreapp3.1 1.49μs 0.308ns 1.15ns 0.0133 0 0 976 B
master CallElasticsearch net472 2.4μs 1.87ns 7.25ns 0.158 0 0 995 B
master CallElasticsearchAsync net6.0 1.32μs 0.578ns 2.24ns 0.0132 0 0 952 B
master CallElasticsearchAsync netcoreapp3.1 1.68μs 0.975ns 3.65ns 0.0133 0 0 1.02 KB
master CallElasticsearchAsync net472 2.55μs 1.82ns 6.82ns 0.167 0 0 1.05 KB
#5653 CallElasticsearch net6.0 1.17μs 1.12ns 4.34ns 0.0134 0 0 976 B
#5653 CallElasticsearch netcoreapp3.1 1.49μs 1.08ns 3.91ns 0.0128 0 0 976 B
#5653 CallElasticsearch net472 2.4μs 2.11ns 8.18ns 0.158 0.0012 0 995 B
#5653 CallElasticsearchAsync net6.0 1.31μs 0.58ns 2.25ns 0.0132 0 0 952 B
#5653 CallElasticsearchAsync netcoreapp3.1 1.65μs 2.32ns 8.7ns 0.0138 0 0 1.02 KB
#5653 CallElasticsearchAsync net472 2.67μs 8.86ns 33.1ns 0.166 0.00132 0 1.05 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.3μs 0.669ns 2.59ns 0.0131 0 0 952 B
master ExecuteAsync netcoreapp3.1 1.62μs 0.761ns 2.85ns 0.0129 0 0 952 B
master ExecuteAsync net472 1.7μs 1.47ns 5.29ns 0.145 0.000847 0 915 B
#5653 ExecuteAsync net6.0 1.28μs 0.6ns 2.24ns 0.0134 0 0 952 B
#5653 ExecuteAsync netcoreapp3.1 1.73μs 0.949ns 3.68ns 0.0128 0 0 952 B
#5653 ExecuteAsync net472 1.83μs 0.897ns 3.47ns 0.145 0.000918 0 915 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 4.07μs 1.51ns 5.63ns 0.0305 0 0 2.22 KB
master SendAsync netcoreapp3.1 5.22μs 27.9ns 220ns 0.0356 0 0 2.76 KB
master SendAsync net472 7.45μs 3.2ns 12.4ns 0.496 0 0 3.12 KB
#5653 SendAsync net6.0 4.26μs 3.19ns 12.4ns 0.0298 0 0 2.22 KB
#5653 SendAsync netcoreapp3.1 4.95μs 3.31ns 11.5ns 0.0371 0 0 2.76 KB
#5653 SendAsync net472 7.54μs 2.34ns 8.74ns 0.494 0 0 3.12 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 1.45μs 3.95ns 15.3ns 0.0229 0 0 1.64 KB
master EnrichedLog netcoreapp3.1 2.3μs 13.4ns 125ns 0.0215 0 0 1.64 KB
master EnrichedLog net472 2.52μs 0.719ns 2.69ns 0.249 0 0 1.57 KB
#5653 EnrichedLog net6.0 1.43μs 0.4ns 1.44ns 0.023 0 0 1.64 KB
#5653 EnrichedLog netcoreapp3.1 2.25μs 1.44ns 5.58ns 0.0225 0 0 1.64 KB
#5653 EnrichedLog net472 2.41μs 1.03ns 4ns 0.249 0 0 1.57 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 115μs 43.5ns 157ns 0.0576 0 0 4.28 KB
master EnrichedLog netcoreapp3.1 121μs 180ns 696ns 0.0606 0 0 4.28 KB
master EnrichedLog net472 149μs 78.3ns 303ns 0.672 0.224 0 4.46 KB
#5653 EnrichedLog net6.0 117μs 143ns 555ns 0.0585 0 0 4.28 KB
#5653 EnrichedLog netcoreapp3.1 120μs 88.6ns 319ns 0 0 0 4.28 KB
#5653 EnrichedLog net472 150μs 100ns 388ns 0.678 0.226 0 4.46 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 3.1μs 2.2ns 8.22ns 0.0309 0 0 2.2 KB
master EnrichedLog netcoreapp3.1 4.27μs 1.96ns 7.6ns 0.0299 0 0 2.2 KB
master EnrichedLog net472 4.87μs 2.22ns 8.61ns 0.319 0 0 2.02 KB
#5653 EnrichedLog net6.0 3.01μs 0.891ns 3.33ns 0.0301 0 0 2.2 KB
#5653 EnrichedLog netcoreapp3.1 4.11μs 2.95ns 11.4ns 0.029 0 0 2.2 KB
#5653 EnrichedLog net472 4.73μs 1.05ns 3.77ns 0.319 0 0 2.02 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 1.35μs 0.503ns 1.95ns 0.0162 0 0 1.14 KB
master SendReceive netcoreapp3.1 1.75μs 1.05ns 4.05ns 0.0157 0 0 1.14 KB
master SendReceive net472 2.11μs 1.66ns 6.22ns 0.183 0 0 1.16 KB
#5653 SendReceive net6.0 1.43μs 0.986ns 3.82ns 0.0157 0 0 1.14 KB
#5653 SendReceive netcoreapp3.1 1.7μs 0.811ns 3.14ns 0.0153 0 0 1.14 KB
#5653 SendReceive net472 2.07μs 1.35ns 5.24ns 0.183 0.00103 0 1.16 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.72μs 0.637ns 2.3ns 0.0217 0 0 1.6 KB
master EnrichedLog netcoreapp3.1 3.97μs 1.97ns 7.64ns 0.0219 0 0 1.65 KB
master EnrichedLog net472 4.22μs 2.83ns 10.9ns 0.322 0 0 2.04 KB
#5653 EnrichedLog net6.0 2.8μs 1.03ns 4ns 0.0225 0 0 1.6 KB
#5653 EnrichedLog netcoreapp3.1 3.81μs 2.18ns 8.45ns 0.0212 0 0 1.65 KB
#5653 EnrichedLog net472 4.4μs 1.82ns 7.04ns 0.322 0 0 2.04 KB
Benchmarks.Trace.SpanBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #5653

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑netcoreapp3.1 1.228 537.34 659.99
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net472 1.136 569.83 647.27

Faster 🎉 in #5653

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑netcoreapp3.1 1.150 758.81 659.85

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 395ns 0.291ns 1.13ns 0.00804 0 0 576 B
master StartFinishSpan netcoreapp3.1 538ns 0.828ns 3.21ns 0.00785 0 0 576 B
master StartFinishSpan net472 570ns 0.402ns 1.56ns 0.0916 0 0 578 B
master StartFinishScope net6.0 509ns 0.177ns 0.663ns 0.00981 0 0 696 B
master StartFinishScope netcoreapp3.1 760ns 1.58ns 5.89ns 0.00943 0 0 696 B
master StartFinishScope net472 807ns 0.704ns 2.73ns 0.104 0 0 658 B
#5653 StartFinishSpan net6.0 403ns 0.125ns 0.484ns 0.00807 0 0 576 B
#5653 StartFinishSpan netcoreapp3.1 660ns 0.314ns 1.17ns 0.00789 0 0 576 B
#5653 StartFinishSpan net472 647ns 0.467ns 1.81ns 0.0917 0 0 578 B
#5653 StartFinishScope net6.0 487ns 0.361ns 1.4ns 0.00975 0 0 696 B
#5653 StartFinishScope netcoreapp3.1 663ns 1.82ns 7.03ns 0.00955 0 0 696 B
#5653 StartFinishScope net472 866ns 0.458ns 1.77ns 0.104 0 0 658 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 677ns 0.417ns 1.61ns 0.00974 0 0 696 B
master RunOnMethodBegin netcoreapp3.1 887ns 0.48ns 1.86ns 0.00938 0 0 696 B
master RunOnMethodBegin net472 1.12μs 0.742ns 2.87ns 0.104 0 0 658 B
#5653 RunOnMethodBegin net6.0 647ns 0.234ns 0.906ns 0.00976 0 0 696 B
#5653 RunOnMethodBegin netcoreapp3.1 895ns 1.03ns 3.98ns 0.00932 0 0 696 B
#5653 RunOnMethodBegin net472 1.08μs 0.591ns 2.29ns 0.104 0 0 658 B

@andrewlock
Copy link
Member

andrewlock commented Jun 5, 2024

Throughput/Crank Report:zap:

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5653) (11.389M)   : 0, 11389237
    master (11.699M)   : 0, 11699133
    benchmarks/2.9.0 (11.418M)   : 0, 11417530

    section Automatic
    This PR (5653) (7.568M)   : 0, 7567939
    master (7.805M)   : 0, 7805369
    benchmarks/2.9.0 (8.116M)   : 0, 8115541

    section Trace stats
    master (8.121M)   : 0, 8120727

    section Manual
    This PR (5653) (9.734M)   : 0, 9733855
    master (9.993M)   : 0, 9993490

    section Manual + Automatic
    This PR (5653) (7.257M)   : 0, 7256627
    master (7.512M)   : 0, 7511907

    section Version Conflict
    master (6.805M)   : 0, 6804718

Loading
gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5653) (9.441M)   : 0, 9441222
    master (9.497M)   : 0, 9497327
    benchmarks/2.9.0 (9.669M)   : 0, 9669411

    section Automatic
    This PR (5653) (6.571M)   : 0, 6570823
    master (6.597M)   : 0, 6597128

    section Trace stats
    master (6.964M)   : 0, 6963538

    section Manual
    This PR (5653) (8.322M)   : 0, 8321920
    master (8.201M)   : 0, 8201410

    section Manual + Automatic
    This PR (5653) (6.231M)   : 0, 6230818
    master (6.259M)   : 0, 6258687

    section Version Conflict
    master (5.683M)   : 0, 5683084

Loading
gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5653) (10.228M)   : 0, 10227978
    master (9.730M)   : 0, 9729759
    benchmarks/2.9.0 (9.964M)   : 0, 9963943

    section Automatic
    This PR (5653) (7.128M)   : 0, 7128089
    master (6.823M)   : 0, 6823234
    benchmarks/2.9.0 (7.246M)   : 0, 7245924

    section Trace stats
    master (7.345M)   : 0, 7345017

    section Manual
    This PR (5653) (8.771M)   : 0, 8771032
    master (8.570M)   : 0, 8570103

    section Manual + Automatic
    This PR (5653) (6.831M)   : 0, 6830801
    master (6.634M)   : 0, 6633828

    section Version Conflict
    master (6.001M)   : 0, 6000821

Loading

Copy link
Member

@andrewlock andrewlock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

10 > 9 👍 But that failing CreatedumpTests... :awkward-monkey:

@kevingosse kevingosse requested a review from a team as a code owner June 6, 2024 10:59
Copy link
Collaborator

@gleocadie gleocadie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@chrisnas chrisnas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kevingosse kevingosse merged commit 957a5c8 into master Jun 7, 2024
64 of 65 checks passed
@kevingosse kevingosse deleted the kevin/libdatadog_10 branch June 7, 2024 08:36
@github-actions github-actions bot added this to the vNext-v2 milestone Jun 7, 2024
@andrewlock andrewlock added the area:native-library Automatic instrumentation native C++ code (Datadog.Trace.ClrProfiler.Native) label Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:native-library Automatic instrumentation native C++ code (Datadog.Trace.ClrProfiler.Native)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants