[CrashTracking] Let libdatadog set the endpoint

[kevingosse]

Summary of changes

Libdatadog v10 knows how to extract the agent endpoint from the environment variable, so remove the placeholder logic.

Reason for change

It was just a temporary solution.

Implementation details

Test coverage

Added a test to make sure that libdatadog pushes telemetry to the right endpoint.

[gleocadie]

LGTM

[chrisnas]

LGTM

[datadog-ddstaging]

Datadog Report

Branch report: kevin/crash_endpoint
Commit report: daf7291
Test service: dd-trace-dotnet

✅ 0 Failed, 343867 Passed, 1962 Skipped, 14h 55m 25.7s Total Time

[andrewlock]

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

• This PR (5666)
• master

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

• Welch test with statistical test for significance of 5%
• Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5666) - mean (74ms)  : 63, 85
     .   : milestone, 74,
    master - mean (73ms)  : 65, 81
     .   : milestone, 73,

    section CallTarget+Inlining+NGEN
    This PR (5666) - mean (976ms)  : 955, 997
     .   : milestone, 976,
    master - mean (974ms)  : 958, 990
     .   : milestone, 974,

Loading

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5666) - mean (108ms)  : 105, 112
     .   : milestone, 108,
    master - mean (108ms)  : 105, 111
     .   : milestone, 108,

    section CallTarget+Inlining+NGEN
    This PR (5666) - mean (684ms)  : 661, 706
     .   : milestone, 684,
    master - mean (687ms)  : 673, 701
     .   : milestone, 687,

Loading

gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5666) - mean (93ms)  : 89, 96
     .   : milestone, 93,
    master - mean (92ms)  : 89, 96
     .   : milestone, 92,

    section CallTarget+Inlining+NGEN
    This PR (5666) - mean (645ms)  : 620, 669
     .   : milestone, 645,
    master - mean (645ms)  : 620, 671
     .   : milestone, 645,

Loading

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5666) - mean (192ms)  : 188, 196
     .   : milestone, 192,
    master - mean (193ms)  : 189, 198
     .   : milestone, 193,

    section CallTarget+Inlining+NGEN
    This PR (5666) - mean (1,078ms)  : 1050, 1106
     .   : milestone, 1078,
    master - mean (1,071ms)  : 1050, 1091
     .   : milestone, 1071,

Loading

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5666) - mean (277ms)  : 270, 283
     .   : milestone, 277,
    master - mean (278ms)  : 272, 283
     .   : milestone, 278,

    section CallTarget+Inlining+NGEN
    This PR (5666) - mean (861ms)  : 834, 887
     .   : milestone, 861,
    master - mean (858ms)  : 833, 883
     .   : milestone, 858,

Loading

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5666) - mean (267ms)  : 262, 273
     .   : milestone, 267,
    master - mean (267ms)  : 262, 272
     .   : milestone, 267,

    section CallTarget+Inlining+NGEN
    This PR (5666) - mean (849ms)  : 824, 875
     .   : milestone, 849,
    master - mean (847ms)  : 822, 873
     .   : milestone, 847,

Loading

[andrewlock]

Just FYI, this is a bit neater in general

data.TryGetPayload(TelemetryRequestTypes.RedactedErrorLogs)

[andrewlock]

Just FYI, You can also do something like this:

var singleLog = log.Logs.Should().ContainSingle().Subject;
var report = JObject.Parse(singleLog);