Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tracing] [Samples] Update MicrosoftExtensionsExample.csproj to remove incompatible library #5689

Merged

Conversation

zacharycmontoya
Copy link
Collaborator

Summary of changes

Remove NetEscapades.Extensions.Logging.RollingFile because it's incompatible with our updated automatic logs correlation implementation

Reason for change

Implementation details

Test coverage

Other details

…patible with our updated automatic logs correlation
@zacharycmontoya zacharycmontoya self-assigned this Jun 13, 2024
@zacharycmontoya zacharycmontoya requested a review from a team as a code owner June 13, 2024 19:52
Copy link
Contributor

@bouwkast bouwkast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@zacharycmontoya zacharycmontoya merged commit 1c5f274 into master Jun 13, 2024
87 checks passed
@zacharycmontoya zacharycmontoya deleted the zach.montoya/update-logs-correlation-example branch June 13, 2024 21:02
@github-actions github-actions bot added this to the vNext-v2 milestone Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants