-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Profiler] Fix typo in crash fix #5692
Conversation
2878b83
to
1914e35
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sweet 😃
Datadog ReportBranch report: ✅ 0 Failed, 339512 Passed, 1940 Skipped, 15h 25m 58.94s Total Time |
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing the following branches/commits: Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (5692) - mean (73ms) : 66, 81
. : milestone, 73,
master - mean (75ms) : 63, 87
. : milestone, 75,
section CallTarget+Inlining+NGEN
This PR (5692) - mean (1,007ms) : 987, 1026
. : milestone, 1007,
master - mean (1,017ms) : 1000, 1034
. : milestone, 1017,
gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (5692) - mean (110ms) : 107, 113
. : milestone, 110,
master - mean (111ms) : 108, 114
. : milestone, 111,
section CallTarget+Inlining+NGEN
This PR (5692) - mean (726ms) : 706, 745
. : milestone, 726,
master - mean (734ms) : 715, 752
. : milestone, 734,
gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (5692) - mean (94ms) : 90, 97
. : milestone, 94,
master - mean (95ms) : 91, 98
. : milestone, 95,
section CallTarget+Inlining+NGEN
This PR (5692) - mean (681ms) : 660, 702
. : milestone, 681,
master - mean (684ms) : 663, 705
. : milestone, 684,
gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (5692) - mean (193ms) : 189, 198
. : milestone, 193,
master - mean (191ms) : 187, 196
. : milestone, 191,
section CallTarget+Inlining+NGEN
This PR (5692) - mean (1,115ms) : 1088, 1143
. : milestone, 1115,
master - mean (1,105ms) : 1083, 1127
. : milestone, 1105,
gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (5692) - mean (277ms) : 274, 281
. : milestone, 277,
master - mean (276ms) : 271, 281
. : milestone, 276,
section CallTarget+Inlining+NGEN
This PR (5692) - mean (914ms) : 894, 934
. : milestone, 914,
master - mean (907ms) : 880, 934
. : milestone, 907,
gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (5692) - mean (267ms) : 263, 272
. : milestone, 267,
master - mean (265ms) : 260, 269
. : milestone, 265,
section CallTarget+Inlining+NGEN
This PR (5692) - mean (898ms) : 870, 926
. : milestone, 898,
master - mean (890ms) : 871, 910
. : milestone, 890,
|
Benchmarks Report for tracer 🐌Benchmarks for #5692 compared to master:
The following thresholds were used for comparing the benchmark speeds:
Allocation changes below 0.5% are ignored. Benchmark detailsBenchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.SpanBenchmark - Faster 🎉 Same allocations ✔️
|
Benchmark | base/diff | Base Median (ns) | Diff Median (ns) | Modality |
---|---|---|---|---|
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net6.0 | 1.191 | 571.05 | 479.55 |
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | StartFinishSpan |
net6.0 | 387ns | 0.152ns | 0.59ns | 0.00815 | 0 | 0 | 576 B |
master | StartFinishSpan |
netcoreapp3.1 | 548ns | 0.276ns | 1.07ns | 0.00768 | 0 | 0 | 576 B |
master | StartFinishSpan |
net472 | 646ns | 0.427ns | 1.65ns | 0.0917 | 0 | 0 | 578 B |
master | StartFinishScope |
net6.0 | 571ns | 0.124ns | 0.448ns | 0.00964 | 0 | 0 | 696 B |
master | StartFinishScope |
netcoreapp3.1 | 735ns | 0.829ns | 3.1ns | 0.00948 | 0 | 0 | 696 B |
master | StartFinishScope |
net472 | 827ns | 1.05ns | 3.94ns | 0.104 | 0 | 0 | 658 B |
#5692 | StartFinishSpan |
net6.0 | 395ns | 0.231ns | 0.893ns | 0.00813 | 0 | 0 | 576 B |
#5692 | StartFinishSpan |
netcoreapp3.1 | 548ns | 0.237ns | 0.886ns | 0.00801 | 0 | 0 | 576 B |
#5692 | StartFinishSpan |
net472 | 674ns | 0.589ns | 2.28ns | 0.0915 | 0 | 0 | 578 B |
#5692 | StartFinishScope |
net6.0 | 480ns | 0.226ns | 0.847ns | 0.00967 | 0 | 0 | 696 B |
#5692 | StartFinishScope |
netcoreapp3.1 | 751ns | 0.769ns | 2.98ns | 0.00928 | 0 | 0 | 696 B |
#5692 | StartFinishScope |
net472 | 901ns | 0.544ns | 2.11ns | 0.104 | 0 | 0 | 658 B |
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | RunOnMethodBegin |
net6.0 | 646ns | 0.5ns | 1.94ns | 0.00978 | 0 | 0 | 696 B |
master | RunOnMethodBegin |
netcoreapp3.1 | 899ns | 1.7ns | 6.57ns | 0.00951 | 0 | 0 | 696 B |
master | RunOnMethodBegin |
net472 | 1.09μs | 0.979ns | 3.79ns | 0.104 | 0 | 0 | 658 B |
#5692 | RunOnMethodBegin |
net6.0 | 631ns | 3.54ns | 22.7ns | 0.00977 | 0 | 0 | 696 B |
#5692 | RunOnMethodBegin |
netcoreapp3.1 | 925ns | 0.406ns | 1.52ns | 0.00949 | 0 | 0 | 696 B |
#5692 | RunOnMethodBegin |
net472 | 1.05μs | 0.513ns | 1.99ns | 0.104 | 0 | 0 | 658 B |
Throughput/Crank Report:zap:Throughput results for AspNetCoreSimpleController comparing the following branches/commits: Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red. Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards! gantt
title Throughput Linux x64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (5692) (11.595M) : 0, 11595454
master (11.438M) : 0, 11438227
benchmarks/2.9.0 (11.574M) : 0, 11573681
section Automatic
This PR (5692) (7.793M) : 0, 7793064
master (7.760M) : 0, 7760404
benchmarks/2.9.0 (8.261M) : 0, 8260805
section Trace stats
master (8.093M) : 0, 8093497
section Manual
This PR (5692) (10.084M) : 0, 10084491
master (9.921M) : 0, 9920785
section Manual + Automatic
This PR (5692) (7.380M) : 0, 7380415
master (7.331M) : 0, 7330615
section Version Conflict
master (6.585M) : 0, 6585366
gantt
title Throughput Linux arm64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (5692) (9.538M) : 0, 9537894
master (9.481M) : 0, 9480572
benchmarks/2.9.0 (9.623M) : 0, 9623209
section Automatic
This PR (5692) (6.634M) : 0, 6633785
master (6.400M) : 0, 6399659
section Trace stats
master (6.953M) : 0, 6952919
section Manual
This PR (5692) (8.300M) : 0, 8300289
master (8.277M) : 0, 8277338
section Manual + Automatic
This PR (5692) (6.144M) : 0, 6144045
master (6.042M) : 0, 6041661
section Version Conflict
master (5.603M) : 0, 5603024
gantt
title Throughput Windows x64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (5692) (9.591M) : 0, 9591306
master (9.801M) : 0, 9800651
benchmarks/2.9.0 (9.948M) : 0, 9948007
section Automatic
This PR (5692) (6.849M) : 0, 6849349
master (6.988M) : 0, 6988350
benchmarks/2.9.0 (7.263M) : 0, 7263417
section Trace stats
master (7.356M) : 0, 7356260
section Manual
This PR (5692) (8.492M) : 0, 8492263
master (8.603M) : 0, 8602853
section Manual + Automatic
This PR (5692) (6.712M) : 0, 6712129
master (6.774M) : 0, 6773730
section Version Conflict
master (6.037M) : 0, 6036783
|
Summary of changes
Check the right class ID
Reason for change
Invalid class ID check
Implementation details
Fix typo
Test coverage
Other details