Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Test Package Versions Bump] Updating package versions #5699

Merged
merged 1 commit into from
Jun 18, 2024

Conversation

github-actions[bot]
Copy link
Contributor

Updates the package versions for integration tests.

@github-actions github-actions bot requested review from a team as code owners June 16, 2024 00:22
@datadog-ddstaging
Copy link

datadog-ddstaging bot commented Jun 16, 2024

Datadog Report

Branch report: bot/test-package-versions-bump
Commit report: 6c14037
Test service: dd-trace-dotnet

✅ 0 Failed, 340152 Passed, 1660 Skipped, 14h 7m 36.53s Total Time

@andrewlock
Copy link
Member

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5699) - mean (72ms)  : 64, 81
     .   : milestone, 72,
    master - mean (73ms)  : 65, 81
     .   : milestone, 73,

    section CallTarget+Inlining+NGEN
    This PR (5699) - mean (1,011ms)  : 990, 1033
     .   : milestone, 1011,
    master - mean (1,008ms)  : 993, 1023
     .   : milestone, 1008,

Loading
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5699) - mean (110ms)  : 106, 114
     .   : milestone, 110,
    master - mean (109ms)  : 106, 113
     .   : milestone, 109,

    section CallTarget+Inlining+NGEN
    This PR (5699) - mean (720ms)  : 700, 740
     .   : milestone, 720,
    master - mean (723ms)  : 709, 738
     .   : milestone, 723,

Loading
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5699) - mean (93ms)  : 90, 97
     .   : milestone, 93,
    master - mean (93ms)  : 89, 96
     .   : milestone, 93,

    section CallTarget+Inlining+NGEN
    This PR (5699) - mean (670ms)  : 652, 688
     .   : milestone, 670,
    master - mean (681ms)  : 660, 703
     .   : milestone, 681,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5699) - mean (191ms)  : 188, 194
     .   : milestone, 191,
    master - mean (192ms)  : 188, 195
     .   : milestone, 192,

    section CallTarget+Inlining+NGEN
    This PR (5699) - mean (1,111ms)  : 1089, 1134
     .   : milestone, 1111,
    master - mean (1,112ms)  : 1089, 1136
     .   : milestone, 1112,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5699) - mean (278ms)  : 271, 285
     .   : milestone, 278,
    master - mean (277ms)  : 273, 282
     .   : milestone, 277,

    section CallTarget+Inlining+NGEN
    This PR (5699) - mean (908ms)  : 880, 936
     .   : milestone, 908,
    master - mean (913ms)  : 889, 936
     .   : milestone, 913,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5699) - mean (267ms)  : 263, 271
     .   : milestone, 267,
    master - mean (265ms)  : 262, 268
     .   : milestone, 265,

    section CallTarget+Inlining+NGEN
    This PR (5699) - mean (895ms)  : 865, 925
     .   : milestone, 895,
    master - mean (892ms)  : 869, 915
     .   : milestone, 892,

Loading

@andrewlock
Copy link
Member

Throughput/Crank Report:zap:

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5699) (11.511M)   : 0, 11511257
    master (11.518M)   : 0, 11518331
    benchmarks/2.9.0 (11.592M)   : 0, 11592436

    section Automatic
    This PR (5699) (7.783M)   : 0, 7782563
    master (7.760M)   : 0, 7759925
    benchmarks/2.9.0 (8.124M)   : 0, 8123984

    section Trace stats
    master (7.980M)   : 0, 7979842

    section Manual
    This PR (5699) (9.932M)   : 0, 9932303
    master (9.851M)   : 0, 9850960

    section Manual + Automatic
    This PR (5699) (7.309M)   : 0, 7309077
    master (7.345M)   : 0, 7344817

    section Version Conflict
    master (6.595M)   : 0, 6594729

Loading
gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5699) (9.607M)   : 0, 9606702
    master (9.590M)   : 0, 9589678
    benchmarks/2.9.0 (9.589M)   : 0, 9589386

    section Automatic
    This PR (5699) (6.637M)   : 0, 6637108
    master (6.539M)   : 0, 6539470

    section Trace stats
    master (6.910M)   : 0, 6910034

    section Manual
    This PR (5699) (8.346M)   : 0, 8346290
    master (8.260M)   : 0, 8259501

    section Manual + Automatic
    This PR (5699) (6.257M)   : 0, 6257208
    master (6.082M)   : 0, 6082291

    section Version Conflict
    master (5.644M)   : 0, 5644464

Loading
gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5699) (10.060M)   : 0, 10060388
    master (10.115M)   : 0, 10115430
    benchmarks/2.9.0 (10.205M)   : 0, 10205493

    section Automatic
    This PR (5699) (7.067M)   : 0, 7066851
    master (7.229M)   : 0, 7228538
    benchmarks/2.9.0 (7.528M)   : 0, 7528021

    section Trace stats
    master (7.589M)   : 0, 7589097

    section Manual
    This PR (5699) (8.731M)   : 0, 8730788
    master (8.979M)   : 0, 8979486

    section Manual + Automatic
    This PR (5699) (6.842M)   : 0, 6841840
    master (6.985M)   : 0, 6984582

    section Version Conflict
    master (6.363M)   : 0, 6362855

Loading

@andrewlock
Copy link
Member

Benchmarks Report for tracer 🐌

Benchmarks for #5699 compared to master:

  • 1 benchmarks are faster, with geometric mean 1.120
  • 2 benchmarks are slower, with geometric mean 1.156
  • All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 7.81μs 42.5ns 240ns 0.0187 0.00749 0 5.43 KB
master StartStopWithChild netcoreapp3.1 9.69μs 48.8ns 229ns 0.0194 0.00969 0 5.62 KB
master StartStopWithChild net472 16μs 50.9ns 197ns 1 0.293 0.0949 6.07 KB
#5699 StartStopWithChild net6.0 7.76μs 44.3ns 343ns 0.015 0.00752 0 5.43 KB
#5699 StartStopWithChild netcoreapp3.1 9.6μs 45.7ns 189ns 0.0195 0.00973 0 5.62 KB
#5699 StartStopWithChild net472 16μs 58.1ns 217ns 1.03 0.322 0.102 6.05 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 493μs 279ns 1.08μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 628μs 181ns 677ns 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 838μs 337ns 1.26μs 0.417 0 0 3.3 KB
#5699 WriteAndFlushEnrichedTraces net6.0 482μs 143ns 537ns 0 0 0 2.7 KB
#5699 WriteAndFlushEnrichedTraces netcoreapp3.1 611μs 297ns 1.15μs 0 0 0 2.7 KB
#5699 WriteAndFlushEnrichedTraces net472 813μs 380ns 1.47μs 0.406 0 0 3.3 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 170μs 173ns 647ns 0.256 0 0 18.44 KB
master SendRequest netcoreapp3.1 193μs 220ns 824ns 0.191 0 0 20.6 KB
master SendRequest net472 0.000676ns 0.000394ns 0.00148ns 0 0 0 0 b
#5699 SendRequest net6.0 172μs 265ns 1.03μs 0.173 0 0 18.44 KB
#5699 SendRequest netcoreapp3.1 192μs 277ns 1.07μs 0.193 0 0 20.6 KB
#5699 SendRequest net472 0.000642ns 0.00033ns 0.00128ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 531μs 259ns 969ns 0.532 0 0 41.56 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 661μs 992ns 3.84μs 0.329 0 0 41.66 KB
master WriteAndFlushEnrichedTraces net472 848μs 4.18μs 18.2μs 8.22 2.47 0.411 53.27 KB
#5699 WriteAndFlushEnrichedTraces net6.0 556μs 1.3μs 5.02μs 0.553 0 0 41.51 KB
#5699 WriteAndFlushEnrichedTraces netcoreapp3.1 644μs 1μs 3.75μs 0.322 0 0 41.81 KB
#5699 WriteAndFlushEnrichedTraces net472 857μs 3.31μs 12.8μs 8.19 2.59 0.431 53.25 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.05μs 0.392ns 1.47ns 0.011 0 0 808 B
master ExecuteNonQuery netcoreapp3.1 1.5μs 0.534ns 1.93ns 0.0106 0 0 808 B
master ExecuteNonQuery net472 1.81μs 1.17ns 4.52ns 0.122 0 0 770 B
#5699 ExecuteNonQuery net6.0 1.08μs 0.457ns 1.71ns 0.0115 0 0 808 B
#5699 ExecuteNonQuery netcoreapp3.1 1.45μs 0.701ns 2.71ns 0.011 0 0 808 B
#5699 ExecuteNonQuery net472 1.71μs 0.501ns 1.94ns 0.122 0 0 770 B
Benchmarks.Trace.ElasticsearchBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #5699

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch‑net6.0 1.168 1,063.37 1,241.95

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.06μs 0.309ns 1.16ns 0.0134 0 0 976 B
master CallElasticsearch netcoreapp3.1 1.5μs 0.684ns 2.65ns 0.0127 0 0 976 B
master CallElasticsearch net472 2.62μs 0.59ns 2.21ns 0.158 0 0 995 B
master CallElasticsearchAsync net6.0 1.37μs 0.81ns 3.14ns 0.0131 0 0 952 B
master CallElasticsearchAsync netcoreapp3.1 1.63μs 0.771ns 2.88ns 0.0138 0 0 1.02 KB
master CallElasticsearchAsync net472 2.55μs 0.773ns 2.79ns 0.167 0 0 1.05 KB
#5699 CallElasticsearch net6.0 1.24μs 1.16ns 4.33ns 0.0138 0 0 976 B
#5699 CallElasticsearch netcoreapp3.1 1.55μs 0.902ns 3.38ns 0.0133 0 0 976 B
#5699 CallElasticsearch net472 2.43μs 0.963ns 3.34ns 0.158 0.00121 0 995 B
#5699 CallElasticsearchAsync net6.0 1.32μs 0.653ns 2.44ns 0.0132 0 0 952 B
#5699 CallElasticsearchAsync netcoreapp3.1 1.6μs 0.797ns 2.98ns 0.0137 0 0 1.02 KB
#5699 CallElasticsearchAsync net472 2.48μs 1.74ns 6.49ns 0.167 0.00123 0 1.05 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.2μs 1.81ns 6.78ns 0.0131 0 0 952 B
master ExecuteAsync netcoreapp3.1 1.66μs 0.596ns 2.15ns 0.0124 0 0 952 B
master ExecuteAsync net472 1.77μs 0.686ns 2.66ns 0.145 0 0 915 B
#5699 ExecuteAsync net6.0 1.25μs 0.356ns 1.33ns 0.0131 0 0 952 B
#5699 ExecuteAsync netcoreapp3.1 1.65μs 1.61ns 5.82ns 0.0124 0 0 952 B
#5699 ExecuteAsync net472 1.84μs 1.64ns 6.12ns 0.145 0.000909 0 915 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 4.18μs 3.3ns 12.8ns 0.0314 0 0 2.22 KB
master SendAsync netcoreapp3.1 4.94μs 1.63ns 6.32ns 0.0371 0 0 2.76 KB
master SendAsync net472 7.54μs 2.9ns 10.9ns 0.499 0 0 3.15 KB
#5699 SendAsync net6.0 4.19μs 1.67ns 6.48ns 0.0312 0 0 2.22 KB
#5699 SendAsync netcoreapp3.1 5.08μs 2.15ns 8.32ns 0.038 0 0 2.76 KB
#5699 SendAsync net472 7.75μs 1.66ns 6.41ns 0.497 0 0 3.15 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 1.44μs 0.76ns 2.84ns 0.0229 0 0 1.64 KB
master EnrichedLog netcoreapp3.1 2.27μs 0.763ns 2.85ns 0.0224 0 0 1.64 KB
master EnrichedLog net472 2.48μs 1.22ns 4.71ns 0.249 0 0 1.57 KB
#5699 EnrichedLog net6.0 1.43μs 0.836ns 3.13ns 0.0234 0 0 1.64 KB
#5699 EnrichedLog netcoreapp3.1 2.23μs 5.08ns 19.7ns 0.0221 0 0 1.64 KB
#5699 EnrichedLog net472 2.47μs 1.38ns 5.18ns 0.249 0 0 1.57 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 114μs 73.1ns 283ns 0.0571 0 0 4.28 KB
master EnrichedLog netcoreapp3.1 117μs 96.8ns 375ns 0.0587 0 0 4.28 KB
master EnrichedLog net472 149μs 91.7ns 355ns 0.663 0.221 0 4.46 KB
#5699 EnrichedLog net6.0 114μs 139ns 522ns 0.0567 0 0 4.28 KB
#5699 EnrichedLog netcoreapp3.1 119μs 191ns 738ns 0 0 0 4.28 KB
#5699 EnrichedLog net472 146μs 92.6ns 346ns 0.657 0.219 0 4.46 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 3.17μs 1.23ns 4.75ns 0.0301 0 0 2.2 KB
master EnrichedLog netcoreapp3.1 4.12μs 1.38ns 5.35ns 0.0288 0 0 2.2 KB
master EnrichedLog net472 4.89μs 1.42ns 5.5ns 0.319 0 0 2.02 KB
#5699 EnrichedLog net6.0 3.06μs 1.36ns 5.27ns 0.0304 0 0 2.2 KB
#5699 EnrichedLog netcoreapp3.1 4.14μs 2.26ns 8.76ns 0.0288 0 0 2.2 KB
#5699 EnrichedLog net472 4.75μs 1.81ns 6.99ns 0.319 0 0 2.02 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 1.34μs 0.829ns 3.21ns 0.0161 0 0 1.14 KB
master SendReceive netcoreapp3.1 1.78μs 1.89ns 7.32ns 0.0149 0 0 1.14 KB
master SendReceive net472 2.09μs 0.867ns 3.24ns 0.184 0.00104 0 1.16 KB
#5699 SendReceive net6.0 1.35μs 1.57ns 6.1ns 0.0156 0 0 1.14 KB
#5699 SendReceive netcoreapp3.1 1.68μs 0.791ns 3.06ns 0.0154 0 0 1.14 KB
#5699 SendReceive net472 2.1μs 1.16ns 4.5ns 0.183 0 0 1.16 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.68μs 2.12ns 8.22ns 0.0225 0 0 1.6 KB
master EnrichedLog netcoreapp3.1 4μs 1.36ns 5.08ns 0.022 0 0 1.65 KB
master EnrichedLog net472 4.22μs 2.11ns 7.88ns 0.322 0 0 2.04 KB
#5699 EnrichedLog net6.0 2.67μs 0.613ns 2.3ns 0.0227 0 0 1.6 KB
#5699 EnrichedLog netcoreapp3.1 3.91μs 1.3ns 4.86ns 0.0214 0 0 1.65 KB
#5699 EnrichedLog net472 4.49μs 2.06ns 7.43ns 0.322 0 0 2.04 KB
Benchmarks.Trace.SpanBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #5699

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑netcoreapp3.1 1.143 652.69 746.24

Faster 🎉 in #5699

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net472 1.120 627.24 560.02

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 401ns 0.13ns 0.449ns 0.00812 0 0 576 B
master StartFinishSpan netcoreapp3.1 611ns 0.274ns 1.06ns 0.00784 0 0 576 B
master StartFinishSpan net472 627ns 0.445ns 1.72ns 0.0917 0 0 578 B
master StartFinishScope net6.0 528ns 0.224ns 0.868ns 0.00981 0 0 696 B
master StartFinishScope netcoreapp3.1 653ns 0.455ns 1.76ns 0.00947 0 0 696 B
master StartFinishScope net472 862ns 0.454ns 1.76ns 0.104 0 0 658 B
#5699 StartFinishSpan net6.0 393ns 0.321ns 1.24ns 0.00811 0 0 576 B
#5699 StartFinishSpan netcoreapp3.1 590ns 0.396ns 1.53ns 0.00767 0 0 576 B
#5699 StartFinishSpan net472 560ns 0.4ns 1.55ns 0.0916 0 0 578 B
#5699 StartFinishScope net6.0 501ns 0.217ns 0.841ns 0.00983 0 0 696 B
#5699 StartFinishScope netcoreapp3.1 746ns 0.531ns 2.06ns 0.00933 0 0 696 B
#5699 StartFinishScope net472 851ns 0.815ns 3.16ns 0.104 0 0 658 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 689ns 0.445ns 1.72ns 0.00969 0 0 696 B
master RunOnMethodBegin netcoreapp3.1 941ns 0.548ns 2.12ns 0.00938 0 0 696 B
master RunOnMethodBegin net472 1.14μs 0.821ns 3.18ns 0.104 0 0 658 B
#5699 RunOnMethodBegin net6.0 657ns 0.608ns 2.35ns 0.00986 0 0 696 B
#5699 RunOnMethodBegin netcoreapp3.1 869ns 0.636ns 2.38ns 0.00918 0 0 696 B
#5699 RunOnMethodBegin net472 1.1μs 0.433ns 1.68ns 0.104 0 0 658 B

Copy link
Member

@andrewlock andrewlock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewlock andrewlock merged commit 6569730 into master Jun 18, 2024
46 checks passed
@andrewlock andrewlock deleted the bot/test-package-versions-bump branch June 18, 2024 09:31
@github-actions github-actions bot added this to the vNext-v2 milestone Jun 18, 2024
@e-n-0 e-n-0 added the area:dependabot dependabot updates label Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:dependabot dependabot updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants