Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update workflow file again #5712

Merged
merged 1 commit into from
Jun 21, 2024
Merged

Conversation

andrewlock
Copy link
Member

@andrewlock andrewlock commented Jun 19, 2024

Summary of changes

Fix GitHub versino-bump action

Reason for change

I got the condition wrong 🤦‍♂️ Also, it didn't support -prerelease releases

Implementation details

Run the version bump if the release does end with .0 (or .0-prerelease)

Test coverage

Meh, surely I can't get it wrong twice 😶

Other details

I got it wrong here first:

@andrewlock andrewlock added the area:builds project files, build scripts, pipelines, versioning, releases, packages label Jun 19, 2024
@andrewlock andrewlock requested a review from a team as a code owner June 19, 2024 12:31
Copy link
Collaborator

@gleocadie gleocadie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewlock andrewlock merged commit f466bbd into master Jun 21, 2024
87 checks passed
@andrewlock andrewlock deleted the andrew/ci/fix-workflow-file-again branch June 21, 2024 12:25
@github-actions github-actions bot added this to the vNext-v2 milestone Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:builds project files, build scripts, pipelines, versioning, releases, packages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants