[Profiler] Add global flag to prevent the profiler from stackwalking while the app is crashing #5729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
area:profiler
kevingosse
approved these changes
Jun 24, 2024
Datadog ReportBranch report: ✅ 0 Failed, 335794 Passed, 1922 Skipped, 15h 43m 54.12s Total Time New Flaky Tests (1)
|
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing the following branches/commits: Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (5729) - mean (72ms) : 69, 75
. : milestone, 72,
master - mean (73ms) : 66, 81
. : milestone, 73,
section CallTarget+Inlining+NGEN
This PR (5729) - mean (993ms) : 966, 1021
. : milestone, 993,
master - mean (987ms) : 966, 1007
. : milestone, 987,
gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (5729) - mean (110ms) : 105, 116
. : milestone, 110,
master - mean (110ms) : 107, 113
. : milestone, 110,
section CallTarget+Inlining+NGEN
This PR (5729) - mean (697ms) : 676, 718
. : milestone, 697,
master - mean (697ms) : 677, 718
. : milestone, 697,
gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (5729) - mean (93ms) : 90, 96
. : milestone, 93,
master - mean (93ms) : 89, 96
. : milestone, 93,
section CallTarget+Inlining+NGEN
This PR (5729) - mean (654ms) : 626, 682
. : milestone, 654,
master - mean (652ms) : 630, 675
. : milestone, 652,
gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (5729) - mean (191ms) : 188, 194
. : milestone, 191,
master - mean (190ms) : 187, 194
. : milestone, 190,
section CallTarget+Inlining+NGEN
This PR (5729) - mean (1,081ms) : 1059, 1103
. : milestone, 1081,
master - mean (1,080ms) : 1055, 1104
. : milestone, 1080,
gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (5729) - mean (278ms) : 272, 284
. : milestone, 278,
master - mean (275ms) : 271, 280
. : milestone, 275,
section CallTarget+Inlining+NGEN
This PR (5729) - mean (872ms) : 845, 899
. : milestone, 872,
master - mean (869ms) : 846, 892
. : milestone, 869,
gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (5729) - mean (265ms) : 262, 269
. : milestone, 265,
master - mean (264ms) : 260, 269
. : milestone, 264,
section CallTarget+Inlining+NGEN
This PR (5729) - mean (855ms) : 834, 876
. : milestone, 855,
master - mean (851ms) : 826, 875
. : milestone, 851,
|
Throughput/Crank Report:zap:Throughput results for AspNetCoreSimpleController comparing the following branches/commits: Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red. Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards! gantt
title Throughput Linux x64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (5729) (11.593M) : 0, 11593400
master (11.680M) : 0, 11680352
benchmarks/2.9.0 (11.545M) : 0, 11545343
section Automatic
This PR (5729) (7.818M) : 0, 7818112
master (7.820M) : 0, 7819638
benchmarks/2.9.0 (8.126M) : 0, 8125785
section Trace stats
master (8.158M) : 0, 8157732
section Manual
This PR (5729) (9.996M) : 0, 9996027
master (9.925M) : 0, 9924578
section Manual + Automatic
This PR (5729) (7.432M) : 0, 7431905
master (7.482M) : 0, 7482449
section Version Conflict
master (6.635M) : 0, 6634968
gantt
title Throughput Linux arm64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (5729) (9.473M) : 0, 9472699
master (9.294M) : 0, 9294338
benchmarks/2.9.0 (9.619M) : 0, 9619209
section Automatic
This PR (5729) (6.523M) : 0, 6522520
master (6.468M) : 0, 6468177
section Trace stats
master (6.754M) : 0, 6754461
section Manual
This PR (5729) (8.218M) : 0, 8218318
master (8.162M) : 0, 8161768
section Manual + Automatic
This PR (5729) (6.222M) : 0, 6222419
master (6.262M) : 0, 6262414
section Version Conflict
master (5.565M) : 0, 5565453
gantt
title Throughput Windows x64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (5729) (10.061M) : 0, 10061452
master (10.199M) : 0, 10198615
benchmarks/2.9.0 (10.207M) : 0, 10207218
section Automatic
This PR (5729) (7.072M) : 0, 7071813
master (7.255M) : 0, 7255144
benchmarks/2.9.0 (7.563M) : 0, 7562593
section Trace stats
master (7.633M) : 0, 7633330
section Manual
This PR (5729) (8.758M) : 0, 8757722
master (9.048M) : 0, 9047753
section Manual + Automatic
This PR (5729) (6.721M) : 0, 6720848
master (6.964M) : 0, 6963644
section Version Conflict
master (6.423M) : 0, 6422917
|
Benchmarks Report for tracer 🐌Benchmarks for #5729 compared to master:
The following thresholds were used for comparing the benchmark speeds:
Allocation changes below 0.5% are ignored. Benchmark detailsBenchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.SpanBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.TraceAnnotationsBenchmark - Faster 🎉 Same allocations ✔️
|
| Benchmark | base/diff | Base Median (ns) | Diff Median (ns) | Modality |
|---|---|---|---|---|
| Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net6.0 | 1.125 | 751.24 | 668.00 |
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | RunOnMethodBegin |
net6.0 | 751ns | 0.589ns | 2.28ns | 0.00983 | 0 | 0 | 696 B |
| master | RunOnMethodBegin |
netcoreapp3.1 | 869ns | 0.529ns | 2.05ns | 0.00941 | 0 | 0 | 696 B |
| master | RunOnMethodBegin |
net472 | 1.14μs | 0.687ns | 2.66ns | 0.104 | 0 | 0 | 658 B |
| #5729 | RunOnMethodBegin |
net6.0 | 668ns | 0.222ns | 0.861ns | 0.00968 | 0 | 0 | 696 B |
| #5729 | RunOnMethodBegin |
netcoreapp3.1 | 919ns | 0.439ns | 1.64ns | 0.00963 | 0 | 0 | 696 B |
| #5729 | RunOnMethodBegin |
net472 | 1.1μs | 0.666ns | 2.4ns | 0.104 | 0 | 0 | 658 B |
gleocadie
deleted the
gleocadie/prevent-profiler-from-from-sampling-thread-on-crash
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
We prevent the profiler from collecting stacks (signal-based profilers) when the app is crashing.
Reason for change
We saw few callstacks reported by the CrashTracking product and it seems that the profiler crashes when collecting callstacks when the app is crashing. To avoid noise and mislead the investigation, we will set a flag that will tell the signal-based profilers to stop what they are doing.
Implementation details
is_app_crashingin the wrapper to inform the profiler to not stackwalk.Test coverage
Other details