Add workflow monitor to all workflows #5733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewlock
added
the
area:builds
lucaspimentel
approved these changes
Jun 24, 2024
bouwkast
approved these changes
Jun 24, 2024
andrewlock
added a commit
that referenced
this pull request
Jun 26, 2024
This reverts commit 4429b42.
andrewlock
added a commit
that referenced
this pull request
Jul 1, 2024
## Summary of changes Reverts the workflow monitor ## Reason for change It appears to absolutely _cripple_ the GitHub action network speed. Actions have been failing on master ever since we merged this PR, but here are some examples: Checkout stage - Before: 9s - After: 3min 30s Install .NET stage - Before: 7s - After: 7min Download Azure Build assets - Before: 40s (it's _big_) - After: timeout after 140s ## Implementation details Revert the monitor, we'll have to YOLO the permissions changes with what we have ## Test coverage I've tested this is the cause by disabling it using the variable. But if it's disabled, there's kind of no point in including it in the workflows, so may as well tear it out ## Other details grmbl grmbl, gonna have to just YOLO our permission changes in that case <!--⚠️ Note: where possible, please obtain 2 approvals prior to merging. Unless CODEOWNERS specifies otherwise, for external teams it is typically best to have one review from a team member, and one review from apm-dotnet. Trivial changes do not require 2 reviews. -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Add GitHub's workflow monitor to our workflows
Reason for change
#5728 changes all the permissions for GitHub actions but it's risky - if we have the permissions wrong, then workflows will break. Monitor tells you what you're using (With big caveats) so it would be wise to use that before going all-in on #5728.
Implementation details
Add the monitor to all our actions as described in the docs.
Later (ideally after a release) we'll use the local tool to see what it says.
Note that the monitor doesn't audit GraphQL or Windows workflows, so we're going to be 🤞 with this either way...
Test coverage
This is the test coverage for #5728
Other details