Redis integration benchmarking #576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobuva
reviewed
Dec 2, 2019
performance/Performance.StackExchange.Redis/Properties/launchSettings.json
Show resolved
Hide resolved
| @@ -1,8 +1,12 @@ | |||
| <Project Sdk="Microsoft.NET.Sdk"> | |||
|
|
|||
| <PropertyGroup> | |||
| <TargetFrameworks Condition="'$(OS)' == 'Windows_NT'">net45;net461;netstandard2.0</TargetFrameworks> | |||
| <TargetFrameworks Condition="'$(OS)' != 'Windows_NT'">netstandard2.0</TargetFrameworks> | |||
| <TargetFrameworks Condition="'$(OS)' == 'Windows_NT'">net452;net461;netcoreapp2.1;netcoreapp3.0</TargetFrameworks> | |||
There was a problem hiding this comment.
We generally want to use netstandard2.0 for class libraries and netcoreappX.Y for executables. Any specific reason for this change?
There was a problem hiding this comment.
I couldn't reference System.Runtime.RuntimeInformation consistently with netstandard for some reason
There was a problem hiding this comment.
You may need the System.Runtime.InteropServices.RuntimeInformation NuGet package. It's what we do in Datadog.Trace.
There was a problem hiding this comment.
Can you change these from netcoreapp# to netstandard2.0?
colin-higgins
force-pushed
the
colin/performance/redis-benchmarking
branch
from
401f4db
to
071c809
Compare
colin-higgins
added
the
type:performance
lucaspimentel
approved these changes
Dec 5, 2019
MikeGoldsmith
pushed a commit
to lightstep/ls-trace-dotnet
that referenced
this pull request
Mar 20, 2020
* Redis integration benchmarks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redis benchmarks
@DataDog/apm-dotnet