Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mini Agent][Private Beta Testing] Mini-agent for Azure Function Apps for non-consumption plans #5792

Merged
merged 9 commits into from
Aug 20, 2024

Conversation

joeyzhao2018
Copy link
Contributor

@joeyzhao2018 joeyzhao2018 commented Jul 18, 2024

SVLS-4943

Summary of changes

Expand the mini-agent use case in Azure Function Apps from currently only consumption plan to

  • Windows still only consumption as other plans tend to have regular agent solutions such as extension
  • Linux servers will all use mini-agent as this is the only viable solution we see so far.

Reason for change

  • We are trying to put the mini-agent into Private Beta
  • Some customers are asking specifically.

Implementation details

I've checked the related configurations as listed below and I think they should still apply in the linux server case if we are starting to use mini-agent.

[History] Usage of IsRunningInAzureFunctionsConsumptionPlan

  • First added by the mini-agent PR
  • In StatsComputationEnabledInternal. The same PR added.
  • In TraceBatchInterval, used to set the trace batch interval to 0. PR Link
  • In IsRemoteConfigurationAvailable, used to indicate remote configuration not available.
  • In isServerless of TelemetrySettings. Used to turn off Metrics by default. PR link.

Test coverage

minor updates to existing tests

Other notes

I've had the idea that we first detect whether the mini-agent path exists and then set related variables listed above assuming mini-agent will be used. However, after some consideration, I think this approach has two main problems.

  1. It's a bit of a chicken-egg situation where we want to know the settings when checking the path but also want to know the path when we set the setting. Logically we can sort this out by putting down the path as one of the setting. Is it worth adding a new configuration to TracerSetting?
  2. I don't know what's the best place to check the DD_MINI_AGENT_PATH.
    Let me know if this idea sounds better? Otherwise, let's keep it as simple as this PR.

@datadog-ddstaging
Copy link

datadog-ddstaging bot commented Jul 18, 2024

Datadog Report

Branch report: joey/mini-agent-non-consumption-plan
Commit report: 8dea14b
Test service: dd-trace-dotnet

✅ 0 Failed, 351934 Passed, 1781 Skipped, 14h 39m 0.47s Total Time

@andrewlock
Copy link
Member

andrewlock commented Jul 18, 2024

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

@andrewlock
Copy link
Member

andrewlock commented Jul 18, 2024

Benchmarks Report for tracer 🐌

Benchmarks for #5792 compared to master:

  • 2 benchmarks are faster, with geometric mean 1.159
  • 1 benchmarks are slower, with geometric mean 1.159
  • All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 7.75μs 44ns 317ns 0.0119 0.00396 0 5.42 KB
master StartStopWithChild netcoreapp3.1 9.88μs 52.8ns 299ns 0.0189 0.00946 0 5.62 KB
master StartStopWithChild net472 16.8μs 98.2ns 873ns 1.02 0.299 0.0913 6.07 KB
#5792 StartStopWithChild net6.0 7.61μs 43.2ns 317ns 0.0153 0.00766 0 5.42 KB
#5792 StartStopWithChild netcoreapp3.1 9.75μs 54.7ns 354ns 0.0191 0.00953 0 5.62 KB
#5792 StartStopWithChild net472 16μs 56.9ns 220ns 1.02 0.31 0.0875 6.06 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 466μs 254ns 982ns 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 656μs 379ns 1.47μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 825μs 395ns 1.53μs 0.414 0 0 3.3 KB
#5792 WriteAndFlushEnrichedTraces net6.0 464μs 310ns 1.16μs 0 0 0 2.7 KB
#5792 WriteAndFlushEnrichedTraces netcoreapp3.1 622μs 213ns 795ns 0 0 0 2.7 KB
#5792 WriteAndFlushEnrichedTraces net472 838μs 561ns 2.17μs 0.419 0 0 3.3 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 193μs 1.09μs 7.46μs 0.185 0 0 18.45 KB
master SendRequest netcoreapp3.1 223μs 1.31μs 11.9μs 0.22 0 0 20.61 KB
master SendRequest net472 0.00042ns 0.000232ns 0.00087ns 0 0 0 0 b
#5792 SendRequest net6.0 192μs 1.04μs 5.69μs 0.19 0 0 18.45 KB
#5792 SendRequest netcoreapp3.1 208μs 1.16μs 7.63μs 0.214 0 0 20.61 KB
#5792 SendRequest net472 9.85E‑05ns 9.85E‑05ns 0.000355ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 565μs 1.46μs 5.65μs 0.539 0 0 41.65 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 663μs 2.47μs 9.55μs 0.327 0 0 41.87 KB
master WriteAndFlushEnrichedTraces net472 868μs 2.51μs 9.39μs 8.36 2.64 0.44 53.34 KB
#5792 WriteAndFlushEnrichedTraces net6.0 568μs 2.98μs 14.3μs 0.561 0 0 41.59 KB
#5792 WriteAndFlushEnrichedTraces netcoreapp3.1 664μs 2.12μs 8.5μs 0.334 0 0 41.79 KB
#5792 WriteAndFlushEnrichedTraces net472 859μs 4.17μs 17.7μs 8.3 2.62 0.437 53.32 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.23μs 0.603ns 2.33ns 0.0141 0 0 1.02 KB
master ExecuteNonQuery netcoreapp3.1 1.62μs 1.02ns 3.81ns 0.0138 0 0 1.02 KB
master ExecuteNonQuery net472 2.01μs 0.979ns 3.53ns 0.156 0 0 987 B
#5792 ExecuteNonQuery net6.0 1.22μs 1.29ns 4.99ns 0.0146 0 0 1.02 KB
#5792 ExecuteNonQuery netcoreapp3.1 1.66μs 1.43ns 5.55ns 0.0141 0 0 1.02 KB
#5792 ExecuteNonQuery net472 1.98μs 2.28ns 8.84ns 0.156 0 0 987 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.24μs 0.932ns 3.49ns 0.0138 0 0 976 B
master CallElasticsearch netcoreapp3.1 1.54μs 0.578ns 2.24ns 0.0131 0 0 976 B
master CallElasticsearch net472 2.39μs 1.15ns 4.29ns 0.158 0 0 995 B
master CallElasticsearchAsync net6.0 1.31μs 0.779ns 3.02ns 0.0131 0 0 952 B
master CallElasticsearchAsync netcoreapp3.1 1.68μs 0.532ns 2.06ns 0.0135 0 0 1.02 KB
master CallElasticsearchAsync net472 2.54μs 1.36ns 5.25ns 0.166 0 0 1.05 KB
#5792 CallElasticsearch net6.0 1.19μs 1.19ns 4.44ns 0.0137 0 0 976 B
#5792 CallElasticsearch netcoreapp3.1 1.61μs 0.567ns 2.12ns 0.0129 0 0 976 B
#5792 CallElasticsearch net472 2.47μs 1.87ns 7.25ns 0.158 0 0 995 B
#5792 CallElasticsearchAsync net6.0 1.38μs 1.14ns 4.27ns 0.0131 0 0 952 B
#5792 CallElasticsearchAsync netcoreapp3.1 1.64μs 0.66ns 2.38ns 0.0141 0 0 1.02 KB
#5792 CallElasticsearchAsync net472 2.51μs 2.17ns 8.41ns 0.167 0 0 1.05 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.27μs 0.974ns 3.77ns 0.0134 0 0 952 B
master ExecuteAsync netcoreapp3.1 1.68μs 0.72ns 2.7ns 0.0128 0 0 952 B
master ExecuteAsync net472 1.76μs 1.62ns 6.27ns 0.145 0 0 915 B
#5792 ExecuteAsync net6.0 1.15μs 0.832ns 3.11ns 0.0133 0 0 952 B
#5792 ExecuteAsync netcoreapp3.1 1.6μs 0.734ns 2.75ns 0.0128 0 0 952 B
#5792 ExecuteAsync net472 1.72μs 0.885ns 3.43ns 0.145 0 0 915 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 4.24μs 1.09ns 4.07ns 0.0298 0 0 2.22 KB
master SendAsync netcoreapp3.1 5.13μs 1.49ns 5.77ns 0.0359 0 0 2.76 KB
master SendAsync net472 7.75μs 2.96ns 11.5ns 0.496 0 0 3.15 KB
#5792 SendAsync net6.0 4.14μs 1.63ns 5.88ns 0.031 0 0 2.22 KB
#5792 SendAsync netcoreapp3.1 5.03μs 2.25ns 8.11ns 0.0379 0 0 2.76 KB
#5792 SendAsync net472 7.8μs 7.45ns 28.9ns 0.499 0 0 3.15 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 1.59μs 0.51ns 1.84ns 0.0228 0 0 1.64 KB
master EnrichedLog netcoreapp3.1 2.29μs 1.8ns 6.75ns 0.0228 0 0 1.64 KB
master EnrichedLog net472 2.67μs 1.96ns 7.6ns 0.249 0 0 1.57 KB
#5792 EnrichedLog net6.0 1.6μs 1.47ns 5.49ns 0.0231 0 0 1.64 KB
#5792 EnrichedLog netcoreapp3.1 2.2μs 2.08ns 7.78ns 0.022 0 0 1.64 KB
#5792 EnrichedLog net472 2.65μs 1.7ns 6.38ns 0.249 0 0 1.57 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 116μs 128ns 462ns 0.0581 0 0 4.28 KB
master EnrichedLog netcoreapp3.1 119μs 166ns 644ns 0 0 0 4.28 KB
master EnrichedLog net472 150μs 175ns 677ns 0.667 0.222 0 4.46 KB
#5792 EnrichedLog net6.0 116μs 290ns 1.12μs 0 0 0 4.28 KB
#5792 EnrichedLog netcoreapp3.1 121μs 309ns 1.2μs 0.0602 0 0 4.28 KB
#5792 EnrichedLog net472 151μs 211ns 819ns 0.678 0.226 0 4.46 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 3.18μs 13.6ns 50.8ns 0.0307 0 0 2.2 KB
master EnrichedLog netcoreapp3.1 4.24μs 1.03ns 3.55ns 0.0298 0 0 2.2 KB
master EnrichedLog net472 4.86μs 1.21ns 4.54ns 0.32 0 0 2.02 KB
#5792 EnrichedLog net6.0 2.98μs 0.768ns 2.97ns 0.0312 0 0 2.2 KB
#5792 EnrichedLog netcoreapp3.1 4.23μs 1.1ns 3.98ns 0.0297 0 0 2.2 KB
#5792 EnrichedLog net472 4.98μs 1.74ns 6.75ns 0.319 0 0 2.02 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 1.35μs 0.897ns 3.48ns 0.0157 0 0 1.14 KB
master SendReceive netcoreapp3.1 1.81μs 1.11ns 4.01ns 0.0153 0 0 1.14 KB
master SendReceive net472 2.15μs 1.33ns 5.14ns 0.183 0 0 1.16 KB
#5792 SendReceive net6.0 1.32μs 0.616ns 2.39ns 0.0164 0 0 1.14 KB
#5792 SendReceive netcoreapp3.1 1.72μs 0.85ns 3.29ns 0.0156 0 0 1.14 KB
#5792 SendReceive net472 2.19μs 1.53ns 5.93ns 0.184 0.00109 0 1.16 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.69μs 0.705ns 2.44ns 0.0216 0 0 1.6 KB
master EnrichedLog netcoreapp3.1 3.86μs 1.94ns 7.52ns 0.0213 0 0 1.65 KB
master EnrichedLog net472 4.26μs 1.62ns 6.08ns 0.323 0 0 2.04 KB
#5792 EnrichedLog net6.0 2.89μs 1.35ns 5.21ns 0.0216 0 0 1.6 KB
#5792 EnrichedLog netcoreapp3.1 3.92μs 1.03ns 3.86ns 0.0214 0 0 1.65 KB
#5792 EnrichedLog net472 4.42μs 2.48ns 9.59ns 0.323 0 0 2.04 KB
Benchmarks.Trace.SpanBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #5792

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net472 1.159 592.24 686.63

Faster 🎉 in #5792

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net6.0 1.195 566.36 473.75

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 432ns 0.25ns 0.968ns 0.00812 0 0 576 B
master StartFinishSpan netcoreapp3.1 553ns 0.34ns 1.32ns 0.00774 0 0 576 B
master StartFinishSpan net472 592ns 0.353ns 1.37ns 0.0918 0 0 578 B
master StartFinishScope net6.0 569ns 2.28ns 8.84ns 0.00971 0 0 696 B
master StartFinishScope netcoreapp3.1 723ns 1.28ns 4.96ns 0.00935 0 0 696 B
master StartFinishScope net472 807ns 1.63ns 6.09ns 0.104 0 0 658 B
#5792 StartFinishSpan net6.0 407ns 0.189ns 0.706ns 0.00811 0 0 576 B
#5792 StartFinishSpan netcoreapp3.1 596ns 0.696ns 2.7ns 0.00777 0 0 576 B
#5792 StartFinishSpan net472 690ns 2.7ns 10.5ns 0.0917 0 0 578 B
#5792 StartFinishScope net6.0 474ns 0.151ns 0.583ns 0.00973 0 0 696 B
#5792 StartFinishScope netcoreapp3.1 650ns 0.588ns 2.28ns 0.00914 0 0 696 B
#5792 StartFinishScope net472 893ns 0.528ns 2.04ns 0.104 0 0 658 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #5792

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net6.0 1.124 712.10 633.52

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 712ns 0.372ns 1.39ns 0.00964 0 0 696 B
master RunOnMethodBegin netcoreapp3.1 1.02μs 0.989ns 3.83ns 0.00917 0 0 696 B
master RunOnMethodBegin net472 1.1μs 3.73ns 13.5ns 0.104 0 0 658 B
#5792 RunOnMethodBegin net6.0 634ns 0.467ns 1.81ns 0.00957 0 0 696 B
#5792 RunOnMethodBegin netcoreapp3.1 953ns 0.514ns 1.99ns 0.00955 0 0 696 B
#5792 RunOnMethodBegin net472 1.1μs 0.567ns 2.04ns 0.104 0 0 658 B

@joeyzhao2018 joeyzhao2018 changed the title [Mini Agent] Remove the Consumption Plan check for Azure Function Apps [Mini Agent][Private Beta Testing] Mini-agent for Azure Function Apps for non-consumption plans Jul 22, 2024
@joeyzhao2018 joeyzhao2018 force-pushed the joey/mini-agent-non-consumption-plan branch 6 times, most recently from 5d72b57 to 89c5b10 Compare July 26, 2024 02:37
@joeyzhao2018 joeyzhao2018 force-pushed the joey/mini-agent-non-consumption-plan branch from 89c5b10 to 3babef0 Compare July 26, 2024 02:39
@joeyzhao2018 joeyzhao2018 marked this pull request as ready for review August 1, 2024 19:24
@joeyzhao2018 joeyzhao2018 requested review from a team as code owners August 1, 2024 19:24
@andrewlock
Copy link
Member

Throughput/Crank Report ⚡

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5792) (11.791M)   : 0, 11790956
    master (11.532M)   : 0, 11531520
    benchmarks/2.9.0 (11.568M)   : 0, 11567598

    section Automatic
    This PR (5792) (7.714M)   : 0, 7713886
    master (7.727M)   : 0, 7727133
    benchmarks/2.9.0 (8.079M)   : 0, 8079346

    section Trace stats
    master (8.135M)   : 0, 8135408

    section Manual
    master (11.628M)   : 0, 11627537

    section Manual + Automatic
    This PR (5792) (7.272M)   : 0, 7271558
    master (7.183M)   : 0, 7183466

    section DD_TRACE_ENABLED=0
    master (10.711M)   : 0, 10710555

Loading
gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5792) (9.607M)   : 0, 9607313
    master (9.524M)   : 0, 9524383

    section Automatic
    This PR (5792) (6.636M)   : 0, 6636303
    master (6.463M)   : 0, 6463282

    section Trace stats
    master (6.871M)   : 0, 6871268

    section Manual
    master (9.587M)   : 0, 9586529

    section Manual + Automatic
    This PR (5792) (6.226M)   : 0, 6226049
    master (6.162M)   : 0, 6162024

    section DD_TRACE_ENABLED=0
    master (8.819M)   : 0, 8818566

Loading
gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5792) (10.083M)   : 0, 10082844
    benchmarks/2.9.0 (10.327M)   : 0, 10326763

    section Automatic
    This PR (5792) (6.572M)   : 0, 6571569
    benchmarks/2.9.0 (7.507M)   : 0, 7507426

    section Manual + Automatic
    This PR (5792) (6.138M)   : 0, 6138365

Loading

@duncanpharvey
Copy link
Contributor

Manually tested the cases below.

Regression Tests:

  • Windows / Premium Plan -> mini agent not started ✅
  • Windows / Consumption Plan -> mini agent started ✅
  • Linux / Consumption Plan -> mini agent started ✅

Behavior added in this PR:

  • Linux / Premium Plan -> mini agent started ✅

Copy link
Member

@lucaspimentel lucaspimentel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one low-priority comment

@lucaspimentel lucaspimentel requested a review from a team August 19, 2024 19:38
Copy link
Member

@andrewlock andrewlock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just +1 on Lucas' comments

@duncanpharvey duncanpharvey merged commit 9a9d06b into master Aug 20, 2024
62 of 67 checks passed
@duncanpharvey duncanpharvey deleted the joey/mini-agent-non-consumption-plan branch August 20, 2024 18:16
@github-actions github-actions bot added this to the vNext-v3 milestone Aug 20, 2024
andrewlock added a commit that referenced this pull request Sep 6, 2024
…ion Plans (#5792 -> v2) (#5986)

## Summary of changes

Start Serverless Mini Agent for Azure Functions on Linux Non-Consumption
(Basic/Standard/Premium) Plans.

## Reason for change

Customers with this setup asking for beta.

## Implementation details

## Test coverage

Unit Tests ✅ 

Manually tested the cases below.

Regression Tests:

Windows / Premium Plan -> mini agent not started ✅
Windows / Consumption Plan -> mini agent started ✅
Linux / Consumption Plan -> mini agent started ✅

Behavior added in this PR:

Linux / Premium Plan -> mini agent started ✅

## Other details
<!-- Fixes #{issue} -->

<!-- ⚠️ Note: where possible, please obtain 2 approvals prior to
merging. Unless CODEOWNERS specifies otherwise, for external teams it is
typically best to have one review from a team member, and one review
from apm-dotnet. Trivial changes do not require 2 reviews. -->

Follows #5792

---------

Co-authored-by: Joey Zhao <5253430+joeyzhao2018@users.noreply.github.com>
Co-authored-by: Lucas Pimentel <lucas.pimentel@datadoghq.com>
Co-authored-by: Andrew Lock <andrew.lock@datadoghq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants