-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Samples] Update IIS sample Dockerfile #5805
Conversation
98937e5
to
af2ca76
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I take your word for it, but I don't really understand why we need to make some of these changes 🤷♂️
# Note: Normally an IIS reset is also required but 'C:\ServiceMonitor.exe w3svc' | ||
# will restart IIS and update the environment variables received by the child w3wp processes | ||
RUN Write-Host 'Determining latest release' ;\ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason this can't be done here and instead has to be moved to a file? 🤔 I don't know of a good reason it needs to be?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Level of care low on this one, but I can think of a few very "mild" reasons 😅
- If a script is going to be more than a handful of lines, I think it deserves its own file (cleaner code, separation of concerns, etc)
- This particular script is not Docker-specific. A separate file makes it easier to copy and use elsewhere.
- It definitely made it easier and faster for me to fix it outside of Docker. (probably the main reason I did it)
e9b34b7
to
a610928
Compare
a610928
to
3b36547
Compare
Summary of changes
Improve the
Dockerfile
used to installdd-trace-dotnet
in the containerized IIS app sample intracer/samples/IISInDocker
.Reason for change
A user reported having issues with the Dockerfile, and I was able to reproduce.
Implementation details
ps1
fileInvoke-WebRequest
instead of .NET'sSystem.Net.WebClient.DownloadFile()
(which is obsolete)
latest
instead of the most recent (not the same thing! this would've downloaded preview versions of v3.x, for example).dockerignore
fileTest coverage
Tested manually.