[Dynamic Instrumentation] DEBUG-2524 Fix EL numeric binary operations #5815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Datadog ReportBranch report: ❌ 26 Failed (0 Known Flaky), 351252 Passed, 2244 Skipped, 23h 23m 41.78s Total Time ❌ Failed Tests (26)
⌛ Performance Regressions vs Default Branch (1)
|
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing the following branches/commits: Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (5815) - mean (69ms) : 67, 72
. : milestone, 69,
master - mean (72ms) : 63, 81
. : milestone, 72,
section CallTarget+Inlining+NGEN
This PR (5815) - mean (1,072ms) : 1037, 1106
. : milestone, 1072,
master - mean (1,067ms) : 1046, 1087
. : milestone, 1067,
gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (5815) - mean (109ms) : 105, 113
. : milestone, 109,
master - mean (110ms) : 105, 115
. : milestone, 110,
section CallTarget+Inlining+NGEN
This PR (5815) - mean (754ms) : 725, 784
. : milestone, 754,
master - mean (756ms) : 727, 786
. : milestone, 756,
gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (5815) - mean (92ms) : 89, 96
. : milestone, 92,
master - mean (93ms) : 89, 96
. : milestone, 93,
section CallTarget+Inlining+NGEN
This PR (5815) - mean (703ms) : 684, 723
. : milestone, 703,
master - mean (704ms) : 681, 728
. : milestone, 704,
gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (5815) - mean (193ms) : 189, 197
. : milestone, 193,
master - mean (192ms) : 189, 195
. : milestone, 192,
section CallTarget+Inlining+NGEN
This PR (5815) - mean (1,169ms) : 1139, 1199
. : milestone, 1169,
master - mean (1,167ms) : 1141, 1193
. : milestone, 1167,
gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (5815) - mean (279ms) : 274, 285
. : milestone, 279,
master - mean (276ms) : 271, 281
. : milestone, 276,
section CallTarget+Inlining+NGEN
This PR (5815) - mean (924ms) : 902, 946
. : milestone, 924,
master - mean (922ms) : 903, 941
. : milestone, 922,
gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (5815) - mean (266ms) : 263, 270
. : milestone, 266,
master - mean (266ms) : 262, 270
. : milestone, 266,
section CallTarget+Inlining+NGEN
This PR (5815) - mean (912ms) : 881, 944
. : milestone, 912,
master - mean (908ms) : 886, 929
. : milestone, 908,
|
Benchmarks Report for tracer 🐌Benchmarks for #5815 compared to master:
The following thresholds were used for comparing the benchmark speeds:
Allocation changes below 0.5% are ignored. Benchmark detailsBenchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.SpanBenchmark - Faster 🎉 Same allocations ✔️
|
| Benchmark | base/diff | Base Median (ns) | Diff Median (ns) | Modality |
|---|---|---|---|---|
| Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net6.0 | 1.260 | 530.69 | 421.06 |
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | StartFinishSpan |
net6.0 | 531ns | 0.519ns | 1.87ns | 0.00811 | 0 | 0 | 576 B |
| master | StartFinishSpan |
netcoreapp3.1 | 565ns | 1.13ns | 4.38ns | 0.00775 | 0 | 0 | 576 B |
| master | StartFinishSpan |
net472 | 666ns | 0.577ns | 2.16ns | 0.0916 | 0 | 0 | 578 B |
| master | StartFinishScope |
net6.0 | 503ns | 0.737ns | 2.85ns | 0.00977 | 0 | 0 | 696 B |
| master | StartFinishScope |
netcoreapp3.1 | 764ns | 0.352ns | 1.37ns | 0.00942 | 0 | 0 | 696 B |
| master | StartFinishScope |
net472 | 861ns | 0.573ns | 2.14ns | 0.104 | 0 | 0 | 658 B |
| #5815 | StartFinishSpan |
net6.0 | 421ns | 0.147ns | 0.552ns | 0.00806 | 0 | 0 | 576 B |
| #5815 | StartFinishSpan |
netcoreapp3.1 | 610ns | 0.485ns | 1.75ns | 0.00777 | 0 | 0 | 576 B |
| #5815 | StartFinishSpan |
net472 | 602ns | 0.633ns | 2.45ns | 0.0918 | 0 | 0 | 578 B |
| #5815 | StartFinishScope |
net6.0 | 476ns | 0.192ns | 0.743ns | 0.00984 | 0 | 0 | 696 B |
| #5815 | StartFinishScope |
netcoreapp3.1 | 795ns | 0.395ns | 1.53ns | 0.00946 | 0 | 0 | 696 B |
| #5815 | StartFinishScope |
net472 | 867ns | 4.31ns | 20.2ns | 0.105 | 0 | 0 | 658 B |
Benchmarks.Trace.TraceAnnotationsBenchmark - Slower ⚠️ Same allocations ✔️
Slower ⚠️ in #5815
Benchmark
diff/base
Base Median (ns)
Diff Median (ns)
Modality
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net472
1.119
1,055.24
1,180.39
Faster 🎉 in #5815
Benchmark
base/diff
Base Median (ns)
Diff Median (ns)
Modality
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net6.0
1.257
818.32
650.90
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑netcoreapp3.1
1.188
1,067.92
898.74
| Benchmark | diff/base | Base Median (ns) | Diff Median (ns) | Modality |
|---|---|---|---|---|
| Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net472 | 1.119 | 1,055.24 | 1,180.39 |
| Benchmark | base/diff | Base Median (ns) | Diff Median (ns) | Modality |
|---|---|---|---|---|
| Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net6.0 | 1.257 | 818.32 | 650.90 | |
| Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑netcoreapp3.1 | 1.188 | 1,067.92 | 898.74 |
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | RunOnMethodBegin |
net6.0 | 820ns | 1.96ns | 7.35ns | 0.00988 | 0 | 0 | 696 B |
| master | RunOnMethodBegin |
netcoreapp3.1 | 1.07μs | 0.629ns | 2.44ns | 0.00957 | 0 | 0 | 696 B |
| master | RunOnMethodBegin |
net472 | 1.06μs | 2.8ns | 10.8ns | 0.104 | 0 | 0 | 658 B |
| #5815 | RunOnMethodBegin |
net6.0 | 650ns | 0.473ns | 1.83ns | 0.00976 | 0 | 0 | 696 B |
| #5815 | RunOnMethodBegin |
netcoreapp3.1 | 899ns | 0.411ns | 1.48ns | 0.00945 | 0 | 0 | 696 B |
| #5815 | RunOnMethodBegin |
net472 | 1.18μs | 2.46ns | 9.22ns | 0.104 | 0 | 0 | 658 B |
dudikeleti
force-pushed
the
dudik/el-compare-numeric-types
branch
from
4b3b489
to
8993a61
Compare
GreenMatan
approved these changes
Aug 7, 2024
tracer/src/Datadog.Trace/Debugger/Expressions/ProbeExpressionParser.General.cs
Outdated
Show resolved
Hide resolved
dudikeleti
force-pushed
the
dudik/el-compare-numeric-types
branch
2 times, most recently
from
83d25e1
to
8dadf3e
Compare
dudikeleti
force-pushed
the
dudik/el-compare-numeric-types
branch
from
ebcee33
to
161cc06
Compare
dudikeleti
added a commit
that referenced
this pull request
Aug 9, 2024
## Summary of changes Fix debugger integration test that broke in this [PR](#5815)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
This PR fix the process of comparison different numeric types
Test coverage
Updated EL tests & system tests