Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Test Package Versions Bump] Updating package versions #5819

Merged
merged 1 commit into from
Jul 31, 2024
Merged

[Test Package Versions Bump] Updating package versions #5819

merged 1 commit into from
Jul 31, 2024

Conversation

github-actions[bot]
Copy link
Contributor

Updates the package versions for integration tests.

@github-actions github-actions bot requested review from a team as code owners July 28, 2024 00:21
@andrewlock
Copy link
Member

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5819) - mean (71ms)  : 66, 76
     .   : milestone, 71,
    master - mean (73ms)  : 65, 82
     .   : milestone, 73,

    section CallTarget+Inlining+NGEN
    This PR (5819) - mean (1,039ms)  : 1011, 1068
     .   : milestone, 1039,
    master - mean (1,059ms)  : 1032, 1086
     .   : milestone, 1059,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5819) - mean (110ms)  : 106, 113
     .   : milestone, 110,
    master - mean (110ms)  : 105, 114
     .   : milestone, 110,

    section CallTarget+Inlining+NGEN
    This PR (5819) - mean (724ms)  : 702, 747
     .   : milestone, 724,
    master - mean (753ms)  : 726, 779
     .   : milestone, 753,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5819) - mean (93ms)  : 89, 96
     .   : milestone, 93,
    master - mean (94ms)  : 90, 98
     .   : milestone, 94,

    section CallTarget+Inlining+NGEN
    This PR (5819) - mean (679ms)  : 656, 703
     .   : milestone, 679,
    master - mean (703ms)  : 673, 733
     .   : milestone, 703,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5819) - mean (191ms)  : 188, 194
     .   : milestone, 191,
    master - mean (192ms)  : 188, 197
     .   : milestone, 192,

    section CallTarget+Inlining+NGEN
    This PR (5819) - mean (1,135ms)  : 1116, 1154
     .   : milestone, 1135,
    master - mean (1,154ms)  : 1127, 1180
     .   : milestone, 1154,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5819) - mean (276ms)  : 272, 280
     .   : milestone, 276,
    master - mean (277ms)  : 272, 281
     .   : milestone, 277,

    section CallTarget+Inlining+NGEN
    This PR (5819) - mean (897ms)  : 880, 915
     .   : milestone, 897,
    master - mean (918ms)  : 893, 943
     .   : milestone, 918,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5819) - mean (265ms)  : 260, 270
     .   : milestone, 265,
    master - mean (267ms)  : 262, 272
     .   : milestone, 267,

    section CallTarget+Inlining+NGEN
    This PR (5819) - mean (876ms)  : 854, 898
     .   : milestone, 876,
    master - mean (899ms)  : 876, 923
     .   : milestone, 899,
Loading

@datadog-ddstaging
Copy link

datadog-ddstaging bot commented Jul 28, 2024 •
edited
Loading

Datadog Report

Branch report: bot/test-package-versions-bump
Commit report: 5d27d43
Test service: dd-trace-dotnet

✅ 0 Failed, 340022 Passed, 1744 Skipped, 14h 48m 26.67s Total Time

@andrewlock
Copy link
Member

Benchmarks Report for tracer 🐌

Benchmarks for #5819 compared to master:

  • 4 benchmarks are faster, with geometric mean 1.129
  • 1 benchmarks have fewer allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 7.5μs 40.5ns 259ns 0.0146 0.00729 0 5.42 KB
master StartStopWithChild netcoreapp3.1 9.87μs 55ns 339ns 0.0198 0.0099 0 5.62 KB
master StartStopWithChild net472 15.9μs 37.5ns 145ns 1.02 0.307 0.0946 6.07 KB
#5819 StartStopWithChild net6.0 7.71μs 39.6ns 190ns 0.0153 0.00763 0 5.43 KB
#5819 StartStopWithChild netcoreapp3.1 9.85μs 54.7ns 328ns 0.0188 0.00942 0 5.62 KB
#5819 StartStopWithChild net472 16μs 61.4ns 238ns 1.02 0.316 0.0948 6.05 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 455μs 304ns 1.18μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 633μs 633ns 2.45μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 843μs 435ns 1.57μs 0.422 0 0 3.3 KB
#5819 WriteAndFlushEnrichedTraces net6.0 470μs 234ns 842ns 0 0 0 2.7 KB
#5819 WriteAndFlushEnrichedTraces netcoreapp3.1 643μs 636ns 2.46μs 0 0 0 2.7 KB
#5819 WriteAndFlushEnrichedTraces net472 853μs 521ns 2.02μs 0.425 0 0 3.3 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 190μs 1μs 7.23μs 0.191 0 0 18.45 KB
master SendRequest netcoreapp3.1 220μs 1.26μs 9.35μs 0.207 0 0 20.61 KB
master SendRequest net472 0.00359ns 0.00127ns 0.00491ns 0 0 0 0 b
#5819 SendRequest net6.0 196μs 1.13μs 8.42μs 0.199 0 0 18.45 KB
#5819 SendRequest netcoreapp3.1 222μs 1.28μs 11.1μs 0.215 0 0 20.61 KB
#5819 SendRequest net472 0.00195ns 0.000558ns 0.00209ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #5819

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑netcoreapp3.1 41.74 KB 41.53 KB -213 B -0.51%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 585μs 2.76μs 16.1μs 0.568 0 0 41.62 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 668μs 2.83μs 11μs 0.331 0 0 41.74 KB
master WriteAndFlushEnrichedTraces net472 884μs 2.96μs 11.4μs 8.25 2.6 0.434 53.29 KB
#5819 WriteAndFlushEnrichedTraces net6.0 587μs 2.81μs 10.9μs 0.566 0 0 41.52 KB
#5819 WriteAndFlushEnrichedTraces netcoreapp3.1 714μs 3.97μs 25.1μs 0.379 0 0 41.53 KB
#5819 WriteAndFlushEnrichedTraces net472 869μs 2.27μs 8.48μs 8.36 2.64 0.44 53.3 KB
Benchmarks.Trace.DbCommandBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #5819

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.DbCommandBenchmark.ExecuteNonQuery‑net6.0 1.115 1,349.61 1,210.12

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.35μs 0.882ns 3.42ns 0.0142 0 0 1.02 KB
master ExecuteNonQuery netcoreapp3.1 1.75μs 4.11ns 15.9ns 0.0132 0 0 1.02 KB
master ExecuteNonQuery net472 2.02μs 2.92ns 11.3ns 0.157 0 0 987 B
#5819 ExecuteNonQuery net6.0 1.21μs 1.09ns 4.07ns 0.0144 0 0 1.02 KB
#5819 ExecuteNonQuery netcoreapp3.1 1.71μs 1.9ns 7.36ns 0.0136 0 0 1.02 KB
#5819 ExecuteNonQuery net472 1.96μs 2.45ns 9.49ns 0.157 0 0 987 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.11μs 0.63ns 2.36ns 0.0139 0 0 976 B
master CallElasticsearch netcoreapp3.1 1.62μs 1.32ns 5.1ns 0.0129 0 0 976 B
master CallElasticsearch net472 2.55μs 1.87ns 7.22ns 0.158 0.00126 0 995 B
master CallElasticsearchAsync net6.0 1.38μs 0.414ns 1.55ns 0.0131 0 0 952 B
master CallElasticsearchAsync netcoreapp3.1 1.55μs 0.87ns 3.37ns 0.014 0 0 1.02 KB
master CallElasticsearchAsync net472 2.71μs 1.66ns 6.44ns 0.167 0.00136 0 1.05 KB
#5819 CallElasticsearch net6.0 1.23μs 0.75ns 2.91ns 0.0135 0 0 976 B
#5819 CallElasticsearch netcoreapp3.1 1.5μs 0.687ns 2.66ns 0.0128 0 0 976 B
#5819 CallElasticsearch net472 2.47μs 1.01ns 3.76ns 0.158 0.00123 0 995 B
#5819 CallElasticsearchAsync net6.0 1.27μs 0.474ns 1.77ns 0.0133 0 0 952 B
#5819 CallElasticsearchAsync netcoreapp3.1 1.58μs 0.679ns 2.63ns 0.0134 0 0 1.02 KB
#5819 CallElasticsearchAsync net472 2.57μs 0.882ns 3.05ns 0.167 0.00127 0 1.05 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.3μs 0.436ns 1.69ns 0.0131 0 0 952 B
master ExecuteAsync netcoreapp3.1 1.59μs 0.56ns 2.17ns 0.0126 0 0 952 B
master ExecuteAsync net472 1.82μs 0.966ns 3.74ns 0.145 0 0 915 B
#5819 ExecuteAsync net6.0 1.31μs 0.367ns 1.37ns 0.013 0 0 952 B
#5819 ExecuteAsync netcoreapp3.1 1.66μs 0.702ns 2.72ns 0.0127 0 0 952 B
#5819 ExecuteAsync net472 1.76μs 0.88ns 3.29ns 0.145 0.000883 0 915 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 4.27μs 2.3ns 8.91ns 0.0299 0 0 2.22 KB
master SendAsync netcoreapp3.1 5.13μs 2.42ns 9.39ns 0.0359 0 0 2.76 KB
master SendAsync net472 7.74μs 2.99ns 11.6ns 0.497 0 0 3.15 KB
#5819 SendAsync net6.0 4.14μs 2.2ns 8.24ns 0.0311 0 0 2.22 KB
#5819 SendAsync netcoreapp3.1 5.15μs 14.4ns 55.8ns 0.035 0 0 2.76 KB
#5819 SendAsync net472 7.81μs 4.01ns 15.5ns 0.499 0 0 3.15 KB
Benchmarks.Trace.ILoggerBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #5819

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.ILoggerBenchmark.EnrichedLog‑netcoreapp3.1 1.139 2,356.63 2,068.86
Benchmarks.Trace.ILoggerBenchmark.EnrichedLog‑net6.0 1.135 1,637.63 1,443.00

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 1.64μs 1.05ns 3.94ns 0.0233 0 0 1.64 KB
master EnrichedLog netcoreapp3.1 2.35μs 1.48ns 5.55ns 0.0221 0 0 1.64 KB
master EnrichedLog net472 2.56μs 0.771ns 2.98ns 0.25 0 0 1.57 KB
#5819 EnrichedLog net6.0 1.44μs 0.831ns 3.11ns 0.0231 0 0 1.64 KB
#5819 EnrichedLog netcoreapp3.1 2.07μs 1.54ns 5.76ns 0.0215 0 0 1.64 KB
#5819 EnrichedLog net472 2.52μs 0.963ns 3.73ns 0.25 0 0 1.57 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 116μs 213ns 825ns 0.0572 0 0 4.28 KB
master EnrichedLog netcoreapp3.1 119μs 110ns 412ns 0.059 0 0 4.28 KB
master EnrichedLog net472 147μs 116ns 450ns 0.662 0.221 0 4.46 KB
#5819 EnrichedLog net6.0 116μs 136ns 511ns 0.0586 0 0 4.28 KB
#5819 EnrichedLog netcoreapp3.1 120μs 94.4ns 366ns 0 0 0 4.28 KB
#5819 EnrichedLog net472 151μs 147ns 571ns 0.68 0.227 0 4.46 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.94μs 1.08ns 4.03ns 0.0309 0 0 2.2 KB
master EnrichedLog netcoreapp3.1 4.32μs 1.93ns 7.21ns 0.0282 0 0 2.2 KB
master EnrichedLog net472 4.81μs 1.66ns 6.43ns 0.319 0 0 2.02 KB
#5819 EnrichedLog net6.0 3.11μs 1.66ns 6.42ns 0.0312 0 0 2.2 KB
#5819 EnrichedLog netcoreapp3.1 3.99μs 1.38ns 5.36ns 0.0298 0 0 2.2 KB
#5819 EnrichedLog net472 4.72μs 1.1ns 4.27ns 0.319 0 0 2.02 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 1.35μs 1.06ns 4.12ns 0.0162 0 0 1.14 KB
master SendReceive netcoreapp3.1 1.8μs 0.727ns 2.82ns 0.0152 0 0 1.14 KB
master SendReceive net472 2.12μs 1.51ns 5.45ns 0.183 0.00105 0 1.16 KB
#5819 SendReceive net6.0 1.31μs 1.22ns 4.71ns 0.0162 0 0 1.14 KB
#5819 SendReceive netcoreapp3.1 1.8μs 0.365ns 1.42ns 0.0152 0 0 1.14 KB
#5819 SendReceive net472 2.1μs 1.44ns 5.56ns 0.183 0 0 1.16 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.64μs 0.703ns 2.63ns 0.0223 0 0 1.6 KB
master EnrichedLog netcoreapp3.1 3.93μs 3.1ns 12ns 0.0216 0 0 1.65 KB
master EnrichedLog net472 4.5μs 1.63ns 6.09ns 0.322 0 0 2.04 KB
#5819 EnrichedLog net6.0 2.9μs 1.16ns 4.2ns 0.0214 0 0 1.6 KB
#5819 EnrichedLog netcoreapp3.1 3.91μs 2.06ns 8ns 0.0216 0 0 1.65 KB
#5819 EnrichedLog net472 4.52μs 4.52ns 16.9ns 0.324 0 0 2.04 KB
Benchmarks.Trace.SpanBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #5819

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net6.0 1.127 547.54 485.88

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 416ns 0.132ns 0.51ns 0.00799 0 0 576 B
master StartFinishSpan netcoreapp3.1 572ns 0.666ns 2.58ns 0.00785 0 0 576 B
master StartFinishSpan net472 678ns 0.783ns 3.03ns 0.0917 0 0 578 B
master StartFinishScope net6.0 548ns 0.196ns 0.732ns 0.00961 0 0 696 B
master StartFinishScope netcoreapp3.1 722ns 0.397ns 1.54ns 0.00941 0 0 696 B
master StartFinishScope net472 879ns 0.372ns 1.44ns 0.104 0 0 658 B
#5819 StartFinishSpan net6.0 398ns 0.142ns 0.533ns 0.008 0 0 576 B
#5819 StartFinishSpan netcoreapp3.1 624ns 0.307ns 1.15ns 0.0075 0 0 576 B
#5819 StartFinishSpan net472 706ns 0.965ns 3.74ns 0.0918 0 0 578 B
#5819 StartFinishScope net6.0 486ns 0.241ns 0.933ns 0.00968 0 0 696 B
#5819 StartFinishScope netcoreapp3.1 717ns 0.423ns 1.64ns 0.00947 0 0 696 B
#5819 StartFinishScope net472 829ns 0.549ns 2.13ns 0.104 0 0 658 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 646ns 0.114ns 0.427ns 0.00978 0 0 696 B
master RunOnMethodBegin netcoreapp3.1 872ns 0.39ns 1.51ns 0.00958 0 0 696 B
master RunOnMethodBegin net472 1.14μs 0.534ns 2.07ns 0.104 0 0 658 B
#5819 RunOnMethodBegin net6.0 603ns 0.276ns 1.07ns 0.0099 0 0 696 B
#5819 RunOnMethodBegin netcoreapp3.1 950ns 0.546ns 2.04ns 0.00952 0 0 696 B
#5819 RunOnMethodBegin net472 1.11μs 0.242ns 0.938ns 0.104 0 0 658 B

andrewlock
andrewlock approved these changes Jul 29, 2024
View reviewed changes
Copy link
Member

@andrewlock andrewlock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, usual system test and throughput failures 🙄

@andrewlock andrewlock merged commit a675b5c into master Jul 31, 2024
56 of 59 checks passed
@andrewlock andrewlock deleted the bot/test-package-versions-bump branch July 31, 2024 12:34
@github-actions github-actions bot added this to the vNext-v3 milestone Jul 31, 2024
@andrewlock andrewlock added area:tests unit tests, integration tests area:test-apps apps used to test integrations area:dependabot dependabot updates labels Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewlock andrewlock andrewlock approved these changes

Assignees
No one assigned
Labels
area:dependabot dependabot updates area:test-apps apps used to test integrations area:tests unit tests, integration tests
Projects
None yet
Milestone
3.1.0-prerelease
Development

Successfully merging this pull request may close these issues.
1 participant
@andrewlock