Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Test Package Versions Bump] Updating package versions #5873

Merged
merged 1 commit into from
Sep 3, 2024
Merged

[Test Package Versions Bump] Updating package versions #5873

merged 1 commit into from
Sep 3, 2024

Conversation

github-actions[bot]
Copy link
Contributor

Updates the package versions for integration tests.

@github-actions github-actions bot requested review from a team as code owners August 11, 2024 00:24
@andrewlock
Copy link
Member

andrewlock commented Aug 11, 2024 •
edited
Loading

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

@datadog-ddstaging
Copy link

datadog-ddstaging bot commented Aug 11, 2024 •
edited
Loading

Datadog Report

Branch report: bot/test-package-versions-bump
Commit report: 7c89acd
Test service: dd-trace-dotnet

✅ 0 Failed, 365269 Passed, 2067 Skipped, 14h 27m 46.62s Total Time

@andrewlock
Copy link
Member

andrewlock commented Aug 11, 2024 •
edited
Loading

Benchmarks Report for tracer 🐌

Benchmarks for #5873 compared to master:

  • 3 benchmarks are slower, with geometric mean 1.143
  • All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 7.78μs 42.1ns 238ns 0.0151 0.00756 0 5.43 KB
master StartStopWithChild netcoreapp3.1 10μs 54.9ns 325ns 0.02 0.00998 0 5.62 KB
master StartStopWithChild net472 16.1μs 52.8ns 205ns 1.02 0.294 0.0953 6.06 KB
#5873 StartStopWithChild net6.0 7.8μs 40.5ns 262ns 0.0161 0.00805 0 5.42 KB
#5873 StartStopWithChild netcoreapp3.1 10.1μs 53.7ns 279ns 0.0195 0.00976 0 5.61 KB
#5873 StartStopWithChild net472 16.1μs 69.6ns 270ns 1.01 0.294 0.0954 6.07 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 477μs 280ns 1.05μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 624μs 254ns 985ns 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 838μs 357ns 1.34μs 0.417 0 0 3.3 KB
#5873 WriteAndFlushEnrichedTraces net6.0 470μs 248ns 928ns 0 0 0 2.7 KB
#5873 WriteAndFlushEnrichedTraces netcoreapp3.1 623μs 163ns 630ns 0 0 0 2.7 KB
#5873 WriteAndFlushEnrichedTraces net472 842μs 298ns 1.15μs 0.419 0 0 3.3 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 179μs 605ns 2.27μs 0.181 0 0 18.45 KB
master SendRequest netcoreapp3.1 202μs 859ns 3.22μs 0.204 0 0 20.61 KB
master SendRequest net472 0.000824ns 0.00043ns 0.00166ns 0 0 0 0 b
#5873 SendRequest net6.0 187μs 1.05μs 7.24μs 0.269 0 0 18.45 KB
#5873 SendRequest netcoreapp3.1 211μs 1.15μs 6.43μs 0.209 0 0 20.61 KB
#5873 SendRequest net472 0.00028ns 0.000216ns 0.000809ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 561μs 2.42μs 9.36μs 0.558 0 0 41.72 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 677μs 3.61μs 18.1μs 0.327 0 0 41.64 KB
master WriteAndFlushEnrichedTraces net472 912μs 3.43μs 12.8μs 8.33 2.31 0.463 53.33 KB
#5873 WriteAndFlushEnrichedTraces net6.0 568μs 2.31μs 8.93μs 0.556 0 0 41.68 KB
#5873 WriteAndFlushEnrichedTraces netcoreapp3.1 678μs 2.49μs 9.3μs 0.34 0 0 41.66 KB
#5873 WriteAndFlushEnrichedTraces net472 858μs 3.99μs 15.4μs 8.25 2.6 0.434 53.29 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.3μs 1.34ns 5.2ns 0.0142 0 0 1.02 KB
master ExecuteNonQuery netcoreapp3.1 1.82μs 4.15ns 15.5ns 0.0135 0 0 1.02 KB
master ExecuteNonQuery net472 2.01μs 1.71ns 6.38ns 0.156 0 0 987 B
#5873 ExecuteNonQuery net6.0 1.3μs 1.4ns 5.4ns 0.0143 0 0 1.02 KB
#5873 ExecuteNonQuery netcoreapp3.1 1.7μs 1.45ns 5.61ns 0.0134 0 0 1.02 KB
#5873 ExecuteNonQuery net472 2.03μs 1.06ns 3.95ns 0.157 0 0 987 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.18μs 1.24ns 4.63ns 0.0136 0 0 976 B
master CallElasticsearch netcoreapp3.1 1.53μs 0.925ns 3.46ns 0.0131 0 0 976 B
master CallElasticsearch net472 2.43μs 1.82ns 7.05ns 0.158 0 0 995 B
master CallElasticsearchAsync net6.0 1.38μs 1.21ns 4.7ns 0.0131 0 0 952 B
master CallElasticsearchAsync netcoreapp3.1 1.57μs 2.41ns 9.34ns 0.014 0 0 1.02 KB
master CallElasticsearchAsync net472 2.47μs 2.36ns 9.13ns 0.166 0 0 1.05 KB
#5873 CallElasticsearch net6.0 1.15μs 1.07ns 4.02ns 0.0135 0 0 976 B
#5873 CallElasticsearch netcoreapp3.1 1.53μs 0.689ns 2.58ns 0.0129 0 0 976 B
#5873 CallElasticsearch net472 2.4μs 0.721ns 2.6ns 0.158 0 0 995 B
#5873 CallElasticsearchAsync net6.0 1.35μs 1.51ns 5.66ns 0.0133 0 0 952 B
#5873 CallElasticsearchAsync netcoreapp3.1 1.55μs 1.42ns 5.1ns 0.0133 0 0 1.02 KB
#5873 CallElasticsearchAsync net472 2.57μs 1.78ns 6.65ns 0.167 0 0 1.05 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.3μs 1.6ns 5.98ns 0.0131 0 0 952 B
master ExecuteAsync netcoreapp3.1 1.65μs 0.604ns 2.34ns 0.0126 0 0 952 B
master ExecuteAsync net472 1.71μs 0.933ns 3.61ns 0.145 0 0 915 B
#5873 ExecuteAsync net6.0 1.2μs 0.381ns 1.42ns 0.0133 0 0 952 B
#5873 ExecuteAsync netcoreapp3.1 1.71μs 0.473ns 1.77ns 0.0128 0 0 952 B
#5873 ExecuteAsync net472 1.74μs 0.668ns 2.5ns 0.145 0 0 915 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 4.19μs 1.2ns 4.49ns 0.0315 0 0 2.22 KB
master SendAsync netcoreapp3.1 5.05μs 1.54ns 5.97ns 0.0379 0 0 2.76 KB
master SendAsync net472 7.69μs 2.46ns 9.19ns 0.497 0 0 3.15 KB
#5873 SendAsync net6.0 4.25μs 1.5ns 5.8ns 0.0319 0 0 2.22 KB
#5873 SendAsync netcoreapp3.1 5.08μs 1.52ns 5.9ns 0.0382 0 0 2.76 KB
#5873 SendAsync net472 7.85μs 3.83ns 14.3ns 0.497 0 0 3.15 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 1.57μs 0.79ns 2.85ns 0.0227 0 0 1.64 KB
master EnrichedLog netcoreapp3.1 2.33μs 1.26ns 4.71ns 0.0222 0 0 1.64 KB
master EnrichedLog net472 2.75μs 1.71ns 6.41ns 0.249 0 0 1.57 KB
#5873 EnrichedLog net6.0 1.44μs 1.14ns 4.27ns 0.0232 0 0 1.64 KB
#5873 EnrichedLog netcoreapp3.1 2.2μs 1.16ns 4.5ns 0.0219 0 0 1.64 KB
#5873 EnrichedLog net472 2.63μs 1.82ns 7.06ns 0.249 0 0 1.57 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 117μs 205ns 795ns 0 0 0 4.28 KB
master EnrichedLog netcoreapp3.1 121μs 204ns 791ns 0 0 0 4.28 KB
master EnrichedLog net472 149μs 254ns 982ns 0.668 0.223 0 4.46 KB
#5873 EnrichedLog net6.0 117μs 121ns 470ns 0.0582 0 0 4.28 KB
#5873 EnrichedLog netcoreapp3.1 121μs 127ns 492ns 0 0 0 4.28 KB
#5873 EnrichedLog net472 151μs 187ns 725ns 0.674 0.225 0 4.46 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 3.04μs 1.12ns 4.34ns 0.0303 0 0 2.2 KB
master EnrichedLog netcoreapp3.1 4.13μs 1.09ns 4.07ns 0.029 0 0 2.2 KB
master EnrichedLog net472 4.85μs 1.05ns 3.77ns 0.32 0 0 2.02 KB
#5873 EnrichedLog net6.0 3.04μs 2.61ns 10.1ns 0.0304 0 0 2.2 KB
#5873 EnrichedLog netcoreapp3.1 4.34μs 0.972ns 3.51ns 0.0282 0 0 2.2 KB
#5873 EnrichedLog net472 4.85μs 1.39ns 5.18ns 0.319 0 0 2.02 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 1.29μs 1.5ns 5.83ns 0.0162 0 0 1.14 KB
master SendReceive netcoreapp3.1 1.75μs 1.88ns 7.27ns 0.0148 0 0 1.14 KB
master SendReceive net472 2.22μs 1.2ns 4.47ns 0.183 0 0 1.16 KB
#5873 SendReceive net6.0 1.4μs 0.713ns 2.67ns 0.0162 0 0 1.14 KB
#5873 SendReceive netcoreapp3.1 1.8μs 1.27ns 4.93ns 0.0153 0 0 1.14 KB
#5873 SendReceive net472 2.19μs 2.18ns 8.46ns 0.183 0.0011 0 1.16 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.67μs 0.989ns 3.83ns 0.0225 0 0 1.6 KB
master EnrichedLog netcoreapp3.1 3.93μs 10.3ns 39.9ns 0.0212 0 0 1.65 KB
master EnrichedLog net472 4.33μs 2.37ns 8.54ns 0.322 0 0 2.04 KB
#5873 EnrichedLog net6.0 2.75μs 1.92ns 7.42ns 0.0221 0 0 1.6 KB
#5873 EnrichedLog netcoreapp3.1 3.97μs 2.22ns 8.61ns 0.0218 0 0 1.65 KB
#5873 EnrichedLog net472 4.47μs 2.2ns 8.53ns 0.323 0 0 2.04 KB
Benchmarks.Trace.SpanBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #5873

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net6.0 1.177 472.13 555.63
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net472 1.121 603.79 676.64

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 402ns 1.21ns 4.7ns 0.00805 0 0 576 B
master StartFinishSpan netcoreapp3.1 580ns 0.314ns 1.22ns 0.00785 0 0 576 B
master StartFinishSpan net472 604ns 0.71ns 2.75ns 0.0917 0 0 578 B
master StartFinishScope net6.0 473ns 0.453ns 1.75ns 0.00978 0 0 696 B
master StartFinishScope netcoreapp3.1 680ns 0.347ns 1.34ns 0.00955 0 0 696 B
master StartFinishScope net472 822ns 1.58ns 6.13ns 0.105 0 0 658 B
#5873 StartFinishSpan net6.0 394ns 0.295ns 1.14ns 0.00817 0 0 576 B
#5873 StartFinishSpan netcoreapp3.1 552ns 0.414ns 1.55ns 0.00776 0 0 576 B
#5873 StartFinishSpan net472 677ns 0.545ns 2.04ns 0.0915 0 0 578 B
#5873 StartFinishScope net6.0 556ns 0.68ns 2.35ns 0.0097 0 0 696 B
#5873 StartFinishScope netcoreapp3.1 688ns 0.469ns 1.82ns 0.0096 0 0 696 B
#5873 StartFinishScope net472 885ns 0.908ns 3.52ns 0.104 0 0 658 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #5873

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net6.0 1.133 583.81 661.20

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 584ns 0.507ns 1.96ns 0.0099 0 0 696 B
master RunOnMethodBegin netcoreapp3.1 954ns 0.881ns 3.41ns 0.00953 0 0 696 B
master RunOnMethodBegin net472 1.14μs 0.817ns 3.17ns 0.104 0 0 658 B
#5873 RunOnMethodBegin net6.0 661ns 0.762ns 2.95ns 0.0098 0 0 696 B
#5873 RunOnMethodBegin netcoreapp3.1 919ns 0.995ns 3.85ns 0.00927 0 0 696 B
#5873 RunOnMethodBegin net472 1.03μs 1.42ns 5.49ns 0.104 0 0 658 B

@github-actions github-actions bot force-pushed the bot/test-package-versions-bump branch from 24be8f1 to 67269f4 Compare August 18, 2024 00:22
andrewlock
andrewlock approved these changes Aug 19, 2024
View reviewed changes
Copy link
Member

@andrewlock andrewlock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot force-pushed the bot/test-package-versions-bump branch from 67269f4 to 4f3bab7 Compare August 25, 2024 00:22
@github-actions github-actions bot force-pushed the bot/test-package-versions-bump branch from 4f3bab7 to 7c89acd Compare September 1, 2024 00:25
@andrewlock andrewlock merged commit 3631a25 into master Sep 3, 2024
58 of 60 checks passed
@andrewlock andrewlock deleted the bot/test-package-versions-bump branch September 3, 2024 12:05
@github-actions github-actions bot added this to the vNext-v3 milestone Sep 3, 2024
@andrewlock andrewlock added the area:builds project files, build scripts, pipelines, versioning, releases, packages label Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewlock andrewlock andrewlock approved these changes

Assignees
No one assigned
Labels
area:builds project files, build scripts, pipelines, versioning, releases, packages
Projects
None yet
Milestone
3.3.0
Development

Successfully merging this pull request may close these issues.
1 participant
@andrewlock