Try fix smoke tests #5889

andrewlock · 2024-08-13T12:27:52Z

Summary of changes

Install v1 docker-compose in the hosted runners used for Windows smoke tests
Cleanup the docker networks in the smoke tests

Reason for change

Microsoft recently stopped shipping the v1 of docker compose. That broke all our Windows smoke tests. Unfortunately, for various other reasons, we couldn't just convert to the v2 format, due to how we're reusing various bits and pieces.

Additionally, we started getting this on our linux smoke tests:

Creating network "ddtrace_20240812_56_default" with the default driver
could not find an available, non-overlapping IPv4 address pool among the defaults to assign to the network

This is basically because we're creating networks, and never cleaning them up, and for efficiency reasons we're not destroying the smoke test VMs after each run.

Implementation details

Install Docker-compose v1 in the Windows VMs. A bit hacky, but the quickest solution right now
Clean up the docker network after running the snapshot tests

Test coverage

I did some manual tests to make sure this all works as expected. Also killed and restored the smoke tests machines which solved the docker network problem temporarily.

Other details

This is obviously still all kinda horrible. I'd love to replace all this yaml with just testcontainers. One day.... stares wistfully into the distance

robertpi

Nice work, thanks!

datadog-ddstaging · 2024-08-13T12:57:01Z

Datadog Report

Branch report: andrew/ci/try-fix-windows-smoke-tests
Commit report: 8600077
Test service: dd-trace-dotnet

✅ 0 Failed, 346811 Passed, 1776 Skipped, 14h 56m 19.21s Total Time

andrewlock · 2024-08-13T13:19:24Z

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

Welch test with statistical test for significance of 5%
Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5889) - mean (74ms)  : 66, 82
     .   : milestone, 74,
    master - mean (73ms)  : 63, 84
     .   : milestone, 73,

    section CallTarget+Inlining+NGEN
    This PR (5889) - mean (1,075ms)  : 1051, 1099
     .   : milestone, 1075,
    master - mean (1,068ms)  : 1047, 1088
     .   : milestone, 1068,

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5889) - mean (111ms)  : 106, 115
     .   : milestone, 111,
    master - mean (109ms)  : 105, 114
     .   : milestone, 109,

    section CallTarget+Inlining+NGEN
    This PR (5889) - mean (754ms)  : 733, 775
     .   : milestone, 754,
    master - mean (748ms)  : 725, 771
     .   : milestone, 748,

gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5889) - mean (94ms)  : 89, 98
     .   : milestone, 94,
    master - mean (92ms)  : 90, 95
     .   : milestone, 92,

    section CallTarget+Inlining+NGEN
    This PR (5889) - mean (710ms)  : 691, 729
     .   : milestone, 710,
    master - mean (702ms)  : 685, 719
     .   : milestone, 702,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5889) - mean (193ms)  : 189, 196
     .   : milestone, 193,
    master - mean (193ms)  : 188, 198
     .   : milestone, 193,

    section CallTarget+Inlining+NGEN
    This PR (5889) - mean (1,176ms)  : 1150, 1202
     .   : milestone, 1176,
    master - mean (1,169ms)  : 1137, 1200
     .   : milestone, 1169,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5889) - mean (276ms)  : 272, 280
     .   : milestone, 276,
    master - mean (276ms)  : 272, 281
     .   : milestone, 276,

    section CallTarget+Inlining+NGEN
    This PR (5889) - mean (921ms)  : 892, 951
     .   : milestone, 921,
    master - mean (918ms)  : 897, 939
     .   : milestone, 918,

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5889) - mean (265ms)  : 260, 269
     .   : milestone, 265,
    master - mean (266ms)  : 262, 270
     .   : milestone, 266,

    section CallTarget+Inlining+NGEN
    This PR (5889) - mean (907ms)  : 878, 935
     .   : milestone, 907,
    master - mean (903ms)  : 884, 921
     .   : milestone, 903,

andrewlock · 2024-08-13T14:06:49Z

Benchmarks Report for tracer 🐌

Benchmarks for #5889 compared to master:

1 benchmarks are faster, with geometric mean 1.146
1 benchmarks are slower, with geometric mean 1.125
1 benchmarks have fewer allocations

The following thresholds were used for comparing the benchmark speeds:

Mann–Whitney U test with statistical test for significance of 5%
Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`StartStopWithChild`	net6.0	7.78μs	41.8ns	304ns	0.015	0.0075	0	5.43 KB
master	`StartStopWithChild`	netcoreapp3.1	9.96μs	53.9ns	310ns	0.0192	0.00962	0	5.62 KB
master	`StartStopWithChild`	net472	15.9μs	45ns	168ns	1.02	0.293	0.1	6.06 KB
#5889	`StartStopWithChild`	net6.0	7.73μs	42.7ns	273ns	0.0201	0.00804	0	5.43 KB
#5889	`StartStopWithChild`	netcoreapp3.1	9.95μs	56ns	372ns	0.0239	0.00955	0	5.62 KB
#5889	`StartStopWithChild`	net472	16.2μs	50.9ns	190ns	0.998	0.286	0.0818	6.07 KB

Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	441μs	379ns	1.47μs	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	625μs	463ns	1.79μs	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	net472	851μs	337ns	1.22μs	0.425	3.3 KB
#5889	`WriteAndFlushEnrichedTraces`	net6.0	478μs	163ns	630ns	0	2.7 KB
#5889	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	653μs	573ns	2.22μs	0	2.7 KB
#5889	`WriteAndFlushEnrichedTraces`	net472	845μs	575ns	2.23μs	0.422	3.3 KB

Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendRequest`	net6.0	197μs	1.15μs	10μs	0.194	18.45 KB
master	`SendRequest`	netcoreapp3.1	221μs	1.24μs	7.93μs	0.208	20.61 KB
master	`SendRequest`	net472	0ns	0ns	0ns	0	0 b
#5889	`SendRequest`	net6.0	195μs	1.11μs	7.59μs	0.188	18.45 KB
#5889	`SendRequest`	netcoreapp3.1	219μs	1.21μs	8.64μs	0.231	20.61 KB
#5889	`SendRequest`	net472	0.00142ns	0.000743ns	0.00288ns	0	0 b

Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #5889

Benchmark	Base Allocated	Diff Allocated	Change	Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑netcoreapp3.1	41.93 KB	41.63 KB	-300 B	-0.72%

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	582μs	2.94μs	13.8μs	0.573	0	0	41.52 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	683μs	3.75μs	22.2μs	0.324	0	0	41.93 KB
master	`WriteAndFlushEnrichedTraces`	net472	853μs	4.08μs	16.8μs	8.33	2.5	0.417	53.28 KB
#5889	`WriteAndFlushEnrichedTraces`	net6.0	562μs	2.91μs	19.3μs	0.556	0	0	41.55 KB
#5889	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	730μs	3.71μs	17μs	0.359	0	0	41.63 KB
#5889	`WriteAndFlushEnrichedTraces`	net472	867μs	4.55μs	23.2μs	8.42	2.66	0.443	53.26 KB

Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`ExecuteNonQuery`	net6.0	1.25μs	1.32ns	4.94ns	0.0143	1.02 KB
master	`ExecuteNonQuery`	netcoreapp3.1	1.76μs	2.79ns	10.8ns	0.0131	1.02 KB
master	`ExecuteNonQuery`	net472	2.01μs	1.23ns	4.28ns	0.156	987 B
#5889	`ExecuteNonQuery`	net6.0	1.35μs	1.4ns	5.44ns	0.0141	1.02 KB
#5889	`ExecuteNonQuery`	netcoreapp3.1	1.76μs	2.13ns	8.26ns	0.0132	1.02 KB
#5889	`ExecuteNonQuery`	net472	1.97μs	3.05ns	11.4ns	0.156	987 B

Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`CallElasticsearch`	net6.0	1.14μs	0.551ns	2.06ns	0.0137	976 B
master	`CallElasticsearch`	netcoreapp3.1	1.51μs	1.46ns	5.27ns	0.0129	976 B
master	`CallElasticsearch`	net472	2.47μs	2.52ns	9.75ns	0.158	995 B
master	`CallElasticsearchAsync`	net6.0	1.24μs	0.384ns	1.44ns	0.0137	952 B
master	`CallElasticsearchAsync`	netcoreapp3.1	1.64μs	1.24ns	4.64ns	0.014	1.02 KB
master	`CallElasticsearchAsync`	net472	2.69μs	1.66ns	6.42ns	0.167	1.05 KB
#5889	`CallElasticsearch`	net6.0	1.25μs	0.862ns	3.34ns	0.0138	976 B
#5889	`CallElasticsearch`	netcoreapp3.1	1.56μs	0.726ns	2.72ns	0.0132	976 B
#5889	`CallElasticsearch`	net472	2.47μs	1.27ns	4.93ns	0.157	995 B
#5889	`CallElasticsearchAsync`	net6.0	1.29μs	0.888ns	3.32ns	0.013	952 B
#5889	`CallElasticsearchAsync`	netcoreapp3.1	1.67μs	0.85ns	3.18ns	0.0142	1.02 KB
#5889	`CallElasticsearchAsync`	net472	2.69μs	1.27ns	4.94ns	0.167	1.05 KB

Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`ExecuteAsync`	net6.0	1.24μs	1.12ns	4.33ns	0.0136	952 B
master	`ExecuteAsync`	netcoreapp3.1	1.56μs	0.597ns	2.31ns	0.0125	952 B
master	`ExecuteAsync`	net472	1.77μs	0.499ns	1.87ns	0.145	915 B
#5889	`ExecuteAsync`	net6.0	1.26μs	0.599ns	2.24ns	0.0133	952 B
#5889	`ExecuteAsync`	netcoreapp3.1	1.67μs	0.7ns	2.62ns	0.0125	952 B
#5889	`ExecuteAsync`	net472	1.71μs	0.698ns	2.7ns	0.145	915 B

Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendAsync`	net6.0	4.17μs	1.97ns	7.65ns	0.0314	2.22 KB
master	`SendAsync`	netcoreapp3.1	5.11μs	1.45ns	5.44ns	0.0359	2.76 KB
master	`SendAsync`	net472	7.86μs	8.74ns	33.8ns	0.497	3.15 KB
#5889	`SendAsync`	net6.0	4.21μs	2.37ns	8.87ns	0.0311	2.22 KB
#5889	`SendAsync`	netcoreapp3.1	5.04μs	0.954ns	3.44ns	0.0353	2.76 KB
#5889	`SendAsync`	net472	7.79μs	1.92ns	7.42ns	0.499	3.15 KB

Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	1.48μs	1.11ns	4.3ns	0.0226	1.64 KB
master	`EnrichedLog`	netcoreapp3.1	2.34μs	1.33ns	4.97ns	0.0223	1.64 KB
master	`EnrichedLog`	net472	2.74μs	0.723ns	2.71ns	0.249	1.57 KB
#5889	`EnrichedLog`	net6.0	1.57μs	1.11ns	4.15ns	0.0235	1.64 KB
#5889	`EnrichedLog`	netcoreapp3.1	2.32μs	1.34ns	5.2ns	0.0221	1.64 KB
#5889	`EnrichedLog`	net472	2.61μs	8.89ns	34.4ns	0.249	1.57 KB

Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`EnrichedLog`	net6.0	117μs	235ns	912ns	0.0581	0	4.28 KB
master	`EnrichedLog`	netcoreapp3.1	120μs	173ns	669ns	0	0	4.28 KB
master	`EnrichedLog`	net472	150μs	126ns	471ns	0.678	0.226	4.46 KB
#5889	`EnrichedLog`	net6.0	118μs	193ns	746ns	0.0589	0	4.28 KB
#5889	`EnrichedLog`	netcoreapp3.1	122μs	300ns	1.16μs	0.0601	0	4.28 KB
#5889	`EnrichedLog`	net472	150μs	408ns	1.58μs	0.678	0.226	4.46 KB

Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	3.04μs	1.88ns	7.29ns	0.0304	2.2 KB
master	`EnrichedLog`	netcoreapp3.1	4.12μs	1.73ns	6.68ns	0.0296	2.2 KB
master	`EnrichedLog`	net472	4.98μs	1.46ns	5.66ns	0.32	2.02 KB
#5889	`EnrichedLog`	net6.0	2.99μs	0.826ns	3.09ns	0.0313	2.2 KB
#5889	`EnrichedLog`	netcoreapp3.1	4.21μs	1.13ns	4.37ns	0.03	2.2 KB
#5889	`EnrichedLog`	net472	4.73μs	0.949ns	3.55ns	0.319	2.02 KB

Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`SendReceive`	net6.0	1.35μs	0.629ns	2.44ns	0.0161	0	1.14 KB
master	`SendReceive`	netcoreapp3.1	1.81μs	1.65ns	6.38ns	0.0154	0	1.14 KB
master	`SendReceive`	net472	2.18μs	1.14ns	4.4ns	0.183	0.00109	1.16 KB
#5889	`SendReceive`	net6.0	1.36μs	0.331ns	1.24ns	0.0163	0	1.14 KB
#5889	`SendReceive`	netcoreapp3.1	1.74μs	0.894ns	3.46ns	0.0157	0	1.14 KB
#5889	`SendReceive`	net472	2.13μs	1.52ns	5.88ns	0.183	0.00106	1.16 KB

Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	2.87μs	0.871ns	3.26ns	0.0215	1.6 KB
master	`EnrichedLog`	netcoreapp3.1	3.83μs	3.39ns	13.1ns	0.0229	1.65 KB
master	`EnrichedLog`	net472	4.42μs	1.99ns	7.44ns	0.323	2.04 KB
#5889	`EnrichedLog`	net6.0	2.75μs	1.61ns	6.02ns	0.0221	1.6 KB
#5889	`EnrichedLog`	netcoreapp3.1	3.87μs	1.13ns	4.39ns	0.0211	1.65 KB
#5889	`EnrichedLog`	net472	4.42μs	3.78ns	13.6ns	0.324	2.04 KB

Benchmarks.Trace.SpanBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #5889

Benchmark	diff/base	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net6.0	1.125	408.68	459.96

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`StartFinishSpan`	net6.0	409ns	0.145ns	0.561ns	0.00811	576 B
master	`StartFinishSpan`	netcoreapp3.1	589ns	0.232ns	0.867ns	0.00767	576 B
master	`StartFinishSpan`	net472	627ns	0.305ns	1.18ns	0.0915	578 B
master	`StartFinishScope`	net6.0	472ns	0.106ns	0.411ns	0.0099	696 B
master	`StartFinishScope`	netcoreapp3.1	740ns	0.351ns	1.36ns	0.00934	696 B
master	`StartFinishScope`	net472	862ns	0.449ns	1.74ns	0.104	658 B
#5889	`StartFinishSpan`	net6.0	460ns	0.204ns	0.764ns	0.00811	576 B
#5889	`StartFinishSpan`	netcoreapp3.1	569ns	0.312ns	1.17ns	0.00782	576 B
#5889	`StartFinishSpan`	net472	639ns	0.954ns	3.69ns	0.0917	578 B
#5889	`StartFinishScope`	net6.0	485ns	0.253ns	0.982ns	0.00975	696 B
#5889	`StartFinishScope`	netcoreapp3.1	679ns	0.301ns	1.17ns	0.00916	696 B
#5889	`StartFinishScope`	net472	836ns	0.551ns	2.06ns	0.104	658 B

Benchmarks.Trace.TraceAnnotationsBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #5889

Benchmark	base/diff	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net6.0	1.146	672.83	587.00

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`RunOnMethodBegin`	net6.0	673ns	0.338ns	1.31ns	0.00975	696 B
master	`RunOnMethodBegin`	netcoreapp3.1	911ns	0.42ns	1.63ns	0.00915	696 B
master	`RunOnMethodBegin`	net472	1.09μs	0.277ns	1.04ns	0.104	658 B
#5889	`RunOnMethodBegin`	net6.0	587ns	0.215ns	0.834ns	0.00976	696 B
#5889	`RunOnMethodBegin`	netcoreapp3.1	976ns	0.249ns	0.931ns	0.00953	696 B
#5889	`RunOnMethodBegin`	net472	1.16μs	0.2ns	0.749ns	0.105	658 B

bouwkast

Thanks!

## Summary of changes - Install v1 docker-compose in the hosted runners used for Windows smoke tests - Cleanup the docker networks in the smoke tests ## Reason for change Microsoft [recently](https://learn.microsoft.com/en-us/azure/devops/release-notes/2024/pipelines/sprint-240-update#dockercompose0-uses-docker-compose-v2-in-v1-compatibility-mode) stopped shipping the v1 of docker compose. That broke all our Windows smoke tests. Unfortunately, for various other reasons, we couldn't just convert to the v2 format, due to how we're reusing various bits and pieces. Additionally, we started getting this on our linux smoke tests: ``` Creating network "ddtrace_20240812_56_default" with the default driver could not find an available, non-overlapping IPv4 address pool among the defaults to assign to the network ``` This is basically because we're creating networks, and never cleaning them up, and for efficiency reasons we're not destroying the smoke test VMs after each run. ## Implementation details - Install Docker-compose v1 in the Windows VMs. A bit hacky, but the quickest solution right now - Clean up the docker network after running the snapshot tests ## Test coverage I did some manual tests to make sure this all works as expected. Also killed and restored the smoke tests machines which solved the docker network problem temporarily. ## Other details This is obviously still all kinda horrible. I'd love to replace all this yaml with just testcontainers. One day.... _stares wistfully into the distance_

## Summary of changes - Install v1 docker-compose in the hosted runners used for Windows smoke tests - Cleanup the docker networks in the smoke tests ## Reason for change Microsoft [recently](https://learn.microsoft.com/en-us/azure/devops/release-notes/2024/pipelines/sprint-240-update#dockercompose0-uses-docker-compose-v2-in-v1-compatibility-mode) stopped shipping the v1 of docker compose. That broke all our Windows smoke tests. Unfortunately, for various other reasons, we couldn't just convert to the v2 format, due to how we're reusing various bits and pieces. Additionally, we started getting this on our linux smoke tests: ``` Creating network "ddtrace_20240812_56_default" with the default driver could not find an available, non-overlapping IPv4 address pool among the defaults to assign to the network ``` This is basically because we're creating networks, and never cleaning them up, and for efficiency reasons we're not destroying the smoke test VMs after each run. ## Implementation details - Install Docker-compose v1 in the Windows VMs. A bit hacky, but the quickest solution right now - Clean up the docker network after running the snapshot tests ## Test coverage I did some manual tests to make sure this all works as expected. Also killed and restored the smoke tests machines which solved the docker network problem temporarily. ## Other details This is obviously still all kinda horrible. I'd love to replace all this yaml with just testcontainers. One day.... _stares wistfully into the distance_ Backport of #5889

andrewlock added 5 commits August 13, 2024 13:01

See if we can use an existing scale set

270bd6c

Try something else

69bfa20

grmbl grmbl

710e4db

Try fix remaining snapshot tests

bd037b3

Clean up unused networks in snapshot tests

8600077

andrewlock added the area:builds project files, build scripts, pipelines, versioning, releases, packages label Aug 13, 2024

andrewlock requested a review from a team as a code owner August 13, 2024 12:27

robertpi approved these changes Aug 13, 2024

View reviewed changes

bouwkast approved these changes Aug 13, 2024

View reviewed changes

robertpi mentioned this pull request Aug 13, 2024

migrate docker-compose to docker compose #5876

Closed

andrewlock merged commit 8318f76 into master Aug 13, 2024
56 of 60 checks passed

andrewlock deleted the andrew/ci/try-fix-windows-smoke-tests branch August 13, 2024 17:32

github-actions bot added this to the vNext-v3 milestone Aug 13, 2024

andrewlock mentioned this pull request Aug 13, 2024

Try fix smoke tests (#5889 -> v2) #5891

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Try fix smoke tests #5889

Try fix smoke tests #5889

andrewlock commented Aug 13, 2024

robertpi left a comment

datadog-ddstaging bot commented Aug 13, 2024 •

edited

Loading

andrewlock commented Aug 13, 2024

andrewlock commented Aug 13, 2024

Raw results

Raw results

Raw results

Fewer allocations 🎉 in #5889

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Slower ⚠️ in #5889

Raw results

Faster 🎉 in #5889

Raw results

bouwkast left a comment

Try fix smoke tests #5889

Try fix smoke tests #5889

Conversation

andrewlock commented Aug 13, 2024

Summary of changes

Reason for change

Implementation details

Test coverage

Other details

robertpi left a comment

Choose a reason for hiding this comment

datadog-ddstaging bot commented Aug 13, 2024 • edited Loading

Datadog Report

andrewlock commented Aug 13, 2024

Execution-Time Benchmarks Report ⏱️

andrewlock commented Aug 13, 2024

Benchmarks Report for tracer 🐌

Benchmark details

Raw results

Raw results

Raw results

Fewer allocations 🎉 in #5889

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Slower ⚠️ in #5889

Raw results

Faster 🎉 in #5889

Raw results

bouwkast left a comment

Choose a reason for hiding this comment

datadog-ddstaging bot commented Aug 13, 2024 •

edited

Loading