New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dynamic Instrumentation] DEBUG-2249 Line and method probes exploration tests #5914

Merged

dudikeleti merged 32 commits into master from dudik/explorationtest-linprobes

Sep 17, 2024

Contributor

dudikeleti commented Aug 16, 2024

Summary of changes

This PR add line porbe exploration tests.

Reason for change

To verify that we aren't breaking any code with our instrumentation.

Implementation details

We instrument each method with a method probe and each method line with a line probe.

Test coverage

Several open source projects (e.g. protobuf.net).

dudikeleti requested review from a team as code owners

August 16, 2024 15:13

github-actions bot added the area:debugger label

datadog-ddstaging bot commented Aug 16, 2024 •

edited

Loading

Datadog Report

Branch report: dudik/explorationtest-linprobes
Commit report: a9929c1
Test service: dd-trace-dotnet

❌ 32 Failed (0 Known Flaky), 372319 Passed, 2715 Skipped, 25h 59m 47.68s Total Time

❌ Failed Tests (32)

This report shows up to 5 failed tests.

MethodProbeTest - Datadog.Trace.Debugger.IntegrationTests.ProbesTests - Details

Expand for error

 Results do not match.
 Pending verification:
 ProbeTests.TryFinallyMethodAndLine.verified.txt: Empty or does not exist
 ProbeTests.TryFinallyMethodAndLine.received.txt
 [
   {
     "ddsource": "dd_debugger",
     "debugger": {
       "diagnostics": {
         "exception": null,
 ...

MethodProbeTest - Datadog.Trace.Debugger.IntegrationTests.ProbesTests - Details

Expand for error

 Results do not match.
 Pending verification:
 ProbeTests.TryFinallyMethodAndLine.verified.txt: Empty or does not exist
 ProbeTests.TryFinallyMethodAndLine.received.txt
 [
   {
     "ddsource": "dd_debugger",
     "debugger": {
       "diagnostics": {
         "exception": null,
 ...

MethodProbeTest - Datadog.Trace.Debugger.IntegrationTests.ProbesTests - Details

Expand for error

 Results do not match.
 Pending verification:
 ProbeTests.TryFinallyMethodAndLine.verified.txt: Empty or does not exist
 ProbeTests.TryFinallyMethodAndLine.received.txt
 [
   {
     "ddsource": "dd_debugger",
     "debugger": {
       "diagnostics": {
         "exception": null,
 ...

MethodProbeTest - Datadog.Trace.Debugger.IntegrationTests.ProbesTests - Details

Expand for error

 Results do not match.
 Pending verification:
 ProbeTests.TryFinallyMethodAndLine.verified.txt: Empty or does not exist
 ProbeTests.TryFinallyMethodAndLine.received.txt
 [
   {
     "ddsource": "dd_debugger",
     "debugger": {
       "diagnostics": {
         "exception": null,
 ...

MethodProbeTest - Datadog.Trace.Debugger.IntegrationTests.ProbesTests - Details

Expand for error

 Results do not match.
 Pending verification:
 ProbeTests.TryFinallyMethodAndLine.verified.txt: Empty or does not exist
 ProbeTests.TryFinallyMethodAndLine.received.txt
 [
   {
     "ddsource": "dd_debugger",
     "debugger": {
       "diagnostics": {
         "exception": null,
 ...

Member

andrewlock commented Aug 16, 2024 •

edited

Loading

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

Welch test with statistical test for significance of 5%
Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5914) - mean (70ms)  : 68, 73
     .   : milestone, 70,
    master - mean (69ms)  : 66, 73
     .   : milestone, 69,

    section CallTarget+Inlining+NGEN
    This PR (5914) - mean (1,125ms)  : 1103, 1148
     .   : milestone, 1125,
    master - mean (1,118ms)  : 1092, 1145
     .   : milestone, 1118,

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5914) - mean (109ms)  : 107, 112
     .   : milestone, 109,
    master - mean (109ms)  : 105, 113
     .   : milestone, 109,

    section CallTarget+Inlining+NGEN
    This PR (5914) - mean (813ms)  : 794, 832
     .   : milestone, 813,
    master - mean (809ms)  : 787, 831
     .   : milestone, 809,

gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5914) - mean (93ms)  : 90, 97
     .   : milestone, 93,
    master - mean (93ms)  : 89, 96
     .   : milestone, 93,

    section CallTarget+Inlining+NGEN
    This PR (5914) - mean (767ms)  : 751, 784
     .   : milestone, 767,
    master - mean (763ms)  : 747, 779
     .   : milestone, 763,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5914) - mean (191ms)  : 187, 196
     .   : milestone, 191,
    master - mean (191ms)  : 188, 194
     .   : milestone, 191,

    section CallTarget+Inlining+NGEN
    This PR (5914) - mean (1,199ms)  : 1175, 1223
     .   : milestone, 1199,
    master - mean (1,194ms)  : 1167, 1220
     .   : milestone, 1194,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5914) - mean (276ms)  : 273, 280
     .   : milestone, 276,
    master - mean (276ms)  : 272, 280
     .   : milestone, 276,

    section CallTarget+Inlining+NGEN
    This PR (5914) - mean (968ms)  : 945, 992
     .   : milestone, 968,
    master - mean (964ms)  : 941, 986
     .   : milestone, 964,

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5914) - mean (265ms)  : 262, 269
     .   : milestone, 265,
    master - mean (265ms)  : 261, 270
     .   : milestone, 265,

    section CallTarget+Inlining+NGEN
    This PR (5914) - mean (947ms)  : 928, 967
     .   : milestone, 947,
    master - mean (949ms)  : 924, 974
     .   : milestone, 949,

Member

andrewlock commented Aug 16, 2024 •

edited

Loading

Benchmarks Report for tracer 🐌

Benchmarks for #5914 compared to master:

All benchmarks have the same speed
All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

Mann–Whitney U test with statistical test for significance of 5%
Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`StartStopWithChild`	net6.0	7.78μs	44.5ns	324ns	0.0112	0.00374	0	5.43 KB
master	`StartStopWithChild`	netcoreapp3.1	9.85μs	43.4ns	157ns	0.0143	0.00476	0	5.62 KB
master	`StartStopWithChild`	net472	16.1μs	33ns	123ns	1.03	0.313	0.102	6.06 KB
#5914	`StartStopWithChild`	net6.0	7.86μs	44.8ns	313ns	0.0155	0.00777	0	5.43 KB
#5914	`StartStopWithChild`	netcoreapp3.1	10.1μs	55.9ns	349ns	0.0204	0.0102	0	5.62 KB
#5914	`StartStopWithChild`	net472	16μs	55.5ns	215ns	1.01	0.287	0.0797	6.07 KB

Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	481μs	158ns	549ns	0	0	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	625μs	304ns	1.18μs	0	0	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	net472	844μs	342ns	1.33μs	0.419	0	0	3.3 KB
#5914	`WriteAndFlushEnrichedTraces`	net6.0	466μs	264ns	989ns	0	0	0	2.7 KB
#5914	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	643μs	224ns	837ns	0	0	0	2.7 KB
#5914	`WriteAndFlushEnrichedTraces`	net472	828μs	883ns	3.3μs	0.408	0	0	3.3 KB

Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`SendRequest`	net6.0	203μs	1.17μs	9.62μs	0.197	0	0	18.45 KB
master	`SendRequest`	netcoreapp3.1	225μs	1.29μs	9.79μs	0.216	0	0	20.61 KB
master	`SendRequest`	net472	0.00235ns	0.000752ns	0.00291ns	0	0	0	0 b
#5914	`SendRequest`	net6.0	204μs	1.27μs	12.4μs	0.159	0	0	18.45 KB
#5914	`SendRequest`	netcoreapp3.1	220μs	1.24μs	8.23μs	0.217	0	0	20.61 KB
#5914	`SendRequest`	net472	0ns	0ns	0ns	0	0	0	0 b

Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	562μs	2.9μs	16.2μs	0.558	0	0	41.65 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	697μs	3.34μs	13.8μs	0.326	0	0	41.87 KB
master	`WriteAndFlushEnrichedTraces`	net472	862μs	2.83μs	11μs	8.45	2.53	0.422	53.29 KB
#5914	`WriteAndFlushEnrichedTraces`	net6.0	551μs	1.39μs	5.22μs	0.568	0	0	41.48 KB
#5914	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	674μs	3.53μs	18μs	0.329	0	0	41.69 KB
#5914	`WriteAndFlushEnrichedTraces`	net472	855μs	3.12μs	12.1μs	8.87	2.53	0.422	53.3 KB

Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`ExecuteNonQuery`	net6.0	1.27μs	0.95ns	3.68ns	0.014	0	0	1.02 KB
master	`ExecuteNonQuery`	netcoreapp3.1	1.73μs	1.25ns	4.84ns	0.0131	0	0	1.02 KB
master	`ExecuteNonQuery`	net472	2.04μs	2.14ns	8.31ns	0.156	0	0	987 B
#5914	`ExecuteNonQuery`	net6.0	1.24μs	0.375ns	1.4ns	0.0142	0	0	1.02 KB
#5914	`ExecuteNonQuery`	netcoreapp3.1	1.76μs	1.48ns	5.74ns	0.0132	0	0	1.02 KB
#5914	`ExecuteNonQuery`	net472	2.02μs	2.7ns	10.5ns	0.157	0	0	987 B

Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`CallElasticsearch`	net6.0	1.23μs	0.454ns	1.7ns	0.0136	0	0	976 B
master	`CallElasticsearch`	netcoreapp3.1	1.56μs	1.79ns	6.7ns	0.0132	0	0	976 B
master	`CallElasticsearch`	net472	2.61μs	2.1ns	8.13ns	0.158	0.0013	0	995 B
master	`CallElasticsearchAsync`	net6.0	1.35μs	0.955ns	3.58ns	0.0135	0	0	952 B
master	`CallElasticsearchAsync`	netcoreapp3.1	1.65μs	0.667ns	2.41ns	0.0133	0	0	1.02 KB
master	`CallElasticsearchAsync`	net472	2.64μs	1.14ns	4.11ns	0.166	0.00133	0	1.05 KB
#5914	`CallElasticsearch`	net6.0	1.17μs	0.648ns	2.51ns	0.0141	0	0	976 B
#5914	`CallElasticsearch`	netcoreapp3.1	1.55μs	0.464ns	1.8ns	0.0133	0	0	976 B
#5914	`CallElasticsearch`	net472	2.5μs	2.24ns	8.69ns	0.157	0	0	995 B
#5914	`CallElasticsearchAsync`	net6.0	1.29μs	0.72ns	2.79ns	0.0135	0	0	952 B
#5914	`CallElasticsearchAsync`	netcoreapp3.1	1.63μs	1.17ns	4.38ns	0.014	0	0	1.02 KB
#5914	`CallElasticsearchAsync`	net472	2.79μs	2.23ns	8.62ns	0.167	0	0	1.05 KB

Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`ExecuteAsync`	net6.0	1.27μs	1.22ns	4.71ns	0.0133	0	0	952 B
master	`ExecuteAsync`	netcoreapp3.1	1.62μs	0.891ns	3.21ns	0.0129	0	0	952 B
master	`ExecuteAsync`	net472	1.82μs	2.47ns	9.55ns	0.145	0	0	915 B
#5914	`ExecuteAsync`	net6.0	1.26μs	1.12ns	4.32ns	0.0133	0	0	952 B
#5914	`ExecuteAsync`	netcoreapp3.1	1.68μs	1.3ns	4.87ns	0.0125	0	0	952 B
#5914	`ExecuteAsync`	net472	1.8μs	1.55ns	6.02ns	0.145	0	0	915 B

Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`SendAsync`	net6.0	4.15μs	0.911ns	3.29ns	0.0312	0	0	2.22 KB
master	`SendAsync`	netcoreapp3.1	5.2μs	20.1ns	78ns	0.036	0	0	2.76 KB
master	`SendAsync`	net472	7.84μs	1.8ns	6.98ns	0.496	0	0	3.15 KB
#5914	`SendAsync`	net6.0	4.07μs	1.46ns	5.67ns	0.0306	0	0	2.22 KB
#5914	`SendAsync`	netcoreapp3.1	5.14μs	2.7ns	10.5ns	0.0358	0	0	2.76 KB
#5914	`SendAsync`	net472	7.74μs	2.41ns	9.35ns	0.497	0	0	3.15 KB

Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`EnrichedLog`	net6.0	1.43μs	0.752ns	2.81ns	0.0229	0	0	1.64 KB
master	`EnrichedLog`	netcoreapp3.1	2.25μs	1.17ns	4.36ns	0.0225	0	0	1.64 KB
master	`EnrichedLog`	net472	2.53μs	0.603ns	2.26ns	0.25	0	0	1.57 KB
#5914	`EnrichedLog`	net6.0	1.58μs	0.548ns	2.05ns	0.0232	0	0	1.64 KB
#5914	`EnrichedLog`	netcoreapp3.1	2.22μs	0.844ns	3.16ns	0.0222	0	0	1.64 KB
#5914	`EnrichedLog`	net472	2.61μs	0.742ns	2.78ns	0.248	0	0	1.57 KB

Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`EnrichedLog`	net6.0	113μs	165ns	594ns	0.0572	0	0	4.28 KB
master	`EnrichedLog`	netcoreapp3.1	117μs	98.7ns	382ns	0.0589	0	0	4.28 KB
master	`EnrichedLog`	net472	145μs	54.4ns	211ns	0.654	0.218	0	4.46 KB
#5914	`EnrichedLog`	net6.0	113μs	177ns	687ns	0.0567	0	0	4.28 KB
#5914	`EnrichedLog`	netcoreapp3.1	118μs	127ns	492ns	0.059	0	0	4.28 KB
#5914	`EnrichedLog`	net472	145μs	36.5ns	141ns	0.654	0.218	0	4.46 KB

Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`EnrichedLog`	net6.0	3.04μs	1.35ns	5.05ns	0.0305	0	0	2.2 KB
master	`EnrichedLog`	netcoreapp3.1	4.31μs	1.12ns	4.36ns	0.0302	0	0	2.2 KB
master	`EnrichedLog`	net472	4.89μs	0.944ns	3.66ns	0.32	0	0	2.02 KB
#5914	`EnrichedLog`	net6.0	3.09μs	0.695ns	2.69ns	0.0309	0	0	2.2 KB
#5914	`EnrichedLog`	netcoreapp3.1	4.27μs	2.33ns	8.72ns	0.03	0	0	2.2 KB
#5914	`EnrichedLog`	net472	4.97μs	1.85ns	6.68ns	0.32	0	0	2.02 KB

Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`SendReceive`	net6.0	1.38μs	0.582ns	2.18ns	0.0159	0	0	1.14 KB
master	`SendReceive`	netcoreapp3.1	1.77μs	0.981ns	3.8ns	0.015	0	0	1.14 KB
master	`SendReceive`	net472	2.07μs	1.26ns	4.86ns	0.183	0.00103	0	1.16 KB
#5914	`SendReceive`	net6.0	1.38μs	0.418ns	1.62ns	0.0164	0	0	1.14 KB
#5914	`SendReceive`	netcoreapp3.1	1.69μs	0.807ns	3.13ns	0.0152	0	0	1.14 KB
#5914	`SendReceive`	net472	2.11μs	1.28ns	4.95ns	0.183	0.00106	0	1.16 KB

Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`EnrichedLog`	net6.0	2.69μs	10.2ns	39.3ns	0.0225	0	0	1.6 KB
master	`EnrichedLog`	netcoreapp3.1	4.03μs	1.14ns	4.41ns	0.0221	0	0	1.65 KB
master	`EnrichedLog`	net472	4.38μs	3.19ns	12.3ns	0.322	0	0	2.04 KB
#5914	`EnrichedLog`	net6.0	2.85μs	0.951ns	3.68ns	0.0228	0	0	1.6 KB
#5914	`EnrichedLog`	netcoreapp3.1	3.93μs	1.74ns	6.74ns	0.0216	0	0	1.65 KB
#5914	`EnrichedLog`	net472	4.31μs	2.61ns	10.1ns	0.322	0	0	2.04 KB

Benchmarks.Trace.SpanBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`StartFinishSpan`	net6.0	412ns	0.227ns	0.819ns	0.00803	0	0	576 B
master	`StartFinishSpan`	netcoreapp3.1	579ns	0.265ns	0.99ns	0.00795	0	0	576 B
master	`StartFinishSpan`	net472	679ns	0.578ns	2.24ns	0.0918	0	0	578 B
master	`StartFinishScope`	net6.0	508ns	0.277ns	1.07ns	0.0097	0	0	696 B
master	`StartFinishScope`	netcoreapp3.1	704ns	0.446ns	1.67ns	0.00933	0	0	696 B
master	`StartFinishScope`	net472	856ns	1.78ns	6.89ns	0.104	0	0	658 B
#5914	`StartFinishSpan`	net6.0	401ns	0.33ns	1.28ns	0.00814	0	0	576 B
#5914	`StartFinishSpan`	netcoreapp3.1	584ns	1.11ns	4.3ns	0.00763	0	0	576 B
#5914	`StartFinishSpan`	net472	688ns	0.576ns	2.23ns	0.0916	0	0	578 B
#5914	`StartFinishScope`	net6.0	479ns	0.283ns	1.1ns	0.00968	0	0	696 B
#5914	`StartFinishScope`	netcoreapp3.1	712ns	0.474ns	1.77ns	0.00943	0	0	696 B
#5914	`StartFinishScope`	net472	888ns	0.872ns	3.38ns	0.104	0	0	658 B

Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`RunOnMethodBegin`	net6.0	653ns	0.484ns	1.88ns	0.00979	0	0	696 B
master	`RunOnMethodBegin`	netcoreapp3.1	895ns	4.29ns	17.1ns	0.00925	0	0	696 B
master	`RunOnMethodBegin`	net472	1.12μs	1.12ns	4.33ns	0.104	0	0	658 B
#5914	`RunOnMethodBegin`	net6.0	599ns	0.465ns	1.8ns	0.00987	0	0	696 B
#5914	`RunOnMethodBegin`	netcoreapp3.1	918ns	1.07ns	4.16ns	0.00926	0	0	696 B
#5914	`RunOnMethodBegin`	net472	1.07μs	0.768ns	2.97ns	0.104	0	0	658 B

dudikeleti force-pushed the dudik/explorationtest-linprobes branch 3 times, most recently from 332ffd4 to a51ae95 Compare

September 10, 2024 09:39

andrewlock reviewed

View reviewed changes

Member

andrewlock left a comment

I mostly just looked at the build/shared code - would be good to have someone who understands the native side review that from the tracer PoV!

tracer/build/_build/Build.ExplorationTests.cs Outdated Show resolved Hide resolved

tracer/build/_build/Build.ExplorationTests.cs Show resolved Hide resolved

tracer/build/_build/Build.ExplorationTests.cs Outdated Show resolved Hide resolved

tracer/build/_build/Build.ExplorationTests.cs Outdated Show resolved Hide resolved

tracer/src/Datadog.Trace/ClrProfiler/Instrumentation.cs Outdated Show resolved Hide resolved

tracer/src/Datadog.Tracer.Native/fault_tolerant_rewriter.cpp Outdated Show resolved Hide resolved

tracer/src/Datadog.Tracer.Native/fault_tolerant_rewriter.cpp Outdated Show resolved Hide resolved

dudikeleti force-pushed the dudik/explorationtest-linprobes branch from 6853dec to 14f3f26 Compare

September 10, 2024 11:23

andrewlock reviewed

View reviewed changes

tracer/build/_build/Build.ExplorationTests.cs Outdated Show resolved Hide resolved

andrewlock reviewed

View reviewed changes

Member

andrewlock left a comment

LGTM, thanks, only not explicitly approving because I want someone to check the native side 😄

tracer/build/_build/Build.ExplorationTests.cs Outdated Show resolved Hide resolved

GreenMatan approved these changes

View reviewed changes

Contributor

GreenMatan left a comment •

edited

Loading

I've already reviewed most of the meat while pairing. Left a few comments on things caught my eyes.

.nuke/build.schema.json Outdated Show resolved Hide resolved

tracer/build/_build/Build.ExplorationTests.cs Outdated Show resolved Hide resolved

tracer/build/_build/Build.ExplorationTests.cs Outdated Show resolved Hide resolved

tracer/src/Datadog.Trace/PDBs/DatadogMetadataReader.cs Show resolved Hide resolved

tracer/src/Datadog.Trace/PDBs/DatadogMetadataReader.cs Outdated Show resolved Hide resolved

tracer/src/Datadog.Tracer.Native/debugger_probes_instrumentation_requester.cpp Show resolved Hide resolved

tracer/src/Datadog.Tracer.Native/debugger_probes_instrumentation_requester.cpp Outdated Show resolved Hide resolved

dudikeleti force-pushed the dudik/explorationtest-linprobes branch from 9f23fde to 3e08654 Compare

September 12, 2024 09:44

tonyredondo approved these changes

View reviewed changes

Member

tonyredondo left a comment

native side LGTM

dudikeleti force-pushed the dudik/explorationtest-linprobes branch 5 times, most recently from 79496eb to c1ee86a Compare

September 13, 2024 00:47

andrewlock approved these changes

View reviewed changes

Member

andrewlock left a comment

LGTM on the build side 👍

dudikeleti force-pushed the dudik/explorationtest-linprobes branch 2 times, most recently from b08a77c to 17a65c9 Compare

September 16, 2024 12:39

Member

andrewlock commented Sep 16, 2024

Throughput/Crank Report ⚡

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5914) (10.641M)   : 0, 10641326
    master (10.867M)   : 0, 10866655
    benchmarks/2.9.0 (11.081M)   : 0, 11080577

    section Automatic
    This PR (5914) (7.195M)   : 0, 7195027
    master (7.063M)   : 0, 7062638
    benchmarks/2.9.0 (7.732M)   : 0, 7732233

    section Trace stats
    master (7.364M)   : 0, 7364303

    section Manual
    master (10.824M)   : 0, 10823898

    section Manual + Automatic
    This PR (5914) (6.638M)   : 0, 6637913
    master (6.575M)   : 0, 6575042

    section DD_TRACE_ENABLED=0
    master (9.990M)   : 0, 9989817

gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5914) (9.617M)   : 0, 9616615
    master (9.746M)   : 0, 9746139
    benchmarks/2.9.0 (9.798M)   : 0, 9798067

    section Automatic
    This PR (5914) (6.567M)   : 0, 6566842
    master (6.518M)   : 0, 6518443

    section Trace stats
    master (6.791M)   : 0, 6791013

    section Manual
    master (9.554M)   : 0, 9554347

    section Manual + Automatic
    This PR (5914) (6.110M)   : 0, 6110198
    master (6.054M)   : 0, 6053863

    section DD_TRACE_ENABLED=0
    master (8.868M)   : 0, 8868379

gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5914) (10.180M)   : 0, 10180344
    master (10.125M)   : 0, 10125159
    benchmarks/2.9.0 (10.067M)   : 0, 10067315

    section Automatic
    This PR (5914) (6.765M)   : 0, 6765300
    master (6.789M)   : 0, 6788744
    benchmarks/2.9.0 (7.552M)   : 0, 7552193

    section Trace stats
    master (7.427M)   : 0, 7426998

    section Manual
    master (10.349M)   : 0, 10348694

    section Manual + Automatic
    This PR (5914) (6.235M)   : 0, 6234958
    master (6.321M)   : 0, 6321226

    section DD_TRACE_ENABLED=0
    master (9.558M)   : 0, 9557791

dudikeleti force-pushed the dudik/explorationtest-linprobes branch from 9c6c8f2 to f193e79 Compare

September 17, 2024 11:01

GreenMatan and others added 3 commits

September 17, 2024 15:06


          Added support for line probes in the exploration tests

c08225c


          Remove old property

c668fab


          Skip certain tests that fail on stackoverflow exception in case of in…

5eb64ee

…strumentall line

dudikeleti and others added 25 commits

September 17, 2024 15:06


          Add line probes and rejit verify env var

62b886e


          Create line probes files and add env vars

f248cb5


          Add instrumentation for exploration line probes

5994be5


          fix exploration tests line probes logic

6f0f5e7


          minor

c34b5b8


          update build schema


          sanitize mvid

b03968a


          Add cal_once

95d99bd


          add TryFinallyMethodAndLine test

d512a39


          skip on non windows

d1bf0c5


          Fix build

90f0014


          Made the Fault-Tolerant Instrumentation to work in conjunction with t…

b091f65

…he Exploration Tests of Method & Line probes


          Update after rebase

1317bb5


          update after rebase

0867a56


          Update test and approval

dd0686a


          Add progress bar for creating lines and improve logs

452f1e1


          Run exploration tests with line scenario only for protobuf

20566a7


          PR comments

a8979cf


          More pr comments

6adad90


          remove WaitForDebuggerAttach

403299f


          trying fix linux build

fe5b280


          another try

9fbeaab


          one more

1ec4b80


          Update approval

67916d8


          fix directory path in linux

d40945c

dudikeleti force-pushed the dudik/explorationtest-linprobes branch from d1c555e to d40945c Compare

September 17, 2024 13:07

dudikeleti merged commit c1a6733 into master

72 of 78 checks passed

dudikeleti deleted the dudik/explorationtest-linprobes branch

September 17, 2024 14:44

github-actions bot added this to the vNext-v3 milestone

andrewlock added the area:tests label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:debugger area:tests