Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a native logger for critical failures in the loader (#5929 -> v2) #5939

Merged
merged 1 commit into from
Aug 28, 2024
Merged

Use a native logger for critical failures in the loader (#5929 -> v2) #5939

merged 1 commit into from
Aug 28, 2024

Commits on Aug 23, 2024

  1. Use a native logger for critical failures in the loader (#5929) 

    ## Summary of changes

Wrap the call to the managed loader in a try/catch, and use a native
logger to log the exception if any.

## Reason for change

There's already a try/catch in the managed loader, but in some
situations we can fail before even getting there (if jitting the method
failed, for instance because of a trimmed runtime). Also, the managed
loader logger can fail.

## Implementation details

This PR adds a try/catch in the code emitted to load the managed loader.
In the catch clause, we call a native logging function, with a direct
unmanaged `calli` call to its address.

Because we have now this outer catch block, I removed the `IsInSsi`
logic which isn't needed anymore.
    @kevingosse @andrewlock
    kevingosse authored and andrewlock committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    068c13e View commit details
    Browse the repository at this point in the history