Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[serverless] No-op AWS Lambda integration on missing API Key" #5941

Conversation

duncanista
Copy link
Contributor

@duncanista duncanista commented Aug 23, 2024

Summary of changes

This reverts commit 8e63384.

Reason for change

It doesn't account for DD_API_KEY_SECRET_ARN or DD_KMS_API_KEY which is considered a regression.

Implementation details

n/a

Test coverage

Confirmed that it stops working for Lambdas with that configuration

Other details

@datadog-ddstaging
Copy link

datadog-ddstaging bot commented Aug 23, 2024

Datadog Report

Branch report: jordan.gonzalez/revert/8e63384717cc1a2608815c661c13c65ed94ba965
Commit report: 6d7bddc
Test service: dd-trace-dotnet

✅ 0 Failed, 301275 Passed, 1616 Skipped, 11h 52m 6.39s Total Time

@andrewlock
Copy link
Member

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

@duncanista duncanista merged commit 1005d98 into master Aug 23, 2024
69 of 72 checks passed
@duncanista duncanista deleted the jordan.gonzalez/revert/8e63384717cc1a2608815c661c13c65ed94ba965 branch August 23, 2024 18:45
@github-actions github-actions bot added this to the vNext-v3 milestone Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants