Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backport][serverless] trigger consolidated pipeline on tags (#6052 => v2) #6053

Merged

Conversation

duncanista
Copy link
Contributor

@duncanista duncanista commented Sep 18, 2024

Summary of changes

Removes exclusion of pipeline trigger for tags.

Reason for change

Serverless requires a build on a tag in order to have a production ready pipeline to use.

Implementation details

n/a

Test coverage

Other details

Backport of #6052

@duncanista duncanista requested a review from a team as a code owner September 18, 2024 14:43
@duncanista duncanista added the area:builds project files, build scripts, pipelines, versioning, releases, packages label Sep 18, 2024
@datadog-ddstaging
Copy link

datadog-ddstaging bot commented Sep 18, 2024

Datadog Report

Branch report: jordan.gonzalez/backport/trigger-pipeline-on-tags
Commit report: 2f7f196
Test service: dd-trace-dotnet

✅ 0 Failed, 352212 Passed, 1821 Skipped, 14h 18m 45.66s Total Time

@andrewlock
Copy link
Member

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6053) - mean (73ms)  : 65, 80
     .   : milestone, 73,
    master - mean (70ms)  : 67, 73
     .   : milestone, 70,

    section CallTarget+Inlining+NGEN
    This PR (6053) - mean (1,053ms)  : 1025, 1081
     .   : milestone, 1053,
    master - mean (1,106ms)  : 1075, 1137
     .   : milestone, 1106,

Loading
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6053) - mean (109ms)  : 105, 112
     .   : milestone, 109,
    master - mean (109ms)  : 105, 113
     .   : milestone, 109,

    section CallTarget+Inlining+NGEN
    This PR (6053) - mean (758ms)  : 731, 785
     .   : milestone, 758,
    master - mean (801ms)  : 783, 820
     .   : milestone, 801,

Loading
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6053) - mean (92ms)  : 90, 95
     .   : milestone, 92,
    master - mean (92ms)  : 89, 95
     .   : milestone, 92,

    section CallTarget+Inlining+NGEN
    This PR (6053) - mean (707ms)  : 688, 727
     .   : milestone, 707,
    master - mean (746ms)  : 724, 768
     .   : milestone, 746,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6053) - mean (191ms)  : 187, 195
     .   : milestone, 191,
    master - mean (191ms)  : 187, 194
     .   : milestone, 191,

    section CallTarget+Inlining+NGEN
    This PR (6053) - mean (1,137ms)  : 1111, 1163
     .   : milestone, 1137,
    master - mean (1,192ms)  : 1167, 1217
     .   : milestone, 1192,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6053) - mean (277ms)  : 273, 282
     .   : milestone, 277,
    master - mean (278ms)  : 274, 282
     .   : milestone, 278,

    section CallTarget+Inlining+NGEN
    This PR (6053) - mean (921ms)  : 899, 944
     .   : milestone, 921,
    master - mean (963ms)  : 942, 984
     .   : milestone, 963,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6053) - mean (266ms)  : 263, 269
     .   : milestone, 266,
    master - mean (266ms)  : 262, 270
     .   : milestone, 266,

    section CallTarget+Inlining+NGEN
    This PR (6053) - mean (898ms)  : 872, 924
     .   : milestone, 898,
    master - mean (944ms)  : 916, 972
     .   : milestone, 944,

Loading

@duncanista duncanista merged commit f11b280 into release/2.x Sep 18, 2024
68 of 71 checks passed
@duncanista duncanista deleted the jordan.gonzalez/backport/trigger-pipeline-on-tags branch September 18, 2024 16:09
@github-actions github-actions bot added this to the vNext-v2 milestone Sep 18, 2024
@andrewlock andrewlock added type:backport Feature backport to old version area:serverless labels Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:builds project files, build scripts, pipelines, versioning, releases, packages area:serverless type:backport Feature backport to old version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants