[Profiler][cleanup] Shorten libdatadog helper functions name #6069

gleocadie · 2024-09-24T11:54:34Z

Summary of changes

Shorten libdatadog helper functions name

Reason for change

cleaner and easier to read.

Implementation details

Use free functions instead of static methods in a static class.

Test coverage

Other details

chrisnas

LGTM

andrewlock · 2024-09-24T12:24:54Z

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

Welch test with statistical test for significance of 5%
Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6069) - mean (70ms)  : 67, 72
     .   : milestone, 70,
    master - mean (70ms)  : 67, 73
     .   : milestone, 70,

    section CallTarget+Inlining+NGEN
    This PR (6069) - mean (1,098ms)  : 1076, 1120
     .   : milestone, 1098,
    master - mean (1,105ms)  : 1067, 1143
     .   : milestone, 1105,

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6069) - mean (109ms)  : 106, 111
     .   : milestone, 109,
    master - mean (109ms)  : 105, 112
     .   : milestone, 109,

    section CallTarget+Inlining+NGEN
    This PR (6069) - mean (770ms)  : 750, 790
     .   : milestone, 770,
    master - mean (766ms)  : 751, 782
     .   : milestone, 766,

gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6069) - mean (92ms)  : 89, 95
     .   : milestone, 92,
    master - mean (92ms)  : 90, 94
     .   : milestone, 92,

    section CallTarget+Inlining+NGEN
    This PR (6069) - mean (738ms)  : 679, 796
     .   : milestone, 738,
    master - mean (727ms)  : 707, 747
     .   : milestone, 727,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6069) - mean (190ms)  : 187, 192
     .   : milestone, 190,
    master - mean (191ms)  : 187, 195
     .   : milestone, 191,

    section CallTarget+Inlining+NGEN
    This PR (6069) - mean (1,194ms)  : 1169, 1220
     .   : milestone, 1194,
    master - mean (1,202ms)  : 1165, 1240
     .   : milestone, 1202,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6069) - mean (276ms)  : 272, 279
     .   : milestone, 276,
    master - mean (276ms)  : 270, 281
     .   : milestone, 276,

    section CallTarget+Inlining+NGEN
    This PR (6069) - mean (939ms)  : 921, 957
     .   : milestone, 939,
    master - mean (938ms)  : 918, 958
     .   : milestone, 938,

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6069) - mean (265ms)  : 261, 269
     .   : milestone, 265,
    master - mean (265ms)  : 261, 269
     .   : milestone, 265,

    section CallTarget+Inlining+NGEN
    This PR (6069) - mean (927ms)  : 909, 945
     .   : milestone, 927,
    master - mean (922ms)  : 906, 939
     .   : milestone, 922,

datadog-ddstaging · 2024-09-24T12:47:15Z

Datadog Report

Branch report: gleocadie/simplify-name-libdatadog
Commit report: 8a31f74
Test service: dd-trace-dotnet

✅ 0 Failed, 369783 Passed, 2354 Skipped, 17h 8m 51.9s Total Time
❄️ 2 New Flaky

New Flaky Tests (2)

SubmitsTraces - Datadog.Trace.ClrProfiler.IntegrationTests.StackExchangeRedisTests - Last Failure
Expand for error
```
 Expected exit code: 0, actual exit code: 134.
```

SubmitsTraces - Datadog.Trace.ClrProfiler.IntegrationTests.StackExchangeRedisTests - Last Failure

Expand for error

 Results do not match.
 Differences:
 Received: StackExchangeRedisTests.V1_2_2.SchemaV1.received.txt
 Verified: StackExchangeRedisTests.V1_2_2.SchemaV1.verified.txt
 Received Content:
 [
   {
     TraceId: Id_1,
     SpanId: Id_2,
     Name: redis.command,
 ...

andrewlock · 2024-09-24T13:00:38Z

Benchmarks Report for tracer 🐌

Benchmarks for #6069 compared to master:

1 benchmarks are faster, with geometric mean 1.126
2 benchmarks are slower, with geometric mean 1.121
All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

Mann–Whitney U test with statistical test for significance of 5%
Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`StartStopWithChild`	net6.0	7.88μs	43.3ns	256ns	0.0162	0.00812	0	5.43 KB
master	`StartStopWithChild`	netcoreapp3.1	9.88μs	55.7ns	390ns	0.0189	0.00945	0	5.61 KB
master	`StartStopWithChild`	net472	15.8μs	52.8ns	205ns	1.02	0.3	0.103	6.07 KB
#6069	`StartStopWithChild`	net6.0	7.78μs	44.3ns	317ns	0.0185	0.00739	0	5.43 KB
#6069	`StartStopWithChild`	netcoreapp3.1	10μs	51.3ns	336ns	0.0199	0.00993	0	5.61 KB
#6069	`StartStopWithChild`	net472	16.6μs	92.9ns	731ns	1.01	0.288	0.0879	6.06 KB

Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	484μs	485ns	1.88μs	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	650μs	417ns	1.56μs	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	net472	835μs	498ns	1.93μs	0.417	3.3 KB
#6069	`WriteAndFlushEnrichedTraces`	net6.0	462μs	150ns	580ns	0	2.7 KB
#6069	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	634μs	190ns	685ns	0	2.7 KB
#6069	`WriteAndFlushEnrichedTraces`	net472	832μs	567ns	2.2μs	0.417	3.3 KB

Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendRequest`	net6.0	207μs	1.21μs	11.1μs	0.202	18.45 KB
master	`SendRequest`	netcoreapp3.1	237μs	1.35μs	9.76μs	0.215	20.61 KB
master	`SendRequest`	net472	0.00304ns	0.00115ns	0.00444ns	0	0 b
#6069	`SendRequest`	net6.0	208μs	1.19μs	8.84μs	0.204	18.45 KB
#6069	`SendRequest`	netcoreapp3.1	231μs	1.23μs	6.72μs	0.229	20.61 KB
#6069	`SendRequest`	net472	0.000364ns	0.000221ns	0.000827ns	0	0 b

Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	577μs	3.1μs	17.8μs	0.566	0	0	41.57 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	686μs	3.28μs	14.3μs	0.347	0	0	41.64 KB
master	`WriteAndFlushEnrichedTraces`	net472	875μs	3.4μs	12.7μs	8.09	2.25	0.45	53.33 KB
#6069	`WriteAndFlushEnrichedTraces`	net6.0	582μs	1.98μs	7.67μs	0.59	0	0	41.49 KB
#6069	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	686μs	3.19μs	15μs	0.363	0	0	41.79 KB
#6069	`WriteAndFlushEnrichedTraces`	net472	835μs	2.57μs	9.62μs	8.28	2.48	0.414	53.32 KB

Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`ExecuteNonQuery`	net6.0	1.34μs	1.32ns	4.95ns	0.0142	1.02 KB
master	`ExecuteNonQuery`	netcoreapp3.1	1.71μs	1.13ns	4.39ns	0.0137	1.02 KB
master	`ExecuteNonQuery`	net472	2.13μs	2.16ns	8.36ns	0.156	987 B
#6069	`ExecuteNonQuery`	net6.0	1.25μs	1.31ns	5.08ns	0.0143	1.02 KB
#6069	`ExecuteNonQuery`	netcoreapp3.1	1.75μs	3.41ns	13.2ns	0.0137	1.02 KB
#6069	`ExecuteNonQuery`	net472	2.07μs	2.05ns	7.94ns	0.156	987 B

Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`CallElasticsearch`	net6.0	1.22μs	3.91ns	14.6ns	0.0139	976 B
master	`CallElasticsearch`	netcoreapp3.1	1.53μs	0.951ns	3.56ns	0.0128	976 B
master	`CallElasticsearch`	net472	2.46μs	1.66ns	6.41ns	0.158	995 B
master	`CallElasticsearchAsync`	net6.0	1.17μs	1.32ns	4.93ns	0.0136	952 B
master	`CallElasticsearchAsync`	netcoreapp3.1	1.68μs	0.823ns	3.08ns	0.0134	1.02 KB
master	`CallElasticsearchAsync`	net472	2.55μs	1.79ns	6.95ns	0.166	1.05 KB
#6069	`CallElasticsearch`	net6.0	1.19μs	1.55ns	6.02ns	0.0138	976 B
#6069	`CallElasticsearch`	netcoreapp3.1	1.56μs	0.714ns	2.67ns	0.0129	976 B
#6069	`CallElasticsearch`	net472	2.6μs	1.68ns	6.51ns	0.158	995 B
#6069	`CallElasticsearchAsync`	net6.0	1.28μs	0.713ns	2.76ns	0.0133	952 B
#6069	`CallElasticsearchAsync`	netcoreapp3.1	1.58μs	1.81ns	6.76ns	0.0137	1.02 KB
#6069	`CallElasticsearchAsync`	net472	2.62μs	1.7ns	6.6ns	0.166	1.05 KB

Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`ExecuteAsync`	net6.0	1.23μs	0.572ns	2.14ns	0.0134	952 B
master	`ExecuteAsync`	netcoreapp3.1	1.61μs	2.86ns	11.1ns	0.0127	952 B
master	`ExecuteAsync`	net472	1.81μs	0.978ns	3.79ns	0.145	915 B
#6069	`ExecuteAsync`	net6.0	1.29μs	0.559ns	2.09ns	0.0129	952 B
#6069	`ExecuteAsync`	netcoreapp3.1	1.64μs	0.606ns	2.27ns	0.0123	952 B
#6069	`ExecuteAsync`	net472	1.75μs	0.498ns	1.86ns	0.145	915 B

Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendAsync`	net6.0	4.26μs	1.23ns	4.6ns	0.0298	2.22 KB
master	`SendAsync`	netcoreapp3.1	5.07μs	4.13ns	16ns	0.0354	2.76 KB
master	`SendAsync`	net472	7.85μs	1.34ns	5.2ns	0.497	3.15 KB
#6069	`SendAsync`	net6.0	4.15μs	3.8ns	14.2ns	0.0311	2.22 KB
#6069	`SendAsync`	netcoreapp3.1	5.22μs	23.3ns	90.3ns	0.0382	2.76 KB
#6069	`SendAsync`	net472	7.8μs	2.45ns	9.5ns	0.499	3.15 KB

Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	1.56μs	0.743ns	2.88ns	0.0227	1.64 KB
master	`EnrichedLog`	netcoreapp3.1	2.2μs	1.15ns	4.46ns	0.022	1.64 KB
master	`EnrichedLog`	net472	2.6μs	1.54ns	5.96ns	0.249	1.57 KB
#6069	`EnrichedLog`	net6.0	1.47μs	0.768ns	2.87ns	0.023	1.64 KB
#6069	`EnrichedLog`	netcoreapp3.1	2.12μs	2.18ns	8.15ns	0.0222	1.64 KB
#6069	`EnrichedLog`	net472	2.76μs	2.04ns	7.9ns	0.249	1.57 KB

Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`EnrichedLog`	net6.0	113μs	120ns	464ns	0.0566	0	4.28 KB
master	`EnrichedLog`	netcoreapp3.1	119μs	106ns	411ns	0.0598	0	4.28 KB
master	`EnrichedLog`	net472	145μs	67.6ns	244ns	0.656	0.219	4.46 KB
#6069	`EnrichedLog`	net6.0	117μs	284ns	1.1μs	0	0	4.28 KB
#6069	`EnrichedLog`	netcoreapp3.1	119μs	252ns	976ns	0.0601	0	4.28 KB
#6069	`EnrichedLog`	net472	148μs	115ns	447ns	0.663	0.221	4.46 KB

Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	3.09μs	0.928ns	3.59ns	0.0308	2.2 KB
master	`EnrichedLog`	netcoreapp3.1	4.41μs	1.9ns	7.37ns	0.0287	2.2 KB
master	`EnrichedLog`	net472	4.81μs	1.3ns	4.85ns	0.32	2.02 KB
#6069	`EnrichedLog`	net6.0	3.22μs	3.71ns	14.4ns	0.0306	2.2 KB
#6069	`EnrichedLog`	netcoreapp3.1	4.22μs	3.77ns	14.1ns	0.03	2.2 KB
#6069	`EnrichedLog`	net472	5μs	1.24ns	4.65ns	0.319	2.02 KB

Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`SendReceive`	net6.0	1.36μs	0.7ns	2.62ns	0.0156	0	1.14 KB
master	`SendReceive`	netcoreapp3.1	1.73μs	1.22ns	4.58ns	0.0155	0	1.14 KB
master	`SendReceive`	net472	2.17μs	1.16ns	4.32ns	0.183	0.00109	1.16 KB
#6069	`SendReceive`	net6.0	1.3μs	0.725ns	2.81ns	0.0163	0	1.14 KB
#6069	`SendReceive`	netcoreapp3.1	1.78μs	1.56ns	6.06ns	0.0151	0	1.14 KB
#6069	`SendReceive`	net472	2.13μs	2.07ns	8.01ns	0.183	0.00107	1.16 KB

Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	2.77μs	10.3ns	40.1ns	0.022	1.6 KB
master	`EnrichedLog`	netcoreapp3.1	3.77μs	1.36ns	5.08ns	0.0209	1.65 KB
master	`EnrichedLog`	net472	4.33μs	1.67ns	6.46ns	0.323	2.04 KB
#6069	`EnrichedLog`	net6.0	2.71μs	0.88ns	3.41ns	0.0217	1.6 KB
#6069	`EnrichedLog`	netcoreapp3.1	3.8μs	1.57ns	6.07ns	0.0227	1.65 KB
#6069	`EnrichedLog`	net472	4.54μs	2.96ns	11.1ns	0.323	2.04 KB

Benchmarks.Trace.SpanBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #6069

Benchmark	diff/base	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net6.0	1.123	477.11	535.84
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑netcoreapp3.1	1.119	594.53	665.16

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`StartFinishSpan`	net6.0	407ns	0.361ns	1.4ns	0.00818	576 B
master	`StartFinishSpan`	netcoreapp3.1	594ns	1.01ns	3.93ns	0.00798	576 B
master	`StartFinishSpan`	net472	654ns	1.56ns	5.84ns	0.0917	578 B
master	`StartFinishScope`	net6.0	477ns	0.235ns	0.911ns	0.00966	696 B
master	`StartFinishScope`	netcoreapp3.1	759ns	1.06ns	4.09ns	0.00938	696 B
master	`StartFinishScope`	net472	888ns	1.04ns	4.01ns	0.105	658 B
#6069	`StartFinishSpan`	net6.0	403ns	0.433ns	1.68ns	0.00806	576 B
#6069	`StartFinishSpan`	netcoreapp3.1	665ns	0.438ns	1.7ns	0.00771	576 B
#6069	`StartFinishSpan`	net472	673ns	1.83ns	7.07ns	0.0916	578 B
#6069	`StartFinishScope`	net6.0	536ns	0.194ns	0.75ns	0.0099	696 B
#6069	`StartFinishScope`	netcoreapp3.1	749ns	0.345ns	1.34ns	0.00936	696 B
#6069	`StartFinishScope`	net472	894ns	4.07ns	15.8ns	0.104	658 B

Benchmarks.Trace.TraceAnnotationsBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #6069

Benchmark	base/diff	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net6.0	1.126	675.74	599.92

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`RunOnMethodBegin`	net6.0	676ns	0.514ns	1.99ns	0.00988	696 B
master	`RunOnMethodBegin`	netcoreapp3.1	982ns	0.697ns	2.61ns	0.00936	696 B
master	`RunOnMethodBegin`	net472	1.11μs	0.875ns	3.39ns	0.105	658 B
#6069	`RunOnMethodBegin`	net6.0	600ns	0.256ns	0.923ns	0.0099	696 B
#6069	`RunOnMethodBegin`	netcoreapp3.1	939ns	1.15ns	4.44ns	0.00923	696 B
#6069	`RunOnMethodBegin`	net472	1.09μs	0.395ns	1.48ns	0.104	658 B

andrewlock · 2024-09-24T13:33:17Z

Throughput/Crank Report ⚡

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6069) (11.049M)   : 0, 11048910
    master (11.101M)   : 0, 11101013
    benchmarks/2.9.0 (11.081M)   : 0, 11080577

    section Automatic
    This PR (6069) (7.352M)   : 0, 7352342
    master (7.322M)   : 0, 7321945
    benchmarks/2.9.0 (7.732M)   : 0, 7732233

    section Trace stats
    master (7.648M)   : 0, 7647979

    section Manual
    master (11.159M)   : 0, 11158874

    section Manual + Automatic
    This PR (6069) (6.870M)   : 0, 6870440
    master (6.756M)   : 0, 6755889

    section DD_TRACE_ENABLED=0
    master (10.104M)   : 0, 10103630

gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6069) (9.429M)   : 0, 9428590
    master (9.538M)   : 0, 9538166
    benchmarks/2.9.0 (9.798M)   : 0, 9798067

    section Automatic
    This PR (6069) (6.390M)   : 0, 6390067
    master (6.560M)   : 0, 6559669

    section Trace stats
    master (6.899M)   : 0, 6898524

    section Manual
    master (9.530M)   : 0, 9529944

    section Manual + Automatic
    This PR (6069) (5.905M)   : 0, 5904897
    master (6.111M)   : 0, 6111240

    section DD_TRACE_ENABLED=0
    master (8.837M)   : 0, 8836832

gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6069) (10.124M)   : 0, 10123619
    master (10.017M)   : 0, 10017307
    benchmarks/2.9.0 (10.067M)   : 0, 10067315

    section Automatic
    This PR (6069) (6.875M)   : 0, 6875152
    master (6.715M)   : 0, 6715040
    benchmarks/2.9.0 (7.552M)   : 0, 7552193

    section Trace stats
    master (7.357M)   : 0, 7357178

    section Manual
    master (9.959M)   : 0, 9958707

    section Manual + Automatic
    This PR (6069) (6.225M)   : 0, 6225031
    master (6.139M)   : 0, 6139159

    section DD_TRACE_ENABLED=0
    master (9.384M)   : 0, 9383899

Shorten libdatadog helper functions name

8a31f74

gleocadie requested a review from a team as a code owner September 24, 2024 11:54

github-actions bot added the area:profiler Issues related to the continous-profiler label Sep 24, 2024

chrisnas approved these changes Sep 24, 2024

View reviewed changes

gleocadie merged commit 73ca3f3 into master Sep 24, 2024
79 of 81 checks passed

gleocadie deleted the gleocadie/simplify-name-libdatadog branch September 24, 2024 15:14

github-actions bot added this to the vNext-v3 milestone Sep 24, 2024

andrewlock added the type:cleanup Minor code clean up label Oct 23, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Profiler][cleanup] Shorten libdatadog helper functions name #6069

[Profiler][cleanup] Shorten libdatadog helper functions name #6069

gleocadie commented Sep 24, 2024

chrisnas left a comment

andrewlock commented Sep 24, 2024

datadog-ddstaging bot commented Sep 24, 2024 •

edited

Loading

andrewlock commented Sep 24, 2024

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Slower ⚠️ in #6069

Raw results

Faster 🎉 in #6069

Raw results

andrewlock commented Sep 24, 2024

[Profiler][cleanup] Shorten libdatadog helper functions name #6069

[Profiler][cleanup] Shorten libdatadog helper functions name #6069

Conversation

gleocadie commented Sep 24, 2024

Summary of changes

Reason for change

Implementation details

Test coverage

Other details

chrisnas left a comment

Choose a reason for hiding this comment

andrewlock commented Sep 24, 2024

Execution-Time Benchmarks Report ⏱️

datadog-ddstaging bot commented Sep 24, 2024 • edited Loading

Datadog Report

New Flaky Tests (2)

andrewlock commented Sep 24, 2024

Benchmarks Report for tracer 🐌

Benchmark details

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Slower ⚠️ in #6069

Raw results

Faster 🎉 in #6069

Raw results

andrewlock commented Sep 24, 2024

Throughput/Crank Report ⚡

datadog-ddstaging bot commented Sep 24, 2024 •

edited

Loading