[CI Visibility] Fix code coverage enabled tag behavior #6111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewlock
approved these changes
Oct 3, 2024
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing the following branches/commits: Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6111) - mean (71ms) : 68, 73
. : milestone, 71,
master - mean (70ms) : 68, 72
. : milestone, 70,
section CallTarget+Inlining+NGEN
This PR (6111) - mean (1,105ms) : 1083, 1126
. : milestone, 1105,
master - mean (1,105ms) : 1087, 1123
. : milestone, 1105,
gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6111) - mean (109ms) : 106, 112
. : milestone, 109,
master - mean (109ms) : 106, 112
. : milestone, 109,
section CallTarget+Inlining+NGEN
This PR (6111) - mean (774ms) : 757, 792
. : milestone, 774,
master - mean (772ms) : 756, 787
. : milestone, 772,
gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6111) - mean (93ms) : 90, 95
. : milestone, 93,
master - mean (93ms) : 90, 96
. : milestone, 93,
section CallTarget+Inlining+NGEN
This PR (6111) - mean (730ms) : 710, 750
. : milestone, 730,
master - mean (727ms) : 709, 744
. : milestone, 727,
gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6111) - mean (190ms) : 187, 193
. : milestone, 190,
master - mean (191ms) : 187, 194
. : milestone, 191,
section CallTarget+Inlining+NGEN
This PR (6111) - mean (1,194ms) : 1169, 1218
. : milestone, 1194,
master - mean (1,194ms) : 1165, 1223
. : milestone, 1194,
gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6111) - mean (275ms) : 271, 280
. : milestone, 275,
master - mean (276ms) : 271, 280
. : milestone, 276,
section CallTarget+Inlining+NGEN
This PR (6111) - mean (942ms) : 925, 958
. : milestone, 942,
master - mean (936ms) : 920, 952
. : milestone, 936,
gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6111) - mean (265ms) : 262, 268
. : milestone, 265,
master - mean (265ms) : 261, 269
. : milestone, 265,
section CallTarget+Inlining+NGEN
This PR (6111) - mean (925ms) : 910, 940
. : milestone, 925,
master - mean (923ms) : 906, 940
. : milestone, 923,
|
juan-fernandez
approved these changes
Oct 3, 2024
Benchmarks Report for tracer 🐌Benchmarks for #6111 compared to master:
The following thresholds were used for comparing the benchmark speeds:
Allocation changes below 0.5% are ignored. Benchmark detailsBenchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.SpanBenchmark - Faster 🎉 Same allocations ✔️
|
| Benchmark | base/diff | Base Median (ns) | Diff Median (ns) | Modality |
|---|---|---|---|---|
| Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net6.0 | 1.169 | 476.39 | 407.37 | |
| Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net6.0 | 1.117 | 535.01 | 478.79 |
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | StartFinishSpan |
net6.0 | 476ns | 0.0983ns | 0.368ns | 0.00818 | 0 | 0 | 576 B |
| master | StartFinishSpan |
netcoreapp3.1 | 548ns | 0.31ns | 1.2ns | 0.00797 | 0 | 0 | 576 B |
| master | StartFinishSpan |
net472 | 674ns | 0.186ns | 0.719ns | 0.0917 | 0 | 0 | 578 B |
| master | StartFinishScope |
net6.0 | 535ns | 0.266ns | 1.03ns | 0.00968 | 0 | 0 | 696 B |
| master | StartFinishScope |
netcoreapp3.1 | 662ns | 0.312ns | 1.12ns | 0.00956 | 0 | 0 | 696 B |
| master | StartFinishScope |
net472 | 841ns | 0.229ns | 0.887ns | 0.104 | 0 | 0 | 658 B |
| #6111 | StartFinishSpan |
net6.0 | 407ns | 0.198ns | 0.768ns | 0.00817 | 0 | 0 | 576 B |
| #6111 | StartFinishSpan |
netcoreapp3.1 | 577ns | 1.2ns | 4.64ns | 0.00793 | 0 | 0 | 576 B |
| #6111 | StartFinishSpan |
net472 | 634ns | 0.561ns | 2.17ns | 0.0918 | 0 | 0 | 578 B |
| #6111 | StartFinishScope |
net6.0 | 479ns | 0.226ns | 0.877ns | 0.00963 | 0 | 0 | 696 B |
| #6111 | StartFinishScope |
netcoreapp3.1 | 706ns | 0.427ns | 1.66ns | 0.00932 | 0 | 0 | 696 B |
| #6111 | StartFinishScope |
net472 | 840ns | 0.591ns | 2.29ns | 0.104 | 0 | 0 | 658 B |
Benchmarks.Trace.TraceAnnotationsBenchmark - Faster 🎉 Same allocations ✔️
Faster 🎉 in #6111
Benchmark
base/diff
Base Median (ns)
Diff Median (ns)
Modality
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net6.0
1.271
762.63
600.17
| Benchmark | base/diff | Base Median (ns) | Diff Median (ns) | Modality |
|---|---|---|---|---|
| Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net6.0 | 1.271 | 762.63 | 600.17 |
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | RunOnMethodBegin |
net6.0 | 763ns | 0.409ns | 1.59ns | 0.00955 | 0 | 0 | 696 B |
| master | RunOnMethodBegin |
netcoreapp3.1 | 997ns | 0.462ns | 1.79ns | 0.00947 | 0 | 0 | 696 B |
| master | RunOnMethodBegin |
net472 | 1.12μs | 0.63ns | 2.44ns | 0.104 | 0 | 0 | 658 B |
| #6111 | RunOnMethodBegin |
net6.0 | 600ns | 0.346ns | 1.34ns | 0.00963 | 0 | 0 | 696 B |
| #6111 | RunOnMethodBegin |
netcoreapp3.1 | 988ns | 0.402ns | 1.56ns | 0.00963 | 0 | 0 | 696 B |
| #6111 | RunOnMethodBegin |
net472 | 1.17μs | 0.662ns | 2.56ns | 0.104 | 0 | 0 | 658 B |
Datadog ReportBranch report: ✅ 0 Failed, 366739 Passed, 2056 Skipped, 15h 53m 32.65s Total Time New Flaky Tests (1)
|
Throughput/Crank Report ⚡Throughput results for AspNetCoreSimpleController comparing the following branches/commits: Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red. Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards! gantt
title Throughput Linux x64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (6111) (10.997M) : 0, 10996540
master (10.898M) : 0, 10898452
benchmarks/2.9.0 (11.081M) : 0, 11080577
section Automatic
This PR (6111) (7.196M) : 0, 7195698
master (7.236M) : 0, 7236170
benchmarks/2.9.0 (7.732M) : 0, 7732233
section Trace stats
master (7.546M) : 0, 7545828
section Manual
master (10.952M) : 0, 10952297
section Manual + Automatic
This PR (6111) (6.805M) : 0, 6804855
master (6.660M) : 0, 6659549
section DD_TRACE_ENABLED=0
master (9.891M) : 0, 9891026
gantt
title Throughput Linux arm64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (6111) (9.391M) : 0, 9390698
master (9.362M) : 0, 9362410
benchmarks/2.9.0 (9.798M) : 0, 9798067
section Automatic
This PR (6111) (6.592M) : 0, 6592041
master (6.598M) : 0, 6597548
section Trace stats
master (6.871M) : 0, 6871246
section Manual
master (9.366M) : 0, 9366333
section Manual + Automatic
This PR (6111) (6.176M) : 0, 6176179
master (6.137M) : 0, 6136716
section DD_TRACE_ENABLED=0
master (8.947M) : 0, 8947125
gantt
title Throughput Windows x64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (6111) (10.093M) : 0, 10093491
master (10.073M) : 0, 10073298
benchmarks/2.9.0 (10.067M) : 0, 10067315
section Automatic
This PR (6111) (6.866M) : 0, 6865660
master (6.830M) : 0, 6829594
benchmarks/2.9.0 (7.552M) : 0, 7552193
section Trace stats
master (7.461M) : 0, 7460530
section Manual
master (9.962M) : 0, 9962060
section Manual + Automatic
This PR (6111) (6.223M) : 0, 6223152
master (6.378M) : 0, 6377879
section DD_TRACE_ENABLED=0
master (9.452M) : 0, 9452401
|
tonyredondo
deleted the
tony/civisibility-fix-codecoverage-enabled-behavior
branch
agocs
pushed a commit
that referenced
this pull request
Oct 8, 2024
## Summary of changes
This PR fixes the current behavior of the `test.code_coverage.enabled`
tag to only set it to true when Intelligent Test Runner is enabled and
collecting coverage data per test
## Reason for change
.NET implementation was setting this value also on global code coverage
reporting, being different to other tracers implementations
## Implementation details
Remove the set tag when reporting the global code coverage from third
party libraries.
## Test coverage
Updated the code coverage reporting test to check we don't set the tag
anymore.
## Other details
<!-- Fixes #{issue} -->
<!-- ⚠️ Note: where possible, please obtain 2 approvals prior to
merging. Unless CODEOWNERS specifies otherwise, for external teams it is
typically best to have one review from a team member, and one review
from apm-dotnet. Trivial changes do not require 2 reviews. -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
This PR fixes the current behavior of the
test.code_coverage.enabledtag to only set it to true when Intelligent Test Runner is enabled and collecting coverage data per testReason for change
.NET implementation was setting this value also on global code coverage reporting, being different to other tracers implementations
Implementation details
Remove the set tag when reporting the global code coverage from third party libraries.
Test coverage
Updated the code coverage reporting test to check we don't set the tag anymore.
Other details