Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ASM] Update ruleset to version 1.13.1 and WAF to version 1.20.0 #6129

Merged
merged 5 commits into from
Oct 15, 2024
Merged

[ASM] Update ruleset to version 1.13.1 and WAF to version 1.20.0 #6129

merged 5 commits into from
Oct 15, 2024

Conversation

NachoEchevarria
Copy link
Contributor

@NachoEchevarria NachoEchevarria commented Oct 8, 2024 •
edited
Loading

Summary of changes

The default ruleset has been updated to version 1.13.1

The WAF version has been updated to 1.20.0

Since the new ruleset includes fingerprint, tests using them have started generating fingerprints, so snapshots need to be updated. Also, the newest WAF version corrects some errors in the FP generation and generates FPs if only some optional parameters are sent, so some new values have been added/modified.

A small update has been done in the code to send FPs if the WAF returns them even if there is no match event, which could potentially happen.

Reason for change

We need to update both the WAF and the ruleset to support the newest FP and RASP features.

Implementation details

Test coverage

Other details

@datadog-ddstaging
Copy link

datadog-ddstaging bot commented Oct 8, 2024 •
edited
Loading

Datadog Report

Branch report: nacho/UpdateRuleSet
Commit report: 5cd0185
Test service: dd-trace-dotnet

✅ 0 Failed, 466554 Passed, 3289 Skipped, 31h 10m 46.86s Total Time
❄️ 1 New Flaky

New Flaky Tests (1)

  • NoExceptions - Datadog.Trace.ClrProfiler.IntegrationTests.SmokeTests.RuntimeMetricsShutdownSmokeTest - Last Failure

    Expand for error 
     
 Actual:   Falseilure took 6msp - Only part of a ReadProcessMemory or WriteProcessMemory request was completed. (-2147024597)tem.Object)

@andrewlock
Copy link
Member

andrewlock commented Oct 8, 2024 •
edited
Loading

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6129) - mean (70ms)  : 68, 72
     .   : milestone, 70,
    master - mean (70ms)  : 67, 72
     .   : milestone, 70,

    section CallTarget+Inlining+NGEN
    This PR (6129) - mean (1,110ms)  : 1087, 1132
     .   : milestone, 1110,
    master - mean (1,107ms)  : 1090, 1125
     .   : milestone, 1107,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6129) - mean (109ms)  : 106, 112
     .   : milestone, 109,
    master - mean (108ms)  : 106, 111
     .   : milestone, 108,

    section CallTarget+Inlining+NGEN
    This PR (6129) - mean (777ms)  : 759, 795
     .   : milestone, 777,
    master - mean (769ms)  : 752, 786
     .   : milestone, 769,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6129) - mean (93ms)  : 89, 97
     .   : milestone, 93,
    master - mean (92ms)  : 89, 94
     .   : milestone, 92,

    section CallTarget+Inlining+NGEN
    This PR (6129) - mean (725ms)  : 706, 744
     .   : milestone, 725,
    master - mean (727ms)  : 708, 747
     .   : milestone, 727,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6129) - mean (190ms)  : 187, 193
     .   : milestone, 190,
    master - mean (189ms)  : 186, 192
     .   : milestone, 189,

    section CallTarget+Inlining+NGEN
    This PR (6129) - mean (1,201ms)  : 1175, 1226
     .   : milestone, 1201,
    master - mean (1,194ms)  : 1168, 1219
     .   : milestone, 1194,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6129) - mean (276ms)  : 269, 282
     .   : milestone, 276,
    master - mean (275ms)  : 270, 280
     .   : milestone, 275,

    section CallTarget+Inlining+NGEN
    This PR (6129) - mean (938ms)  : 922, 954
     .   : milestone, 938,
    master - mean (942ms)  : 925, 958
     .   : milestone, 942,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6129) - mean (264ms)  : 259, 269
     .   : milestone, 264,
    master - mean (262ms)  : 259, 266
     .   : milestone, 262,

    section CallTarget+Inlining+NGEN
    This PR (6129) - mean (918ms)  : 905, 932
     .   : milestone, 918,
    master - mean (922ms)  : 904, 939
     .   : milestone, 922,
Loading

@andrewlock
Copy link
Member

andrewlock commented Oct 8, 2024 •
edited
Loading

Benchmarks Report for appsec 🐌

Benchmarks for #6129 compared to master:

  • 1 benchmarks are faster, with geometric mean 1.163
  • 2 benchmarks have more allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.Asm.AppSecBodyBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master AllCycleSimpleBody net6.0 72.7μs 129ns 483ns 0.0717 0 0 6.01 KB
master AllCycleSimpleBody netcoreapp3.1 62.6μs 126ns 489ns 0.0936 0 0 6.95 KB
master AllCycleSimpleBody net472 49.3μs 136ns 526ns 1.32 0 0 8.34 KB
master AllCycleMoreComplexBody net6.0 78.4μs 89.9ns 348ns 0.119 0 0 9.51 KB
master AllCycleMoreComplexBody netcoreapp3.1 69.9μs 116ns 436ns 0.106 0 0 10.36 KB
master AllCycleMoreComplexBody net472 55.8μs 58.7ns 227ns 1.86 0.0278 0 11.85 KB
master ObjectExtractorSimpleBody net6.0 143ns 0.256ns 0.992ns 0.00395 0 0 280 B
master ObjectExtractorSimpleBody netcoreapp3.1 208ns 0.179ns 0.67ns 0.00365 0 0 272 B
master ObjectExtractorSimpleBody net472 174ns 0.155ns 0.6ns 0.0446 0 0 281 B
master ObjectExtractorMoreComplexBody net6.0 3.09μs 1.5ns 5.8ns 0.0541 0 0 3.78 KB
master ObjectExtractorMoreComplexBody netcoreapp3.1 3.97μs 1.77ns 6.39ns 0.0496 0 0 3.69 KB
master ObjectExtractorMoreComplexBody net472 3.82μs 2.62ns 10.2ns 0.602 0.00574 0 3.8 KB
#6129 AllCycleSimpleBody net6.0 71.5μs 76.6ns 297ns 0.0714 0 0 6 KB
#6129 AllCycleSimpleBody netcoreapp3.1 63.9μs 86.1ns 333ns 0.0956 0 0 6.95 KB
#6129 AllCycleSimpleBody net472 49.2μs 58.6ns 219ns 1.32 0 0 8.34 KB
#6129 AllCycleMoreComplexBody net6.0 78.3μs 96.5ns 348ns 0.121 0 0 9.51 KB
#6129 AllCycleMoreComplexBody netcoreapp3.1 70.1μs 90ns 349ns 0.106 0 0 10.37 KB
#6129 AllCycleMoreComplexBody net472 56.7μs 41ns 159ns 1.87 0.0284 0 11.85 KB
#6129 ObjectExtractorSimpleBody net6.0 145ns 0.161ns 0.603ns 0.00396 0 0 280 B
#6129 ObjectExtractorSimpleBody netcoreapp3.1 221ns 0.227ns 0.878ns 0.00378 0 0 272 B
#6129 ObjectExtractorSimpleBody net472 173ns 0.16ns 0.62ns 0.0446 0 0 281 B
#6129 ObjectExtractorMoreComplexBody net6.0 3.02μs 1.48ns 5.54ns 0.0529 0 0 3.78 KB
#6129 ObjectExtractorMoreComplexBody netcoreapp3.1 3.92μs 2.81ns 10.5ns 0.0508 0 0 3.69 KB
#6129 ObjectExtractorMoreComplexBody net472 3.8μs 3.18ns 12.3ns 0.602 0.00571 0 3.8 KB
Benchmarks.Trace.Asm.AppSecEncoderBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EncodeArgs net6.0 37.6μs 18.6ns 67.1ns 0.448 0 0 32.4 KB
master EncodeArgs netcoreapp3.1 53.9μs 23.5ns 91.1ns 0.431 0 0 32.4 KB
master EncodeArgs net472 66.6μs 37.9ns 147ns 5.14 0.0668 0 32.5 KB
master EncodeLegacyArgs net6.0 75.4μs 36.5ns 141ns 0 0 0 2.14 KB
master EncodeLegacyArgs netcoreapp3.1 105μs 500ns 2μs 0 0 0 2.14 KB
master EncodeLegacyArgs net472 156μs 85.5ns 331ns 0.311 0 0 2.15 KB
#6129 EncodeArgs net6.0 38μs 21ns 81.5ns 0.455 0 0 32.4 KB
#6129 EncodeArgs netcoreapp3.1 54.9μs 18.7ns 67.3ns 0.438 0 0 32.4 KB
#6129 EncodeArgs net472 68.1μs 43.9ns 170ns 5.15 0.0683 0 32.5 KB
#6129 EncodeLegacyArgs net6.0 80.7μs 454ns 2.98μs 0 0 0 2.14 KB
#6129 EncodeLegacyArgs netcoreapp3.1 105μs 120ns 463ns 0 0 0 2.14 KB
#6129 EncodeLegacyArgs net472 153μs 118ns 456ns 0.308 0 0 2.15 KB
Benchmarks.Trace.Asm.AppSecWafBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunWafRealisticBenchmark net6.0 185μs 124ns 480ns 0 0 0 2.44 KB
master RunWafRealisticBenchmark netcoreapp3.1 198μs 242ns 936ns 0 0 0 2.39 KB
master RunWafRealisticBenchmark net472 211μs 142ns 550ns 0.318 0 0 2.46 KB
master RunWafRealisticBenchmarkWithAttack net6.0 122μs 134ns 519ns 0 0 0 1.47 KB
master RunWafRealisticBenchmarkWithAttack netcoreapp3.1 130μs 97.8ns 339ns 0 0 0 1.46 KB
master RunWafRealisticBenchmarkWithAttack net472 139μs 65.4ns 253ns 0.208 0 0 1.49 KB
#6129 RunWafRealisticBenchmark net6.0 186μs 105ns 406ns 0 0 0 2.44 KB
#6129 RunWafRealisticBenchmark netcoreapp3.1 199μs 252ns 943ns 0 0 0 2.39 KB
#6129 RunWafRealisticBenchmark net472 210μs 67.9ns 254ns 0.315 0 0 2.46 KB
#6129 RunWafRealisticBenchmarkWithAttack net6.0 122μs 54.1ns 209ns 0 0 0 1.47 KB
#6129 RunWafRealisticBenchmarkWithAttack netcoreapp3.1 131μs 158ns 614ns 0 0 0 1.46 KB
#6129 RunWafRealisticBenchmarkWithAttack net472 139μs 58.6ns 227ns 0.209 0 0 1.49 KB
Benchmarks.Trace.Iast.StringAspectsBenchmark - Faster 🎉 More allocations ⚠️

Faster 🎉 in #6129

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑net6.0 1.163 61,300.00 52,700.00 multimodal

More allocations ⚠️ in #6129

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑net472 57.06 KB 59.44 KB 2.38 KB 4.16%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑netcoreapp3.1 252.61 KB 254.13 KB 1.52 KB 0.60%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StringConcatBenchmark net6.0 61.4μs 848ns 8.48μs 0 0 0 43.44 KB
master StringConcatBenchmark netcoreapp3.1 53.8μs 289ns 1.64μs 0 0 0 42.64 KB
master StringConcatBenchmark net472 38.7μs 212ns 1.14μs 0 0 0 57.06 KB
master StringConcatAspectBenchmark net6.0 312μs 1.45μs 8.19μs 0 0 0 255.47 KB
master StringConcatAspectBenchmark netcoreapp3.1 333μs 2.56μs 24.9μs 0 0 0 252.61 KB
master StringConcatAspectBenchmark net472 275μs 4.88μs 46.6μs 0 0 0 278.53 KB
#6129 StringConcatBenchmark net6.0 53μs 302ns 2.09μs 0 0 0 43.44 KB
#6129 StringConcatBenchmark netcoreapp3.1 53.6μs 198ns 863ns 0 0 0 42.64 KB
#6129 StringConcatBenchmark net472 37.5μs 164ns 590ns 0 0 0 59.44 KB
#6129 StringConcatAspectBenchmark net6.0 310μs 1.43μs 8.08μs 0 0 0 255.17 KB
#6129 StringConcatAspectBenchmark netcoreapp3.1 335μs 1.39μs 7.48μs 0 0 0 254.13 KB
#6129 StringConcatAspectBenchmark net472 293μs 6.68μs 65.1μs 0 0 0 278.53 KB

@andrewlock
Copy link
Member

andrewlock commented Oct 8, 2024 •
edited
Loading

Throughput/Crank Report ⚡

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6129) (11.279M)   : 0, 11279199
    master (11.099M)   : 0, 11098662
    benchmarks/2.9.0 (11.081M)   : 0, 11080577

    section Automatic
    This PR (6129) (7.415M)   : 0, 7415290
    master (7.353M)   : 0, 7353407
    benchmarks/2.9.0 (7.732M)   : 0, 7732233

    section Trace stats
    master (7.604M)   : 0, 7604389

    section Manual
    master (10.912M)   : 0, 10911730

    section Manual + Automatic
    This PR (6129) (6.869M)   : 0, 6868651
    master (6.757M)   : 0, 6756825

    section DD_TRACE_ENABLED=0
    master (10.056M)   : 0, 10055906
Loading 
gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6129) (9.525M)   : 0, 9525259
    master (9.588M)   : 0, 9587958
    benchmarks/2.9.0 (9.798M)   : 0, 9798067

    section Automatic
    This PR (6129) (6.591M)   : 0, 6590712
    master (6.554M)   : 0, 6554472

    section Trace stats
    master (6.811M)   : 0, 6811095

    section Manual
    master (9.622M)   : 0, 9622473

    section Manual + Automatic
    This PR (6129) (6.219M)   : 0, 6218798
    master (5.894M)   : 0, 5893873

    section DD_TRACE_ENABLED=0
    master (8.887M)   : 0, 8886504
Loading 
gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6129) (10.009M)   : 0, 10009029
    master (10.171M)   : 0, 10171179
    benchmarks/2.9.0 (10.067M)   : 0, 10067315

    section Automatic
    This PR (6129) (6.501M)   : 0, 6500911
    master (6.514M)   : 0, 6513949
    benchmarks/2.9.0 (7.552M)   : 0, 7552193

    section Trace stats
    master (7.311M)   : 0, 7310649

    section Manual
    master (10.008M)   : 0, 10007638

    section Manual + Automatic
    This PR (6129) (6.009M)   : 0, 6008954
    master (6.286M)   : 0, 6285745

    section DD_TRACE_ENABLED=0
    master (9.389M)   : 0, 9388827
Loading

@andrewlock
Copy link
Member

andrewlock commented Oct 8, 2024 •
edited
Loading

Benchmarks Report for tracer 🐌

Benchmarks for #6129 compared to master:

  • 1 benchmarks are faster, with geometric mean 1.125
  • 1 benchmarks are slower, with geometric mean 1.152
  • All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 7.85μs 43.7ns 290ns 0.0124 0.00415 0 5.43 KB
master StartStopWithChild netcoreapp3.1 10μs 56.2ns 364ns 0.0207 0.0104 0 5.61 KB
master StartStopWithChild net472 16.6μs 38.7ns 150ns 1.03 0.313 0.104 6.08 KB
#6129 StartStopWithChild net6.0 7.97μs 45.2ns 299ns 0.0191 0.00765 0 5.43 KB
#6129 StartStopWithChild netcoreapp3.1 10.1μs 53.4ns 262ns 0.0199 0.00498 0 5.62 KB
#6129 StartStopWithChild net472 16.9μs 51.6ns 193ns 1 0.288 0.0785 6.06 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 478μs 146ns 545ns 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 634μs 206ns 800ns 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 844μs 654ns 2.53μs 0.419 0 0 3.3 KB
#6129 WriteAndFlushEnrichedTraces net6.0 464μs 327ns 1.27μs 0 0 0 2.7 KB
#6129 WriteAndFlushEnrichedTraces netcoreapp3.1 650μs 337ns 1.21μs 0 0 0 2.7 KB
#6129 WriteAndFlushEnrichedTraces net472 842μs 491ns 1.9μs 0.419 0 0 3.3 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 190μs 1.03μs 6.24μs 0.201 0 0 18.45 KB
master SendRequest netcoreapp3.1 224μs 1.28μs 9.23μs 0.212 0 0 20.61 KB
master SendRequest net472 0.0314ns 0.00646ns 0.025ns 0 0 0 0 b
#6129 SendRequest net6.0 195μs 1.09μs 7.58μs 0.18 0 0 18.45 KB
#6129 SendRequest netcoreapp3.1 220μs 1.27μs 9.47μs 0.224 0 0 20.61 KB
#6129 SendRequest net472 0.00135ns 0.000442ns 0.00165ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 559μs 3μs 15.6μs 0.568 0 0 41.63 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 680μs 2.27μs 7.86μs 0.342 0 0 41.72 KB
master WriteAndFlushEnrichedTraces net472 843μs 2.27μs 8.17μs 8.56 2.57 0.428 53.27 KB
#6129 WriteAndFlushEnrichedTraces net6.0 551μs 1.43μs 5.15μs 0.551 0 0 41.53 KB
#6129 WriteAndFlushEnrichedTraces netcoreapp3.1 726μs 3.06μs 11.5μs 0.361 0 0 41.82 KB
#6129 WriteAndFlushEnrichedTraces net472 890μs 4.31μs 17.3μs 8.25 2.6 0.434 53.31 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.27μs 1.55ns 5.8ns 0.0145 0 0 1.02 KB
master ExecuteNonQuery netcoreapp3.1 1.76μs 2.38ns 8.9ns 0.0131 0 0 1.02 KB
master ExecuteNonQuery net472 2.1μs 1.85ns 6.93ns 0.157 0 0 987 B
#6129 ExecuteNonQuery net6.0 1.28μs 1.95ns 7.53ns 0.0142 0 0 1.02 KB
#6129 ExecuteNonQuery netcoreapp3.1 1.84μs 1.48ns 5.75ns 0.0137 0 0 1.02 KB
#6129 ExecuteNonQuery net472 2.05μs 1.6ns 6ns 0.157 0 0 987 B
Benchmarks.Trace.ElasticsearchBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #6129

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch‑net6.0 1.152 1,090.71 1,256.66

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.09μs 1.22ns 4.72ns 0.0139 0 0 976 B
master CallElasticsearch netcoreapp3.1 1.63μs 0.507ns 1.9ns 0.0129 0 0 976 B
master CallElasticsearch net472 2.55μs 1.26ns 4.89ns 0.157 0 0 995 B
master CallElasticsearchAsync net6.0 1.28μs 0.419ns 1.51ns 0.0135 0 0 952 B
master CallElasticsearchAsync netcoreapp3.1 1.63μs 1.55ns 5.81ns 0.0138 0 0 1.02 KB
master CallElasticsearchAsync net472 2.57μs 2.41ns 9.02ns 0.166 0 0 1.05 KB
#6129 CallElasticsearch net6.0 1.26μs 1.21ns 4.69ns 0.0138 0 0 976 B
#6129 CallElasticsearch netcoreapp3.1 1.6μs 0.469ns 1.69ns 0.0128 0 0 976 B
#6129 CallElasticsearch net472 2.42μs 1.95ns 7.54ns 0.158 0 0 995 B
#6129 CallElasticsearchAsync net6.0 1.28μs 1.71ns 6.64ns 0.0135 0 0 952 B
#6129 CallElasticsearchAsync netcoreapp3.1 1.69μs 0.884ns 3.42ns 0.0134 0 0 1.02 KB
#6129 CallElasticsearchAsync net472 2.6μs 2.26ns 8.76ns 0.167 0 0 1.05 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.29μs 1.12ns 4.32ns 0.0129 0 0 952 B
master ExecuteAsync netcoreapp3.1 1.66μs 3.5ns 13.6ns 0.0125 0 0 952 B
master ExecuteAsync net472 1.72μs 0.571ns 2.21ns 0.145 0 0 915 B
#6129 ExecuteAsync net6.0 1.31μs 1.55ns 5.99ns 0.013 0 0 952 B
#6129 ExecuteAsync netcoreapp3.1 1.66μs 0.938ns 3.63ns 0.0125 0 0 952 B
#6129 ExecuteAsync net472 1.75μs 1.1ns 4.12ns 0.145 0 0 915 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 4.17μs 2.47ns 9.58ns 0.0311 0 0 2.22 KB
master SendAsync netcoreapp3.1 5.01μs 2.23ns 8.65ns 0.0375 0 0 2.76 KB
master SendAsync net472 7.78μs 4.13ns 14.3ns 0.5 0 0 3.15 KB
#6129 SendAsync net6.0 4.18μs 1.73ns 6.47ns 0.0316 0 0 2.22 KB
#6129 SendAsync netcoreapp3.1 5.08μs 1.42ns 5.31ns 0.0359 0 0 2.76 KB
#6129 SendAsync net472 7.93μs 2.63ns 10.2ns 0.499 0 0 3.15 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 1.44μs 0.862ns 3.23ns 0.0231 0 0 1.64 KB
master EnrichedLog netcoreapp3.1 2.31μs 1.19ns 4.45ns 0.0219 0 0 1.64 KB
master EnrichedLog net472 2.69μs 0.793ns 2.86ns 0.25 0 0 1.57 KB
#6129 EnrichedLog net6.0 1.57μs 5.53ns 20.7ns 0.023 0 0 1.64 KB
#6129 EnrichedLog netcoreapp3.1 2.17μs 1.09ns 4.21ns 0.0224 0 0 1.64 KB
#6129 EnrichedLog net472 2.52μs 0.978ns 3.79ns 0.248 0 0 1.57 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 118μs 134ns 501ns 0.0594 0 0 4.28 KB
master EnrichedLog netcoreapp3.1 123μs 225ns 871ns 0 0 0 4.28 KB
master EnrichedLog net472 151μs 276ns 1.07μs 0.673 0.224 0 4.46 KB
#6129 EnrichedLog net6.0 118μs 117ns 454ns 0.0587 0 0 4.28 KB
#6129 EnrichedLog netcoreapp3.1 122μs 244ns 946ns 0 0 0 4.28 KB
#6129 EnrichedLog net472 152μs 157ns 609ns 0.685 0.228 0 4.46 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.91μs 1.11ns 4.29ns 0.0308 0 0 2.2 KB
master EnrichedLog netcoreapp3.1 4.26μs 1.56ns 6.06ns 0.0299 0 0 2.2 KB
master EnrichedLog net472 4.95μs 3.49ns 13.5ns 0.318 0 0 2.02 KB
#6129 EnrichedLog net6.0 3.14μs 1.6ns 6.21ns 0.031 0 0 2.2 KB
#6129 EnrichedLog netcoreapp3.1 4.4μs 2.7ns 10.5ns 0.0285 0 0 2.2 KB
#6129 EnrichedLog net472 4.81μs 1.45ns 5.63ns 0.32 0 0 2.02 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 1.44μs 0.536ns 2ns 0.0159 0 0 1.14 KB
master SendReceive netcoreapp3.1 1.75μs 1.06ns 4.11ns 0.0158 0 0 1.14 KB
master SendReceive net472 2.12μs 1.12ns 4.2ns 0.183 0.00106 0 1.16 KB
#6129 SendReceive net6.0 1.35μs 1.33ns 5.16ns 0.0163 0 0 1.14 KB
#6129 SendReceive netcoreapp3.1 1.79μs 1.26ns 4.86ns 0.0152 0 0 1.14 KB
#6129 SendReceive net472 2.09μs 1.63ns 6.31ns 0.183 0.00104 0 1.16 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.71μs 0.634ns 2.46ns 0.0217 0 0 1.6 KB
master EnrichedLog netcoreapp3.1 3.97μs 1.38ns 5.18ns 0.0217 0 0 1.65 KB
master EnrichedLog net472 4.54μs 1.32ns 4.94ns 0.322 0 0 2.04 KB
#6129 EnrichedLog net6.0 2.73μs 1.13ns 4.22ns 0.0219 0 0 1.6 KB
#6129 EnrichedLog netcoreapp3.1 3.88μs 1.03ns 3.72ns 0.0213 0 0 1.65 KB
#6129 EnrichedLog net472 4.39μs 2.49ns 9.65ns 0.324 0 0 2.04 KB
Benchmarks.Trace.SpanBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 400ns 0.173ns 0.669ns 0.00805 0 0 576 B
master StartFinishSpan netcoreapp3.1 594ns 0.522ns 2.02ns 0.00781 0 0 576 B
master StartFinishSpan net472 720ns 0.394ns 1.53ns 0.0915 0 0 578 B
master StartFinishScope net6.0 483ns 0.242ns 0.939ns 0.0097 0 0 696 B
master StartFinishScope netcoreapp3.1 717ns 0.438ns 1.7ns 0.00935 0 0 696 B
master StartFinishScope net472 932ns 0.652ns 2.52ns 0.105 0 0 658 B
#6129 StartFinishSpan net6.0 413ns 0.165ns 0.619ns 0.00817 0 0 576 B
#6129 StartFinishSpan netcoreapp3.1 571ns 0.227ns 0.881ns 0.0078 0 0 576 B
#6129 StartFinishSpan net472 741ns 1.78ns 6.89ns 0.0917 0 0 578 B
#6129 StartFinishScope net6.0 482ns 0.225ns 0.778ns 0.00969 0 0 696 B
#6129 StartFinishScope netcoreapp3.1 726ns 0.749ns 2.59ns 0.00946 0 0 696 B
#6129 StartFinishScope net472 912ns 0.588ns 2.2ns 0.104 0 0 658 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #6129

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net6.0 1.125 734.52 652.83

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 734ns 0.274ns 1.06ns 0.00982 0 0 696 B
master RunOnMethodBegin netcoreapp3.1 916ns 0.21ns 0.758ns 0.00921 0 0 696 B
master RunOnMethodBegin net472 1.12μs 0.475ns 1.71ns 0.104 0 0 658 B
#6129 RunOnMethodBegin net6.0 653ns 0.304ns 1.18ns 0.00983 0 0 696 B
#6129 RunOnMethodBegin netcoreapp3.1 914ns 0.397ns 1.54ns 0.00956 0 0 696 B
#6129 RunOnMethodBegin net472 1.14μs 0.697ns 2.7ns 0.104 0 0 658 B

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 9, 2024 •
edited
Loading

Snapshots difference summary

The following differences have been observed in committed snapshots. It is meant to help the reviewer.
The diff is simplistic, so please check some files anyway while we improve it.

2 occurrences of :

-        "_dd.appsec.waf.version": "1.19.1",
+        "_dd.appsec.waf.version": "1.20.0",

2 occurrences of :

-        "_dd.appsec.event_rules.loaded": 153.0,
+        "_dd.appsec.event_rules.loaded": 158.0,

12 occurrences of :

+      _dd.appsec.fp.http.endpoint: http-get-0587c50e-8e35c2cd-,

4 occurrences of :

+      _dd.appsec.fp.http.endpoint: http-get-92238171-0a2bbc6e-,

6 occurrences of :

+      _dd.appsec.fp.http.endpoint: http-get-e1e32f93-3b9c358f-,

4 occurrences of :

+      _dd.appsec.fp.http.endpoint: http-get-05b4d989-4740ae63-,

4 occurrences of :

+      _dd.appsec.fp.http.endpoint: http-get-92238171-0a2bbc6e-,
[...]
+      _dd.appsec.fp.session: ssn----,

4 occurrences of :

+      _dd.appsec.fp.http.endpoint: http-get-e1e32f93-3b9c358f-,
[...]
+      _dd.appsec.fp.session: ssn----,

4 occurrences of :

+      _dd.appsec.fp.http.endpoint: http-get-05b4d989-4740ae63-,
[...]
+      _dd.appsec.fp.session: ssn----,

4 occurrences of :

+      _dd.appsec.fp.http.endpoint: http-get-ece9044c-4740ae63-,
[...]
+      _dd.appsec.fp.session: ssn----,

54 occurrences of :

+      _dd.appsec.fp.session: ssn----,

10 occurrences of :

+      _dd.appsec.fp.http.header: hdr-0100000000-3626b5f8-1-4740ae63,
+      _dd.appsec.fp.http.network: net-1-1000000000,

5 occurrences of :

+      _dd.appsec.fp.http.endpoint: http-get-9ce5b35c-8e35c2cd-,
+      _dd.appsec.fp.http.header: hdr-0100000000-3626b5f8-1-4740ae63,
+      _dd.appsec.fp.http.network: net-1-1000000000,

5 occurrences of :

+      _dd.appsec.fp.http.endpoint: http-get-7f4bf8ee-49fefa92-,
+      _dd.appsec.fp.http.header: hdr-0100000000-3626b5f8-1-4740ae63,
+      _dd.appsec.fp.http.network: net-1-1000000000,

5 occurrences of :

+      _dd.appsec.fp.http.endpoint: http-get-7f4bf8ee-17b4850e-,
+      _dd.appsec.fp.http.header: hdr-0100000000-3626b5f8-1-4740ae63,
+      _dd.appsec.fp.http.network: net-1-1000000000,

5 occurrences of :

+      _dd.appsec.fp.http.endpoint: http-get-9ce5b35c-49fefa92-,
+      _dd.appsec.fp.http.header: hdr-0100000000-3626b5f8-1-4740ae63,
+      _dd.appsec.fp.http.network: net-1-1000000000,

1 occurrences of :

+      _dd.appsec.fp.http.endpoint: http-get-a848ab99-8e35c2cd-,

18 occurrences of :

+      _dd.appsec.fp.http.header: hdr-0000000000-3626b5f8-1-4740ae63,
+      _dd.appsec.fp.http.network: net-1-1000000000,

5 occurrences of :

+      _dd.appsec.fp.http.endpoint: http-get-9ce5b35c-8e35c2cd-,
+      _dd.appsec.fp.http.header: hdr-0000000000-3626b5f8-1-4740ae63,
+      _dd.appsec.fp.http.network: net-1-1000000000,

17 occurrences of :

+      _dd.appsec.fp.http.endpoint: http-get-7f4bf8ee-49fefa92-,
+      _dd.appsec.fp.http.header: hdr-0000000000-3626b5f8-1-4740ae63,
+      _dd.appsec.fp.http.network: net-1-1000000000,

5 occurrences of :

+      _dd.appsec.fp.http.endpoint: http-get-7f4bf8ee-17b4850e-,
+      _dd.appsec.fp.http.header: hdr-0000000000-3626b5f8-1-4740ae63,
+      _dd.appsec.fp.http.network: net-1-1000000000,

5 occurrences of :

+      _dd.appsec.fp.http.endpoint: http-get-9ce5b35c-49fefa92-,
+      _dd.appsec.fp.http.header: hdr-0000000000-3626b5f8-1-4740ae63,
+      _dd.appsec.fp.http.network: net-1-1000000000,

14 occurrences of :

+      _dd.appsec.fp.http.endpoint: http-get-7f4bf8ee-b25f03de-,

1 occurrences of :

-      _dd.appsec.event_rules.version: 1.10.0,
+      _dd.appsec.event_rules.version: 1.13.1,
+      _dd.appsec.fp.http.header: hdr-0000000000-3626b5f8-1-4740ae63,
+      _dd.appsec.fp.http.network: net-1-1000000000,
+      _dd.appsec.fp.session: ssn-5860faf0---,

1 occurrences of :

-      _dd.appsec.event_rules.version: 1.10.0,
+      _dd.appsec.event_rules.version: 1.13.1,
+      _dd.appsec.fp.http.endpoint: http-get-7f4bf8ee-49fefa92-,
+      _dd.appsec.fp.http.header: hdr-0000000000-3626b5f8-1-4740ae63,
+      _dd.appsec.fp.http.network: net-1-1000000000,
[...]
-      _dd.appsec.waf.version: 1.19.1,
+      _dd.appsec.waf.version: 1.20.0,

1 occurrences of :

-      _dd.appsec.event_rules.loaded: 153.0,
+      _dd.appsec.event_rules.loaded: 158.0,

1 occurrences of :

-      _dd.appsec.waf.version: 1.19.1,
+      _dd.appsec.waf.version: 1.20.0,

3 occurrences of :

+      _dd.appsec.fp.http.header: hdr-0000000000-bf177a93-1-4740ae63,
+      _dd.appsec.fp.http.network: net-1-1000000000,

5 occurrences of :

+      _dd.appsec.fp.http.endpoint: http-get-80022bec-ccaaac7c-,

5 occurrences of :

+      _dd.appsec.fp.http.endpoint: http-get-c75550dd-ccaaac7c-,

5 occurrences of :

+      _dd.appsec.fp.http.endpoint: http-get-5ede5d09-ccaaac7c-,

20 occurrences of :

+      _dd.appsec.fp.http.endpoint: http-get-0587c50e--,
[...]
+      _dd.appsec.fp.session: ssn----,

10 occurrences of :

+      _dd.appsec.fp.http.endpoint: http-get-9ce5b35c-2e4a7b5a-,
[...]
+      _dd.appsec.fp.session: ssn----,

20 occurrences of :

+      _dd.appsec.fp.http.endpoint: http-get-9ce5b35c--,
[...]
+      _dd.appsec.fp.session: ssn----,

10 occurrences of :

+      _dd.appsec.fp.http.endpoint: http-get-7f4bf8ee-b25f03de-,
[...]
+      _dd.appsec.fp.session: ssn----,

5 occurrences of :

+      _dd.appsec.fp.http.endpoint: http-get-74ef4633--,
[...]
+      _dd.appsec.fp.session: ssn----,

5 occurrences of :

+      _dd.appsec.fp.http.endpoint: http-get-0cfc1178--,
[...]
+      _dd.appsec.fp.session: ssn----,

18 occurrences of :

+      _dd.appsec.fp.http.endpoint: http-get-0587c50e-b25f03de-,
[...]
+      _dd.appsec.fp.session: ssn----,

6 occurrences of :

-      _dd.appsec.waf.version: 1.19.1,
+      _dd.appsec.waf.version: 1.20.0,
[...]
-      _dd.appsec.event_rules.loaded: 153.0,
+      _dd.appsec.event_rules.loaded: 158.0,

1 occurrences of :

-      _dd.appsec.event_rules.version: 1.10.0,
+      _dd.appsec.event_rules.version: 1.13.1,
+      _dd.appsec.fp.http.endpoint: http-get-8a5edab2--,
+      _dd.appsec.fp.http.header: hdr-0000000000-3626b5f8-1-4740ae63,
+      _dd.appsec.fp.http.network: net-1-1000000000,
+      _dd.appsec.fp.session: ssn----,

2 occurrences of :

-      _dd.appsec.event_rules.version: 1.10.0,
+      _dd.appsec.event_rules.version: 1.13.1,
+      _dd.appsec.fp.http.endpoint: http-get-c9ffce19--,
+      _dd.appsec.fp.http.header: hdr-0000000000-3626b5f8-1-4740ae63,
+      _dd.appsec.fp.http.network: net-1-1000000000,
+      _dd.appsec.fp.session: ssn-5860faf0---,

1 occurrences of :

-      _dd.appsec.event_rules.version: 1.10.0,
+      _dd.appsec.event_rules.version: 1.13.1,
+      _dd.appsec.fp.http.endpoint: http-get-8a5edab2--,
+      _dd.appsec.fp.http.header: hdr-0000000000-3626b5f8-3-98425651,
+      _dd.appsec.fp.http.network: net-1-1000000000,
+      _dd.appsec.fp.session: ssn----,

2 occurrences of :

-      _dd.appsec.event_rules.version: 1.10.0,
+      _dd.appsec.event_rules.version: 1.13.1,
+      _dd.appsec.fp.http.endpoint: http-get-c9ffce19--,
+      _dd.appsec.fp.http.header: hdr-0000000000-3626b5f8-3-98425651,
+      _dd.appsec.fp.http.network: net-1-1000000000,
+      _dd.appsec.fp.session: ssn-5860faf0---,

1 occurrences of :

+      _dd.appsec.fp.http.endpoint: http-get-0587c50e--,
+      _dd.appsec.fp.http.header: hdr-0100000000-948f4ea1-1-4740ae63,
+      _dd.appsec.fp.http.network: net-1-1000000000,
+      _dd.appsec.fp.session: ssn----,

2 occurrences of :

+      _dd.appsec.fp.http.endpoint: http-get-0587c50e--,
+      _dd.appsec.fp.http.header: hdr-0000000000-948f4ea1-1-4740ae63,
+      _dd.appsec.fp.http.network: net-1-1000000000,
+      _dd.appsec.fp.session: ssn----,

1 occurrences of :

+      _dd.appsec.fp.http.endpoint: http-get-0587c50e--,
+      _dd.appsec.fp.http.header: hdr-0100000000-948f4ea1-3-98425651,
+      _dd.appsec.fp.http.network: net-1-1000000000,
+      _dd.appsec.fp.session: ssn----,

2 occurrences of :

+      _dd.appsec.fp.http.endpoint: http-get-0587c50e--,
+      _dd.appsec.fp.http.header: hdr-0000000000-948f4ea1-3-98425651,
+      _dd.appsec.fp.http.network: net-1-1000000000,
+      _dd.appsec.fp.session: ssn----,

2 occurrences of :

+      _dd.appsec.fp.http.endpoint: http-get-6b529abb--,
[...]
+      _dd.appsec.fp.session: ssn----,

2 occurrences of :

+      _dd.appsec.fp.http.endpoint: http-get-e7fc1c3d--,
[...]
+      _dd.appsec.fp.session: ssn----,

10 occurrences of :

+      _dd.appsec.fp.http.endpoint: http-get-7ab84831--,
[...]
+      _dd.appsec.fp.session: ssn----,

10 occurrences of :

+      _dd.appsec.fp.http.endpoint: http-get-0553e2d1--,
[...]
+      _dd.appsec.fp.session: ssn----,

10 occurrences of :

+      _dd.appsec.fp.http.endpoint: http-get-33e6044f-b25f03de-,
[...]
+      _dd.appsec.fp.session: ssn----,

10 occurrences of :

+      _dd.appsec.fp.http.endpoint: http-get-42b7ca6a-b25f03de-,
[...]
+      _dd.appsec.fp.session: ssn----,

10 occurrences of :

+      _dd.appsec.fp.http.endpoint: http-get-5ca47921-b25f03de-,
[...]
+      _dd.appsec.fp.session: ssn----,

1 occurrences of :

-      _dd.appsec.event_rules.version: 1.10.0,
+      _dd.appsec.event_rules.version: 1.13.1,
+      _dd.appsec.fp.http.endpoint: http-get-7ab84831--,
+      _dd.appsec.fp.http.header: hdr-0000000000-3626b5f8-1-4740ae63,
+      _dd.appsec.fp.http.network: net-1-1000000000,
+      _dd.appsec.fp.session: ssn----,

1 occurrences of :

-      _dd.appsec.event_rules.version: 1.10.0,
+      _dd.appsec.event_rules.version: 1.13.1,
+      _dd.appsec.fp.http.endpoint: http-get-c4cf151d--,
+      _dd.appsec.fp.http.header: hdr-0000000000-3626b5f8-1-4740ae63,
+      _dd.appsec.fp.http.network: net-1-1000000000,
+      _dd.appsec.fp.session: ssn-5860faf0---,

1 occurrences of :

-      _dd.appsec.event_rules.version: 1.10.0,
+      _dd.appsec.event_rules.version: 1.13.1,
+      _dd.appsec.fp.http.endpoint: http-get-7ab84831--,
+      _dd.appsec.fp.http.header: hdr-0000000000-3626b5f8-3-98425651,
+      _dd.appsec.fp.http.network: net-1-1000000000,
+      _dd.appsec.fp.session: ssn----,

1 occurrences of :

-      _dd.appsec.event_rules.version: 1.10.0,
+      _dd.appsec.event_rules.version: 1.13.1,
+      _dd.appsec.fp.http.endpoint: http-get-c4cf151d--,
+      _dd.appsec.fp.http.header: hdr-0000000000-3626b5f8-3-98425651,
+      _dd.appsec.fp.http.network: net-1-1000000000,
+      _dd.appsec.fp.session: ssn-5860faf0---,

1 occurrences of :

-      _dd.appsec.event_rules.version: 1.10.0,
+      _dd.appsec.event_rules.version: 1.13.1,
+      _dd.appsec.fp.http.endpoint: http-get-d2b1037e--,
+      _dd.appsec.fp.http.header: hdr-0000000000-3626b5f8-1-4740ae63,
+      _dd.appsec.fp.http.network: net-1-1000000000,
+      _dd.appsec.fp.session: ssn----,

1 occurrences of :

-      _dd.appsec.event_rules.version: 1.10.0,
+      _dd.appsec.event_rules.version: 1.13.1,
+      _dd.appsec.fp.http.endpoint: http-get-d2b1037e--,
+      _dd.appsec.fp.http.header: hdr-0000000000-3626b5f8-3-98425651,
+      _dd.appsec.fp.http.network: net-1-1000000000,
+      _dd.appsec.fp.session: ssn----,

3 occurrences of :

+      _dd.appsec.fp.http.header: hdr-0000000000-e7f19e02-1-4740ae63,
+      _dd.appsec.fp.http.network: net-1-1000000000,

@NachoEchevarria NachoEchevarria changed the title update ruleset [ASM] Update ruleset to the version 1.13.1 Oct 10, 2024
@NachoEchevarria NachoEchevarria changed the title [ASM] Update ruleset to the version 1.13.1 [ASM] Update ruleset to version 1.13.1 Oct 10, 2024
@NachoEchevarria NachoEchevarria marked this pull request as ready for review October 10, 2024 12:39
@NachoEchevarria NachoEchevarria requested review from a team as code owners October 10, 2024 12:39
@NachoEchevarria NachoEchevarria changed the title [ASM] Update ruleset to version 1.13.1 [ASM] Update ruleset to version 1.13.1 and WAF to version 1.20.0 Oct 14, 2024
andrewlock
andrewlock approved these changes Oct 15, 2024
View reviewed changes
Copy link
Member

@andrewlock andrewlock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the only APM-related change here in in Build.Steps.cs, so LGTM 👍

@NachoEchevarria
Copy link
Contributor Author

Thanks for the reviews!

@NachoEchevarria NachoEchevarria merged commit aa5cedc into master Oct 15, 2024
75 checks passed
@NachoEchevarria NachoEchevarria deleted the nacho/UpdateRuleSet branch October 15, 2024 09:59
@github-actions github-actions bot added this to the vNext-v3 milestone Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewlock andrewlock andrewlock approved these changes

@anna-git anna-git anna-git approved these changes

Assignees
No one assigned
Labels
area:asm
Projects
None yet
Milestone
3.4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@NachoEchevarria @andrewlock @anna-git