Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Profiler] Make sure Watcher thread is started before Sampler thread #6134

Merged
merged 1 commit into from
Oct 9, 2024
Merged

[Profiler] Make sure Watcher thread is started before Sampler thread #6134

merged 1 commit into from
Oct 9, 2024

Conversation

gleocadie
Copy link
Collaborator

Summary of changes

Ensure Watcher thread is started before Sampler thread.

Reason for change

We got a customer report where the app was hanged.
The Sampler thread interrupted the Main thread (because it might have executed managed code at some point or a bug in the CLR ¯\_(ツ)_/¯) and that thread was holding at least 3 locks (the loadlibrary one, one shared between RtlLookupFunctionEntry and RtlInvertedFunctionTable and one between LdrpXXX functions).
The Sampler thread interrupted the Main thread while it was holding those locks. The Sampler thread called RtlLookupFunctionEntry function and was blocked on the lock (the one taken by RtlInvertedFunctionTable).
We noticed that the Watcher thread was blocked on LdrpDrainWorkQueue (lock taken by a call to one the LdrpXX called by the Main thread)

Implementation details

Start the sampler thread iff the Watcher thread has started.

Test coverage

Other details

@gleocadie gleocadie requested a review from a team as a code owner October 9, 2024 12:47
@github-actions github-actions bot added the area:profiler Issues related to the continous-profiler label Oct 9, 2024
@gleocadie gleocadie force-pushed the gleocadie/start-sampler-thread-after-sampler-manager branch from d3c21f3 to 3b69232 Compare October 9, 2024 13:05
@datadog-ddstaging
Copy link

datadog-ddstaging bot commented Oct 9, 2024 •
edited
Loading

Datadog Report

Branch report: gleocadie/start-sampler-thread-after-sampler-manager
Commit report: 3b69232
Test service: dd-trace-dotnet

✅ 0 Failed, 363949 Passed, 2360 Skipped, 16h 25m 31.95s Total Time

@andrewlock
Copy link
Member

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6134) - mean (70ms)  : 67, 72
     .   : milestone, 70,
    master - mean (70ms)  : 68, 72
     .   : milestone, 70,

    section CallTarget+Inlining+NGEN
    This PR (6134) - mean (1,112ms)  : 1088, 1136
     .   : milestone, 1112,
    master - mean (1,134ms)  : 1024, 1245
     .   : milestone, 1134,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6134) - mean (108ms)  : 105, 111
     .   : milestone, 108,
    master - mean (109ms)  : 107, 111
     .   : milestone, 109,

    section CallTarget+Inlining+NGEN
    This PR (6134) - mean (770ms)  : 753, 787
     .   : milestone, 770,
    master - mean (786ms)  : 727, 844
     .   : milestone, 786,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6134) - mean (92ms)  : 89, 94
     .   : milestone, 92,
    master - mean (92ms)  : 90, 95
     .   : milestone, 92,

    section CallTarget+Inlining+NGEN
    This PR (6134) - mean (728ms)  : 715, 742
     .   : milestone, 728,
    master - mean (746ms)  : 688, 804
     .   : milestone, 746,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6134) - mean (190ms)  : 186, 194
     .   : milestone, 190,
    master - mean (191ms)  : 185, 196
     .   : milestone, 191,

    section CallTarget+Inlining+NGEN
    This PR (6134) - mean (1,200ms)  : 1173, 1227
     .   : milestone, 1200,
    master - mean (1,200ms)  : 1172, 1229
     .   : milestone, 1200,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6134) - mean (277ms)  : 272, 281
     .   : milestone, 277,
    master - mean (274ms)  : 267, 280
     .   : milestone, 274,

    section CallTarget+Inlining+NGEN
    This PR (6134) - mean (946ms)  : 933, 959
     .   : milestone, 946,
    master - mean (942ms)  : 924, 960
     .   : milestone, 942,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6134) - mean (266ms)  : 261, 272
     .   : milestone, 266,
    master - mean (262ms)  : 257, 266
     .   : milestone, 262,

    section CallTarget+Inlining+NGEN
    This PR (6134) - mean (932ms)  : 914, 951
     .   : milestone, 932,
    master - mean (924ms)  : 909, 940
     .   : milestone, 924,
Loading

@andrewlock
Copy link
Member

Throughput/Crank Report ⚡

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6134) (11.104M)   : 0, 11104315
    master (10.968M)   : 0, 10967703
    benchmarks/2.9.0 (11.081M)   : 0, 11080577

    section Automatic
    This PR (6134) (7.266M)   : 0, 7266031
    master (7.499M)   : 0, 7498602
    benchmarks/2.9.0 (7.732M)   : 0, 7732233

    section Trace stats
    master (7.730M)   : 0, 7730219

    section Manual
    master (10.997M)   : 0, 10997334

    section Manual + Automatic
    This PR (6134) (6.753M)   : 0, 6752881
    master (6.928M)   : 0, 6928368

    section DD_TRACE_ENABLED=0
    master (10.242M)   : 0, 10241521
Loading 
gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6134) (9.720M)   : 0, 9719872
    master (9.765M)   : 0, 9764861
    benchmarks/2.9.0 (9.798M)   : 0, 9798067

    section Automatic
    This PR (6134) (6.513M)   : 0, 6513240
    master (6.545M)   : 0, 6544657

    section Trace stats
    master (6.922M)   : 0, 6922162

    section Manual
    master (9.379M)   : 0, 9378664

    section Manual + Automatic
    This PR (6134) (5.947M)   : 0, 5946768
    master (6.036M)   : 0, 6035752

    section DD_TRACE_ENABLED=0
    master (8.760M)   : 0, 8759671
Loading 
gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6134) (10.378M)   : 0, 10377960
    master (10.044M)   : 0, 10043559
    benchmarks/2.9.0 (10.067M)   : 0, 10067315

    section Automatic
    This PR (6134) (6.905M)   : 0, 6905382
    master (6.831M)   : 0, 6830575
    benchmarks/2.9.0 (7.552M)   : 0, 7552193

    section Trace stats
    master (7.431M)   : 0, 7431125

    section Manual
    master (10.244M)   : 0, 10244304

    section Manual + Automatic
    This PR (6134) (6.422M)   : 0, 6422099
    master (6.385M)   : 0, 6385152

    section DD_TRACE_ENABLED=0
    master (9.451M)   : 0, 9451177
Loading

@andrewlock
Copy link
Member

Benchmarks Report for tracer 🐌

Benchmarks for #6134 compared to master:

  • 4 benchmarks are faster, with geometric mean 1.135
  • 4 benchmarks are slower, with geometric mean 1.161
  • 1 benchmarks have more allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 7.54μs 43.9ns 383ns 0.0115 0.00383 0 5.43 KB
master StartStopWithChild netcoreapp3.1 9.93μs 57.1ns 427ns 0.0154 0.00514 0 5.62 KB
master StartStopWithChild net472 16.7μs 77.5ns 319ns 1.02 0.3 0.105 6.06 KB
#6134 StartStopWithChild net6.0 7.7μs 42.5ns 262ns 0.0112 0.00375 0 5.43 KB
#6134 StartStopWithChild netcoreapp3.1 10.1μs 56.5ns 375ns 0.0204 0.0102 0 5.61 KB
#6134 StartStopWithChild net472 16.6μs 53.2ns 206ns 1.02 0.308 0.0915 6.08 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 488μs 452ns 1.75μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 646μs 795ns 3.08μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 839μs 561ns 2.17μs 0.417 0 0 3.3 KB
#6134 WriteAndFlushEnrichedTraces net6.0 491μs 367ns 1.37μs 0 0 0 2.7 KB
#6134 WriteAndFlushEnrichedTraces netcoreapp3.1 644μs 580ns 2.25μs 0 0 0 2.7 KB
#6134 WriteAndFlushEnrichedTraces net472 842μs 700ns 2.52μs 0.419 0 0 3.3 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 211μs 1.21μs 9.21μs 0.201 0 0 18.45 KB
master SendRequest netcoreapp3.1 229μs 1.29μs 9.04μs 0.246 0 0 20.61 KB
master SendRequest net472 0.00273ns 0.000927ns 0.00359ns 0 0 0 0 b
#6134 SendRequest net6.0 202μs 1.14μs 7.9μs 0.21 0 0 18.45 KB
#6134 SendRequest netcoreapp3.1 241μs 1.28μs 6.92μs 0.242 0 0 20.61 KB
#6134 SendRequest net472 0.00558ns 0.00188ns 0.00729ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ More allocations ⚠️

More allocations ⚠️ in #6134

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑net6.0 41.51 KB 41.81 KB 301 B 0.73%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 603μs 3.16μs 20.5μs 0.581 0 0 41.51 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 732μs 3.36μs 12.6μs 0.406 0 0 41.53 KB
master WriteAndFlushEnrichedTraces net472 856μs 3.46μs 12.9μs 8.19 2.59 0.431 53.32 KB
#6134 WriteAndFlushEnrichedTraces net6.0 623μs 3.6μs 28.4μs 0.573 0 0 41.81 KB
#6134 WriteAndFlushEnrichedTraces netcoreapp3.1 686μs 3.23μs 12.9μs 0.345 0 0 41.65 KB
#6134 WriteAndFlushEnrichedTraces net472 832μs 2.75μs 10.3μs 8.87 2.53 0.422 53.29 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.3μs 1.32ns 5.1ns 0.0144 0 0 1.02 KB
master ExecuteNonQuery netcoreapp3.1 1.8μs 1.76ns 6.82ns 0.0134 0 0 1.02 KB
master ExecuteNonQuery net472 2.09μs 1.9ns 7.37ns 0.156 0 0 987 B
#6134 ExecuteNonQuery net6.0 1.2μs 0.859ns 3.1ns 0.0145 0 0 1.02 KB
#6134 ExecuteNonQuery netcoreapp3.1 1.67μs 1.47ns 5.69ns 0.0133 0 0 1.02 KB
#6134 ExecuteNonQuery net472 2.12μs 2.81ns 10.9ns 0.156 0 0 987 B
Benchmarks.Trace.ElasticsearchBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #6134

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch‑net6.0 1.128 1,073.78 1,211.37

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.07μs 0.379ns 1.42ns 0.0135 0 0 976 B
master CallElasticsearch netcoreapp3.1 1.5μs 1.93ns 7.48ns 0.0136 0 0 976 B
master CallElasticsearch net472 2.53μs 1.22ns 4.58ns 0.158 0 0 995 B
master CallElasticsearchAsync net6.0 1.21μs 0.576ns 2.16ns 0.0133 0 0 952 B
master CallElasticsearchAsync netcoreapp3.1 1.57μs 0.915ns 3.42ns 0.0141 0 0 1.02 KB
master CallElasticsearchAsync net472 2.63μs 0.979ns 3.79ns 0.166 0 0 1.05 KB
#6134 CallElasticsearch net6.0 1.21μs 0.687ns 2.57ns 0.014 0 0 976 B
#6134 CallElasticsearch netcoreapp3.1 1.58μs 0.783ns 3.03ns 0.0134 0 0 976 B
#6134 CallElasticsearch net472 2.57μs 1.98ns 7.68ns 0.158 0 0 995 B
#6134 CallElasticsearchAsync net6.0 1.22μs 0.664ns 2.57ns 0.013 0 0 952 B
#6134 CallElasticsearchAsync netcoreapp3.1 1.64μs 2.06ns 7.7ns 0.0139 0 0 1.02 KB
#6134 CallElasticsearchAsync net472 2.61μs 2.13ns 8.25ns 0.167 0 0 1.05 KB
Benchmarks.Trace.GraphQLBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #6134

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync‑net6.0 1.140 1,306.51 1,145.75

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.31μs 0.753ns 2.82ns 0.0137 0 0 952 B
master ExecuteAsync netcoreapp3.1 1.61μs 0.579ns 2.16ns 0.0128 0 0 952 B
master ExecuteAsync net472 1.83μs 0.916ns 3.55ns 0.144 0 0 915 B
#6134 ExecuteAsync net6.0 1.15μs 0.775ns 3ns 0.0131 0 0 952 B
#6134 ExecuteAsync netcoreapp3.1 1.59μs 0.562ns 2.03ns 0.0129 0 0 952 B
#6134 ExecuteAsync net472 1.88μs 0.486ns 1.75ns 0.145 0 0 915 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 4.19μs 1.48ns 5.12ns 0.0314 0 0 2.22 KB
master SendAsync netcoreapp3.1 5.19μs 1.05ns 3.92ns 0.0364 0 0 2.76 KB
master SendAsync net472 7.84μs 2.12ns 7.92ns 0.497 0 0 3.15 KB
#6134 SendAsync net6.0 4.15μs 1.92ns 6.91ns 0.0311 0 0 2.22 KB
#6134 SendAsync netcoreapp3.1 5.06μs 2.18ns 8.45ns 0.0379 0 0 2.76 KB
#6134 SendAsync net472 7.82μs 2.36ns 9.16ns 0.499 0 0 3.15 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 1.48μs 0.465ns 1.61ns 0.023 0 0 1.64 KB
master EnrichedLog netcoreapp3.1 2.34μs 0.747ns 2.69ns 0.0227 0 0 1.64 KB
master EnrichedLog net472 2.6μs 0.764ns 2.96ns 0.249 0 0 1.57 KB
#6134 EnrichedLog net6.0 1.5μs 0.663ns 2.39ns 0.0228 0 0 1.64 KB
#6134 EnrichedLog netcoreapp3.1 2.18μs 0.718ns 2.59ns 0.0219 0 0 1.64 KB
#6134 EnrichedLog net472 2.52μs 0.665ns 2.4ns 0.25 0 0 1.57 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 116μs 289ns 1.12μs 0.0578 0 0 4.28 KB
master EnrichedLog netcoreapp3.1 118μs 164ns 615ns 0.0588 0 0 4.28 KB
master EnrichedLog net472 146μs 102ns 394ns 0.655 0.218 0 4.46 KB
#6134 EnrichedLog net6.0 114μs 146ns 565ns 0.057 0 0 4.28 KB
#6134 EnrichedLog netcoreapp3.1 119μs 86.4ns 323ns 0 0 0 4.28 KB
#6134 EnrichedLog net472 147μs 129ns 501ns 0.659 0.22 0 4.46 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 3.01μs 0.78ns 3.02ns 0.0301 0 0 2.2 KB
master EnrichedLog netcoreapp3.1 4.08μs 1.71ns 6.41ns 0.0285 0 0 2.2 KB
master EnrichedLog net472 4.9μs 0.996ns 3.86ns 0.319 0 0 2.02 KB
#6134 EnrichedLog net6.0 3.02μs 0.56ns 2.17ns 0.03 0 0 2.2 KB
#6134 EnrichedLog netcoreapp3.1 4.14μs 2.16ns 8.35ns 0.0291 0 0 2.2 KB
#6134 EnrichedLog net472 4.9μs 0.918ns 3.56ns 0.318 0 0 2.02 KB
Benchmarks.Trace.RedisBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #6134

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.RedisBenchmark.SendReceive‑net6.0 1.125 1,396.69 1,240.97

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 1.4μs 0.736ns 2.85ns 0.016 0 0 1.14 KB
master SendReceive netcoreapp3.1 1.82μs 2.96ns 11.5ns 0.0154 0 0 1.14 KB
master SendReceive net472 2.21μs 0.526ns 1.9ns 0.183 0.0011 0 1.16 KB
#6134 SendReceive net6.0 1.24μs 1.59ns 6.15ns 0.0162 0 0 1.14 KB
#6134 SendReceive netcoreapp3.1 1.76μs 1.7ns 6.58ns 0.0158 0 0 1.14 KB
#6134 SendReceive net472 2.09μs 0.61ns 2.2ns 0.183 0.00105 0 1.16 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.74μs 0.773ns 2.99ns 0.0219 0 0 1.6 KB
master EnrichedLog netcoreapp3.1 3.94μs 0.926ns 3.46ns 0.0216 0 0 1.65 KB
master EnrichedLog net472 4.49μs 2.79ns 10.8ns 0.322 0 0 2.04 KB
#6134 EnrichedLog net6.0 2.9μs 1.14ns 4.4ns 0.0218 0 0 1.6 KB
#6134 EnrichedLog netcoreapp3.1 3.89μs 1.87ns 7.26ns 0.0214 0 0 1.65 KB
#6134 EnrichedLog net472 4.55μs 3.01ns 11.7ns 0.323 0 0 2.04 KB
Benchmarks.Trace.SpanBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #6134

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net6.0 1.151 486.72 560.43
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net6.0 1.128 403.03 454.58

Faster 🎉 in #6134

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net472 1.147 653.59 569.58

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 403ns 0.202ns 0.782ns 0.00811 0 0 576 B
master StartFinishSpan netcoreapp3.1 552ns 0.462ns 1.79ns 0.00801 0 0 576 B
master StartFinishSpan net472 656ns 1.33ns 5.16ns 0.0917 0 0 578 B
master StartFinishScope net6.0 487ns 0.204ns 0.708ns 0.00974 0 0 696 B
master StartFinishScope netcoreapp3.1 764ns 1.43ns 5.53ns 0.00966 0 0 696 B
master StartFinishScope net472 882ns 0.658ns 2.55ns 0.104 0 0 658 B
#6134 StartFinishSpan net6.0 455ns 0.189ns 0.733ns 0.00801 0 0 576 B
#6134 StartFinishSpan netcoreapp3.1 594ns 0.674ns 2.52ns 0.00794 0 0 576 B
#6134 StartFinishSpan net472 570ns 0.72ns 2.79ns 0.0917 0 0 578 B
#6134 StartFinishScope net6.0 560ns 0.228ns 0.852ns 0.00978 0 0 696 B
#6134 StartFinishScope netcoreapp3.1 742ns 1.32ns 4.95ns 0.00931 0 0 696 B
#6134 StartFinishScope net472 843ns 0.458ns 1.71ns 0.104 0 0 658 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #6134

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net6.0 1.241 587.31 728.74

Faster 🎉 in #6134

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑netcoreapp3.1 1.127 979.89 869.64

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 587ns 0.19ns 0.712ns 0.00979 0 0 696 B
master RunOnMethodBegin netcoreapp3.1 979ns 0.418ns 1.56ns 0.00928 0 0 696 B
master RunOnMethodBegin net472 1.12μs 1.58ns 6.12ns 0.104 0 0 658 B
#6134 RunOnMethodBegin net6.0 729ns 0.253ns 0.948ns 0.00986 0 0 696 B
#6134 RunOnMethodBegin netcoreapp3.1 869ns 0.524ns 2.03ns 0.00954 0 0 696 B
#6134 RunOnMethodBegin net472 1.07μs 0.487ns 1.76ns 0.104 0 0 658 B

chrisnas
chrisnas approved these changes Oct 9, 2024
View reviewed changes
Copy link
Contributor

@chrisnas chrisnas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gleocadie gleocadie merged commit 88badd0 into master Oct 9, 2024
80 of 82 checks passed
@gleocadie gleocadie deleted the gleocadie/start-sampler-thread-after-sampler-manager branch October 9, 2024 14:31
@github-actions github-actions bot added this to the vNext-v3 milestone Oct 9, 2024
@andrewlock andrewlock mentioned this pull request Oct 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisnas chrisnas chrisnas approved these changes

Assignees
No one assigned
Labels
area:profiler Issues related to the continous-profiler identified-by:customer type:bug
Projects
None yet
Milestone
3.4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@gleocadie @andrewlock @chrisnas