Add support for the "new" dev.azure.com style URLs in SourceLink URL parsing logic #6159

OmerRaviv · 2024-10-16T04:14:50Z

Summary of changes

Fixes #6146

Backported to 2.x in #6178

Reason for change

Customer reported an issue where the tracer reports incorrect git.repository_url as a result of this bug.

Test coverage

Add a new test case.

datadog-ddstaging · 2024-10-16T04:33:56Z

Datadog Report

Branch report: omerr/fix-sourcelink-azure-devops-dev-urls
Commit report: b4db927
Test service: dd-trace-dotnet

✅ 0 Failed, 371628 Passed, 2103 Skipped, 15h 4m 34.34s Total Time
⌛ 1 Performance Regression

⌛ Performance Regressions vs Default Branch (1)

Profiler_cpu_walltime - scenarios 3.54s (+214.99ms, +6%) - Details

andrewlock

Thanks! Just a couple of nits (let me know if you'd like me to take care of those!)

tracer/src/Datadog.Trace/PDBs/SourceLink/AzureDevOpsSourceLinkUrlParser.cs

andrewlock · 2024-10-17T04:01:57Z

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

Welch test with statistical test for significance of 5%
Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6159) - mean (70ms)  : 68, 72
     .   : milestone, 70,
    master - mean (70ms)  : 66, 74
     .   : milestone, 70,

    section CallTarget+Inlining+NGEN
    This PR (6159) - mean (1,113ms)  : 1094, 1132
     .   : milestone, 1113,
    master - mean (1,113ms)  : 1078, 1148
     .   : milestone, 1113,

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6159) - mean (109ms)  : 105, 113
     .   : milestone, 109,
    master - mean (109ms)  : 107, 112
     .   : milestone, 109,

    section CallTarget+Inlining+NGEN
    This PR (6159) - mean (771ms)  : 752, 790
     .   : milestone, 771,
    master - mean (770ms)  : 751, 789
     .   : milestone, 770,

gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6159) - mean (92ms)  : 90, 94
     .   : milestone, 92,
    master - mean (92ms)  : 90, 95
     .   : milestone, 92,

    section CallTarget+Inlining+NGEN
    This PR (6159) - mean (729ms)  : 710, 748
     .   : milestone, 729,
    master - mean (728ms)  : 710, 746
     .   : milestone, 728,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6159) - mean (191ms)  : 188, 194
     .   : milestone, 191,
    master - mean (191ms)  : 186, 195
     .   : milestone, 191,

    section CallTarget+Inlining+NGEN
    This PR (6159) - mean (1,207ms)  : 1187, 1227
     .   : milestone, 1207,
    master - mean (1,202ms)  : 1183, 1221
     .   : milestone, 1202,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6159) - mean (277ms)  : 273, 281
     .   : milestone, 277,
    master - mean (275ms)  : 271, 280
     .   : milestone, 275,

    section CallTarget+Inlining+NGEN
    This PR (6159) - mean (947ms)  : 927, 967
     .   : milestone, 947,
    master - mean (944ms)  : 922, 966
     .   : milestone, 944,

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6159) - mean (265ms)  : 261, 268
     .   : milestone, 265,
    master - mean (265ms)  : 260, 270
     .   : milestone, 265,

    section CallTarget+Inlining+NGEN
    This PR (6159) - mean (929ms)  : 911, 948
     .   : milestone, 929,
    master - mean (927ms)  : 906, 947
     .   : milestone, 927,

andrewlock · 2024-10-17T05:02:05Z

Throughput/Crank Report ⚡

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6159) (10.968M)   : 0, 10968128
    master (11.101M)   : 0, 11100941
    benchmarks/2.9.0 (11.081M)   : 0, 11080577

    section Automatic
    This PR (6159) (7.427M)   : 0, 7427216
    master (7.389M)   : 0, 7389242
    benchmarks/2.9.0 (7.732M)   : 0, 7732233

    section Trace stats
    master (7.528M)   : 0, 7528321

    section Manual
    master (10.986M)   : 0, 10986040

    section Manual + Automatic
    This PR (6159) (6.949M)   : 0, 6949417
    master (6.820M)   : 0, 6819504

    section DD_TRACE_ENABLED=0
    master (10.304M)   : 0, 10304285

gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6159) (9.515M)   : 0, 9515336
    master (9.728M)   : 0, 9727588
    benchmarks/2.9.0 (9.798M)   : 0, 9798067

    section Automatic
    This PR (6159) (6.679M)   : 0, 6679155
    master (6.463M)   : 0, 6463228

    section Trace stats
    master (6.591M)   : 0, 6591023

    section Manual
    master (9.627M)   : 0, 9627166

    section Manual + Automatic
    This PR (6159) (6.070M)   : 0, 6070293
    master (6.028M)   : 0, 6027833

    section DD_TRACE_ENABLED=0
    master (8.762M)   : 0, 8761785

gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6159) (9.749M)   : 0, 9749215
    master (9.966M)   : 0, 9965554
    benchmarks/2.9.0 (10.067M)   : 0, 10067315

    section Automatic
    This PR (6159) (6.401M)   : 0, 6401159
    master (6.494M)   : 0, 6493647
    benchmarks/2.9.0 (7.552M)   : 0, 7552193

    section Trace stats
    master (7.096M)   : 0, 7096492

    section Manual
    master (9.850M)   : 0, 9850046

    section Manual + Automatic
    This PR (6159) (6.022M)   : 0, 6021713
    master (5.952M)   : 0, 5952386

    section DD_TRACE_ENABLED=0
    master (9.119M)   : 0, 9118624

andrewlock · 2024-10-17T09:25:28Z

Benchmarks Report for tracer 🐌

Benchmarks for #6159 compared to master:

4 benchmarks are faster, with geometric mean 1.164
1 benchmarks have fewer allocations

The following thresholds were used for comparing the benchmark speeds:

Mann–Whitney U test with statistical test for significance of 5%
Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`StartStopWithChild`	net6.0	7.93μs	40.4ns	181ns	0.0152	0.00758	0	5.43 KB
master	`StartStopWithChild`	netcoreapp3.1	9.87μs	53.1ns	340ns	0.0143	0.00477	0	5.62 KB
master	`StartStopWithChild`	net472	16.5μs	70.4ns	273ns	1.04	0.324	0.0971	6.07 KB
#6159	`StartStopWithChild`	net6.0	7.74μs	44.3ns	332ns	0.0158	0.00789	0	5.42 KB
#6159	`StartStopWithChild`	netcoreapp3.1	9.97μs	54.7ns	328ns	0.0189	0.00946	0	5.62 KB
#6159	`StartStopWithChild`	net472	16.2μs	59.8ns	231ns	1.01	0.29	0.0965	6.07 KB

Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	492μs	211ns	761ns	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	638μs	1.29μs	4.83μs	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	net472	832μs	362ns	1.4μs	0.417	3.3 KB
#6159	`WriteAndFlushEnrichedTraces`	net6.0	473μs	287ns	1.07μs	0	2.7 KB
#6159	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	653μs	409ns	1.53μs	0	2.7 KB
#6159	`WriteAndFlushEnrichedTraces`	net472	842μs	537ns	2.01μs	0.419	3.3 KB

Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendRequest`	net6.0	213μs	1.21μs	8.5μs	0.201	18.45 KB
master	`SendRequest`	netcoreapp3.1	221μs	1.25μs	9.01μs	0.215	20.61 KB
master	`SendRequest`	net472	0.00364ns	0.00143ns	0.00535ns	0	0 b
#6159	`SendRequest`	net6.0	197μs	1.06μs	5.72μs	0.192	18.45 KB
#6159	`SendRequest`	netcoreapp3.1	237μs	1.36μs	11μs	0.231	20.61 KB
#6159	`SendRequest`	net472	0.000308ns	0.000224ns	0.000806ns	0	0 b

Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #6159

Benchmark	Base Allocated	Diff Allocated	Change	Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑netcoreapp3.1	41.95 KB	41.68 KB	-268 B	-0.64%

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	571μs	2.93μs	13.8μs	0.553	0	0	41.63 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	668μs	3.2μs	12.4μs	0.322	0	0	41.95 KB
master	`WriteAndFlushEnrichedTraces`	net472	862μs	2.99μs	11.2μs	8.13	2.57	0.428	53.34 KB
#6159	`WriteAndFlushEnrichedTraces`	net6.0	570μs	2.93μs	14μs	0.573	0	0	41.53 KB
#6159	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	704μs	3.84μs	21.7μs	0.336	0	0	41.68 KB
#6159	`WriteAndFlushEnrichedTraces`	net472	867μs	3.89μs	15.1μs	8.19	2.59	0.431	53.3 KB

Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`ExecuteNonQuery`	net6.0	1.2μs	1.67ns	6.25ns	0.0143	1.02 KB
master	`ExecuteNonQuery`	netcoreapp3.1	1.7μs	1.98ns	7.68ns	0.0136	1.02 KB
master	`ExecuteNonQuery`	net472	2.16μs	1.76ns	6.6ns	0.157	987 B
#6159	`ExecuteNonQuery`	net6.0	1.32μs	1.16ns	4.48ns	0.0146	1.02 KB
#6159	`ExecuteNonQuery`	netcoreapp3.1	1.76μs	0.679ns	2.45ns	0.0133	1.02 KB
#6159	`ExecuteNonQuery`	net472	2.08μs	1.66ns	5.98ns	0.156	987 B

Benchmarks.Trace.ElasticsearchBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #6159

Benchmark	base/diff	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync‑net6.0	1.183	1,449.72	1,224.95

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`CallElasticsearch`	net6.0	1.23μs	0.31ns	1.16ns	0.0136	976 B
master	`CallElasticsearch`	netcoreapp3.1	1.5μs	1.08ns	4.18ns	0.0127	976 B
master	`CallElasticsearch`	net472	2.48μs	1.57ns	5.86ns	0.158	995 B
master	`CallElasticsearchAsync`	net6.0	1.45μs	0.762ns	2.95ns	0.0138	952 B
master	`CallElasticsearchAsync`	netcoreapp3.1	1.66μs	0.56ns	2.02ns	0.0141	1.02 KB
master	`CallElasticsearchAsync`	net472	2.55μs	0.914ns	3.42ns	0.167	1.05 KB
#6159	`CallElasticsearch`	net6.0	1.19μs	0.925ns	3.58ns	0.0139	976 B
#6159	`CallElasticsearch`	netcoreapp3.1	1.46μs	0.601ns	2.25ns	0.0131	976 B
#6159	`CallElasticsearch`	net472	2.42μs	1.27ns	4.91ns	0.158	995 B
#6159	`CallElasticsearchAsync`	net6.0	1.22μs	1.4ns	5.41ns	0.0135	952 B
#6159	`CallElasticsearchAsync`	netcoreapp3.1	1.63μs	0.522ns	2.02ns	0.0138	1.02 KB
#6159	`CallElasticsearchAsync`	net472	2.6μs	1.38ns	5.17ns	0.167	1.05 KB

Benchmarks.Trace.GraphQLBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #6159

Benchmark	base/diff	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync‑net6.0	1.169	1,386.86	1,186.86

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`ExecuteAsync`	net6.0	1.39μs	0.538ns	2.01ns	0.0133	0	952 B
master	`ExecuteAsync`	netcoreapp3.1	1.55μs	1.95ns	7.56ns	0.0125	0	952 B
master	`ExecuteAsync`	net472	1.87μs	0.402ns	1.5ns	0.145	0.000936	915 B
#6159	`ExecuteAsync`	net6.0	1.19μs	0.824ns	3.08ns	0.0136	0	952 B
#6159	`ExecuteAsync`	netcoreapp3.1	1.57μs	1.05ns	3.92ns	0.0125	0	952 B
#6159	`ExecuteAsync`	net472	1.9μs	1.67ns	6.45ns	0.145	0	915 B

Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendAsync`	net6.0	4.17μs	2.03ns	7.85ns	0.0312	2.22 KB
master	`SendAsync`	netcoreapp3.1	5.13μs	1.59ns	5.73ns	0.036	2.76 KB
master	`SendAsync`	net472	7.84μs	2.64ns	10.2ns	0.5	3.15 KB
#6159	`SendAsync`	net6.0	4.27μs	2.91ns	10.9ns	0.03	2.22 KB
#6159	`SendAsync`	netcoreapp3.1	5.21μs	3.42ns	12.8ns	0.0363	2.76 KB
#6159	`SendAsync`	net472	7.83μs	2.36ns	8.84ns	0.498	3.15 KB

Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	1.54μs	0.751ns	2.91ns	0.0231	1.64 KB
master	`EnrichedLog`	netcoreapp3.1	2.41μs	1.42ns	5.48ns	0.0224	1.64 KB
master	`EnrichedLog`	net472	2.65μs	0.863ns	3.23ns	0.249	1.57 KB
#6159	`EnrichedLog`	net6.0	1.44μs	0.749ns	2.8ns	0.0232	1.64 KB
#6159	`EnrichedLog`	netcoreapp3.1	2.28μs	1.1ns	4.11ns	0.0216	1.64 KB
#6159	`EnrichedLog`	net472	2.61μs	0.787ns	3.05ns	0.249	1.57 KB

Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`EnrichedLog`	net6.0	116μs	305ns	1.18μs	0	0	4.28 KB
master	`EnrichedLog`	netcoreapp3.1	122μs	122ns	457ns	0.0613	0	4.28 KB
master	`EnrichedLog`	net472	152μs	169ns	653ns	0.679	0.226	4.46 KB
#6159	`EnrichedLog`	net6.0	115μs	198ns	767ns	0.0579	0	4.28 KB
#6159	`EnrichedLog`	netcoreapp3.1	123μs	186ns	721ns	0.0608	0	4.28 KB
#6159	`EnrichedLog`	net472	152μs	101ns	392ns	0.686	0.229	4.46 KB

Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	3.17μs	0.983ns	3.81ns	0.0316	2.2 KB
master	`EnrichedLog`	netcoreapp3.1	4.2μs	3.55ns	13.7ns	0.0295	2.2 KB
master	`EnrichedLog`	net472	4.85μs	1.37ns	5.3ns	0.319	2.02 KB
#6159	`EnrichedLog`	net6.0	3.13μs	0.889ns	3.33ns	0.0298	2.2 KB
#6159	`EnrichedLog`	netcoreapp3.1	4.29μs	1.51ns	5.83ns	0.0279	2.2 KB
#6159	`EnrichedLog`	net472	5.05μs	1.78ns	6.88ns	0.319	2.02 KB

Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`SendReceive`	net6.0	1.37μs	1.12ns	4.18ns	0.0163	0	1.14 KB
master	`SendReceive`	netcoreapp3.1	1.82μs	0.877ns	3.28ns	0.0154	0	1.14 KB
master	`SendReceive`	net472	2.04μs	0.944ns	3.66ns	0.184	0.00102	1.16 KB
#6159	`SendReceive`	net6.0	1.5μs	1.31ns	4.91ns	0.0158	0	1.14 KB
#6159	`SendReceive`	netcoreapp3.1	1.82μs	1.03ns	3.84ns	0.0149	0	1.14 KB
#6159	`SendReceive`	net472	2.1μs	1.11ns	4.29ns	0.183	0	1.16 KB

Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	2.92μs	1.39ns	5.38ns	0.0219	1.6 KB
master	`EnrichedLog`	netcoreapp3.1	3.93μs	1.16ns	4.19ns	0.0217	1.65 KB
master	`EnrichedLog`	net472	4.47μs	5.69ns	22ns	0.322	2.04 KB
#6159	`EnrichedLog`	net6.0	2.76μs	1ns	3.88ns	0.022	1.6 KB
#6159	`EnrichedLog`	netcoreapp3.1	3.87μs	1.35ns	5.23ns	0.0213	1.65 KB
#6159	`EnrichedLog`	net472	4.3μs	1.27ns	4.74ns	0.322	2.04 KB

Benchmarks.Trace.SpanBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #6159

Benchmark	base/diff	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net6.0	1.180	564.30	478.25
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net6.0	1.127	454.03	403.03

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`StartFinishSpan`	net6.0	454ns	0.274ns	1.06ns	0.00811	576 B
master	`StartFinishSpan`	netcoreapp3.1	623ns	0.578ns	2.16ns	0.00774	576 B
master	`StartFinishSpan`	net472	715ns	0.61ns	2.36ns	0.0918	578 B
master	`StartFinishScope`	net6.0	562ns	1.85ns	7.16ns	0.00965	696 B
master	`StartFinishScope`	netcoreapp3.1	719ns	1.24ns	4.63ns	0.00949	696 B
master	`StartFinishScope`	net472	890ns	0.674ns	2.52ns	0.105	658 B
#6159	`StartFinishSpan`	net6.0	403ns	0.22ns	0.851ns	0.008	576 B
#6159	`StartFinishSpan`	netcoreapp3.1	590ns	0.404ns	1.57ns	0.00784	576 B
#6159	`StartFinishSpan`	net472	713ns	0.822ns	3.18ns	0.0917	578 B
#6159	`StartFinishScope`	net6.0	478ns	0.224ns	0.807ns	0.00982	696 B
#6159	`StartFinishScope`	netcoreapp3.1	730ns	0.508ns	1.97ns	0.0096	696 B
#6159	`StartFinishScope`	net472	869ns	0.789ns	2.85ns	0.104	658 B

Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`RunOnMethodBegin`	net6.0	667ns	0.353ns	1.37ns	0.00988	696 B
master	`RunOnMethodBegin`	netcoreapp3.1	925ns	0.469ns	1.82ns	0.00934	696 B
master	`RunOnMethodBegin`	net472	1.15μs	1.04ns	4.02ns	0.104	658 B
#6159	`RunOnMethodBegin`	net6.0	675ns	0.457ns	1.77ns	0.00983	696 B
#6159	`RunOnMethodBegin`	netcoreapp3.1	925ns	0.394ns	1.52ns	0.00944	696 B
#6159	`RunOnMethodBegin`	net472	1.09μs	0.642ns	2.4ns	0.104	658 B

dudikeleti

LGTM - I left one nit comment

dudikeleti · 2024-10-17T14:26:42Z

tracer/src/Datadog.Trace/PDBs/SourceLink/AzureDevOpsSourceLinkUrlParser.cs

@@ -46,15 +53,15 @@ internal override bool TryParseSourceLinkUrl(Uri uri, [NotNullWhen(true)] out st
                return false;
            }

-            var segments = uri.AbsolutePath.Split(new[] { '/' }, StringSplitOptions.RemoveEmptyEntries);
+            var segments = uri.AbsolutePath.Split(new char[] { '/' }, StringSplitOptions.RemoveEmptyEntries);


Can we remove this split and the following check and do it only in BuildRepositoryUrl(uri) ?

…re DevOps URL

…parsing logic (#6159) ## Summary of changes Fixes #6146 ## Reason for change Customer reported an issue where the tracer reports incorrect `git.repository_url` as a result of this bug. ## Test coverage Add a new test case.

…parsing logic (#6159 => v2) (#6178) ## Summary of changes Fixes #6146 2.x backport of #6159 ## Reason for change Customer reported an issue where the tracer reports incorrect `git.repository_url` as a result of this bug. ## Test coverage Add a new test case. Co-authored-by: Omer Raviv <omer.raviv@datadoghq.com>

OmerRaviv requested review from a team as code owners October 16, 2024 04:14

andrewlock approved these changes Oct 16, 2024

View reviewed changes

tracer/src/Datadog.Trace/PDBs/SourceLink/AzureDevOpsSourceLinkUrlParser.cs Outdated Show resolved Hide resolved

tracer/src/Datadog.Trace/PDBs/SourceLink/AzureDevOpsSourceLinkUrlParser.cs Outdated Show resolved Hide resolved

OmerRaviv force-pushed the omerr/fix-sourcelink-azure-devops-dev-urls branch 2 times, most recently from 7f31392 to cf0c1f9 Compare October 17, 2024 03:26

OmerRaviv force-pushed the omerr/fix-sourcelink-azure-devops-dev-urls branch from cf0c1f9 to 58527e4 Compare October 17, 2024 14:23

dudikeleti approved these changes Oct 17, 2024

View reviewed changes

OmerRaviv added 3 commits October 21, 2024 21:23

Fix #6146, add support for the "new" dev.azure.com style URLs

e75dbf3

Avoid throwing an exception when there is an unrecognized host in Azu…

0551f93

…re DevOps URL

Address PR feedback - remove redundant check

b4db927

OmerRaviv force-pushed the omerr/fix-sourcelink-azure-devops-dev-urls branch from 413fb04 to b4db927 Compare October 22, 2024 01:23

andrewlock approved these changes Oct 22, 2024

View reviewed changes

andrewlock merged commit 434015e into master Oct 22, 2024
75 checks passed

andrewlock deleted the omerr/fix-sourcelink-azure-devops-dev-urls branch October 22, 2024 16:46

github-actions bot added this to the vNext-v3 milestone Oct 22, 2024

andrewlock added area:tracer The core tracer library (Datadog.Trace, does not include OpenTracing, native code, or integrations) type:bug labels Oct 22, 2024

lucaspimentel mentioned this pull request Oct 22, 2024

Add support for the "new" dev.azure.com style URLs in SourceLink URL parsing logic (#6159 => v2) #6178

Merged

andrewlock added the identified-by:customer label Oct 23, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for the "new" dev.azure.com style URLs in SourceLink URL parsing logic #6159

Add support for the "new" dev.azure.com style URLs in SourceLink URL parsing logic #6159

OmerRaviv commented Oct 16, 2024 •

edited by lucaspimentel

Loading

datadog-ddstaging bot commented Oct 16, 2024 •

edited

Loading

andrewlock left a comment

andrewlock commented Oct 17, 2024 •

edited

Loading

andrewlock commented Oct 17, 2024 •

edited

Loading

andrewlock commented Oct 17, 2024 •

edited

Loading

Raw results

Raw results

Raw results

Fewer allocations 🎉 in #6159

Raw results

Raw results

Faster 🎉 in #6159

Raw results

Faster 🎉 in #6159

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Faster 🎉 in #6159

Raw results

Raw results

dudikeleti left a comment

dudikeleti Oct 17, 2024

Add support for the "new" dev.azure.com style URLs in SourceLink URL parsing logic #6159

Add support for the "new" dev.azure.com style URLs in SourceLink URL parsing logic #6159

Conversation

OmerRaviv commented Oct 16, 2024 • edited by lucaspimentel Loading

Summary of changes

Reason for change

Test coverage

datadog-ddstaging bot commented Oct 16, 2024 • edited Loading

Datadog Report

⌛ Performance Regressions vs Default Branch (1)

andrewlock left a comment

Choose a reason for hiding this comment

andrewlock commented Oct 17, 2024 • edited Loading

Execution-Time Benchmarks Report ⏱️

andrewlock commented Oct 17, 2024 • edited Loading

Throughput/Crank Report ⚡

andrewlock commented Oct 17, 2024 • edited Loading

Benchmarks Report for tracer 🐌

Benchmark details

Raw results

Raw results

Raw results

Fewer allocations 🎉 in #6159

Raw results

Raw results

Faster 🎉 in #6159

Raw results

Faster 🎉 in #6159

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Faster 🎉 in #6159

Raw results

Raw results

dudikeleti left a comment

Choose a reason for hiding this comment

dudikeleti Oct 17, 2024

Choose a reason for hiding this comment

OmerRaviv commented Oct 16, 2024 •

edited by lucaspimentel

Loading

datadog-ddstaging bot commented Oct 16, 2024 •

edited

Loading

andrewlock commented Oct 17, 2024 •

edited

Loading

andrewlock commented Oct 17, 2024 •

edited

Loading

andrewlock commented Oct 17, 2024 •

edited

Loading