Add SSI denylist and tests (#5928 => v2) #6182

andrewlock · 2024-10-23T08:49:13Z

Summary of changes

Adds the SSI denylist and initial testing

Reason for change

We want to bail out early if we don't support the platform.

Implementation details

Add a requirements.json file that specifies supported hosts and some of the patterns we expect to block or allow injection on

Test coverage

This includes a requirements_json_test stage. This will be ported to the one-pipeline once the auto_inject code is merged, this is a PoC that proves it works atm

Other details

Backport of #5928

## Summary of changes Adds the SSI denylist and initial testing ## Reason for change We want to bail out early if we don't support the platform. ## Implementation details Add a requirements.json file that specifies supported hosts and some of the patterns we expect to block or allow injection on ## Test coverage This includes a `requirements_json_test` stage. This will be ported to the one-pipeline once the `auto_inject` code is merged, this is a PoC that proves it works atm ## Other details Will backport this to 2.x as well

andrewlock · 2024-10-23T09:15:01Z

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

Welch test with statistical test for significance of 5%
Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6182) - mean (72ms)  : 67, 78
     .   : milestone, 72,
    master - mean (71ms)  : 68, 75
     .   : milestone, 71,

    section CallTarget+Inlining+NGEN
    This PR (6182) - mean (1,028ms)  : 1008, 1048
     .   : milestone, 1028,
    master - mean (1,120ms)  : 1092, 1149
     .   : milestone, 1120,

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6182) - mean (110ms)  : 107, 113
     .   : milestone, 110,
    master - mean (109ms)  : 107, 112
     .   : milestone, 109,

    section CallTarget+Inlining+NGEN
    This PR (6182) - mean (705ms)  : 683, 727
     .   : milestone, 705,
    master - mean (776ms)  : 757, 795
     .   : milestone, 776,

gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6182) - mean (94ms)  : 89, 99
     .   : milestone, 94,
    master - mean (93ms)  : 89, 97
     .   : milestone, 93,

    section CallTarget+Inlining+NGEN
    This PR (6182) - mean (664ms)  : 644, 684
     .   : milestone, 664,
    master - mean (728ms)  : 710, 746
     .   : milestone, 728,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6182) - mean (191ms)  : 188, 194
     .   : milestone, 191,
    master - mean (190ms)  : 187, 193
     .   : milestone, 190,

    section CallTarget+Inlining+NGEN
    This PR (6182) - mean (1,113ms)  : 1092, 1135
     .   : milestone, 1113,
    master - mean (1,193ms)  : 1168, 1218
     .   : milestone, 1193,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6182) - mean (278ms)  : 272, 283
     .   : milestone, 278,
    master - mean (275ms)  : 270, 279
     .   : milestone, 275,

    section CallTarget+Inlining+NGEN
    This PR (6182) - mean (873ms)  : 848, 897
     .   : milestone, 873,
    master - mean (943ms)  : 924, 961
     .   : milestone, 943,

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6182) - mean (266ms)  : 261, 271
     .   : milestone, 266,
    master - mean (264ms)  : 260, 268
     .   : milestone, 264,

    section CallTarget+Inlining+NGEN
    This PR (6182) - mean (858ms)  : 838, 877
     .   : milestone, 858,
    master - mean (923ms)  : 907, 938
     .   : milestone, 923,

andrewlock · 2024-10-23T10:00:30Z

Benchmarks Report for tracer 🐌

Benchmarks for #6182 compared to master:

1 benchmarks are faster, with geometric mean 1.117
1 benchmarks have fewer allocations

The following thresholds were used for comparing the benchmark speeds:

Mann–Whitney U test with statistical test for significance of 5%
Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`StartStopWithChild`	net6.0	7.59μs	43ns	292ns	0.0268	0.0153	0.00383	5.42 KB
master	`StartStopWithChild`	netcoreapp3.1	9.82μs	51.6ns	253ns	0.0204	0.0102	0	5.62 KB
master	`StartStopWithChild`	net472	16.4μs	55.4ns	215ns	1.01	0.304	0.0904	6.06 KB
#6182	`StartStopWithChild`	net6.0	7.67μs	43.2ns	283ns	0.0114	0.0076	0	5.43 KB
#6182	`StartStopWithChild`	netcoreapp3.1	9.87μs	53ns	276ns	0.0192	0.0048	0	5.62 KB
#6182	`StartStopWithChild`	net472	16.3μs	51.2ns	198ns	1.03	0.321	0.0905	6.07 KB

Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	482μs	225ns	841ns	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	632μs	284ns	1.1μs	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	net472	841μs	324ns	1.21μs	0.417	3.3 KB
#6182	`WriteAndFlushEnrichedTraces`	net6.0	470μs	552ns	2.14μs	0	2.7 KB
#6182	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	634μs	316ns	1.18μs	0	2.7 KB
#6182	`WriteAndFlushEnrichedTraces`	net472	832μs	571ns	2.21μs	0.417	3.3 KB

Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendRequest`	net6.0	202μs	1.15μs	11.3μs	0.196	18.45 KB
master	`SendRequest`	netcoreapp3.1	222μs	1.27μs	10.5μs	0.209	20.61 KB
master	`SendRequest`	net472	0.000402ns	0.000281ns	0.00105ns	0	0 b
#6182	`SendRequest`	net6.0	199μs	1.14μs	8.94μs	0.182	18.45 KB
#6182	`SendRequest`	netcoreapp3.1	222μs	1.29μs	10.6μs	0.247	20.61 KB
#6182	`SendRequest`	net472	0.000343ns	0.000277ns	0.000997ns	0	0 b

Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #6182

Benchmark	Base Allocated	Diff Allocated	Change	Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑netcoreapp3.1	41.93 KB	41.66 KB	-277 B	-0.66%

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	578μs	3.02μs	14.8μs	0.558	0	0	41.56 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	696μs	3.34μs	14.2μs	0.355	0	0	41.93 KB
master	`WriteAndFlushEnrichedTraces`	net472	868μs	4.34μs	18.4μs	8.19	2.59	0.431	53.27 KB
#6182	`WriteAndFlushEnrichedTraces`	net6.0	590μs	3.25μs	20.8μs	0.558	0	0	41.63 KB
#6182	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	677μs	3.19μs	12.3μs	0.345	0	0	41.66 KB
#6182	`WriteAndFlushEnrichedTraces`	net472	836μs	3.31μs	12.8μs	8.22	2.47	0.411	53.28 KB

Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`ExecuteNonQuery`	net6.0	1.3μs	1.16ns	4.5ns	0.0143	1.02 KB
master	`ExecuteNonQuery`	netcoreapp3.1	1.79μs	1.74ns	6.73ns	0.0135	1.02 KB
master	`ExecuteNonQuery`	net472	2.1μs	1.65ns	5.94ns	0.156	987 B
#6182	`ExecuteNonQuery`	net6.0	1.22μs	1.15ns	4.31ns	0.014	1.02 KB
#6182	`ExecuteNonQuery`	netcoreapp3.1	1.74μs	1.25ns	4.85ns	0.014	1.02 KB
#6182	`ExecuteNonQuery`	net472	2.02μs	1.52ns	5.67ns	0.157	987 B

Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`CallElasticsearch`	net6.0	1.23μs	0.726ns	2.72ns	0.0138	0	976 B
master	`CallElasticsearch`	netcoreapp3.1	1.46μs	0.507ns	1.9ns	0.0132	0	976 B
master	`CallElasticsearch`	net472	2.53μs	1.84ns	7.14ns	0.157	0	995 B
master	`CallElasticsearchAsync`	net6.0	1.27μs	0.763ns	2.96ns	0.0133	0	952 B
master	`CallElasticsearchAsync`	netcoreapp3.1	1.56μs	2.71ns	10.5ns	0.0133	0	1.02 KB
master	`CallElasticsearchAsync`	net472	2.54μs	2.87ns	11.1ns	0.166	0	1.05 KB
#6182	`CallElasticsearch`	net6.0	1.18μs	1.1ns	4.13ns	0.0136	0	976 B
#6182	`CallElasticsearch`	netcoreapp3.1	1.56μs	1.18ns	4.4ns	0.0133	0	976 B
#6182	`CallElasticsearch`	net472	2.45μs	0.989ns	3.7ns	0.158	0.00123	995 B
#6182	`CallElasticsearchAsync`	net6.0	1.33μs	1.23ns	4.77ns	0.0132	0	952 B
#6182	`CallElasticsearchAsync`	netcoreapp3.1	1.64μs	1.23ns	4.75ns	0.014	0	1.02 KB
#6182	`CallElasticsearchAsync`	net472	2.59μs	1.11ns	4.3ns	0.166	0	1.05 KB

Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`ExecuteAsync`	net6.0	1.22μs	0.898ns	3.48ns	0.0131	0	952 B
master	`ExecuteAsync`	netcoreapp3.1	1.57μs	1.19ns	4.46ns	0.0126	0	952 B
master	`ExecuteAsync`	net472	1.78μs	0.4ns	1.5ns	0.145	0	915 B
#6182	`ExecuteAsync`	net6.0	1.18μs	0.401ns	1.5ns	0.013	0	952 B
#6182	`ExecuteAsync`	netcoreapp3.1	1.64μs	0.644ns	2.41ns	0.0131	0	952 B
#6182	`ExecuteAsync`	net472	1.82μs	0.543ns	1.96ns	0.145	0.000917	915 B

Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendAsync`	net6.0	4.31μs	3.58ns	13.4ns	0.0302	2.22 KB
master	`SendAsync`	netcoreapp3.1	5.1μs	6.69ns	25.9ns	0.0358	2.76 KB
master	`SendAsync`	net472	7.81μs	5.89ns	22.8ns	0.497	3.15 KB
#6182	`SendAsync`	net6.0	4.11μs	1.41ns	5.29ns	0.0309	2.22 KB
#6182	`SendAsync`	netcoreapp3.1	5.11μs	2.22ns	8.29ns	0.0355	2.76 KB
#6182	`SendAsync`	net472	7.74μs	2.32ns	8.99ns	0.497	3.15 KB

Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	1.45μs	0.859ns	2.98ns	0.0232	1.64 KB
master	`EnrichedLog`	netcoreapp3.1	2.26μs	1.78ns	6.43ns	0.0219	1.64 KB
master	`EnrichedLog`	net472	2.63μs	1.69ns	6.56ns	0.249	1.57 KB
#6182	`EnrichedLog`	net6.0	1.49μs	0.628ns	2.35ns	0.0226	1.64 KB
#6182	`EnrichedLog`	netcoreapp3.1	2.22μs	1.37ns	5.32ns	0.0221	1.64 KB
#6182	`EnrichedLog`	net472	2.69μs	0.819ns	3.17ns	0.249	1.57 KB

Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`EnrichedLog`	net6.0	115μs	140ns	543ns	0.0574	0	4.28 KB
master	`EnrichedLog`	netcoreapp3.1	122μs	127ns	492ns	0	0	4.28 KB
master	`EnrichedLog`	net472	151μs	198ns	767ns	0.682	0.227	4.46 KB
#6182	`EnrichedLog`	net6.0	116μs	169ns	631ns	0.0583	0	4.28 KB
#6182	`EnrichedLog`	netcoreapp3.1	121μs	170ns	658ns	0	0	4.28 KB
#6182	`EnrichedLog`	net472	153μs	116ns	450ns	0.691	0.23	4.46 KB

Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	2.91μs	1.31ns	5.09ns	0.0304	2.2 KB
master	`EnrichedLog`	netcoreapp3.1	4.16μs	1.7ns	6.57ns	0.0291	2.2 KB
master	`EnrichedLog`	net472	4.85μs	1.62ns	6.26ns	0.319	2.02 KB
#6182	`EnrichedLog`	net6.0	3.08μs	1.25ns	4.83ns	0.0307	2.2 KB
#6182	`EnrichedLog`	netcoreapp3.1	4.03μs	1.23ns	4.75ns	0.0283	2.2 KB
#6182	`EnrichedLog`	net472	4.74μs	1.1ns	4.1ns	0.319	2.02 KB

Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`SendReceive`	net6.0	1.38μs	0.438ns	1.7ns	0.0158	0	1.14 KB
master	`SendReceive`	netcoreapp3.1	1.82μs	0.999ns	3.87ns	0.0156	0	1.14 KB
master	`SendReceive`	net472	2.12μs	0.776ns	3.01ns	0.183	0.00106	1.16 KB
#6182	`SendReceive`	net6.0	1.32μs	0.664ns	2.57ns	0.0159	0	1.14 KB
#6182	`SendReceive`	netcoreapp3.1	1.78μs	1.24ns	4.8ns	0.0151	0	1.14 KB
#6182	`SendReceive`	net472	2.16μs	0.901ns	3.49ns	0.183	0	1.16 KB

Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	2.69μs	4.88ns	17.6ns	0.0214	1.6 KB
master	`EnrichedLog`	netcoreapp3.1	3.91μs	1.5ns	5.8ns	0.0216	1.65 KB
master	`EnrichedLog`	net472	4.44μs	0.951ns	3.43ns	0.322	2.04 KB
#6182	`EnrichedLog`	net6.0	2.8μs	0.537ns	2.01ns	0.0224	1.6 KB
#6182	`EnrichedLog`	netcoreapp3.1	3.92μs	3.37ns	13ns	0.0216	1.65 KB
#6182	`EnrichedLog`	net472	4.53μs	1.33ns	5.15ns	0.323	2.04 KB

Benchmarks.Trace.SpanBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #6182

Benchmark	base/diff	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net6.0	1.117	446.05	399.17

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`StartFinishSpan`	net6.0	446ns	0.361ns	1.4ns	0.00805	576 B
master	`StartFinishSpan`	netcoreapp3.1	595ns	0.515ns	1.99ns	0.00747	576 B
master	`StartFinishSpan`	net472	670ns	0.827ns	3.2ns	0.0918	578 B
master	`StartFinishScope`	net6.0	509ns	0.292ns	1.13ns	0.00971	696 B
master	`StartFinishScope`	netcoreapp3.1	711ns	1.1ns	4.24ns	0.00918	696 B
master	`StartFinishScope`	net472	881ns	0.806ns	3.12ns	0.104	658 B
#6182	`StartFinishSpan`	net6.0	399ns	0.231ns	0.897ns	0.00806	576 B
#6182	`StartFinishSpan`	netcoreapp3.1	544ns	0.412ns	1.54ns	0.00789	576 B
#6182	`StartFinishSpan`	net472	736ns	0.682ns	2.64ns	0.0915	578 B
#6182	`StartFinishScope`	net6.0	488ns	0.502ns	1.95ns	0.00978	696 B
#6182	`StartFinishScope`	netcoreapp3.1	756ns	0.712ns	2.76ns	0.00941	696 B
#6182	`StartFinishScope`	net472	868ns	0.765ns	2.96ns	0.104	658 B

Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`RunOnMethodBegin`	net6.0	651ns	0.612ns	2.21ns	0.00967	696 B
master	`RunOnMethodBegin`	netcoreapp3.1	977ns	0.873ns	3.38ns	0.0093	696 B
master	`RunOnMethodBegin`	net472	1.13μs	1.27ns	4.92ns	0.105	658 B
#6182	`RunOnMethodBegin`	net6.0	598ns	0.333ns	1.25ns	0.00963	696 B
#6182	`RunOnMethodBegin`	netcoreapp3.1	996ns	0.613ns	2.38ns	0.00948	696 B
#6182	`RunOnMethodBegin`	net472	1.18μs	0.89ns	3.45ns	0.104	658 B

andrewlock · 2024-10-23T10:16:17Z

Throughput/Crank Report:zap:

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6182) (11.025M)   : 0, 11025002
    master (11.141M)   : 0, 11140719
    benchmarks/2.9.0 (11.081M)   : 0, 11080577

    section Automatic
    This PR (6182) (7.458M)   : 0, 7457958
    master (7.280M)   : 0, 7279870
    benchmarks/2.9.0 (7.732M)   : 0, 7732233

    section Trace stats
    master (7.669M)   : 0, 7668885

    section Manual
    This PR (6182) (9.536M)   : crit ,0, 9536134
    master (11.075M)   : 0, 11074558

    section Manual + Automatic
    This PR (6182) (6.971M)   : 0, 6971282
    master (6.727M)   : 0, 6727438

gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6182) (9.668M)   : 0, 9667995
    master (9.575M)   : 0, 9575114
    benchmarks/2.9.0 (9.798M)   : 0, 9798067

    section Automatic
    This PR (6182) (6.702M)   : 0, 6702349
    master (6.573M)   : 0, 6573227

    section Trace stats
    master (6.889M)   : 0, 6888898

    section Manual
    This PR (6182) (8.372M)   : crit ,0, 8371856
    master (9.554M)   : 0, 9554430

    section Manual + Automatic
    This PR (6182) (6.163M)   : 0, 6162622
    master (6.223M)   : 0, 6222792

gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6182) (9.781M)   : 0, 9781172
    master (10.041M)   : 0, 10040592
    benchmarks/2.9.0 (10.067M)   : 0, 10067315

    section Automatic
    This PR (6182) (6.434M)   : 0, 6434094
    master (6.448M)   : 0, 6447976
    benchmarks/2.9.0 (7.552M)   : 0, 7552193

    section Trace stats
    master (7.067M)   : 0, 7067450

    section Manual
    This PR (6182) (8.361M)   : crit ,0, 8360887
    master (9.677M)   : 0, 9676828

    section Manual + Automatic
    This PR (6182) (6.002M)   : 0, 6002440
    master (6.140M)   : 0, 6140399

datadog-ddstaging · 2024-10-23T10:20:40Z

Datadog Report

Branch report: andrew/backport/add-ssi-denylist
Commit report: c582678
Test service: dd-trace-dotnet

✅ 0 Failed, 352093 Passed, 2581 Skipped, 24h 43m 57.9s Total Time

## Summary of changes Fixes the allow list test ## Reason for change In #6182 I backported the SSI list, but annoyingly looks like the test was wrong, which has broken it ## Implementation details Fix the test ## Test coverage The test didn't run previously for "reasons". It _should_ run now

andrewlock added 2 commits October 23, 2024 09:45

2.x does not support arm64 musl

c582678

andrewlock added the area:builds project files, build scripts, pipelines, versioning, releases, packages label Oct 23, 2024

andrewlock requested review from a team as code owners October 23, 2024 08:49

kevingosse approved these changes Oct 23, 2024

View reviewed changes

andrewlock added the type:backport Feature backport to old version label Oct 23, 2024

andrewlock merged commit 084a790 into release/2.x Oct 23, 2024
63 of 65 checks passed

andrewlock deleted the andrew/backport/add-ssi-denylist branch October 23, 2024 12:24

github-actions bot added this to the vNext-v2 milestone Oct 23, 2024

andrewlock mentioned this pull request Oct 23, 2024

Fix requirements.json test #6186

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add SSI denylist and tests (#5928 => v2) #6182

Add SSI denylist and tests (#5928 => v2) #6182

andrewlock commented Oct 23, 2024 •

edited

Loading

andrewlock commented Oct 23, 2024

andrewlock commented Oct 23, 2024

Raw results

Raw results

Raw results

Fewer allocations 🎉 in #6182

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Faster 🎉 in #6182

Raw results

Raw results

andrewlock commented Oct 23, 2024

datadog-ddstaging bot commented Oct 23, 2024 •

edited

Loading

Add SSI denylist and tests (#5928 => v2) #6182

Add SSI denylist and tests (#5928 => v2) #6182

Conversation

andrewlock commented Oct 23, 2024 • edited Loading

Summary of changes

Reason for change

Implementation details

Test coverage

Other details

andrewlock commented Oct 23, 2024

Execution-Time Benchmarks Report ⏱️

andrewlock commented Oct 23, 2024

Benchmarks Report for tracer 🐌

Benchmark details

Raw results

Raw results

Raw results

Fewer allocations 🎉 in #6182

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Faster 🎉 in #6182

Raw results

Raw results

andrewlock commented Oct 23, 2024

Throughput/Crank Report:zap:

datadog-ddstaging bot commented Oct 23, 2024 • edited Loading

Datadog Report

andrewlock commented Oct 23, 2024 •

edited

Loading

datadog-ddstaging bot commented Oct 23, 2024 •

edited

Loading