Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix using the wrong pool for smoke tests #6196

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

andrewlock
Copy link
Member

Summary of changes

Use azure-windows-scale-set-2 instead of azure-windows-scale-set

Reason for change

This was an oversight way back when we updated. It shouldn't matter, it's just sub-optimal.

Implementation details

Fix the pool we use

@andrewlock andrewlock added the area:builds project files, build scripts, pipelines, versioning, releases, packages label Oct 24, 2024
@andrewlock andrewlock requested a review from a team as a code owner October 24, 2024 13:16
@andrewlock
Copy link
Member Author

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6196) - mean (71ms)  : 68, 74
     .   : milestone, 71,
    master - mean (70ms)  : 68, 72
     .   : milestone, 70,

    section CallTarget+Inlining+NGEN
    This PR (6196) - mean (1,120ms)  : 1095, 1145
     .   : milestone, 1120,
    master - mean (1,112ms)  : 1086, 1139
     .   : milestone, 1112,

Loading
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6196) - mean (109ms)  : 106, 112
     .   : milestone, 109,
    master - mean (109ms)  : 106, 112
     .   : milestone, 109,

    section CallTarget+Inlining+NGEN
    This PR (6196) - mean (773ms)  : 755, 791
     .   : milestone, 773,
    master - mean (773ms)  : 760, 787
     .   : milestone, 773,

Loading
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6196) - mean (93ms)  : 90, 96
     .   : milestone, 93,
    master - mean (93ms)  : 89, 96
     .   : milestone, 93,

    section CallTarget+Inlining+NGEN
    This PR (6196) - mean (728ms)  : 705, 751
     .   : milestone, 728,
    master - mean (727ms)  : 714, 740
     .   : milestone, 727,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6196) - mean (190ms)  : 187, 193
     .   : milestone, 190,
    master - mean (190ms)  : 188, 192
     .   : milestone, 190,

    section CallTarget+Inlining+NGEN
    This PR (6196) - mean (1,201ms)  : 1178, 1224
     .   : milestone, 1201,
    master - mean (1,202ms)  : 1176, 1227
     .   : milestone, 1202,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6196) - mean (275ms)  : 271, 279
     .   : milestone, 275,
    master - mean (276ms)  : 270, 282
     .   : milestone, 276,

    section CallTarget+Inlining+NGEN
    This PR (6196) - mean (947ms)  : 929, 966
     .   : milestone, 947,
    master - mean (945ms)  : 925, 965
     .   : milestone, 945,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6196) - mean (264ms)  : 261, 267
     .   : milestone, 264,
    master - mean (265ms)  : 261, 270
     .   : milestone, 265,

    section CallTarget+Inlining+NGEN
    This PR (6196) - mean (923ms)  : 904, 943
     .   : milestone, 923,
    master - mean (926ms)  : 909, 944
     .   : milestone, 926,

Loading

@datadog-ddstaging
Copy link

datadog-ddstaging bot commented Oct 24, 2024

Datadog Report

Branch report: andrew/ci/fix-using-wrong-pool
Commit report: 38dd10a
Test service: dd-trace-dotnet

✅ 0 Failed, 368041 Passed, 2098 Skipped, 15h 17m 53.08s Total Time

@andrewlock
Copy link
Member Author

Benchmarks Report for tracer 🐌

Benchmarks for #6196 compared to master:

  • 1 benchmarks are slower, with geometric mean 1.149
  • All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 7.78μs 43.8ns 291ns 0.0152 0.00381 0 5.43 KB
master StartStopWithChild netcoreapp3.1 9.8μs 55.3ns 391ns 0.024 0.00959 0 5.62 KB
master StartStopWithChild net472 16.4μs 71.6ns 277ns 1.05 0.345 0.0904 6.07 KB
#6196 StartStopWithChild net6.0 7.64μs 43.6ns 311ns 0.0108 0.00721 0 5.43 KB
#6196 StartStopWithChild netcoreapp3.1 10.3μs 55.7ns 315ns 0.0148 0.00492 0 5.62 KB
#6196 StartStopWithChild net472 16.1μs 39.6ns 153ns 1.02 0.298 0.0967 6.06 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 465μs 416ns 1.61μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 642μs 434ns 1.63μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 845μs 553ns 2.14μs 0.422 0 0 3.3 KB
#6196 WriteAndFlushEnrichedTraces net6.0 494μs 418ns 1.56μs 0 0 0 2.7 KB
#6196 WriteAndFlushEnrichedTraces netcoreapp3.1 663μs 434ns 1.68μs 0 0 0 2.7 KB
#6196 WriteAndFlushEnrichedTraces net472 835μs 824ns 3.19μs 0.414 0 0 3.3 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 201μs 1.18μs 11μs 0.2 0 0 18.45 KB
master SendRequest netcoreapp3.1 222μs 1.29μs 11.9μs 0.241 0 0 20.61 KB
master SendRequest net472 0.00047ns 0.000285ns 0.00103ns 0 0 0 0 b
#6196 SendRequest net6.0 201μs 1.17μs 10.1μs 0.203 0 0 18.45 KB
#6196 SendRequest netcoreapp3.1 226μs 1.32μs 12.3μs 0.207 0 0 20.61 KB
#6196 SendRequest net472 4.67E‑05ns 4.67E‑05ns 0.000175ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 556μs 2.99μs 15.5μs 0.576 0 0 41.6 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 690μs 3.74μs 22.1μs 0.343 0 0 41.66 KB
master WriteAndFlushEnrichedTraces net472 837μs 3.15μs 12.2μs 8.69 2.48 0.414 53.35 KB
#6196 WriteAndFlushEnrichedTraces net6.0 588μs 3.25μs 20.3μs 0.579 0 0 41.74 KB
#6196 WriteAndFlushEnrichedTraces netcoreapp3.1 678μs 3.64μs 19.3μs 0.342 0 0 41.69 KB
#6196 WriteAndFlushEnrichedTraces net472 878μs 4.32μs 18.8μs 8.42 2.66 0.443 53.28 KB
Benchmarks.Trace.DbCommandBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #6196

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.DbCommandBenchmark.ExecuteNonQuery‑net6.0 1.149 1,272.37 1,461.38

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.27μs 1.43ns 5.34ns 0.0141 0 0 1.02 KB
master ExecuteNonQuery netcoreapp3.1 1.71μs 1.28ns 4.97ns 0.0138 0 0 1.02 KB
master ExecuteNonQuery net472 2.1μs 2.75ns 10.3ns 0.157 0 0 987 B
#6196 ExecuteNonQuery net6.0 1.46μs 0.695ns 2.51ns 0.0142 0 0 1.02 KB
#6196 ExecuteNonQuery netcoreapp3.1 1.73μs 1.27ns 4.9ns 0.014 0 0 1.02 KB
#6196 ExecuteNonQuery net472 2.08μs 1.33ns 4.97ns 0.156 0 0 987 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.25μs 0.38ns 1.42ns 0.0137 0 0 976 B
master CallElasticsearch netcoreapp3.1 1.5μs 0.514ns 1.85ns 0.0128 0 0 976 B
master CallElasticsearch net472 2.49μs 2.71ns 9.75ns 0.157 0 0 995 B
master CallElasticsearchAsync net6.0 1.3μs 1.07ns 4.15ns 0.013 0 0 952 B
master CallElasticsearchAsync netcoreapp3.1 1.65μs 0.635ns 2.38ns 0.0141 0 0 1.02 KB
master CallElasticsearchAsync net472 2.42μs 1.04ns 3.74ns 0.167 0 0 1.05 KB
#6196 CallElasticsearch net6.0 1.22μs 0.539ns 2.02ns 0.0134 0 0 976 B
#6196 CallElasticsearch netcoreapp3.1 1.52μs 0.717ns 2.78ns 0.0129 0 0 976 B
#6196 CallElasticsearch net472 2.43μs 1.21ns 4.19ns 0.158 0 0 995 B
#6196 CallElasticsearchAsync net6.0 1.29μs 0.55ns 2.13ns 0.0129 0 0 952 B
#6196 CallElasticsearchAsync netcoreapp3.1 1.64μs 2.36ns 9.12ns 0.0136 0 0 1.02 KB
#6196 CallElasticsearchAsync net472 2.58μs 1.83ns 7.07ns 0.166 0 0 1.05 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.25μs 0.609ns 2.28ns 0.0131 0 0 952 B
master ExecuteAsync netcoreapp3.1 1.69μs 0.968ns 3.62ns 0.0125 0 0 952 B
master ExecuteAsync net472 1.88μs 1.44ns 5.57ns 0.144 0 0 915 B
#6196 ExecuteAsync net6.0 1.18μs 0.473ns 1.83ns 0.0131 0 0 952 B
#6196 ExecuteAsync netcoreapp3.1 1.67μs 0.757ns 2.83ns 0.0125 0 0 952 B
#6196 ExecuteAsync net472 1.88μs 0.242ns 0.905ns 0.145 0 0 915 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 4.1μs 1.11ns 4.31ns 0.0308 0 0 2.22 KB
master SendAsync netcoreapp3.1 5.18μs 8.15ns 31.6ns 0.0361 0 0 2.76 KB
master SendAsync net472 7.78μs 3.23ns 12.5ns 0.498 0 0 3.15 KB
#6196 SendAsync net6.0 4.22μs 1.84ns 6.88ns 0.0311 0 0 2.22 KB
#6196 SendAsync netcoreapp3.1 5.04μs 4.42ns 17.1ns 0.0378 0 0 2.76 KB
#6196 SendAsync net472 7.9μs 2.77ns 10.7ns 0.499 0 0 3.15 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 1.57μs 0.707ns 2.65ns 0.0227 0 0 1.64 KB
master EnrichedLog netcoreapp3.1 2.16μs 1.09ns 4.06ns 0.0226 0 0 1.64 KB
master EnrichedLog net472 2.61μs 0.957ns 3.7ns 0.249 0 0 1.57 KB
#6196 EnrichedLog net6.0 1.61μs 1.27ns 4.73ns 0.0227 0 0 1.64 KB
#6196 EnrichedLog netcoreapp3.1 2.18μs 1.76ns 6.6ns 0.0218 0 0 1.64 KB
#6196 EnrichedLog net472 2.57μs 1.04ns 3.74ns 0.249 0 0 1.57 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 114μs 237ns 919ns 0.0574 0 0 4.28 KB
master EnrichedLog netcoreapp3.1 120μs 245ns 948ns 0.0599 0 0 4.28 KB
master EnrichedLog net472 150μs 191ns 716ns 0.678 0.226 0 4.46 KB
#6196 EnrichedLog net6.0 116μs 304ns 1.18μs 0.058 0 0 4.28 KB
#6196 EnrichedLog netcoreapp3.1 122μs 165ns 640ns 0.0609 0 0 4.28 KB
#6196 EnrichedLog net472 152μs 114ns 427ns 0.683 0.228 0 4.46 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 3.14μs 2.34ns 9.05ns 0.0298 0 0 2.2 KB
master EnrichedLog netcoreapp3.1 4.09μs 1.23ns 4.75ns 0.0287 0 0 2.2 KB
master EnrichedLog net472 4.74μs 0.811ns 3.14ns 0.321 0 0 2.02 KB
#6196 EnrichedLog net6.0 3.03μs 1.18ns 4.57ns 0.0302 0 0 2.2 KB
#6196 EnrichedLog netcoreapp3.1 4.1μs 1.8ns 6.98ns 0.0285 0 0 2.2 KB
#6196 EnrichedLog net472 4.72μs 1.34ns 5.18ns 0.319 0 0 2.02 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 1.36μs 1.64ns 6.35ns 0.0162 0 0 1.14 KB
master SendReceive netcoreapp3.1 1.78μs 0.85ns 3.18ns 0.0151 0 0 1.14 KB
master SendReceive net472 2.13μs 2.07ns 8.01ns 0.183 0 0 1.16 KB
#6196 SendReceive net6.0 1.48μs 1.14ns 4.4ns 0.0162 0 0 1.14 KB
#6196 SendReceive netcoreapp3.1 1.74μs 1.04ns 3.75ns 0.0157 0 0 1.14 KB
#6196 SendReceive net472 2.03μs 0.766ns 2.97ns 0.183 0 0 1.16 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.59μs 0.724ns 2.71ns 0.022 0 0 1.6 KB
master EnrichedLog netcoreapp3.1 4.04μs 0.823ns 2.85ns 0.0223 0 0 1.65 KB
master EnrichedLog net472 4.28μs 2.59ns 9.71ns 0.322 0 0 2.04 KB
#6196 EnrichedLog net6.0 2.72μs 0.994ns 3.85ns 0.0218 0 0 1.6 KB
#6196 EnrichedLog netcoreapp3.1 3.9μs 2.22ns 8.58ns 0.0213 0 0 1.65 KB
#6196 EnrichedLog net472 4.45μs 4.79ns 17.3ns 0.323 0 0 2.04 KB
Benchmarks.Trace.SpanBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 401ns 0.253ns 0.981ns 0.00803 0 0 576 B
master StartFinishSpan netcoreapp3.1 597ns 0.443ns 1.72ns 0.00787 0 0 576 B
master StartFinishSpan net472 669ns 0.3ns 1.16ns 0.0916 0 0 578 B
master StartFinishScope net6.0 495ns 1.9ns 7.1ns 0.00966 0 0 696 B
master StartFinishScope netcoreapp3.1 742ns 0.455ns 1.76ns 0.00949 0 0 696 B
master StartFinishScope net472 880ns 0.714ns 2.67ns 0.105 0 0 658 B
#6196 StartFinishSpan net6.0 399ns 0.107ns 0.413ns 0.00799 0 0 576 B
#6196 StartFinishSpan netcoreapp3.1 568ns 0.275ns 1.06ns 0.00773 0 0 576 B
#6196 StartFinishSpan net472 708ns 0.259ns 0.934ns 0.0916 0 0 578 B
#6196 StartFinishScope net6.0 507ns 0.0882ns 0.342ns 0.00982 0 0 696 B
#6196 StartFinishScope netcoreapp3.1 776ns 0.456ns 1.77ns 0.0093 0 0 696 B
#6196 StartFinishScope net472 894ns 0.608ns 2.35ns 0.105 0 0 658 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 652ns 0.805ns 3.12ns 0.00983 0 0 696 B
master RunOnMethodBegin netcoreapp3.1 965ns 0.919ns 3.56ns 0.00939 0 0 696 B
master RunOnMethodBegin net472 1.13μs 1.11ns 4.3ns 0.104 0 0 658 B
#6196 RunOnMethodBegin net6.0 691ns 0.394ns 1.53ns 0.00966 0 0 696 B
#6196 RunOnMethodBegin netcoreapp3.1 964ns 0.505ns 1.96ns 0.00922 0 0 696 B
#6196 RunOnMethodBegin net472 1.15μs 0.207ns 0.774ns 0.104 0 0 658 B

@andrewlock
Copy link
Member Author

Throughput/Crank Report ⚡

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6196) (11.199M)   : 0, 11199457
    master (11.274M)   : 0, 11274027
    benchmarks/2.9.0 (11.081M)   : 0, 11080577

    section Automatic
    This PR (6196) (7.434M)   : 0, 7434345
    master (7.426M)   : 0, 7425892
    benchmarks/2.9.0 (7.732M)   : 0, 7732233

    section Trace stats
    master (7.675M)   : 0, 7674910

    section Manual
    master (11.118M)   : 0, 11117646

    section Manual + Automatic
    This PR (6196) (6.854M)   : 0, 6853515
    master (6.861M)   : 0, 6861358

    section DD_TRACE_ENABLED=0
    master (10.287M)   : 0, 10287259

Loading
gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6196) (9.702M)   : 0, 9701631
    master (9.384M)   : 0, 9383676
    benchmarks/2.9.0 (9.798M)   : 0, 9798067

    section Automatic
    This PR (6196) (6.496M)   : 0, 6496080
    master (6.570M)   : 0, 6570004

    section Trace stats
    master (6.840M)   : 0, 6839824

    section Manual
    master (9.309M)   : 0, 9309037

    section Manual + Automatic
    This PR (6196) (6.061M)   : 0, 6060618
    master (6.074M)   : 0, 6073870

    section DD_TRACE_ENABLED=0
    master (8.865M)   : 0, 8864615

Loading
gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6196) (10.034M)   : 0, 10033820
    master (9.946M)   : 0, 9946424
    benchmarks/2.9.0 (10.067M)   : 0, 10067315

    section Automatic
    This PR (6196) (6.486M)   : 0, 6486002
    master (6.353M)   : 0, 6353030
    benchmarks/2.9.0 (7.552M)   : 0, 7552193

    section Trace stats
    master (7.199M)   : 0, 7199204

    section Manual
    master (9.594M)   : 0, 9593813

    section Manual + Automatic
    This PR (6196) (5.929M)   : 0, 5929337
    master (5.983M)   : 0, 5982831

    section DD_TRACE_ENABLED=0
    master (9.232M)   : 0, 9232243

Loading

@andrewlock andrewlock merged commit b80c0cf into master Oct 25, 2024
75 checks passed
@andrewlock andrewlock deleted the andrew/ci/fix-using-wrong-pool branch October 25, 2024 16:38
@github-actions github-actions bot added this to the vNext-v3 milestone Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:builds project files, build scripts, pipelines, versioning, releases, packages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants