-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more info when GenerateDumpIfDbgRequested fails (take 2) #6197
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Datadog ReportBranch report: ✅ 0 Failed, 368977 Passed, 2435 Skipped, 17h 9m 7.05s Total Time |
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing the following branches/commits: Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6197) - mean (71ms) : 68, 74
. : milestone, 71,
master - mean (70ms) : 68, 72
. : milestone, 70,
section CallTarget+Inlining+NGEN
This PR (6197) - mean (1,120ms) : 1093, 1146
. : milestone, 1120,
master - mean (1,112ms) : 1086, 1139
. : milestone, 1112,
gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6197) - mean (109ms) : 106, 113
. : milestone, 109,
master - mean (109ms) : 106, 112
. : milestone, 109,
section CallTarget+Inlining+NGEN
This PR (6197) - mean (776ms) : 761, 791
. : milestone, 776,
master - mean (773ms) : 760, 787
. : milestone, 773,
gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6197) - mean (93ms) : 90, 96
. : milestone, 93,
master - mean (93ms) : 89, 96
. : milestone, 93,
section CallTarget+Inlining+NGEN
This PR (6197) - mean (731ms) : 718, 744
. : milestone, 731,
master - mean (727ms) : 714, 740
. : milestone, 727,
gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6197) - mean (190ms) : 186, 195
. : milestone, 190,
master - mean (190ms) : 188, 192
. : milestone, 190,
section CallTarget+Inlining+NGEN
This PR (6197) - mean (1,199ms) : 1167, 1231
. : milestone, 1199,
master - mean (1,202ms) : 1176, 1227
. : milestone, 1202,
gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6197) - mean (275ms) : 271, 279
. : milestone, 275,
master - mean (276ms) : 270, 282
. : milestone, 276,
section CallTarget+Inlining+NGEN
This PR (6197) - mean (941ms) : 926, 957
. : milestone, 941,
master - mean (945ms) : 925, 965
. : milestone, 945,
gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6197) - mean (264ms) : 261, 267
. : milestone, 264,
master - mean (265ms) : 261, 270
. : milestone, 265,
section CallTarget+Inlining+NGEN
This PR (6197) - mean (928ms) : 910, 947
. : milestone, 928,
master - mean (926ms) : 909, 944
. : milestone, 926,
|
Benchmarks Report for tracer 🐌Benchmarks for #6197 compared to master:
The following thresholds were used for comparing the benchmark speeds:
Allocation changes below 0.5% are ignored. Benchmark detailsBenchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ More allocations
|
Benchmark | Base Allocated | Diff Allocated | Change | Change % |
---|---|---|---|---|
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑netcoreapp3.1 | 41.66 KB | 42.02 KB | 361 B | 0.87% |
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | WriteAndFlushEnrichedTraces |
net6.0 | 556μs | 2.99μs | 15.5μs | 0.576 | 0 | 0 | 41.6 KB |
master | WriteAndFlushEnrichedTraces |
netcoreapp3.1 | 690μs | 3.74μs | 22.1μs | 0.343 | 0 | 0 | 41.66 KB |
master | WriteAndFlushEnrichedTraces |
net472 | 837μs | 3.15μs | 12.2μs | 8.69 | 2.48 | 0.414 | 53.35 KB |
#6197 | WriteAndFlushEnrichedTraces |
net6.0 | 562μs | 2.24μs | 8.39μs | 0.543 | 0 | 0 | 41.5 KB |
#6197 | WriteAndFlushEnrichedTraces |
netcoreapp3.1 | 694μs | 3.91μs | 28.7μs | 0.336 | 0 | 0 | 42.02 KB |
#6197 | WriteAndFlushEnrichedTraces |
net472 | 859μs | 3.57μs | 13.8μs | 8.33 | 2.5 | 0.417 | 53.31 KB |
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | ExecuteNonQuery |
net6.0 | 1.27μs | 1.43ns | 5.34ns | 0.0141 | 0 | 0 | 1.02 KB |
master | ExecuteNonQuery |
netcoreapp3.1 | 1.71μs | 1.28ns | 4.97ns | 0.0138 | 0 | 0 | 1.02 KB |
master | ExecuteNonQuery |
net472 | 2.1μs | 2.75ns | 10.3ns | 0.157 | 0 | 0 | 987 B |
#6197 | ExecuteNonQuery |
net6.0 | 1.37μs | 1.24ns | 4.81ns | 0.0143 | 0 | 0 | 1.02 KB |
#6197 | ExecuteNonQuery |
netcoreapp3.1 | 1.7μs | 1.09ns | 4.2ns | 0.0138 | 0 | 0 | 1.02 KB |
#6197 | ExecuteNonQuery |
net472 | 2.03μs | 2.04ns | 7.9ns | 0.156 | 0 | 0 | 987 B |
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | CallElasticsearch |
net6.0 | 1.25μs | 0.38ns | 1.42ns | 0.0137 | 0 | 0 | 976 B |
master | CallElasticsearch |
netcoreapp3.1 | 1.5μs | 0.514ns | 1.85ns | 0.0128 | 0 | 0 | 976 B |
master | CallElasticsearch |
net472 | 2.49μs | 2.71ns | 9.75ns | 0.157 | 0 | 0 | 995 B |
master | CallElasticsearchAsync |
net6.0 | 1.3μs | 1.07ns | 4.15ns | 0.013 | 0 | 0 | 952 B |
master | CallElasticsearchAsync |
netcoreapp3.1 | 1.65μs | 0.635ns | 2.38ns | 0.0141 | 0 | 0 | 1.02 KB |
master | CallElasticsearchAsync |
net472 | 2.42μs | 1.04ns | 3.74ns | 0.167 | 0 | 0 | 1.05 KB |
#6197 | CallElasticsearch |
net6.0 | 1.17μs | 0.511ns | 1.98ns | 0.0135 | 0 | 0 | 976 B |
#6197 | CallElasticsearch |
netcoreapp3.1 | 1.53μs | 1.2ns | 4.66ns | 0.0132 | 0 | 0 | 976 B |
#6197 | CallElasticsearch |
net472 | 2.54μs | 5.22ns | 20.2ns | 0.158 | 0 | 0 | 995 B |
#6197 | CallElasticsearchAsync |
net6.0 | 1.35μs | 0.725ns | 2.71ns | 0.0134 | 0 | 0 | 952 B |
#6197 | CallElasticsearchAsync |
netcoreapp3.1 | 1.64μs | 0.926ns | 3.46ns | 0.0138 | 0 | 0 | 1.02 KB |
#6197 | CallElasticsearchAsync |
net472 | 2.58μs | 1.69ns | 6.55ns | 0.167 | 0 | 0 | 1.05 KB |
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | ExecuteAsync |
net6.0 | 1.25μs | 0.609ns | 2.28ns | 0.0131 | 0 | 0 | 952 B |
master | ExecuteAsync |
netcoreapp3.1 | 1.69μs | 0.968ns | 3.62ns | 0.0125 | 0 | 0 | 952 B |
master | ExecuteAsync |
net472 | 1.88μs | 1.44ns | 5.57ns | 0.144 | 0 | 0 | 915 B |
#6197 | ExecuteAsync |
net6.0 | 1.25μs | 0.351ns | 1.31ns | 0.0133 | 0 | 0 | 952 B |
#6197 | ExecuteAsync |
netcoreapp3.1 | 1.65μs | 1.44ns | 5.58ns | 0.0123 | 0 | 0 | 952 B |
#6197 | ExecuteAsync |
net472 | 1.8μs | 0.84ns | 3.25ns | 0.145 | 0 | 0 | 915 B |
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | SendAsync |
net6.0 | 4.1μs | 1.11ns | 4.31ns | 0.0308 | 0 | 0 | 2.22 KB |
master | SendAsync |
netcoreapp3.1 | 5.18μs | 8.15ns | 31.6ns | 0.0361 | 0 | 0 | 2.76 KB |
master | SendAsync |
net472 | 7.78μs | 3.23ns | 12.5ns | 0.498 | 0 | 0 | 3.15 KB |
#6197 | SendAsync |
net6.0 | 4.15μs | 1.94ns | 7.26ns | 0.0312 | 0 | 0 | 2.22 KB |
#6197 | SendAsync |
netcoreapp3.1 | 5.01μs | 2.62ns | 10.1ns | 0.0376 | 0 | 0 | 2.76 KB |
#6197 | SendAsync |
net472 | 7.86μs | 1.29ns | 4.99ns | 0.5 | 0 | 0 | 3.15 KB |
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | EnrichedLog |
net6.0 | 1.57μs | 0.707ns | 2.65ns | 0.0227 | 0 | 0 | 1.64 KB |
master | EnrichedLog |
netcoreapp3.1 | 2.16μs | 1.09ns | 4.06ns | 0.0226 | 0 | 0 | 1.64 KB |
master | EnrichedLog |
net472 | 2.61μs | 0.957ns | 3.7ns | 0.249 | 0 | 0 | 1.57 KB |
#6197 | EnrichedLog |
net6.0 | 1.44μs | 0.595ns | 2.14ns | 0.0232 | 0 | 0 | 1.64 KB |
#6197 | EnrichedLog |
netcoreapp3.1 | 2.09μs | 0.847ns | 3.17ns | 0.0219 | 0 | 0 | 1.64 KB |
#6197 | EnrichedLog |
net472 | 2.54μs | 0.839ns | 3.25ns | 0.25 | 0 | 0 | 1.57 KB |
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | EnrichedLog |
net6.0 | 114μs | 237ns | 919ns | 0.0574 | 0 | 0 | 4.28 KB |
master | EnrichedLog |
netcoreapp3.1 | 120μs | 245ns | 948ns | 0.0599 | 0 | 0 | 4.28 KB |
master | EnrichedLog |
net472 | 150μs | 191ns | 716ns | 0.678 | 0.226 | 0 | 4.46 KB |
#6197 | EnrichedLog |
net6.0 | 115μs | 172ns | 621ns | 0.0574 | 0 | 0 | 4.28 KB |
#6197 | EnrichedLog |
netcoreapp3.1 | 121μs | 163ns | 633ns | 0.06 | 0 | 0 | 4.28 KB |
#6197 | EnrichedLog |
net472 | 152μs | 193ns | 747ns | 0.679 | 0.226 | 0 | 4.46 KB |
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | EnrichedLog |
net6.0 | 3.14μs | 2.34ns | 9.05ns | 0.0298 | 0 | 0 | 2.2 KB |
master | EnrichedLog |
netcoreapp3.1 | 4.09μs | 1.23ns | 4.75ns | 0.0287 | 0 | 0 | 2.2 KB |
master | EnrichedLog |
net472 | 4.74μs | 0.811ns | 3.14ns | 0.321 | 0 | 0 | 2.02 KB |
#6197 | EnrichedLog |
net6.0 | 3.01μs | 1.21ns | 4.68ns | 0.0301 | 0 | 0 | 2.2 KB |
#6197 | EnrichedLog |
netcoreapp3.1 | 4.17μs | 1.43ns | 5.52ns | 0.0293 | 0 | 0 | 2.2 KB |
#6197 | EnrichedLog |
net472 | 4.9μs | 1.86ns | 7.2ns | 0.318 | 0 | 0 | 2.02 KB |
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | SendReceive |
net6.0 | 1.36μs | 1.64ns | 6.35ns | 0.0162 | 0 | 0 | 1.14 KB |
master | SendReceive |
netcoreapp3.1 | 1.78μs | 0.85ns | 3.18ns | 0.0151 | 0 | 0 | 1.14 KB |
master | SendReceive |
net472 | 2.13μs | 2.07ns | 8.01ns | 0.183 | 0 | 0 | 1.16 KB |
#6197 | SendReceive |
net6.0 | 1.41μs | 1.8ns | 6.98ns | 0.0162 | 0 | 0 | 1.14 KB |
#6197 | SendReceive |
netcoreapp3.1 | 1.77μs | 1.26ns | 4.9ns | 0.015 | 0 | 0 | 1.14 KB |
#6197 | SendReceive |
net472 | 2.08μs | 1.19ns | 4.3ns | 0.183 | 0.00103 | 0 | 1.16 KB |
Benchmarks.Trace.SerilogBenchmark - Slower ⚠️ Same allocations ✔️
Slower ⚠️ in #6197
Benchmark
diff/base
Base Median (ns)
Diff Median (ns)
Modality
Benchmarks.Trace.SerilogBenchmark.EnrichedLog‑net6.0
1.143
2,586.48
2,956.97
Benchmark | diff/base | Base Median (ns) | Diff Median (ns) | Modality |
---|---|---|---|---|
Benchmarks.Trace.SerilogBenchmark.EnrichedLog‑net6.0 | 1.143 | 2,586.48 | 2,956.97 |
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | EnrichedLog |
net6.0 | 2.59μs | 0.724ns | 2.71ns | 0.022 | 0 | 0 | 1.6 KB |
master | EnrichedLog |
netcoreapp3.1 | 4.04μs | 0.823ns | 2.85ns | 0.0223 | 0 | 0 | 1.65 KB |
master | EnrichedLog |
net472 | 4.28μs | 2.59ns | 9.71ns | 0.322 | 0 | 0 | 2.04 KB |
#6197 | EnrichedLog |
net6.0 | 2.96μs | 4.75ns | 17.1ns | 0.0219 | 0 | 0 | 1.6 KB |
#6197 | EnrichedLog |
netcoreapp3.1 | 4.02μs | 3.58ns | 13.4ns | 0.0222 | 0 | 0 | 1.65 KB |
#6197 | EnrichedLog |
net472 | 4.48μs | 1.83ns | 6.84ns | 0.323 | 0 | 0 | 2.04 KB |
Benchmarks.Trace.SpanBenchmark - Slower ⚠️ Same allocations ✔️
Slower ⚠️ in #6197
Benchmark
diff/base
Base Median (ns)
Diff Median (ns)
Modality
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net472
1.128
669.43
754.81
Benchmark | diff/base | Base Median (ns) | Diff Median (ns) | Modality |
---|---|---|---|---|
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net472 | 1.128 | 669.43 | 754.81 |
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | StartFinishSpan |
net6.0 | 401ns | 0.253ns | 0.981ns | 0.00803 | 0 | 0 | 576 B |
master | StartFinishSpan |
netcoreapp3.1 | 597ns | 0.443ns | 1.72ns | 0.00787 | 0 | 0 | 576 B |
master | StartFinishSpan |
net472 | 669ns | 0.3ns | 1.16ns | 0.0916 | 0 | 0 | 578 B |
master | StartFinishScope |
net6.0 | 495ns | 1.9ns | 7.1ns | 0.00966 | 0 | 0 | 696 B |
master | StartFinishScope |
netcoreapp3.1 | 742ns | 0.455ns | 1.76ns | 0.00949 | 0 | 0 | 696 B |
master | StartFinishScope |
net472 | 880ns | 0.714ns | 2.67ns | 0.105 | 0 | 0 | 658 B |
#6197 | StartFinishSpan |
net6.0 | 432ns | 0.434ns | 1.68ns | 0.00808 | 0 | 0 | 576 B |
#6197 | StartFinishSpan |
netcoreapp3.1 | 559ns | 0.347ns | 1.3ns | 0.00776 | 0 | 0 | 576 B |
#6197 | StartFinishSpan |
net472 | 755ns | 0.524ns | 1.96ns | 0.0917 | 0 | 0 | 578 B |
#6197 | StartFinishScope |
net6.0 | 486ns | 0.192ns | 0.745ns | 0.00973 | 0 | 0 | 696 B |
#6197 | StartFinishScope |
netcoreapp3.1 | 825ns | 0.35ns | 1.36ns | 0.0095 | 0 | 0 | 696 B |
#6197 | StartFinishScope |
net472 | 827ns | 0.603ns | 2.34ns | 0.104 | 0 | 0 | 658 B |
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | RunOnMethodBegin |
net6.0 | 652ns | 0.805ns | 3.12ns | 0.00983 | 0 | 0 | 696 B |
master | RunOnMethodBegin |
netcoreapp3.1 | 965ns | 0.919ns | 3.56ns | 0.00939 | 0 | 0 | 696 B |
master | RunOnMethodBegin |
net472 | 1.13μs | 1.11ns | 4.3ns | 0.104 | 0 | 0 | 658 B |
#6197 | RunOnMethodBegin |
net6.0 | 662ns | 0.434ns | 1.63ns | 0.00971 | 0 | 0 | 696 B |
#6197 | RunOnMethodBegin |
netcoreapp3.1 | 912ns | 1.36ns | 5.26ns | 0.00918 | 0 | 0 | 696 B |
#6197 | RunOnMethodBegin |
net472 | 1.22μs | 0.261ns | 1.01ns | 0.104 | 0 | 0 | 658 B |
Throughput/Crank Report ⚡Throughput results for AspNetCoreSimpleController comparing the following branches/commits: Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red. Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards! gantt
title Throughput Linux x64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (6197) (11.151M) : 0, 11150693
master (11.274M) : 0, 11274027
benchmarks/2.9.0 (11.081M) : 0, 11080577
section Automatic
This PR (6197) (7.366M) : 0, 7365640
master (7.426M) : 0, 7425892
benchmarks/2.9.0 (7.732M) : 0, 7732233
section Trace stats
master (7.675M) : 0, 7674910
section Manual
master (11.118M) : 0, 11117646
section Manual + Automatic
This PR (6197) (6.802M) : 0, 6801909
master (6.861M) : 0, 6861358
section DD_TRACE_ENABLED=0
master (10.287M) : 0, 10287259
gantt
title Throughput Linux arm64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (6197) (9.536M) : 0, 9535990
master (9.384M) : 0, 9383676
benchmarks/2.9.0 (9.798M) : 0, 9798067
section Automatic
This PR (6197) (6.582M) : 0, 6581758
master (6.570M) : 0, 6570004
section Trace stats
master (6.840M) : 0, 6839824
section Manual
master (9.309M) : 0, 9309037
section Manual + Automatic
This PR (6197) (6.095M) : 0, 6095123
master (6.074M) : 0, 6073870
section DD_TRACE_ENABLED=0
master (8.865M) : 0, 8864615
gantt
title Throughput Windows x64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (6197) (10.043M) : 0, 10042754
master (9.946M) : 0, 9946424
benchmarks/2.9.0 (10.067M) : 0, 10067315
section Automatic
This PR (6197) (6.586M) : 0, 6586010
master (6.353M) : 0, 6353030
benchmarks/2.9.0 (7.552M) : 0, 7552193
section Trace stats
master (7.199M) : 0, 7199204
section Manual
master (9.594M) : 0, 9593813
section Manual + Automatic
This PR (6197) (5.936M) : 0, 5936222
master (5.983M) : 0, 5982831
section DD_TRACE_ENABLED=0
master (9.232M) : 0, 9232243
|
Summary of changes
List the status of the threads when GenerateDumpIfDbgRequested fails.
This is a continuation of #6113. I enumerated the files, but the threads are directories 🤦
Reason for change
Flaky test