Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI Visibility] Fix errors detected from error tracking. #6222

Merged
merged 2 commits into from
Oct 30, 2024

Conversation

tonyredondo
Copy link
Member

@tonyredondo tonyredondo commented Oct 30, 2024

Summary of changes

Fix an error seem in the error tracking product where the innerFolder is empty.

Reason for change

Fixes a bug

Implementation details

Add a check

@datadog-ddstaging
Copy link

datadog-ddstaging bot commented Oct 30, 2024

Datadog Report

Branch report: tony/civisibility-fix-errors
Commit report: f159bba
Test service: dd-trace-dotnet

✅ 0 Failed, 365166 Passed, 2072 Skipped, 15h 18m 35.68s Total Time
❄️ 2 New Flaky

New Flaky Tests (2)

  • OnSupportedFrameworkInSsi_CallsForwarderWithExpectedTelemetry - Datadog.Trace.ClrProfiler.IntegrationTests.InstrumentationTests - Last Failure

    Expand for error
     Expected boolean to be true, but found False.
    
  • OnSupportedFrameworkInSsi_CallsForwarderWithExpectedTelemetry - Datadog.Trace.ClrProfiler.IntegrationTests.InstrumentationTests - Last Failure

    Expand for error
     Expected boolean to be true, but found False.
    

@andrewlock
Copy link
Member

andrewlock commented Oct 30, 2024

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6222) - mean (71ms)  : 68, 74
     .   : milestone, 71,
    master - mean (70ms)  : 68, 72
     .   : milestone, 70,

    section CallTarget+Inlining+NGEN
    This PR (6222) - mean (1,116ms)  : 1095, 1136
     .   : milestone, 1116,
    master - mean (1,118ms)  : 1096, 1140
     .   : milestone, 1118,

Loading
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6222) - mean (110ms)  : 107, 113
     .   : milestone, 110,
    master - mean (110ms)  : 106, 114
     .   : milestone, 110,

    section CallTarget+Inlining+NGEN
    This PR (6222) - mean (776ms)  : 760, 791
     .   : milestone, 776,
    master - mean (778ms)  : 753, 803
     .   : milestone, 778,

Loading
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6222) - mean (93ms)  : 90, 96
     .   : milestone, 93,
    master - mean (94ms)  : 90, 97
     .   : milestone, 94,

    section CallTarget+Inlining+NGEN
    This PR (6222) - mean (727ms)  : 710, 744
     .   : milestone, 727,
    master - mean (733ms)  : 716, 750
     .   : milestone, 733,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6222) - mean (191ms)  : 188, 194
     .   : milestone, 191,
    master - mean (190ms)  : 187, 194
     .   : milestone, 190,

    section CallTarget+Inlining+NGEN
    This PR (6222) - mean (1,205ms)  : 1185, 1226
     .   : milestone, 1205,
    master - mean (1,204ms)  : 1181, 1227
     .   : milestone, 1204,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6222) - mean (278ms)  : 273, 282
     .   : milestone, 278,
    master - mean (276ms)  : 271, 281
     .   : milestone, 276,

    section CallTarget+Inlining+NGEN
    This PR (6222) - mean (944ms)  : 921, 968
     .   : milestone, 944,
    master - mean (945ms)  : 927, 964
     .   : milestone, 945,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6222) - mean (264ms)  : 261, 268
     .   : milestone, 264,
    master - mean (265ms)  : 261, 269
     .   : milestone, 265,

    section CallTarget+Inlining+NGEN
    This PR (6222) - mean (928ms)  : 906, 950
     .   : milestone, 928,
    master - mean (928ms)  : 907, 950
     .   : milestone, 928,

Loading

@tonyredondo tonyredondo marked this pull request as ready for review October 30, 2024 16:09
@tonyredondo tonyredondo requested review from a team as code owners October 30, 2024 16:09
@@ -162,7 +162,6 @@
"tracer\\test\\test-applications\\regression\\Sandbox.AutomaticInstrumentation\\Sandbox.AutomaticInstrumentation.csproj",
"tracer\\test\\test-applications\\regression\\Sandbox.ManualTracing\\Sandbox.ManualTracing.csproj",
"tracer\\test\\test-applications\\regression\\ServiceBus.Minimal.MassTransit\\ServiceBus.Minimal.MassTransit.csproj",
"tracer\\test\\test-applications\\regression\\ServiceBus.Minimal.NServiceBus\\ServiceBus.Minimal.NServiceBus.csproj",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😕

Copy link
Member Author

@tonyredondo tonyredondo Oct 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without that it doesn't build in Rider for mac... it's the filter file

@tonyredondo tonyredondo merged commit 8707242 into master Oct 30, 2024
74 of 77 checks passed
@tonyredondo tonyredondo deleted the tony/civisibility-fix-errors branch October 30, 2024 19:20
@github-actions github-actions bot added this to the vNext-v3 milestone Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants