Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move all RC int values to long, to mirror RC backend (#6219 => v2) #6228

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

andrewlock
Copy link
Member

Summary of changes

RC backend use long for there integer fields.

Backport of

## Summary of changes

RC backend use long for there integer fields.
@datadog-ddstaging
Copy link

datadog-ddstaging bot commented Nov 1, 2024

Datadog Report

Branch report: backport/robert/correct-rc-version-size
Commit report: 92a5663
Test service: dd-trace-dotnet

❌ 3 Failed (0 Known Flaky), 341275 Passed, 1758 Skipped, 14h 15m 59.09s Total Time

❌ Failed Tests (3)

  • AzureFunctionsTests+InProcessRuntimeV4.SubmitsTraces - Datadog.Trace.ClrProfiler.IntegrationTests - Details

    Expand for error
     The sample did not exit in 600000ms. Memory dump taken: True. Killing process.
    
  • AzureFunctionsTests+IsolatedRuntimeV4.SubmitsTraces - Datadog.Trace.ClrProfiler.IntegrationTests - Details

    Expand for error
     Expected exit code: -1, actual exit code: 1.
    
  • AzureFunctionsTests+IsolatedRuntimeV4.SubmitsTraces - Datadog.Trace.ClrProfiler.IntegrationTests - Details

    Expand for error
     The sample did not exit in 600000ms. Memory dump taken: True. Killing process.
    

@andrewlock
Copy link
Member Author

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6228) - mean (74ms)  : 64, 84
     .   : milestone, 74,
    master - mean (71ms)  : 68, 74
     .   : milestone, 71,

    section CallTarget+Inlining+NGEN
    This PR (6228) - mean (1,024ms)  : 1001, 1047
     .   : milestone, 1024,
    master - mean (1,117ms)  : 1097, 1138
     .   : milestone, 1117,

Loading
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6228) - mean (111ms)  : 107, 115
     .   : milestone, 111,
    master - mean (110ms)  : 105, 115
     .   : milestone, 110,

    section CallTarget+Inlining+NGEN
    This PR (6228) - mean (705ms)  : 686, 724
     .   : milestone, 705,
    master - mean (780ms)  : 764, 796
     .   : milestone, 780,

Loading
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6228) - mean (94ms)  : 90, 98
     .   : milestone, 94,
    master - mean (93ms)  : 91, 96
     .   : milestone, 93,

    section CallTarget+Inlining+NGEN
    This PR (6228) - mean (665ms)  : 638, 692
     .   : milestone, 665,
    master - mean (734ms)  : 721, 747
     .   : milestone, 734,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6228) - mean (192ms)  : 188, 196
     .   : milestone, 192,
    master - mean (190ms)  : 186, 194
     .   : milestone, 190,

    section CallTarget+Inlining+NGEN
    This PR (6228) - mean (1,110ms)  : 1084, 1135
     .   : milestone, 1110,
    master - mean (1,221ms)  : 1199, 1243
     .   : milestone, 1221,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6228) - mean (278ms)  : 275, 281
     .   : milestone, 278,
    master - mean (277ms)  : 270, 284
     .   : milestone, 277,

    section CallTarget+Inlining+NGEN
    This PR (6228) - mean (873ms)  : 850, 896
     .   : milestone, 873,
    master - mean (949ms)  : 929, 969
     .   : milestone, 949,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6228) - mean (266ms)  : 261, 272
     .   : milestone, 266,
    master - mean (264ms)  : 261, 268
     .   : milestone, 264,

    section CallTarget+Inlining+NGEN
    This PR (6228) - mean (856ms)  : 834, 877
     .   : milestone, 856,
    master - mean (932ms)  : 911, 952
     .   : milestone, 932,

Loading

@andrewlock andrewlock merged commit 9f27913 into release/2.x Nov 4, 2024
70 of 73 checks passed
@andrewlock andrewlock deleted the backport/robert/correct-rc-version-size branch November 4, 2024 09:28
@github-actions github-actions bot added this to the vNext-v2 milestone Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants