Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Test Package Versions Bump] Updating package versions #6230

Merged
merged 1 commit into from
Nov 4, 2024
Merged

[Test Package Versions Bump] Updating package versions #6230

merged 1 commit into from
Nov 4, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Nov 3, 2024

Updates the package versions for integration tests.

@github-actions github-actions bot requested review from a team as code owners November 3, 2024 00:24
@datadog-ddstaging
Copy link

datadog-ddstaging bot commented Nov 3, 2024 •
edited
Loading

Datadog Report

Branch report: bot/test-package-versions-bump
Commit report: 7c8606c
Test service: dd-trace-dotnet

✅ 0 Failed, 366639 Passed, 2082 Skipped, 15h 0m 17.22s Total Time

@andrewlock
Copy link
Member

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6230) - mean (71ms)  : 68, 73
     .   : milestone, 71,
    master - mean (70ms)  : 68, 73
     .   : milestone, 70,

    section CallTarget+Inlining+NGEN
    This PR (6230) - mean (1,118ms)  : 1091, 1144
     .   : milestone, 1118,
    master - mean (1,116ms)  : 1097, 1135
     .   : milestone, 1116,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6230) - mean (110ms)  : 107, 113
     .   : milestone, 110,
    master - mean (111ms)  : 107, 114
     .   : milestone, 111,

    section CallTarget+Inlining+NGEN
    This PR (6230) - mean (780ms)  : 764, 795
     .   : milestone, 780,
    master - mean (781ms)  : 767, 795
     .   : milestone, 781,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6230) - mean (93ms)  : 91, 96
     .   : milestone, 93,
    master - mean (93ms)  : 89, 97
     .   : milestone, 93,

    section CallTarget+Inlining+NGEN
    This PR (6230) - mean (738ms)  : 718, 757
     .   : milestone, 738,
    master - mean (736ms)  : 714, 758
     .   : milestone, 736,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6230) - mean (190ms)  : 187, 193
     .   : milestone, 190,
    master - mean (190ms)  : 186, 194
     .   : milestone, 190,

    section CallTarget+Inlining+NGEN
    This PR (6230) - mean (1,219ms)  : 1195, 1244
     .   : milestone, 1219,
    master - mean (1,219ms)  : 1194, 1245
     .   : milestone, 1219,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6230) - mean (277ms)  : 271, 283
     .   : milestone, 277,
    master - mean (276ms)  : 272, 280
     .   : milestone, 276,

    section CallTarget+Inlining+NGEN
    This PR (6230) - mean (944ms)  : 929, 959
     .   : milestone, 944,
    master - mean (949ms)  : 935, 964
     .   : milestone, 949,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6230) - mean (265ms)  : 260, 269
     .   : milestone, 265,
    master - mean (264ms)  : 261, 268
     .   : milestone, 264,

    section CallTarget+Inlining+NGEN
    This PR (6230) - mean (927ms)  : 910, 944
     .   : milestone, 927,
    master - mean (931ms)  : 909, 953
     .   : milestone, 931,
Loading

@andrewlock
Copy link
Member

Throughput/Crank Report ⚡

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6230) (11.109M)   : 0, 11108974
    master (11.028M)   : 0, 11028078
    benchmarks/2.9.0 (11.164M)   : 0, 11163993

    section Automatic
    This PR (6230) (7.074M)   : 0, 7073770
    master (7.251M)   : 0, 7251220
    benchmarks/2.9.0 (7.879M)   : 0, 7879272

    section Trace stats
    master (7.533M)   : 0, 7533382

    section Manual
    master (11.112M)   : 0, 11112322

    section Manual + Automatic
    This PR (6230) (6.636M)   : 0, 6636474
    master (6.714M)   : 0, 6714002

    section DD_TRACE_ENABLED=0
    master (10.130M)   : 0, 10130306
Loading 
gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6230) (9.661M)   : 0, 9660971
    master (9.465M)   : 0, 9465070
    benchmarks/2.9.0 (9.561M)   : 0, 9560849

    section Automatic
    This PR (6230) (6.330M)   : 0, 6330284
    master (6.373M)   : 0, 6373273

    section Trace stats
    master (6.826M)   : 0, 6825779

    section Manual
    master (9.220M)   : 0, 9220316

    section Manual + Automatic
    This PR (6230) (5.945M)   : 0, 5945396
    master (6.035M)   : 0, 6035067

    section DD_TRACE_ENABLED=0
    master (8.837M)   : 0, 8836881
Loading 
gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6230) (9.716M)   : 0, 9715759
    master (9.929M)   : 0, 9928896
    benchmarks/2.9.0 (9.732M)   : 0, 9731843

    section Automatic
    This PR (6230) (6.448M)   : 0, 6447502
    master (6.459M)   : 0, 6459369
    benchmarks/2.9.0 (7.149M)   : 0, 7148766

    section Trace stats
    master (7.116M)   : 0, 7115940

    section Manual
    master (9.820M)   : 0, 9820322

    section Manual + Automatic
    This PR (6230) (5.874M)   : 0, 5873591
    master (5.982M)   : 0, 5982250

    section DD_TRACE_ENABLED=0
    master (9.279M)   : 0, 9278996
Loading

@andrewlock
Copy link
Member

Benchmarks Report for tracer 🐌

Benchmarks for #6230 compared to master:

  • 1 benchmarks are faster, with geometric mean 1.121
  • All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 8.01μs 45.4ns 318ns 0.016 0.00401 0 5.61 KB
master StartStopWithChild netcoreapp3.1 10.1μs 55.4ns 359ns 0.0147 0.0049 0 5.8 KB
master StartStopWithChild net472 16.3μs 55.7ns 216ns 1.04 0.316 0.105 6.21 KB
#6230 StartStopWithChild net6.0 7.95μs 45.7ns 377ns 0.0158 0.0079 0 5.61 KB
#6230 StartStopWithChild netcoreapp3.1 10.1μs 54.4ns 303ns 0.024 0.00959 0 5.8 KB
#6230 StartStopWithChild net472 16.3μs 49.5ns 185ns 1.05 0.32 0.0985 6.2 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 498μs 285ns 1.03μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 652μs 426ns 1.65μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 839μs 447ns 1.73μs 0.417 0 0 3.3 KB
#6230 WriteAndFlushEnrichedTraces net6.0 482μs 463ns 1.73μs 0 0 0 2.7 KB
#6230 WriteAndFlushEnrichedTraces netcoreapp3.1 638μs 336ns 1.26μs 0 0 0 2.7 KB
#6230 WriteAndFlushEnrichedTraces net472 835μs 477ns 1.85μs 0.414 0 0 3.3 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 217μs 1.47μs 14.6μs 0.195 0 0 18.73 KB
master SendRequest netcoreapp3.1 238μs 1.35μs 11.3μs 0.243 0 0 20.89 KB
master SendRequest net472 0.000945ns 0.000617ns 0.00222ns 0 0 0 0 b
#6230 SendRequest net6.0 218μs 1.28μs 12.4μs 0.224 0 0 18.73 KB
#6230 SendRequest netcoreapp3.1 243μs 1.43μs 14μs 0.229 0 0 20.89 KB
#6230 SendRequest net472 0.000516ns 0.000229ns 0.000857ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 572μs 2.61μs 10.1μs 0.625 0 0 41.62 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 726μs 3.75μs 18μs 0.355 0 0 41.87 KB
master WriteAndFlushEnrichedTraces net472 870μs 4.41μs 20.7μs 8.68 2.6 0.434 53.36 KB
#6230 WriteAndFlushEnrichedTraces net6.0 562μs 2.73μs 11.3μs 0.598 0 0 41.53 KB
#6230 WriteAndFlushEnrichedTraces netcoreapp3.1 712μs 3.58μs 16μs 0.343 0 0 41.75 KB
#6230 WriteAndFlushEnrichedTraces net472 910μs 3.7μs 14.8μs 8.04 2.23 0.446 53.36 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.44μs 1.76ns 6.82ns 0.0144 0 0 1.02 KB
master ExecuteNonQuery netcoreapp3.1 1.75μs 1.26ns 4.7ns 0.0139 0 0 1.02 KB
master ExecuteNonQuery net472 2.16μs 1.25ns 4.84ns 0.157 0.00109 0 987 B
#6230 ExecuteNonQuery net6.0 1.33μs 1.21ns 4.69ns 0.014 0 0 1.02 KB
#6230 ExecuteNonQuery netcoreapp3.1 1.75μs 1.71ns 6.41ns 0.0139 0 0 1.02 KB
#6230 ExecuteNonQuery net472 2.08μs 1.48ns 5.74ns 0.157 0.00104 0 987 B
Benchmarks.Trace.ElasticsearchBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #6230

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch‑netcoreapp3.1 1.121 1,685.64 1,503.40

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.2μs 3.3ns 12.8ns 0.0136 0 0 976 B
master CallElasticsearch netcoreapp3.1 1.69μs 0.972ns 3.76ns 0.0127 0 0 976 B
master CallElasticsearch net472 2.55μs 1.18ns 4.4ns 0.158 0 0 995 B
master CallElasticsearchAsync net6.0 1.24μs 0.794ns 3.08ns 0.0136 0 0 952 B
master CallElasticsearchAsync netcoreapp3.1 1.72μs 0.635ns 2.38ns 0.0138 0 0 1.02 KB
master CallElasticsearchAsync net472 2.59μs 0.857ns 3.2ns 0.167 0 0 1.05 KB
#6230 CallElasticsearch net6.0 1.12μs 0.506ns 1.89ns 0.0136 0 0 976 B
#6230 CallElasticsearch netcoreapp3.1 1.5μs 0.786ns 3.04ns 0.0128 0 0 976 B
#6230 CallElasticsearch net472 2.58μs 1.29ns 4.84ns 0.158 0 0 995 B
#6230 CallElasticsearchAsync net6.0 1.36μs 0.625ns 2.34ns 0.0136 0 0 952 B
#6230 CallElasticsearchAsync netcoreapp3.1 1.69μs 0.777ns 2.91ns 0.0135 0 0 1.02 KB
#6230 CallElasticsearchAsync net472 2.51μs 0.624ns 2.25ns 0.167 0 0 1.05 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.28μs 0.659ns 2.47ns 0.0134 0 0 952 B
master ExecuteAsync netcoreapp3.1 1.56μs 1.51ns 5.64ns 0.0126 0 0 952 B
master ExecuteAsync net472 1.84μs 1.47ns 5.68ns 0.144 0 0 915 B
#6230 ExecuteAsync net6.0 1.33μs 0.528ns 1.98ns 0.0133 0 0 952 B
#6230 ExecuteAsync netcoreapp3.1 1.6μs 1.62ns 6.06ns 0.0129 0 0 952 B
#6230 ExecuteAsync net472 1.79μs 0.993ns 3.85ns 0.145 0 0 915 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 4.41μs 2.49ns 9.33ns 0.0331 0 0 2.31 KB
master SendAsync netcoreapp3.1 5.19μs 1.31ns 4.89ns 0.0389 0 0 2.85 KB
master SendAsync net472 7.37μs 1.67ns 6.26ns 0.496 0 0 3.12 KB
#6230 SendAsync net6.0 4.43μs 2.54ns 9.84ns 0.0309 0 0 2.31 KB
#6230 SendAsync netcoreapp3.1 5.31μs 2.52ns 9.76ns 0.0372 0 0 2.85 KB
#6230 SendAsync net472 7.4μs 4.49ns 17.4ns 0.492 0 0 3.12 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 1.55μs 1.11ns 4.28ns 0.0226 0 0 1.64 KB
master EnrichedLog netcoreapp3.1 2.18μs 1.25ns 4.69ns 0.022 0 0 1.64 KB
master EnrichedLog net472 2.51μs 1.34ns 5ns 0.249 0 0 1.57 KB
#6230 EnrichedLog net6.0 1.54μs 0.731ns 2.83ns 0.0229 0 0 1.64 KB
#6230 EnrichedLog netcoreapp3.1 2.27μs 3.77ns 14.1ns 0.0223 0 0 1.64 KB
#6230 EnrichedLog net472 2.67μs 1.75ns 6.77ns 0.25 0 0 1.57 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 119μs 182ns 704ns 0.0591 0 0 4.28 KB
master EnrichedLog netcoreapp3.1 125μs 174ns 672ns 0 0 0 4.28 KB
master EnrichedLog net472 153μs 301ns 1.16μs 0.693 0.231 0 4.46 KB
#6230 EnrichedLog net6.0 118μs 136ns 509ns 0.0594 0 0 4.28 KB
#6230 EnrichedLog netcoreapp3.1 121μs 315ns 1.22μs 0 0 0 4.28 KB
#6230 EnrichedLog net472 152μs 222ns 861ns 0.68 0.227 0 4.46 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.97μs 1.15ns 4.29ns 0.031 0 0 2.2 KB
master EnrichedLog netcoreapp3.1 4.22μs 1.08ns 4.04ns 0.0296 0 0 2.2 KB
master EnrichedLog net472 4.69μs 4.75ns 18.4ns 0.321 0 0 2.02 KB
#6230 EnrichedLog net6.0 3.04μs 1.62ns 6.28ns 0.0314 0 0 2.2 KB
#6230 EnrichedLog netcoreapp3.1 4.06μs 2.36ns 8.53ns 0.0305 0 0 2.2 KB
#6230 EnrichedLog net472 4.77μs 3.48ns 13.5ns 0.32 0 0 2.02 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 1.39μs 1.08ns 4.19ns 0.0161 0 0 1.14 KB
master SendReceive netcoreapp3.1 1.73μs 0.723ns 2.8ns 0.0147 0 0 1.14 KB
master SendReceive net472 2.08μs 1.38ns 5.17ns 0.183 0 0 1.16 KB
#6230 SendReceive net6.0 1.34μs 0.624ns 2.33ns 0.0161 0 0 1.14 KB
#6230 SendReceive netcoreapp3.1 1.72μs 0.854ns 3.31ns 0.0155 0 0 1.14 KB
#6230 SendReceive net472 2.14μs 0.589ns 2.2ns 0.183 0 0 1.16 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.67μs 0.606ns 2.18ns 0.0226 0 0 1.6 KB
master EnrichedLog netcoreapp3.1 3.89μs 1.06ns 4.1ns 0.0215 0 0 1.65 KB
master EnrichedLog net472 4.33μs 1.2ns 4.5ns 0.322 0 0 2.04 KB
#6230 EnrichedLog net6.0 2.75μs 1.29ns 5ns 0.022 0 0 1.6 KB
#6230 EnrichedLog netcoreapp3.1 3.89μs 5.29ns 19.8ns 0.0213 0 0 1.65 KB
#6230 EnrichedLog net472 4.26μs 3.35ns 13ns 0.322 0 0 2.04 KB
Benchmarks.Trace.SpanBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 411ns 0.253ns 0.911ns 0.00808 0 0 576 B
master StartFinishSpan netcoreapp3.1 636ns 0.391ns 1.51ns 0.00764 0 0 576 B
master StartFinishSpan net472 736ns 0.614ns 2.38ns 0.0917 0 0 578 B
master StartFinishScope net6.0 478ns 0.461ns 1.79ns 0.00986 0 0 696 B
master StartFinishScope netcoreapp3.1 712ns 0.661ns 2.56ns 0.0092 0 0 696 B
master StartFinishScope net472 930ns 0.752ns 2.91ns 0.104 0 0 658 B
#6230 StartFinishSpan net6.0 403ns 0.249ns 0.964ns 0.00811 0 0 576 B
#6230 StartFinishSpan netcoreapp3.1 571ns 1.84ns 7.11ns 0.0079 0 0 576 B
#6230 StartFinishSpan net472 702ns 1.1ns 4.25ns 0.0916 0 0 578 B
#6230 StartFinishScope net6.0 488ns 0.606ns 2.35ns 0.00966 0 0 696 B
#6230 StartFinishScope netcoreapp3.1 660ns 0.618ns 2.39ns 0.00943 0 0 696 B
#6230 StartFinishScope net472 880ns 0.764ns 2.96ns 0.104 0 0 658 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 608ns 0.426ns 1.65ns 0.00972 0 0 696 B
master RunOnMethodBegin netcoreapp3.1 856ns 0.722ns 2.8ns 0.00941 0 0 696 B
master RunOnMethodBegin net472 1.15μs 0.76ns 2.94ns 0.104 0 0 658 B
#6230 RunOnMethodBegin net6.0 608ns 0.637ns 2.47ns 0.00978 0 0 696 B
#6230 RunOnMethodBegin netcoreapp3.1 950ns 1.08ns 4.17ns 0.00953 0 0 696 B
#6230 RunOnMethodBegin net472 1.15μs 0.818ns 3.17ns 0.105 0 0 658 B

andrewlock
andrewlock approved these changes Nov 4, 2024
View reviewed changes
Copy link
Member

@andrewlock andrewlock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🤖

@andrewlock andrewlock merged commit 6f4580e into master Nov 4, 2024
67 checks passed
@andrewlock andrewlock deleted the bot/test-package-versions-bump branch November 4, 2024 10:47
@github-actions github-actions bot added this to the vNext-v3 milestone Nov 4, 2024
@andrewlock andrewlock added area:test-apps apps used to test integrations area:dependabot dependabot updates labels Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewlock andrewlock andrewlock approved these changes

Assignees
No one assigned
Labels
area:dependabot dependabot updates area:test-apps apps used to test integrations
Projects
None yet
Milestone
3.5.0
Development

Successfully merging this pull request may close these issues.
1 participant
@andrewlock