Downgrade error to warning #6263

andrewlock · 2024-11-08T14:51:41Z

Summary of changes

Downgrades an error that is due to invalid user input

Reason for change

It's not a bug on our side, so no need to report it

Implementation details

Error -> Warning

Test coverage

Annoyingly, some of our integration tests were actually replying on this behavior, so had to workaround that 🙄

https://datadoghq.atlassian.net/browse/AIDM-467

bouwkast

Thanks :)

datadog-ddstaging · 2024-11-08T15:15:35Z

Datadog Report

Branch report: andrew/downgrade-error-to-warning
Commit report: 40974de
Test service: dd-trace-dotnet

✅ 0 Failed, 457121 Passed, 2783 Skipped, 19h 17m 42.3s Total Time

andrewlock · 2024-11-08T15:24:38Z

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

Welch test with statistical test for significance of 5%
Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6263) - mean (72ms)  : 64, 80
     .   : milestone, 72,
    master - mean (71ms)  : 64, 79
     .   : milestone, 71,

    section CallTarget+Inlining+NGEN
    This PR (6263) - mean (1,107ms)  : 1084, 1129
     .   : milestone, 1107,
    master - mean (1,109ms)  : 1094, 1124
     .   : milestone, 1109,

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6263) - mean (108ms)  : 105, 110
     .   : milestone, 108,
    master - mean (109ms)  : 107, 111
     .   : milestone, 109,

    section CallTarget+Inlining+NGEN
    This PR (6263) - mean (764ms)  : 746, 783
     .   : milestone, 764,
    master - mean (776ms)  : 763, 789
     .   : milestone, 776,

gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6263) - mean (91ms)  : 89, 94
     .   : milestone, 91,
    master - mean (93ms)  : 91, 95
     .   : milestone, 93,

    section CallTarget+Inlining+NGEN
    This PR (6263) - mean (716ms)  : 704, 729
     .   : milestone, 716,
    master - mean (725ms)  : 709, 740
     .   : milestone, 725,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6263) - mean (191ms)  : 186, 196
     .   : milestone, 191,
    master - mean (191ms)  : 184, 197
     .   : milestone, 191,

    section CallTarget+Inlining+NGEN
    This PR (6263) - mean (1,225ms)  : 1203, 1246
     .   : milestone, 1225,
    master - mean (1,227ms)  : 1204, 1250
     .   : milestone, 1227,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6263) - mean (276ms)  : 271, 280
     .   : milestone, 276,
    master - mean (275ms)  : 271, 279
     .   : milestone, 275,

    section CallTarget+Inlining+NGEN
    This PR (6263) - mean (939ms)  : 923, 954
     .   : milestone, 939,
    master - mean (945ms)  : 929, 961
     .   : milestone, 945,

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6263) - mean (265ms)  : 262, 269
     .   : milestone, 265,
    master - mean (266ms)  : 261, 271
     .   : milestone, 266,

    section CallTarget+Inlining+NGEN
    This PR (6263) - mean (923ms)  : 899, 947
     .   : milestone, 923,
    master - mean (931ms)  : 909, 954
     .   : milestone, 931,

andrewlock · 2024-11-08T16:52:02Z

Benchmarks Report for tracer 🐌

Benchmarks for #6263 compared to master:

1 benchmarks are faster, with geometric mean 1.142
1 benchmarks are slower, with geometric mean 1.123
All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

Mann–Whitney U test with statistical test for significance of 5%
Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`StartStopWithChild`	net6.0	8.13μs	40.7ns	223ns	0.0203	0.00813	0	5.6 KB
master	`StartStopWithChild`	netcoreapp3.1	10.2μs	55.1ns	307ns	0.0245	0.0098	0	5.8 KB
master	`StartStopWithChild`	net472	16.6μs	48.7ns	189ns	1.06	0.325	0.108	6.21 KB
#6263	`StartStopWithChild`	net6.0	8.06μs	44.8ns	276ns	0.0154	0.0077	0	5.61 KB
#6263	`StartStopWithChild`	netcoreapp3.1	10.3μs	55.8ns	325ns	0.015	0.00502	0	5.8 KB
#6263	`StartStopWithChild`	net472	16.3μs	44.5ns	172ns	1.06	0.334	0.111	6.21 KB

Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	467μs	326ns	1.22μs	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	644μs	322ns	1.25μs	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	net472	833μs	425ns	1.64μs	0.417	3.3 KB
#6263	`WriteAndFlushEnrichedTraces`	net6.0	479μs	218ns	785ns	0	2.7 KB
#6263	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	639μs	561ns	2.17μs	0	2.7 KB
#6263	`WriteAndFlushEnrichedTraces`	net472	840μs	472ns	1.83μs	0.419	3.3 KB

Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendRequest`	net6.0	203μs	1.17μs	9.7μs	0.192	18.73 KB
master	`SendRequest`	netcoreapp3.1	219μs	1.25μs	8.63μs	0.21	20.89 KB
master	`SendRequest`	net472	0.00233ns	0.000599ns	0.00232ns	0	0 b
#6263	`SendRequest`	net6.0	203μs	1.35μs	13.3μs	0.2	18.73 KB
#6263	`SendRequest`	netcoreapp3.1	222μs	1.22μs	7.4μs	0.217	20.89 KB
#6263	`SendRequest`	net472	0.000212ns	0.000212ns	0.00082ns	0	0 b

Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	569μs	2.32μs	9.86μs	0.558	0	0	41.65 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	679μs	3.42μs	15.3μs	0.334	0	0	41.74 KB
master	`WriteAndFlushEnrichedTraces`	net472	866μs	2.61μs	9.78μs	8.19	2.59	0.431	53.32 KB
#6263	`WriteAndFlushEnrichedTraces`	net6.0	580μs	2.55μs	11.4μs	0.579	0	0	41.63 KB
#6263	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	689μs	3.67μs	20.1μs	0.332	0	0	41.86 KB
#6263	`WriteAndFlushEnrichedTraces`	net472	868μs	4.19μs	18.3μs	8.5	2.55	0.425	53.32 KB

Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`ExecuteNonQuery`	net6.0	1.23μs	0.792ns	3.07ns	0.0142	0	1.02 KB
master	`ExecuteNonQuery`	netcoreapp3.1	1.81μs	1.07ns	3.99ns	0.0135	0	1.02 KB
master	`ExecuteNonQuery`	net472	2.04μs	2.13ns	8.26ns	0.156	0.00102	987 B
#6263	`ExecuteNonQuery`	net6.0	1.22μs	1.02ns	3.97ns	0.0145	0	1.02 KB
#6263	`ExecuteNonQuery`	netcoreapp3.1	1.76μs	5.81ns	22.5ns	0.014	0	1.02 KB
#6263	`ExecuteNonQuery`	net472	2.09μs	2ns	7.73ns	0.156	0.00104	987 B

Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`CallElasticsearch`	net6.0	1.22μs	0.904ns	3.38ns	0.0134	976 B
master	`CallElasticsearch`	netcoreapp3.1	1.6μs	1.49ns	5.77ns	0.0129	976 B
master	`CallElasticsearch`	net472	2.59μs	4.1ns	14.8ns	0.158	995 B
master	`CallElasticsearchAsync`	net6.0	1.26μs	0.926ns	3.59ns	0.0133	952 B
master	`CallElasticsearchAsync`	netcoreapp3.1	1.63μs	0.761ns	2.74ns	0.0139	1.02 KB
master	`CallElasticsearchAsync`	net472	2.53μs	2.2ns	8.52ns	0.166	1.05 KB
#6263	`CallElasticsearch`	net6.0	1.18μs	0.378ns	1.41ns	0.0137	976 B
#6263	`CallElasticsearch`	netcoreapp3.1	1.6μs	1.62ns	6.27ns	0.0136	976 B
#6263	`CallElasticsearch`	net472	2.51μs	1.33ns	5.16ns	0.158	995 B
#6263	`CallElasticsearchAsync`	net6.0	1.32μs	0.781ns	3.02ns	0.0131	952 B
#6263	`CallElasticsearchAsync`	netcoreapp3.1	1.68μs	0.752ns	2.91ns	0.0134	1.02 KB
#6263	`CallElasticsearchAsync`	net472	2.64μs	1.43ns	5.55ns	0.167	1.05 KB

Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`ExecuteAsync`	net6.0	1.38μs	0.608ns	2.28ns	0.0132	952 B
master	`ExecuteAsync`	netcoreapp3.1	1.72μs	1.28ns	4.8ns	0.0129	952 B
master	`ExecuteAsync`	net472	1.76μs	0.524ns	1.89ns	0.145	915 B
#6263	`ExecuteAsync`	net6.0	1.34μs	0.754ns	2.82ns	0.0134	952 B
#6263	`ExecuteAsync`	netcoreapp3.1	1.59μs	1.37ns	5.31ns	0.0126	952 B
#6263	`ExecuteAsync`	net472	1.83μs	0.675ns	2.53ns	0.145	915 B

Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendAsync`	net6.0	4.32μs	2.29ns	8.55ns	0.0325	2.31 KB
master	`SendAsync`	netcoreapp3.1	5.25μs	3.66ns	14.2ns	0.0395	2.85 KB
master	`SendAsync`	net472	7.55μs	1.68ns	6.51ns	0.495	3.12 KB
#6263	`SendAsync`	net6.0	4.5μs	1.98ns	7.4ns	0.0314	2.31 KB
#6263	`SendAsync`	netcoreapp3.1	5.17μs	3.46ns	13.4ns	0.0387	2.85 KB
#6263	`SendAsync`	net472	7.69μs	1.59ns	6.14ns	0.492	3.12 KB

Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	1.53μs	0.98ns	3.79ns	0.023	1.64 KB
master	`EnrichedLog`	netcoreapp3.1	2.26μs	0.962ns	3.47ns	0.0224	1.64 KB
master	`EnrichedLog`	net472	2.57μs	1.52ns	5.9ns	0.249	1.57 KB
#6263	`EnrichedLog`	net6.0	1.57μs	0.639ns	2.39ns	0.0229	1.64 KB
#6263	`EnrichedLog`	netcoreapp3.1	2.37μs	1.51ns	5.45ns	0.0225	1.64 KB
#6263	`EnrichedLog`	net472	2.69μs	2.13ns	8.24ns	0.249	1.57 KB

Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`EnrichedLog`	net6.0	119μs	231ns	895ns	0.0594	0	4.28 KB
master	`EnrichedLog`	netcoreapp3.1	124μs	195ns	756ns	0	0	4.28 KB
master	`EnrichedLog`	net472	155μs	164ns	634ns	0.697	0.232	4.46 KB
#6263	`EnrichedLog`	net6.0	118μs	181ns	677ns	0.0591	0	4.28 KB
#6263	`EnrichedLog`	netcoreapp3.1	122μs	218ns	845ns	0	0	4.28 KB
#6263	`EnrichedLog`	net472	151μs	174ns	674ns	0.676	0.225	4.46 KB

Benchmarks.Trace.NLogBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #6263

Benchmark	diff/base	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.NLogBenchmark.EnrichedLog‑net6.0	1.123	2,866.25	3,218.60

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	2.87μs	0.836ns	3.24ns	0.0301	2.2 KB
master	`EnrichedLog`	netcoreapp3.1	4.19μs	1.71ns	6.62ns	0.0291	2.2 KB
master	`EnrichedLog`	net472	4.94μs	1.55ns	5.82ns	0.319	2.02 KB
#6263	`EnrichedLog`	net6.0	3.22μs	0.78ns	2.81ns	0.0306	2.2 KB
#6263	`EnrichedLog`	netcoreapp3.1	4.31μs	3.03ns	10.9ns	0.0301	2.2 KB
#6263	`EnrichedLog`	net472	4.98μs	1.11ns	4.16ns	0.321	2.02 KB

Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendReceive`	net6.0	1.35μs	1.79ns	6.93ns	0.016	1.14 KB
master	`SendReceive`	netcoreapp3.1	1.77μs	0.842ns	3.26ns	0.0151	1.14 KB
master	`SendReceive`	net472	2.1μs	1.2ns	4.64ns	0.183	1.16 KB
#6263	`SendReceive`	net6.0	1.32μs	1.06ns	3.83ns	0.0158	1.14 KB
#6263	`SendReceive`	netcoreapp3.1	1.89μs	9.48ns	41.3ns	0.0157	1.14 KB
#6263	`SendReceive`	net472	2.23μs	6.45ns	22.4ns	0.184	1.16 KB

Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	2.86μs	1.68ns	6.52ns	0.0227	1.6 KB
master	`EnrichedLog`	netcoreapp3.1	3.88μs	3.73ns	14.4ns	0.0217	1.65 KB
master	`EnrichedLog`	net472	4.32μs	3.06ns	11.9ns	0.323	2.04 KB
#6263	`EnrichedLog`	net6.0	2.85μs	1.8ns	6.98ns	0.0214	1.6 KB
#6263	`EnrichedLog`	netcoreapp3.1	3.86μs	2.15ns	8.32ns	0.0212	1.65 KB
#6263	`EnrichedLog`	net472	4.3μs	4.46ns	17.3ns	0.322	2.04 KB

Benchmarks.Trace.SpanBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #6263

Benchmark	base/diff	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net6.0	1.142	462.65	405.18

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`StartFinishSpan`	net6.0	462ns	0.48ns	1.8ns	0.00814	576 B
master	`StartFinishSpan`	netcoreapp3.1	606ns	1.29ns	5ns	0.00788	576 B
master	`StartFinishSpan`	net472	720ns	1.02ns	3.94ns	0.0917	578 B
master	`StartFinishScope`	net6.0	533ns	0.405ns	1.57ns	0.00967	696 B
master	`StartFinishScope`	netcoreapp3.1	692ns	0.935ns	3.62ns	0.00938	696 B
master	`StartFinishScope`	net472	884ns	0.808ns	3.13ns	0.104	658 B
#6263	`StartFinishSpan`	net6.0	405ns	0.184ns	0.687ns	0.00811	576 B
#6263	`StartFinishSpan`	netcoreapp3.1	651ns	0.355ns	1.33ns	0.00784	576 B
#6263	`StartFinishSpan`	net472	679ns	1.02ns	3.83ns	0.0916	578 B
#6263	`StartFinishScope`	net6.0	479ns	0.266ns	1.03ns	0.00982	696 B
#6263	`StartFinishScope`	netcoreapp3.1	680ns	0.643ns	2.49ns	0.00956	696 B
#6263	`StartFinishScope`	net472	904ns	0.858ns	3.32ns	0.104	658 B

Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`RunOnMethodBegin`	net6.0	603ns	1.73ns	6.48ns	0.00961	696 B
master	`RunOnMethodBegin`	netcoreapp3.1	900ns	0.624ns	2.16ns	0.0093	696 B
master	`RunOnMethodBegin`	net472	1.1μs	1.45ns	5.62ns	0.104	658 B
#6263	`RunOnMethodBegin`	net6.0	602ns	0.63ns	2.44ns	0.00964	696 B
#6263	`RunOnMethodBegin`	netcoreapp3.1	926ns	0.816ns	3.16ns	0.00934	696 B
#6263	`RunOnMethodBegin`	net472	1.24μs	6.71ns	39.7ns	0.104	658 B

andrewlock · 2024-11-13T20:08:42Z

Throughput/Crank Report ⚡

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6263) (11.135M)   : 0, 11134535
    master (11.138M)   : 0, 11137526
    benchmarks/2.9.0 (11.033M)   : 0, 11032866

    section Automatic
    This PR (6263) (7.252M)   : 0, 7251818
    master (7.296M)   : 0, 7295708
    benchmarks/2.9.0 (7.786M)   : 0, 7785853

    section Trace stats
    master (7.579M)   : 0, 7579141

    section Manual
    master (11.154M)   : 0, 11154232

    section Manual + Automatic
    This PR (6263) (6.634M)   : 0, 6633613
    master (6.616M)   : 0, 6616418

    section DD_TRACE_ENABLED=0
    master (10.155M)   : 0, 10154896

gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6263) (9.501M)   : 0, 9501143
    master (9.515M)   : 0, 9515388
    benchmarks/2.9.0 (9.495M)   : 0, 9494821

    section Automatic
    This PR (6263) (6.403M)   : 0, 6403319
    master (6.416M)   : 0, 6416261

    section Trace stats
    master (6.719M)   : 0, 6718560

    section Manual
    master (9.633M)   : 0, 9633358

    section Manual + Automatic
    This PR (6263) (5.912M)   : 0, 5912424
    master (5.972M)   : 0, 5972415

    section DD_TRACE_ENABLED=0
    master (8.741M)   : 0, 8740855

gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6263) (9.424M)   : 0, 9424315
    master (9.435M)   : 0, 9435349
    benchmarks/2.9.0 (10.020M)   : 0, 10019592

    section Automatic
    This PR (6263) (6.213M)   : 0, 6212860
    master (6.245M)   : 0, 6244921
    benchmarks/2.9.0 (7.255M)   : 0, 7255257

    section Trace stats
    master (6.687M)   : 0, 6686776

    section Manual
    master (9.498M)   : 0, 9497601

    section Manual + Automatic
    This PR (6263) (5.828M)   : 0, 5827783
    master (5.774M)   : 0, 5773612

    section DD_TRACE_ENABLED=0
    master (9.014M)   : 0, 9013860

andrewlock added area:tracer The core tracer library (Datadog.Trace, does not include OpenTracing, native code, or integrations) type:cleanup Minor code clean up identified-by:telemetry labels Nov 8, 2024

andrewlock requested a review from a team as a code owner November 8, 2024 14:51

bouwkast approved these changes Nov 8, 2024

View reviewed changes

andrewlock added 2 commits November 13, 2024 15:25

Downgrade error to warning

15d822a

Fix redacted error test

40974de

andrewlock force-pushed the andrew/downgrade-error-to-warning branch from 34b402b to 40974de Compare November 13, 2024 16:06

andrewlock requested a review from a team as a code owner November 13, 2024 16:06

kevingosse approved these changes Nov 15, 2024

View reviewed changes

andrewlock merged commit 3f4d521 into master Nov 15, 2024
74 of 76 checks passed

andrewlock deleted the andrew/downgrade-error-to-warning branch November 15, 2024 16:03

github-actions bot added this to the vNext-v3 milestone Nov 15, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Downgrade error to warning #6263

Downgrade error to warning #6263

andrewlock commented Nov 8, 2024 •

edited

Loading

bouwkast left a comment

datadog-ddstaging bot commented Nov 8, 2024 •

edited

Loading

andrewlock commented Nov 8, 2024 •

edited

Loading

andrewlock commented Nov 8, 2024 •

edited

Loading

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Slower ⚠️ in #6263

Raw results

Raw results

Raw results

Faster 🎉 in #6263

Raw results

Raw results

andrewlock commented Nov 13, 2024

Downgrade error to warning #6263

Downgrade error to warning #6263

Conversation

andrewlock commented Nov 8, 2024 • edited Loading

Summary of changes

Reason for change

Implementation details

Test coverage

bouwkast left a comment

Choose a reason for hiding this comment

datadog-ddstaging bot commented Nov 8, 2024 • edited Loading

Datadog Report

andrewlock commented Nov 8, 2024 • edited Loading

Execution-Time Benchmarks Report ⏱️

andrewlock commented Nov 8, 2024 • edited Loading

Benchmarks Report for tracer 🐌

Benchmark details

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Slower ⚠️ in #6263

Raw results

Raw results

Raw results

Faster 🎉 in #6263

Raw results

Raw results

andrewlock commented Nov 13, 2024

Throughput/Crank Report ⚡

andrewlock commented Nov 8, 2024 •

edited

Loading

datadog-ddstaging bot commented Nov 8, 2024 •

edited

Loading

andrewlock commented Nov 8, 2024 •

edited

Loading

andrewlock commented Nov 8, 2024 •

edited

Loading