Small fixes for .NET 9

[andrewlock]

Summary of changes

• Unskip trimming tests test that were failing with RC2
• Fix the gitlab build

Reason for change

#6265 introduced .NET 9 support, but the trimming test wasn't working with rc2, so temporarily skipped it.

Also, I broke the GitLab build 🙈

Implementation details

Fix the gitlab build, unskip the test because it works with the GA release

Test coverage

This is the test

Other details

Requires 👇

• https://github.com/DataDog/images/pull/6112

I tried to skip the x86 .NET Ready2Run manual instrumentation test, but there's still something weird going on there with it looking for the dotnet runtime in the "wrong" place. I'm 99% sure this is purely a build-related issue, so I don't have much impetuous flogging it much more at this point... 🙈

[datadog-ddstaging]

Datadog Report

Branch report: andrew/dotnet-9-fixes
Commit report: e1ed02b
Test service: dd-trace-dotnet

✅ 0 Failed, 451303 Passed, 2725 Skipped, 19h 20m 33.85s Total Time

[andrewlock]

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

• This PR (6277)
• master

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

• Welch test with statistical test for significance of 5%
• Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6277) - mean (71ms)  : 64, 78
     .   : milestone, 71,
    master - mean (72ms)  : 64, 80
     .   : milestone, 72,

    section CallTarget+Inlining+NGEN
    This PR (6277) - mean (1,107ms)  : 1089, 1125
     .   : milestone, 1107,
    master - mean (1,112ms)  : 1091, 1134
     .   : milestone, 1112,

Loading

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6277) - mean (108ms)  : 104, 111
     .   : milestone, 108,
    master - mean (109ms)  : 106, 112
     .   : milestone, 109,

    section CallTarget+Inlining+NGEN
    This PR (6277) - mean (766ms)  : 751, 780
     .   : milestone, 766,
    master - mean (770ms)  : 757, 782
     .   : milestone, 770,

Loading

gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6277) - mean (91ms)  : 89, 94
     .   : milestone, 91,
    master - mean (93ms)  : 91, 95
     .   : milestone, 93,

    section CallTarget+Inlining+NGEN
    This PR (6277) - mean (718ms)  : 703, 732
     .   : milestone, 718,
    master - mean (724ms)  : 709, 740
     .   : milestone, 724,

Loading

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6277) - mean (192ms)  : 183, 201
     .   : milestone, 192,
    master - mean (190ms)  : 185, 195
     .   : milestone, 190,

    section CallTarget+Inlining+NGEN
    This PR (6277) - mean (1,228ms)  : 1205, 1250
     .   : milestone, 1228,
    master - mean (1,229ms)  : 1205, 1252
     .   : milestone, 1229,

Loading

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6277) - mean (277ms)  : 273, 281
     .   : milestone, 277,
    master - mean (277ms)  : 273, 281
     .   : milestone, 277,

    section CallTarget+Inlining+NGEN
    This PR (6277) - mean (945ms)  : 927, 964
     .   : milestone, 945,
    master - mean (947ms)  : 930, 963
     .   : milestone, 947,

Loading

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6277) - mean (265ms)  : 261, 269
     .   : milestone, 265,
    master - mean (265ms)  : 260, 269
     .   : milestone, 265,

    section CallTarget+Inlining+NGEN
    This PR (6277) - mean (920ms)  : 898, 943
     .   : milestone, 920,
    master - mean (928ms)  : 907, 949
     .   : milestone, 928,

Loading

[bouwkast]

Thanks!

[andrewlock]

Throughput/Crank Report ⚡

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

• This PR (6277)
• master
• benchmarks/2.9.0

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6277) (11.195M)   : 0, 11195009
    master (11.092M)   : 0, 11091647
    benchmarks/2.9.0 (11.033M)   : 0, 11032866

    section Automatic
    This PR (6277) (7.117M)   : 0, 7117447
    master (7.247M)   : 0, 7247456
    benchmarks/2.9.0 (7.786M)   : 0, 7785853

    section Trace stats
    master (7.567M)   : 0, 7566624

    section Manual
    master (11.125M)   : 0, 11125038

    section Manual + Automatic
    This PR (6277) (6.569M)   : 0, 6569139
    master (6.734M)   : 0, 6733580

    section DD_TRACE_ENABLED=0
    master (10.150M)   : 0, 10149788

Loading

gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6277) (9.656M)   : 0, 9656254
    master (9.672M)   : 0, 9672005
    benchmarks/2.9.0 (9.495M)   : 0, 9494821

    section Automatic
    This PR (6277) (6.252M)   : 0, 6251777
    master (6.434M)   : 0, 6433517

    section Trace stats
    master (6.711M)   : 0, 6710571

    section Manual
    master (9.432M)   : 0, 9431949

    section Manual + Automatic
    This PR (6277) (5.809M)   : 0, 5809064
    master (5.956M)   : 0, 5955854

    section DD_TRACE_ENABLED=0
    master (8.885M)   : 0, 8884829

Loading

gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6277) (9.969M)   : 0, 9969138
    master (9.850M)   : 0, 9849596
    benchmarks/2.9.0 (10.020M)   : 0, 10019592

    section Automatic
    This PR (6277) (6.747M)   : 0, 6747365
    master (6.340M)   : 0, 6339934
    benchmarks/2.9.0 (7.255M)   : 0, 7255257

    section Trace stats
    master (6.803M)   : 0, 6803435

    section Manual
    master (9.774M)   : 0, 9774066

    section Manual + Automatic
    This PR (6277) (6.321M)   : 0, 6321137
    master (0.010M)   : 0, 10074

    section DD_TRACE_ENABLED=0
    master (9.121M)   : 0, 9121169

Loading