-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Profiler] Gleocadie/clean up profiler code #6291
base: master
Are you sure you want to change the base?
Conversation
b70b8c9
to
a0211e3
Compare
Datadog ReportBranch report: ❌ 1 Failed (0 Known Flaky), 449445 Passed, 3173 Skipped, 21h 12m 4.68s Total Time ❌ Failed Tests (1)
|
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing the following branches/commits: Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6291) - mean (72ms) : 63, 81
. : milestone, 72,
master - mean (71ms) : 63, 80
. : milestone, 71,
section CallTarget+Inlining+NGEN
This PR (6291) - mean (1,112ms) : 1091, 1133
. : milestone, 1112,
master - mean (1,107ms) : 1087, 1127
. : milestone, 1107,
gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6291) - mean (108ms) : 105, 111
. : milestone, 108,
master - mean (108ms) : 106, 111
. : milestone, 108,
section CallTarget+Inlining+NGEN
This PR (6291) - mean (766ms) : 752, 780
. : milestone, 766,
master - mean (764ms) : 749, 779
. : milestone, 764,
gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6291) - mean (92ms) : 90, 94
. : milestone, 92,
master - mean (92ms) : 89, 94
. : milestone, 92,
section CallTarget+Inlining+NGEN
This PR (6291) - mean (716ms) : 703, 728
. : milestone, 716,
master - mean (723ms) : 711, 735
. : milestone, 723,
gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6291) - mean (191ms) : 186, 195
. : milestone, 191,
master - mean (192ms) : 184, 200
. : milestone, 192,
section CallTarget+Inlining+NGEN
This PR (6291) - mean (1,211ms) : 1192, 1231
. : milestone, 1211,
master - mean (1,208ms) : 1188, 1228
. : milestone, 1208,
gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6291) - mean (276ms) : 273, 280
. : milestone, 276,
master - mean (276ms) : 272, 279
. : milestone, 276,
section CallTarget+Inlining+NGEN
This PR (6291) - mean (941ms) : 919, 963
. : milestone, 941,
master - mean (943ms) : 922, 964
. : milestone, 943,
gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6291) - mean (265ms) : 261, 270
. : milestone, 265,
master - mean (265ms) : 261, 269
. : milestone, 265,
section CallTarget+Inlining+NGEN
This PR (6291) - mean (923ms) : 903, 944
. : milestone, 923,
master - mean (926ms) : 905, 948
. : milestone, 926,
|
a0211e3
to
c5fd5dc
Compare
c5fd5dc
to
3a5cef0
Compare
Benchmarks Report for tracer 🐌Benchmarks for #6291 compared to master:
The following thresholds were used for comparing the benchmark speeds:
Allocation changes below 0.5% are ignored. Benchmark detailsBenchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.RedisBenchmark - Faster 🎉 Same allocations ✔️
|
Benchmark | base/diff | Base Median (ns) | Diff Median (ns) | Modality |
---|---|---|---|---|
Benchmarks.Trace.RedisBenchmark.SendReceive‑net6.0 | 1.152 | 1,473.56 | 1,278.62 |
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | SendReceive |
net6.0 | 1.47μs | 0.453ns | 1.63ns | 0.0162 | 0 | 0 | 1.14 KB |
master | SendReceive |
netcoreapp3.1 | 1.84μs | 1.08ns | 4.17ns | 0.0155 | 0 | 0 | 1.14 KB |
master | SendReceive |
net472 | 2.17μs | 0.769ns | 2.98ns | 0.183 | 0 | 0 | 1.16 KB |
#6291 | SendReceive |
net6.0 | 1.28μs | 0.5ns | 1.87ns | 0.016 | 0 | 0 | 1.14 KB |
#6291 | SendReceive |
netcoreapp3.1 | 1.83μs | 0.801ns | 3.1ns | 0.0156 | 0 | 0 | 1.14 KB |
#6291 | SendReceive |
net472 | 2.09μs | 1.16ns | 4.5ns | 0.183 | 0 | 0 | 1.16 KB |
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | EnrichedLog |
net6.0 | 2.61μs | 0.941ns | 3.64ns | 0.0221 | 0 | 0 | 1.6 KB |
master | EnrichedLog |
netcoreapp3.1 | 3.95μs | 1.48ns | 5.12ns | 0.0217 | 0 | 0 | 1.65 KB |
master | EnrichedLog |
net472 | 4.32μs | 1.75ns | 6.55ns | 0.324 | 0 | 0 | 2.04 KB |
#6291 | EnrichedLog |
net6.0 | 2.89μs | 2.02ns | 6.99ns | 0.0222 | 0 | 0 | 1.6 KB |
#6291 | EnrichedLog |
netcoreapp3.1 | 3.86μs | 1.82ns | 7.03ns | 0.0213 | 0 | 0 | 1.65 KB |
#6291 | EnrichedLog |
net472 | 4.37μs | 1.47ns | 5.5ns | 0.324 | 0 | 0 | 2.04 KB |
Benchmarks.Trace.SpanBenchmark - Slower ⚠️ Same allocations ✔️
Slower ⚠️ in #6291
Benchmark
diff/base
Base Median (ns)
Diff Median (ns)
Modality
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net6.0
1.159
396.85
459.90
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net472
1.122
856.63
961.12
Benchmark | diff/base | Base Median (ns) | Diff Median (ns) | Modality |
---|---|---|---|---|
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net6.0 | 1.159 | 396.85 | 459.90 | |
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net472 | 1.122 | 856.63 | 961.12 |
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | StartFinishSpan |
net6.0 | 397ns | 0.217ns | 0.841ns | 0.00812 | 0 | 0 | 576 B |
master | StartFinishSpan |
netcoreapp3.1 | 559ns | 0.447ns | 1.73ns | 0.00768 | 0 | 0 | 576 B |
master | StartFinishSpan |
net472 | 606ns | 1.2ns | 4.66ns | 0.0917 | 0 | 0 | 578 B |
master | StartFinishScope |
net6.0 | 490ns | 0.172ns | 0.666ns | 0.00987 | 0 | 0 | 696 B |
master | StartFinishScope |
netcoreapp3.1 | 765ns | 0.77ns | 2.98ns | 0.00921 | 0 | 0 | 696 B |
master | StartFinishScope |
net472 | 857ns | 0.977ns | 3.78ns | 0.104 | 0 | 0 | 658 B |
#6291 | StartFinishSpan |
net6.0 | 460ns | 0.333ns | 1.29ns | 0.00799 | 0 | 0 | 576 B |
#6291 | StartFinishSpan |
netcoreapp3.1 | 613ns | 0.44ns | 1.71ns | 0.00776 | 0 | 0 | 576 B |
#6291 | StartFinishSpan |
net472 | 676ns | 0.773ns | 2.99ns | 0.0917 | 0 | 0 | 578 B |
#6291 | StartFinishScope |
net6.0 | 486ns | 0.475ns | 1.84ns | 0.00972 | 0 | 0 | 696 B |
#6291 | StartFinishScope |
netcoreapp3.1 | 781ns | 0.461ns | 1.78ns | 0.00931 | 0 | 0 | 696 B |
#6291 | StartFinishScope |
net472 | 959ns | 1.34ns | 5.19ns | 0.104 | 0 | 0 | 658 B |
Benchmarks.Trace.TraceAnnotationsBenchmark - Slower ⚠️ Same allocations ✔️
Slower ⚠️ in #6291
Benchmark
diff/base
Base Median (ns)
Diff Median (ns)
Modality
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net472
1.114
1,050.21
1,169.46
Faster 🎉 in #6291
Benchmark
base/diff
Base Median (ns)
Diff Median (ns)
Modality
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net6.0
1.201
734.21
611.50
Benchmark | diff/base | Base Median (ns) | Diff Median (ns) | Modality |
---|---|---|---|---|
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net472 | 1.114 | 1,050.21 | 1,169.46 |
Benchmark | base/diff | Base Median (ns) | Diff Median (ns) | Modality |
---|---|---|---|---|
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net6.0 | 1.201 | 734.21 | 611.50 |
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | RunOnMethodBegin |
net6.0 | 734ns | 0.618ns | 2.39ns | 0.0099 | 0 | 0 | 696 B |
master | RunOnMethodBegin |
netcoreapp3.1 | 942ns | 0.844ns | 3.27ns | 0.00947 | 0 | 0 | 696 B |
master | RunOnMethodBegin |
net472 | 1.05μs | 1.25ns | 4.85ns | 0.104 | 0 | 0 | 658 B |
#6291 | RunOnMethodBegin |
net6.0 | 611ns | 0.642ns | 2.49ns | 0.00963 | 0 | 0 | 696 B |
#6291 | RunOnMethodBegin |
netcoreapp3.1 | 975ns | 0.783ns | 2.82ns | 0.0093 | 0 | 0 | 696 B |
#6291 | RunOnMethodBegin |
net472 | 1.17μs | 0.772ns | 2.99ns | 0.105 | 0 | 0 | 658 B |
Throughput/Crank Report ⚡Throughput results for AspNetCoreSimpleController comparing the following branches/commits: Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red. Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards! gantt
title Throughput Linux x64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (6291) (11.214M) : 0, 11214156
master (11.120M) : 0, 11120201
benchmarks/2.9.0 (11.033M) : 0, 11032866
section Automatic
This PR (6291) (7.210M) : 0, 7209624
master (7.143M) : 0, 7143247
benchmarks/2.9.0 (7.786M) : 0, 7785853
section Trace stats
master (7.563M) : 0, 7562834
section Manual
master (11.052M) : 0, 11051540
section Manual + Automatic
This PR (6291) (6.764M) : 0, 6763612
master (6.532M) : 0, 6532471
section DD_TRACE_ENABLED=0
master (10.176M) : 0, 10176174
gantt
title Throughput Linux arm64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (6291) (9.704M) : 0, 9703682
master (9.435M) : 0, 9435139
benchmarks/2.9.0 (9.495M) : 0, 9494821
section Automatic
This PR (6291) (6.488M) : 0, 6488026
master (6.301M) : 0, 6300608
section Trace stats
master (6.646M) : 0, 6646045
section Manual
master (9.564M) : 0, 9563833
section Manual + Automatic
This PR (6291) (6.063M) : 0, 6062807
master (5.897M) : 0, 5897193
section DD_TRACE_ENABLED=0
master (8.862M) : 0, 8862065
gantt
title Throughput Windows x64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (6291) (9.487M) : 0, 9487238
master (9.832M) : 0, 9832351
benchmarks/2.9.0 (10.020M) : 0, 10019592
section Automatic
This PR (6291) (6.162M) : 0, 6161772
master (6.258M) : 0, 6258447
benchmarks/2.9.0 (7.255M) : 0, 7255257
section Trace stats
master (6.950M) : 0, 6950057
section Manual
master (9.945M) : 0, 9945109
section Manual + Automatic
This PR (6291) (5.774M) : 0, 5773712
master (5.742M) : 0, 5742033
section DD_TRACE_ENABLED=0
master (9.091M) : 0, 9091089
|
Summary of changes
Reason for change
Implementation details
Test coverage
Other details