-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more smoke testing for .NET 9 #6296
base: master
Are you sure you want to change the base?
Conversation
Datadog ReportBranch report: ✅ 0 Failed, 254589 Passed, 932 Skipped, 7h 42m 45.49s Total Time |
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing the following branches/commits: Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6296) - mean (73ms) : 64, 81
. : milestone, 73,
master - mean (72ms) : 63, 81
. : milestone, 72,
section CallTarget+Inlining+NGEN
This PR (6296) - mean (1,114ms) : 1090, 1138
. : milestone, 1114,
master - mean (1,107ms) : 1082, 1132
. : milestone, 1107,
gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6296) - mean (110ms) : 107, 112
. : milestone, 110,
master - mean (108ms) : 105, 111
. : milestone, 108,
section CallTarget+Inlining+NGEN
This PR (6296) - mean (802ms) : 642, 961
. : milestone, 802,
master - mean (770ms) : 753, 786
. : milestone, 770,
gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6296) - mean (94ms) : 87, 102
. : milestone, 94,
master - mean (92ms) : 90, 94
. : milestone, 92,
section CallTarget+Inlining+NGEN
This PR (6296) - mean (734ms) : 703, 765
. : milestone, 734,
master - mean (725ms) : 709, 741
. : milestone, 725,
gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6296) - mean (191ms) : 186, 196
. : milestone, 191,
master - mean (191ms) : 185, 196
. : milestone, 191,
section CallTarget+Inlining+NGEN
This PR (6296) - mean (1,212ms) : 1186, 1238
. : milestone, 1212,
master - mean (1,213ms) : 1190, 1237
. : milestone, 1213,
gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6296) - mean (276ms) : 272, 281
. : milestone, 276,
master - mean (276ms) : 271, 280
. : milestone, 276,
section CallTarget+Inlining+NGEN
This PR (6296) - mean (939ms) : 919, 959
. : milestone, 939,
master - mean (945ms) : 929, 960
. : milestone, 945,
gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6296) - mean (265ms) : 262, 269
. : milestone, 265,
master - mean (265ms) : 260, 270
. : milestone, 265,
section CallTarget+Inlining+NGEN
This PR (6296) - mean (923ms) : 905, 941
. : milestone, 923,
master - mean (930ms) : 907, 952
. : milestone, 930,
|
Summary of changes
Reason for change
We want to run smoke tests on supported distros
Implementation details
We had to disable the crash tracking tests for the .NET 9 smoke tests on debian x64 because they would hang (due to a bug in the runtime, not related to our instrumentation). That issue mentions that using
--init
solves the issue, so added that as a temporary fix and the crash tracking tests pass (so can unskip them)Also added testing for
fedora:40
(x64and arm64) - x64 is still using rc2 currentlyrhel:8
andrhel:9
still using preview 7centos-stream:9
opensuse:15
Test coverage
More now - did a full installer run here.
Other details
This doesn't cover all the supported distros, but it's a good start