Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddtrace/tracer: add support for span links on Span Context #2973

Merged
merged 2 commits into from
Nov 8, 2024

Conversation

mhlidd
Copy link
Contributor

@mhlidd mhlidd commented Nov 8, 2024

What does this PR do?

Sets the framework that allows span links to be stored in extracted span contexts, and creates a new SpanContextWithLinks interface that enables access to such span links.

Motivation

In #2948, we update the functionality of chainedPropagator extract to create span links when there are conflicting trace ids in distributed tracing, and add those span links to the subsequently created span. In order to verify the proper functionality of this feature, this PR sets the framework of the updates in #2948 to allow us to write comprehensive system-tests.

APMAPI-883

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@mhlidd mhlidd marked this pull request as ready for review November 8, 2024 20:42
@mhlidd mhlidd requested a review from a team as a code owner November 8, 2024 20:42
@mhlidd mhlidd requested a review from mtoffl01 November 8, 2024 20:42
@mhlidd mhlidd changed the title Prerequisite tasks for adding support for conflicting trace ids in distributed tracing tracer: Adding framework to support conflicting trace ids in distributed tracing Nov 8, 2024
@mtoffl01 mtoffl01 changed the title tracer: Adding framework to support conflicting trace ids in distributed tracing ddtrace/tracer: add support for Span Links on Span Context Nov 8, 2024
@mtoffl01 mtoffl01 changed the title ddtrace/tracer: add support for Span Links on Span Context ddtrace/tracer: add support for span links on Span Context Nov 8, 2024
@pr-commenter
Copy link

pr-commenter bot commented Nov 8, 2024

Benchmarks

Benchmark execution time: 2024-11-08 21:25:13

Comparing candidate commit 4d35314 in PR branch mhlidd/prep_extracted_spanlinks with baseline commit 716a72c in branch main.

Found 1 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 0 unstable metrics.

scenario:BenchmarkSetTagStringer-24

  • 🟩 execution_time [-6.144ns; -3.936ns] or [-4.215%; -2.700%]

@mtoffl01 mtoffl01 merged commit 591c40e into main Nov 8, 2024
150 checks passed
@mtoffl01 mtoffl01 deleted the mhlidd/prep_extracted_spanlinks branch November 8, 2024 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants