Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose jmxfetch "initial refresh beans period" config. #2659

Merged
merged 1 commit into from
Apr 26, 2021
Merged

Expose jmxfetch "initial refresh beans period" config. #2659

merged 1 commit into from
Apr 26, 2021

Conversation

essobedo
Copy link
Contributor

Motivation

A new feature has been added to jmxfetch allowing to have a configurable period for the 1st bean refresh (for more details, please refer to the related PR DataDog/jmxfetch#349), the goal of this PR is to propagate the required changes to benefit from this new feature in the Java Agent

Modifications:

  • Adds a system property jmxfetch.initial-refresh-beans-period to be able to set the value
  • Provides the value of this property to the configuration of jmxfetch

Result

It is now possible to easily set a period for the 1st bean refresh from the Java Agent thanks to a System property

@essobedo essobedo requested a review from a team as a code owner April 26, 2021 14:00
@tylerbenson tylerbenson added the tag: community Community contribution label Apr 26, 2021
Copy link
Contributor

@tylerbenson tylerbenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@essobedo
Copy link
Contributor Author

FYI the build failure doesn't seem to be related to this PR

Copy link
Member

@richardstartin richardstartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks 👍🏻

@essobedo essobedo changed the title Allow to set the param initial refresh beans period with a System property Allow to set the initial refresh beans period with a System property Apr 26, 2021
@tylerbenson tylerbenson changed the title Allow to set the initial refresh beans period with a System property Expose jmxfetch "initial refresh beans period" config. Apr 26, 2021
@tylerbenson tylerbenson merged commit 21e7c92 into DataDog:master Apr 26, 2021
@essobedo essobedo deleted the jmxfetch_init_refresh_beans branch April 26, 2021 20:13
@tylerbenson tylerbenson added this to the 0.79.0 milestone Apr 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tag: community Community contribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants