Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make remote config quiet until endpoint is discovered #4078

Merged
merged 1 commit into from
Oct 25, 2022

Conversation

smola
Copy link
Member

@smola smola commented Oct 24, 2022

What Does This Do

Make remote config quiet until endpoint is discovered

Also make some more initialization lazy.

Motivation

Remote config poller has a lower polling interval than feature discovery. In the previous version, remote config polling every 5 seconds got too verbose until a remote config endpoint was discovered (which would never happened if the agent simply had no remote config enabled).

Additional Notes

Example of log before this PR:

web_1    | [dd.trace 2022-10-21 11:18:21:216 +0000] [dd-remote-config] DEBUG datadog.remoteconfig.ConfigurationPoller - Failed to poll remote configuration from (no endpoint discovered yet)
web_1    | java.io.IOException: Endpoint has not been discovered yet
web_1    | 	at datadog.remoteconfig.ConfigurationPoller.fetchConfiguration(ConfigurationPoller.java:201)
web_1    | 	at datadog.remoteconfig.ConfigurationPoller.sendRequest(ConfigurationPoller.java:212)
web_1    | 	at datadog.remoteconfig.ConfigurationPoller.poll(ConfigurationPoller.java:179)
web_1    | 	at datadog.trace.util.AgentTaskScheduler$PeriodicTask.run(AgentTaskScheduler.java:299)
web_1    | 	at datadog.trace.util.AgentTaskScheduler$Worker.run(AgentTaskScheduler.java:254)
web_1    | 	at java.base/java.lang.Thread.run(Thread.java:829)

@smola smola added the comp: remote config Configuration at Runtime label Oct 24, 2022
@smola smola requested review from a team, cataphract and ValentinZakharov October 24, 2022 11:03
@smola smola marked this pull request as ready for review October 24, 2022 12:22
@smola smola requested a review from a team as a code owner October 24, 2022 12:22
We also:

* Make some more initialization lazy.
@smola smola force-pushed the smola/remote-config-quiet branch from 8b6a543 to b9b1f99 Compare October 25, 2022 10:48
@smola smola merged commit dd96526 into master Oct 25, 2022
@smola smola deleted the smola/remote-config-quiet branch October 25, 2022 15:47
@github-actions github-actions bot added this to the 0.114.0 milestone Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp: remote config Configuration at Runtime
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants