Do not log exceptions when remote config returns 404 #4087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the agent has remote config enabled, the library discovers the endpoint, and then the agent is restarted with remote config disabled, we want to keep the logs quiet. We keep a debug-level message, but no warning or exception.
bantonsson
approved these changes
Oct 25, 2022
|
@bantonsson I agree. I'll check with other people working on remote config. So far, in dotnet and node we're not triggering again discovery of the remote config endpoint once it's been discovered. But it's probably a good idea to retrigger it once we got a 404. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
If the agent has remote config enabled, the library discovers the endpoint, and then the agent is restarted with remote config disabled, we want to keep the logs quiet. We keep a debug-level message, but no warning or exception.
Motivation
Additional Notes