Replace async-profiler context tracker with async-profiler scope listener #4096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardstartin
force-pushed
the
rgs/async-profiler-scope-listener
branch
3 times, most recently
from
4adb913 to
2236355
Compare
richardstartin
force-pushed
the
rgs/async-profiler-scope-listener
branch
from
2236355 to
38d08b7
Compare
jbachorik
reviewed
Oct 26, 2022
...rofiling-context/src/main/java/com/datadog/profiling/context/AsyncProfilerScopeListener.java
Outdated
Show resolved
Hide resolved
jbachorik
approved these changes
Oct 26, 2022
richardstartin
force-pushed
the
rgs/async-profiler-scope-listener
branch
from
38d08b7 to
862f7e1
Compare
richardstartin
force-pushed
the
rgs/async-profiler-scope-listener
branch
from
c827fc2 to
22e3e1a
Compare
richardstartin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
ExtendedScopeListenerinterface to accept a local root span IDAsyncProfiler's context APIMotivation
Since profiling now only tracks context when scopes are activated and doesn't use any of the custom hooks made available for checkpoints, this simplifies the integration and coalesces two scope stacks.
Additional Notes