liberty-20 fixes and tests #4258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cataphract
force-pushed
the
glopes/liberty-20-fixes
branch
2 times, most recently
from
0315506 to
eefb55d
Compare
smola
reviewed
Nov 16, 2022
...erty-20/src/main/java/datadog/trace/instrumentation/liberty20/HttpServletExtractAdapter.java
Show resolved
Hide resolved
...tion/liberty-20/src/test/groovy/datadog/trace/instrumentation/liberty20/Liberty20Test.groovy
Outdated
Show resolved
Hide resolved
cataphract
force-pushed
the
glopes/liberty-20-fixes
branch
2 times, most recently
from
b757afa to
763a1eb
Compare
cataphract
force-pushed
the
glopes/liberty-20-fixes
branch
16 times, most recently
from
97b91c9 to
ba71a93
Compare
smola
reviewed
Nov 25, 2022
cataphract
force-pushed
the
glopes/liberty-20-fixes
branch
from
ba71a93 to
78fb2a3
Compare
smola
approved these changes
Nov 25, 2022
3 tasks
mcculls
reviewed
Nov 25, 2022
| } | ||
| DEBUG_MH = debugMH; | ||
| WARN_MH = warnMH; | ||
| WARN_THR_MH = warnThrMH; |
There was a problem hiding this comment.
@cataphract is there a reason for all these method handles? the logger used by instrumentation advice is exposed by the tracer via the bootclasspath and is repackaged to avoid clashing with application loggers, so you shouldn't need to use reflection to access it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds tests on the liberty-20 module (besides the smoke tests) and fixes several problems with openliberty: instrumenting the WebApp class, which only shows up in the first request for a servlet, supporting capture of urlencoded post parameter, fixing blocking responses, and capturing response headers.