add support for multiple configurations for debugger #4285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shatzi
force-pushed
the
shatzi/DEBUG-1186/debugger-multi-config-support
branch
from
3c44d78 to
a2d7c55
Compare
jpbempel
reviewed
Nov 21, 2022
remote-config/src/main/java/datadog/remoteconfig/ConfigurationPoller.java
Outdated
Show resolved
Hide resolved
remote-config/src/main/java/datadog/remoteconfig/state/ParsedConfigKey.java
Outdated
Show resolved
Hide resolved
remote-config/src/main/java/datadog/remoteconfig/state/ProductState.java
Outdated
Show resolved
Hide resolved
remote-config/src/main/java/datadog/remoteconfig/state/ProductState.java
Outdated
Show resolved
Hide resolved
jpbempel
reviewed
Nov 21, 2022
remote-config/src/main/java/datadog/remoteconfig/ConfigurationPoller.java
Outdated
Show resolved
Hide resolved
remote-config/src/main/java/datadog/remoteconfig/ConfigurationPoller.java
Outdated
Show resolved
Hide resolved
remote-config/src/main/java/datadog/remoteconfig/state/ParsedConfigKey.java
Outdated
Show resolved
Hide resolved
remote-config/src/main/java/datadog/remoteconfig/state/ProductState.java
Outdated
Show resolved
Hide resolved
shatzi
requested review from
cimi and
ojung
and removed request for
a team and
cimi
jpbempel
approved these changes
Nov 22, 2022
ojung
reviewed
Nov 22, 2022
remote-config/src/main/java/datadog/remoteconfig/ConfigurationPoller.java
Outdated
Show resolved
Hide resolved
remote-config/src/main/java/datadog/remoteconfig/ConfigurationPoller.java
Outdated
Show resolved
Hide resolved
.../agent-debugger/src/main/java/com/datadog/debugger/agent/DebuggerProductChangesListener.java
Outdated
Show resolved
Hide resolved
remote-config/src/main/java/datadog/remoteconfig/state/ProductState.java
Outdated
Show resolved
Hide resolved
shatzi
force-pushed
the
shatzi/DEBUG-1186/debugger-multi-config-support
branch
from
33789ef to
cf58df4
Compare
ojung
approved these changes
Nov 22, 2022
shatzi
force-pushed
the
shatzi/DEBUG-1186/debugger-multi-config-support
branch
7 times, most recently
from
85a6845 to
d4f3a17
Compare
smola
added
comp: debugger
shatzi
force-pushed
the
shatzi/DEBUG-1186/debugger-multi-config-support
branch
from
d4f3a17 to
2e57d15
Compare
smola
approved these changes
Nov 25, 2022
shatzi
force-pushed
the
shatzi/DEBUG-1186/debugger-multi-config-support
branch
from
99247c9 to
bfbf5e8
Compare
shatzi
force-pushed
the
shatzi/DEBUG-1186/debugger-multi-config-support
branch
from
bfbf5e8 to
7966bfb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Adding support for multiple configuration for debugger. This allow backend to send multiple probe configuration to be applied at the client library
Motivation
Support for logs probes.
Additional Notes