Add scheduled task to clear the resolver's type pools #4298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcculls
force-pushed
the
mcculls/type-pool-cleaning
branch
from
ec16da9 to
0b6a18f
Compare
mcculls
force-pushed
the
mcculls/type-pool-cleaning
branch
from
0b6a18f to
9c6b46f
Compare
bantonsson
approved these changes
Nov 23, 2022
PerfectSlayer
added
tag: performance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Periodically resets the type-resolver state by clearing its shared type-pools.
Motivation
Type transformations happen mainly at startup. By clearing the type-pools at a long enough interval after start we can reduce long-term memory overhead without impacting performance. The type-pools continue to be cleared at the same interval in case further types are transformed over the life of the application.
Additional Notes
Defaults to every 5 minutes