Fix bug in dependency resolution under high concurrency #4335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smola
changed the title
smola
force-pushed
the
smola/telemetry-inst-overhead
branch
3 times, most recently
from
3f238e5 to
5707436
Compare
mcculls
reviewed
Nov 28, 2022
telemetry/src/main/java/datadog/telemetry/dependency/LocationsCollectingTransformer.java
Outdated
Show resolved
Hide resolved
mcculls
approved these changes
Nov 28, 2022
smola
force-pushed
the
smola/telemetry-inst-overhead
branch
3 times, most recently
from
6e7bfa7 to
df98774
Compare
smola
commented
Nov 28, 2022
telemetry/src/main/java/datadog/telemetry/dependency/DependencyResolverQueue.java
Show resolved
Hide resolved
smola
force-pushed
the
smola/telemetry-inst-overhead
branch
from
df98774 to
d57e85d
Compare
mcculls
reviewed
Nov 28, 2022
telemetry/src/main/java/datadog/telemetry/dependency/LocationsCollectingTransformer.java
Outdated
Show resolved
Hide resolved
ValentinZakharov
approved these changes
Nov 28, 2022
smola
force-pushed
the
smola/telemetry-inst-overhead
branch
from
d57e85d to
f5c70a3
Compare
smola
force-pushed
the
smola/telemetry-inst-overhead
branch
from
f5c70a3 to
1ea71df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Motivation
Telemetry gets blocked (or extremely slowed down) when many classes are loaded in parallel. The standard
WeakHashMapimplementation seems to be the culprit, and using ourWeakCachesolves it.Additional Notes